mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-10-22 14:05:37 +02:00
46064f8f88
Return true for Director::is_absolute_url() checks if they're prefixed with two or more slashes (as browsers interpret this as a valid URL) More solid URL checks in Director::is_site_url(), using a conservative parse_url() hostname comparison rather than Director::makeRelative(), which is not designed for security purposes
248 lines
9.7 KiB
PHP
248 lines
9.7 KiB
PHP
<?php
|
|
/**
|
|
* @package sapphire
|
|
* @subpackage tests
|
|
*
|
|
* @todo test Director::alternateBaseFolder()
|
|
*/
|
|
class DirectorTest extends SapphireTest {
|
|
|
|
protected static $originalRequestURI;
|
|
|
|
function setUp() {
|
|
parent::setUp();
|
|
|
|
// Hold the original request URI once so it doesn't get overwritten
|
|
if(!self::$originalRequestURI) {
|
|
self::$originalRequestURI = $_SERVER['REQUEST_URI'];
|
|
}
|
|
|
|
Director::addRules(99, array(
|
|
'DirectorTestRule/$Action/$ID/$OtherID' => 'DirectorTestRequest_Controller'
|
|
));
|
|
}
|
|
|
|
function tearDown() {
|
|
// TODO Remove director rule, currently API doesnt allow this
|
|
|
|
// Reinstate the original REQUEST_URI after it was modified by some tests
|
|
$_SERVER['REQUEST_URI'] = self::$originalRequestURI;
|
|
|
|
parent::tearDown();
|
|
}
|
|
|
|
public function testFileExists() {
|
|
$tempFileName = 'DirectorTest_testFileExists.tmp';
|
|
$tempFilePath = TEMP_FOLDER . '/' . $tempFileName;
|
|
|
|
// create temp file
|
|
file_put_contents($tempFilePath, '');
|
|
|
|
$this->assertTrue(
|
|
Director::fileExists($tempFilePath),
|
|
'File exist check with absolute path'
|
|
);
|
|
|
|
$this->assertTrue(
|
|
Director::fileExists($tempFilePath . '?queryparams=1&foo[bar]=bar'),
|
|
'File exist check with query params ignored'
|
|
);
|
|
|
|
unlink($tempFilePath);
|
|
}
|
|
|
|
public function testAlternativeBaseURL() {
|
|
// relative base URLs - you should end them in a /
|
|
Director::setBaseURL('/relativebase/');
|
|
$this->assertEquals('/relativebase/', Director::baseURL());
|
|
$this->assertEquals(Director::protocolAndHost() . '/relativebase/', Director::absoluteBaseURL());
|
|
$this->assertEquals(Director::protocolAndHost() . '/relativebase/subfolder/test', Director::absoluteURL('subfolder/test'));
|
|
|
|
// absolute base URLs - you should end them in a /
|
|
Director::setBaseURL('http://www.example.org/');
|
|
$this->assertEquals('http://www.example.org/', Director::baseURL());
|
|
$this->assertEquals('http://www.example.org/', Director::absoluteBaseURL());
|
|
$this->assertEquals('http://www.example.org/subfolder/test', Director::absoluteURL('subfolder/test'));
|
|
|
|
// Setting it to false restores functionality
|
|
Director::setBaseURL(false);
|
|
$this->assertEquals(BASE_URL.'/', Director::baseURL());
|
|
$this->assertEquals(Director::protocolAndHost().BASE_URL.'/', Director::absoluteBaseURL(BASE_URL));
|
|
$this->assertEquals(Director::protocolAndHost().BASE_URL . '/subfolder/test', Director::absoluteURL('subfolder/test'));
|
|
}
|
|
|
|
/**
|
|
* Tests that {@link Director::is_absolute()} works under different environment types
|
|
*/
|
|
public function testIsAbsolute() {
|
|
$expected = array (
|
|
'C:/something' => true,
|
|
'd:\\' => true,
|
|
'e/' => false,
|
|
's:/directory' => true,
|
|
'/var/www' => true,
|
|
'\\Something' => true,
|
|
'something/c:' => false,
|
|
'folder' => false,
|
|
'a/c:/' => false
|
|
);
|
|
|
|
foreach($expected as $path => $result) {
|
|
$this->assertEquals(Director::is_absolute($path), $result, "Test result for $path");
|
|
}
|
|
}
|
|
|
|
public function testIsAbsoluteUrl() {
|
|
$this->assertTrue(Director::is_absolute_url('http://test.com/testpage'));
|
|
$this->assertTrue(Director::is_absolute_url('ftp://test.com'));
|
|
$this->assertFalse(Director::is_absolute_url('test.com/testpage'));
|
|
$this->assertFalse(Director::is_absolute_url('/relative'));
|
|
$this->assertFalse(Director::is_absolute_url('relative'));
|
|
$this->assertTrue(Director::is_absolute_url("https://test.com/?url=http://foo.com"));
|
|
$this->assertTrue(Director::is_absolute_url("trickparseurl:http://test.com"));
|
|
$this->assertTrue(Director::is_absolute_url('//test.com'));
|
|
$this->assertTrue(Director::is_absolute_url('/////test.com'));
|
|
$this->assertTrue(Director::is_absolute_url(' ///test.com'));
|
|
$this->assertTrue(Director::is_absolute_url('http:test.com'));
|
|
$this->assertTrue(Director::is_absolute_url('//http://test.com'));
|
|
}
|
|
|
|
public function testIsRelativeUrl() {
|
|
$siteUrl = Director::absoluteBaseURL();
|
|
$this->assertFalse(Director::is_relative_url('http://test.com'));
|
|
$this->assertFalse(Director::is_relative_url('https://test.com'));
|
|
$this->assertFalse(Director::is_relative_url(' https://test.com/testpage '));
|
|
$this->assertTrue(Director::is_relative_url('test.com/testpage'));
|
|
$this->assertFalse(Director::is_relative_url('ftp://test.com'));
|
|
$this->assertTrue(Director::is_relative_url('/relative'));
|
|
$this->assertTrue(Director::is_relative_url('relative'));
|
|
// $this->assertTrue(Director::is_relative_url('/relative/?url=http://test.com'));
|
|
}
|
|
|
|
public function testMakeRelative() {
|
|
$siteUrl = Director::absoluteBaseURL();
|
|
$siteUrlNoProtocol = preg_replace('/https?:\/\//', '', $siteUrl);
|
|
$this->assertEquals(Director::makeRelative("$siteUrl"), '');
|
|
//$this->assertEquals(Director::makeRelative("https://$siteUrlNoProtocol"), '');
|
|
$this->assertEquals(Director::makeRelative(" $siteUrl/testpage "), 'testpage');
|
|
//$this->assertEquals(Director::makeRelative("$siteUrlNoProtocol/testpage"), 'testpage');
|
|
$this->assertEquals(Director::makeRelative('ftp://test.com'), 'ftp://test.com');
|
|
$this->assertEquals(Director::makeRelative('http://test.com'), 'http://test.com');
|
|
// the below is not a relative URL, test makes no sense
|
|
// $this->assertEquals(Director::makeRelative('/relative'), '/relative');
|
|
$this->assertEquals(Director::makeRelative('relative'), 'relative');
|
|
$this->assertEquals(Director::makeRelative("$siteUrl/?url=http://test.com"), '?url=http://test.com');
|
|
}
|
|
|
|
/**
|
|
* Mostly tested by {@link testIsRelativeUrl()},
|
|
* just adding the host name matching aspect here.
|
|
*/
|
|
public function testIsSiteUrl() {
|
|
$this->assertFalse(Director::is_site_url("http://test.com"));
|
|
$this->assertTrue(Director::is_site_url(Director::absoluteBaseURL()));
|
|
$this->assertFalse(Director::is_site_url("http://test.com?url=" . Director::absoluteBaseURL()));
|
|
$this->assertFalse(Director::is_site_url("http://test.com?url=" . urlencode(Director::absoluteBaseURL())));
|
|
$this->assertFalse(Director::is_site_url("//test.com?url=" . Director::absoluteBaseURL()));
|
|
}
|
|
|
|
public function testResetGlobalsAfterTestRequest() {
|
|
|
|
$_GET = array('somekey' => 'getvalue');
|
|
$_POST = array('somekey' => 'postvalue');
|
|
$_COOKIE = array('somekey' => 'cookievalue');
|
|
|
|
$getresponse = Director::test('errorpage?somekey=sometestgetvalue', array('somekey' => 'sometestpostvalue'), null, null, null, null, array('somekey' => 'sometestcookievalue'));
|
|
|
|
$this->assertEquals('getvalue', $_GET['somekey'], '$_GET reset to original value after Director::test()');
|
|
$this->assertEquals('postvalue', $_POST['somekey'], '$_POST reset to original value after Director::test()');
|
|
$this->assertEquals('cookievalue', $_COOKIE['somekey'], '$_COOKIE reset to original value after Director::test()');
|
|
}
|
|
|
|
public function testTestRequestCarriesGlobals() {
|
|
|
|
$fixture = array('somekey' => 'sometestvalue');
|
|
|
|
foreach(array('get', 'post') as $method) {
|
|
|
|
foreach(array('return%sValue', 'returnRequestValue', 'returnCookieValue') as $testfunction) {
|
|
|
|
$url = 'DirectorTestRequest_Controller/' . sprintf($testfunction, ucfirst($method)) . '?' . http_build_query($fixture);
|
|
$getresponse = Director::test($url, $fixture, null, strtoupper($method), null, null, $fixture);
|
|
|
|
$this->assertType('SS_HTTPResponse', $getresponse, 'Director::test() returns SS_HTTPResponse');
|
|
$this->assertEquals($fixture['somekey'], $getresponse->getBody(), 'Director::test() ' . $testfunction);
|
|
|
|
}
|
|
|
|
}
|
|
}
|
|
|
|
function testURLParam() {
|
|
Director::test('DirectorTestRule/myaction/myid/myotherid');
|
|
// TODO Works on the assumption that urlParam() is not unset after a test run, which is dodgy
|
|
$this->assertEquals(Director::urlParam('Action'), 'myaction');
|
|
$this->assertEquals(Director::urlParam('ID'), 'myid');
|
|
$this->assertEquals(Director::urlParam('OtherID'), 'myotherid');
|
|
}
|
|
|
|
function testURLParams() {
|
|
Director::test('DirectorTestRule/myaction/myid/myotherid');
|
|
// TODO Works on the assumption that urlParam() is not unset after a test run, which is dodgy
|
|
$this->assertEquals(
|
|
Director::urlParams(),
|
|
array(
|
|
'Controller' => 'DirectorTestRequest_Controller',
|
|
'Action' => 'myaction',
|
|
'ID' => 'myid',
|
|
'OtherID' => 'myotherid'
|
|
)
|
|
);
|
|
}
|
|
|
|
function testForceSSLProtectsEntireSite() {
|
|
$_SERVER['REQUEST_URI'] = Director::baseURL() . 'admin';
|
|
$output = Director::forceSSL();
|
|
$this->assertEquals($output, 'https://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI']);
|
|
|
|
$_SERVER['REQUEST_URI'] = Director::baseURL() . 'some-url';
|
|
$output = Director::forceSSL();
|
|
$this->assertEquals($output, 'https://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI']);
|
|
}
|
|
|
|
function testForceSSLOnTopLevelPagePattern() {
|
|
$_SERVER['REQUEST_URI'] = Director::baseURL() . 'admin';
|
|
$output = Director::forceSSL(array('/^admin/'));
|
|
$this->assertEquals($output, 'https://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI']);
|
|
}
|
|
|
|
function testForceSSLOnSubPagesPattern() {
|
|
$_SERVER['REQUEST_URI'] = Director::baseURL() . 'Security/login';
|
|
$output = Director::forceSSL(array('/^Security/'));
|
|
$this->assertEquals($output, 'https://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI']);
|
|
}
|
|
|
|
function testForceSSLWithPatternDoesNotMatchOtherPages() {
|
|
$_SERVER['REQUEST_URI'] = Director::baseURL() . 'normal-page';
|
|
$output = Director::forceSSL(array('/^admin/'));
|
|
$this->assertFalse($output);
|
|
|
|
$_SERVER['REQUEST_URI'] = Director::baseURL() . 'just-another-page/sub-url';
|
|
$output = Director::forceSSL(array('/^admin/', '/^Security/'));
|
|
$this->assertFalse($output);
|
|
}
|
|
|
|
}
|
|
|
|
class DirectorTestRequest_Controller extends Controller implements TestOnly {
|
|
|
|
public function returnGetValue($request) { return $_GET['somekey']; }
|
|
|
|
public function returnPostValue($request) { return $_POST['somekey']; }
|
|
|
|
public function returnRequestValue($request) { return $_REQUEST['somekey']; }
|
|
|
|
public function returnCookieValue($request) { return $_COOKIE['somekey']; }
|
|
|
|
}
|