Merge 5835657133fe2b816e8714a0a91d67f7a135ae71 into 483e944601b140cc891633048ba526037b6d3808

FIX remove placeholder search text on readonly field
2024-10-22 12:05:37 +00:00 · 2024-10-08 17:06:17 +13:00 · 2024-10-08 17:04:07 +13:00
2 changed files with 1 additions and 3 deletions
--- a/src/Forms/SearchableDropdownTrait.php
+++ b/src/Forms/SearchableDropdownTrait.php
@ -598,7 +598,7 @@ trait SearchableDropdownTrait
        $field->setReadonly(true);

        // Remove the text "Type to search..." on a read-only field
-        // $field->setPlaceholder('');
+        $this->setUseDynamicPlaceholder(false);

        return $field;
    }
--- a/tests/php/Forms/SearchableDropdownTraitTest.php
+++ b/tests/php/Forms/SearchableDropdownTraitTest.php
@ -73,8 +73,6 @@ class SearchableDropdownTraitTest extends SapphireTest
        $this->assertSame('My empty string', $field->getPlaceholder());
        $field->setPlaceholder('My placeholder');
        $this->assertSame('My placeholder', $field->getPlaceholder());
-        $readonlyField = $field->performReadonlyTransformation();
-        $this->assertSame('', $readonlyField->getPlaceholder());
    }

    public function testSeachContext(): void
Author	SHA1	Message	Date
Andrew Paxley	8aa51d8b28	Merge 5835657133fe2b816e8714a0a91d67f7a135ae71 into 483e944601b140cc891633048ba526037b6d3808	2024-10-08 17:06:17 +13:00
Andrew Paxley	5835657133	FIX remove placeholder search text on readonly field	2024-10-08 17:04:07 +13:00