Merge branch '5.3' into 5

Merge pull request #11438 from creative-commoners/pulls/5.3/fix-unit-test
MNT Fix unit test
2024-10-22 14:05:37 +02:00 · 2024-10-22 05:33:36 +00:00 · 2024-10-22 18:32:46 +13:00 · 2024-10-22 17:56:01 +13:00
1 changed files with 8 additions and 0 deletions
--- a/tests/php/Security/VersionedMemberAuthenticatorTest.php
+++ b/tests/php/Security/VersionedMemberAuthenticatorTest.php
@ -43,6 +43,14 @@ class VersionedMemberAuthenticatorTest extends SapphireTest
            return;
        }

+        // Explicity add the Versioned extension to Member, even though it's already in $required_extensions.
+        // This is done to call `unset(self::class::$extra_methods[strtolower($subclass)]);` in
+        // Extensible::add_extension() so when CustomMethods::getExtraMethodConfig() updates the $extra_methods
+        // it will include methods of Versioned such as publishSingle()
+        // This issue will only occur when running subsequent unit test classes in the same process, rather than this
+        // this unit test class in isolation
+        Member::add_extension(Versioned::class);
+
        // Enforce dummy validation (this can otherwise be influenced by recipe config)
        Deprecation::withSuppressedNotice(
            fn() => PasswordValidator::singleton()
Author	SHA1	Message	Date
github-actions	16cb2702af	Merge branch '5.3' into 5	2024-10-22 05:33:36 +00:00
Guy Sartorelli	fe39a2a046	Merge pull request #11438 from creative-commoners/pulls/5.3/fix-unit-test MNT Fix unit test	2024-10-22 18:32:46 +13:00
Steve Boyd	6df8732761	MNT Fix unit test	2024-10-22 17:56:01 +13:00