Merge 0fed76ecf1 into ebbd6427b2

DEBUG see what the field thinks will show
FIX remove placeholder search text on readonly field
2024-10-22 14:05:37 +02:00 · 2024-10-11 16:28:28 +13:00 · 2024-10-10 16:32:05 +13:00 · 2024-10-10 15:02:14 +13:00
2 changed files with 5 additions and 1 deletions
--- a/src/Forms/SearchableDropdownTrait.php
+++ b/src/Forms/SearchableDropdownTrait.php
@ -139,7 +139,6 @@ trait SearchableDropdownTrait
                return $emptyString;
            }
        }
-        $name = $this->getName();
        if ($this->getUseDynamicPlaceholder()) {
            if ($this->getIsSearchable()) {
                if (!$this->getIsLazyLoaded()) {
@ -598,6 +597,9 @@ trait SearchableDropdownTrait
        $field->setSource($this->sourceList);
        $field->setReadonly(true);

+        // Remove the text "Type to search..." on a read-only field
+        // $field->setPlaceholder('');
+
        return $field;
    }
 }
--- a/tests/php/Forms/SearchableDropdownTraitTest.php
+++ b/tests/php/Forms/SearchableDropdownTraitTest.php
@ -73,6 +73,8 @@ class SearchableDropdownTraitTest extends SapphireTest
        $this->assertSame('My empty string', $field->getPlaceholder());
        $field->setPlaceholder('My placeholder');
        $this->assertSame('My placeholder', $field->getPlaceholder());
+        $readonlyField = $field->performReadonlyTransformation();
+        $this->assertSame('', $readonlyField->getPlaceholder());
    }

    public function testSeachContext(): void
Author	SHA1	Message	Date
Andrew Paxley	88a752e08d	Merge `0fed76ecf1` into `ebbd6427b2`	2024-10-11 16:28:28 +13:00
Andrew Paxley	0fed76ecf1	DEBUG see what the field thinks will show	2024-10-10 16:32:05 +13:00
Andrew Paxley	b5203fdc50	FIX remove placeholder search text on readonly field	2024-10-10 15:02:14 +13:00