tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
2,501 Commits 31 Branches 527 Tags 162 MiB
fadb2c50fd
Commit Graph

554 Commits

Author SHA1 Message Date
Ingo Schommer
b515a2f2d7 BUGFIX Removed unused ComplexTableField->unpagedSourceItems - was already commented out in r70956, and doesn't seem to be used across parent- or subclasses. Added ticket #3484 to re-enable popup pagination, which was broken and disabled due to the deprecation of $unpagedSourceItems (see r53830) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71348 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:06 +13:00
Will Rossiter
479f8c0fa3 MINOR: added user friendly labels - should really be _t compatible I guess 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71345 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:06 +13:00
Sam Minnee
ce28dccdec BUGFIX #3442: Fix pagination in HasManyComplexTable, HasOneComplexTableField, ManyManyComplexTable 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71018 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:05 +13:00
Normann Lou
2939e33554 ENHANCEMENT: Ticket 2756: Newsletter performance problem, run out of memory. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70956 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:05 +13:00
Sean Harvey
66ce174441 MINOR Code formatting fix in DateField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70953 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:05 +13:00
Sean Harvey
f5b22dadff MINOR Code formatting fixes in CheckboxSetField 
MINOR Added phpDoc comments for documentation that needs to be written explaining the different source data that can be used with CheckboxSetField

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70843 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:04 +13:00
Normann Lou
c9df0ee039 BUGFIX: 
1. TableListField? exportfunality random bug. 
2. make Email_BounceRecord::canCreate() return false; so that it can not be manully create from CRM, instead, it should create through email buncing system.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70747 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:03 +13:00
Normann Lou
b114900053 BUGFIX: 1. TableListField exportfunality random bug. 2. make Email_BounceRecord::canCreate() return false; so that it can not be manully create from CRM, instead, it should create through email buncing system. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70743 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:03 +13:00
Normann Lou
b9145ab995 BUGFIX: 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70741 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:03 +13:00
Normann Lou
85abd8664b Undoing change committed in r 70734 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70740 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:03 +13:00
Normann Lou
d7f67183c6 git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70734 467b73ca-7a2a-4603-9d3b-597d59a354a9 2011-02-02 14:27:03 +13:00
Normann Lou
f71025aa40 BUGFIX: $_POST[$this->Name] in TableField::SubmittedFieldSet are not always set 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70695 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:02 +13:00
Sean Harvey
7f9e91d2b5 MINOR Changed $title parameter to HtmlEditorField constructor to null to be consistent with TextareaField and so title is derived based on the name of the field if no title is given. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70647 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:02 +13:00
Sean Harvey
c6275611ee BUGFIX Defined jsValidation() and validate() so that inherited validation from DateField doesn't break PopupDateTimeField - this still needs fixing, and PopupDateTimeField shouldn't inherit from CalendarDateField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70609 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:02 +13:00
Sean Harvey
6eec6006a5 MINOR Code formatting fix in FormField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70608 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:02 +13:00
Will Rossiter
59da2e1887 MINOR: ticket 1846. Changed Action to title case 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70598 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:01 +13:00
Saophalkun Ponlu
5ddb00dfa3 BUGFIX: when the total number of rows is 0 the pagination says 1 to 0 of 0 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70565 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:01 +13:00
Sean Harvey
87772a9713 BUGFIX Hidden field needs to exist for DateField_Disabled in order for validation to pass correctly 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70545 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:01 +13:00
Sean Harvey
68898849ad MINOR Update ResetFormAction to make use of createTag() method instead of patching together strings to make the form input 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70269 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:00 +13:00
Sean Harvey
9c4552efa3 MINOR Fixed undefined variable error in TableListField->generateExportFileData() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70257 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:00 +13:00
Normann Lou
d3a5bcbb7f APICHANGE: we move the filedata generation part of export() function to a new function generateExportFileData, so that, a child class could reuse the function when overload export function 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70150 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:59 +13:00
Sean Harvey
b839d2c2c1 BUGFIX Removed for attribute on FieldGroup->FieldHolder() since there's no ID of any input fields to match the label to. 
BUGFIX Changed the FieldHolder method to use explicit functionality instead of statically calling FormField::FieldHolder()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70127 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:58 +13:00
Sean Harvey
504c515ee6 MINOR Code formatting fixes in HtmlEditorField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70059 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:58 +13:00
Sean Harvey
44f2caf60b BUGFIX Fixed FileField->getFolderName() - it was not returning $this->folderName, instead it was returning an undefined variable in error 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69975 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:57 +13:00
Saophalkun Ponlu
9278f0ffe5 BUGFIX: error when creating a form 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69973 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:57 +13:00
Sean Harvey
f9c25b2465 MINOR Removed "edit image" button since the image editor has been removed 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69939 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:56 +13:00
Sam Minnee
ec5448008c ENHANCEMENT #3313 gigtech: Added ComplexTableField::setAddTitle() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69924 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:56 +13:00
Ingo Schommer
23ed38765c ENHANCEMENT Moved i18n::get_existing_content_languages() to correct namespace in Translatable::get_existing_content_languages(). 
BUGFIX Using SQL DISTINCT in get_existing_content_languages()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69891 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:55 +13:00
Sean Harvey
8c88519d9f BUGFIX Fixed use of undefined constant error, and undefined variable error in TableField stopping CMS user from adding records to a TableField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69870 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:55 +13:00
Sean Harvey
d0831b37b6 MINOR Moved form session error set up from Form constructor to method so it can be used again if need be 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69843 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:55 +13:00
Sean Harvey
eecda158c3 ENHANCEMENT Caption support for the HtmlEditorField in the SS CMS. Ticket #2937 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69824 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:55 +13:00
Sean Harvey
2d7237d65f BUGFIX If TreeDropdownField source object is "Folder", don't show "File" tree items unless the marking filter function is explicitly set. This fixes the bug where files were appearing for selecting a folder in the thumbnailstrip field in CMS 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69803 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:54 +13:00
Sam Minnee
6ff158cee4 Better error messages when HasManyComplexTableField can't configure itself properly. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69731 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:54 +13:00
Sam Minnee
4f32e1873b BUGFIX #3248: Fixed TreeDropdownField when using non-ID key field 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69696 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:54 +13:00
Sam Minnee
5f9120e99e BUGFIX #3188: Fixed default HeaderField name to be non-conflicting with other fields, for backward compat 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69695 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:54 +13:00
Ingo Schommer
c3074cae5d BUGFIX Don't include Validator.js if Validator->javascriptValidationHandler is set to 'none' (in Validator::__construct()). 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69689 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:54 +13:00
Ingo Schommer
adfc2131dd API CHANGE Enforcing usage of a Validator instance in Forms if its not explicitly passed to the Form constructor. By default a new RequiredField instance is used without any fields marked as required. This was necessary because some FormField implementations rely on their validate() method, sometimes as a wrongly placed processing hook, but mostly for security reasons. One example are file extension checks in FileField subclasses. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69688 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:54 +13:00
Sean Harvey
5bde2dbe93 BUGFIX CountryDropdownField now allows for title to be optional, which uses the name of the field if not set. This makes it consistent with DropdownField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69378 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:53 +13:00
Sean Harvey
1213a073a0 BUGFIX Added check before foreach() to fix potential HMCTF bugs 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69377 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:53 +13:00
Sam Minnee
1a9180abaa ENHANCEMENT: Update ForeignKey and Primary key default fields to use SQLMap for their dropdown source for better performance. 
API CHANGE: Add keyField and titleField arguments to SQLMap
BUGFIX: Get DrodpownField::$emptyString working when used with a SQLMap source

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69360 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sam Minnee
c0fc790e32 Simplified implementation of FieldSet::makeReadonlyField() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69350 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sam Minnee
d64297e9ee Simplified implementation of FieldSet::makeReadonlyField() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69349 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sean Harvey
c5ab033cdd ENHANCEMENT Added renameField() to FieldSet 
MINOR Added test for FieldSet->renameField() to test method behaviour

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69244 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Ingo Schommer
22a9f3ab91 MINOR logical bug in FormScaffolder 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69206 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:51 +13:00
Ingo Schommer
c5bb7b76a2 BUGFIX Making "Main" tab in FormScaffolder translatable 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69203 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:51 +13:00
Ingo Schommer
522c34b6da MINOR Making CTF save button translatable 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68758 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:50 +13:00
Sam Minnee
caa4ddf3fd ENHANCEMENT: Allow HtmlEditorField on front-end forms 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68701 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:49 +13:00
Sam Minnee
bb7027484e Made CalendarDataField JS more self-suffficient 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68700 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:49 +13:00
Sean Harvey
f93b782e94 BUGFIX Fixed HasManyComplexTableField/ManyManyComplexTableField issue with source items which broke from changes in r66080. Thanks hamish! 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68628 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:49 +13:00
Ingo Schommer
042a4f0fac BUGFIX Allowing FormAction instances to be readonly by setting disabled="disabled". Adding CSS class "disabled". 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68194 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:48 +13:00