Commit Graph

10084 Commits

Author SHA1 Message Date
Sean Harvey
2392f93ce1 Merge branch 'loop-segfault' of https://github.com/simonwelsh/silverstripe-framework into simonwelsh-loop-segfault 2012-05-11 14:10:23 +12:00
Sean Harvey
1616bae730 MINOR Adding phpdoc to HTTP::get_mime_type() 2012-05-11 14:05:40 +12:00
Simon Welsh
ab34688273 BUGFIX: Looping over a PaginatedList in the template caused a seg fault/bus error. 2012-05-11 14:03:31 +12:00
Sean Harvey
6f672e5f36 MINOR Fixing use of <% control %> with <% with %> or <% loop %> as necessary. 2012-05-11 13:49:20 +12:00
Sean Harvey
1e6a52616d Merge pull request #431 from robert-h-curry/7305-tabset-classes
MINOR: Changed classes on tabset li and a tags to match new standard.
2012-05-10 17:20:34 -07:00
Sam Minnée
f27de361d8 Merge pull request #433 from halkyon/use_of_deprecated_code
Replacing internal use of deprecated code
2012-05-10 17:16:44 -07:00
Sam Minnée
448b2141fd Merge pull request #432 from silverstripe-scienceninjas/mimetypes
API CHANGE: Do not rely on a specific OS mime type detection, use PHP fi...
2012-05-10 16:51:23 -07:00
Sean Harvey
46f51d5653 MINOR Fixing deprecated use of SQLQuery 2012-05-11 11:39:06 +12:00
Stig Lindqvist
dffae1a2e7 API CHANGE: Do not rely on a specific OS mime type detection, use PHP finfo
This also removes the $global_mimetypes that was generating weird errors when both HTTP and Mailer classes tried to modify and use it.

Support of finfo should be straightforward since PHP 5.3 includes that module that default
2012-05-11 11:34:07 +12:00
Sean Harvey
23c93b9a44 MINOR Fixing ArrayDataTest to use toMap() instead of getArray() which is deprecated. 2012-05-11 11:27:36 +12:00
Sean Harvey
1859070fa9 MINOR Fixing use of deprecated getAllFields(), mark field as deprecated properly. 2012-05-11 11:23:24 +12:00
Robert Curry
6dd94bd6f7 MINOR: Changed classes on tabset li and a tags to match new standard. 2012-05-11 11:12:44 +12:00
Sean Harvey
8a46e38613 API CHANGE Removed old HTTP::sendRequest() and HTTP::sendPostRequest()
functions which are sparsely used, and not maintained or tested. Use custom code instead.
2012-05-11 11:04:51 +12:00
Ingo Schommer
7f4c6e3d19 MINOR Fixed small button styles (now used in URLSegment "edit" button etc.) 2012-05-10 14:17:02 +02:00
Ingo Schommer
8b4afc01a7 Merge pull request #426 from halkyon/jquery_upgrade
MINOR Upgrade jQuery dependency to 1.7.2
2012-05-10 02:49:41 -07:00
Ingo Schommer
da1d910045 Merge pull request #427 from halkyon/jquery_ui_upgrade
MINOR Upgrade jQuery UI dependency to 1.8.20
2012-05-10 02:48:11 -07:00
Naomi Guyer
f2411cf13a BUGFIX: Uploads save button not visible (Trac #7294)
Fixed the calculation of height for the upload (non AssetUploads) area
so that the save button would show. Took off the min-height, as this
will cause UI issues when there are multiple files open for editing.
2012-05-10 11:41:10 +02:00
Naomi Guyer
106bd47e88 BUGFIX: #7295 Long Filenames break layout
Add text overflow and a max width to filenames.
2012-05-10 11:41:10 +02:00
Naomi Guyer
68f9cde226 BUGFIX: 7219-feedback-changes-file-upload
Altered files from ENHANCEMENT: UI Changes to FileUpload Area
(TRAC-7219 that were missed in the prior push
2012-05-10 11:41:09 +02:00
Ingo Schommer
8e1aae35de Merge pull request #428 from silverstripe-scienceninjas/datefield-calendar
BUGFIX: DateField with calender do not format the date correctly after it's picked from the calendar.
2012-05-10 02:17:52 -07:00
Ingo Schommer
2753744f9e ENHANCEMENT Moving X-Status message handling in CMS from global ajaxError to ajaxComplete handler, to allow success messages being passed this way as well. 2012-05-10 10:44:21 +02:00
Ingo Schommer
6956b1be5c Merge pull request #412 from adrexia/sapphire
---

The two bug fixes impact on the file area, but have wider reach.

BUGFIX: Colour Adjustments
Change the constructive button colour to match the colour used in the designs, and fix up calculations to produce the correct button colour.

BUGFIX: IE Colours
Replace hard coded colours in IE with variables, and refactor code so that shared IE7 and IE8 fixes are in one place.

ENHANCEMENT: UI Changes to FileUpload Area (TRAC-7219)
1. Add arrows to edit dropdowns
2. Adjust lightened fields so they dont look like input boxes, and fix rgba colours
3. Add ability to click file names to edit
4. Add feedback when edit button is hovered
5. Add feedback if a file has been opened for editing and shut again (saved changes, unsaved changes, unchanged)
6. Add ability to open and close all files to edit them all at once
7. Add overall feedback for file uploads, and fix NaN error
8. Fix up area to match design
9. Fix error messages so they fit in the provided space
10. Fix case where a single uploaded file errors
2012-05-10 10:27:11 +02:00
Stig Lindqvist
42e3d94639 Merge pull request #425 from halkyon/gridfielddetailform_lang
BUGFIX #7298 Fixed incorrect message in GridFieldDetailForm from en.yml
2012-05-09 23:03:26 -07:00
Stig Lindqvist
a5355a7f39 BUGFIX: DateField with calender do not format the date correctly after it's picked from the calendar. 2012-05-10 17:33:57 +12:00
Sean Harvey
c9900b7df2 MINOR Upgrade jQuery UI dependency to 1.8.20 2012-05-10 16:39:50 +12:00
Sean Harvey
1e8a89db8f MINOR Upgrade jQuery dependency to 1.7.2 2012-05-10 16:21:11 +12:00
Sean Harvey
c1f7e0ed48 BUGFIX #7298 Fixed incorrect message in GridFieldDetailForm from en.yml language file. 2012-05-10 15:46:54 +12:00
Sean Harvey
138ba0c5bf Merge pull request #424 from adrexia/chosen-bug
BUGFIX: typeof undefined error fix
2012-05-09 20:26:03 -07:00
Naomi Guyer
6c5255246f BUGFIX: typeof undefined error fix
Make chosen check if a trigger exists before continuing
2012-05-10 15:18:52 +12:00
Sean Harvey
321483f097 Merge pull request #422 from silverstripe-scienceninjas/member-mapInGroup
BUGFIX: Member::mapInGroups() throws SQL error
2012-05-09 19:28:29 -07:00
Sean Harvey
56e75b4486 MINOR Revert changes for 5.4 2012-05-10 14:11:33 +12:00
Sean Harvey
f30a3bd760 BUGFIX Database::doesSchemaNeedUpdating() if schemaUpdateTransaction is NULL, then return FALSE. If schemaUpdateTransaction is an array, then return TRUE. This replaces the automatic casting which is not clear. 2012-05-10 13:58:29 +12:00
Stig Lindqvist
bbe3879eaa BUGFIX: Member::mapInGroups() throws SQL error
Renamed the Member::mapInGroups() to Member::map_in_groups() since it's a static method and throws deprecation message if using the old variant.
Rewrote the mapInGroups to use a more ORMy way of fetching Members for a set of groups and included a test for.
2012-05-10 13:53:54 +12:00
Sean Harvey
7dcfdb05fa MINOR Fixing broken test on PHP 5.4 2012-05-10 13:40:35 +12:00
Sean Harvey
68c5066adf MINOR Remove old _ALL_CLASSES from old manifest builder (has been replaced since) 2012-05-10 13:25:04 +12:00
Sean Harvey
1f4aa0537b Merge pull request #421 from silverstripe-scienceninjas/bad-exception-throwing
BUGFIX Throwing an InvalidArgumentException without the new keyword results in a Fatal error
2012-05-09 17:56:57 -07:00
Stig Lindqvist
c05e80c9f3 Merge pull request #418 from halkyon/phpunit_fixes
Fixing phpunit.xml support, remove PHPUnit 3.4 support
2012-05-09 17:51:04 -07:00
Stig Lindqvist
ce5684c776 BUGFIX Throwing an InvalidArgumentException without the new keyword results in a Fatal error 2012-05-10 11:21:32 +12:00
Ingo Schommer
6655830231 MINOR Upgrading notes around tab rewrites 2012-05-09 17:47:19 +02:00
Ingo Schommer
11f4756225 ENHANCEMENT Auto-hiding tab bar in CMS forms if only a single tab is available (to save screen space and reduce UI clutter) (see #7261) 2012-05-09 17:19:20 +02:00
Ingo Schommer
8c9560d288 ENHANCEMENT FieldList->setTabPathRewrites() for better backwards compatibility (see #7261) 2012-05-09 17:18:16 +02:00
Sean Harvey
a1d676d353 BUGFIX Ensure PHPUnit 3.6 is available, show a nice message if not 2012-05-09 23:40:25 +12:00
Sean Harvey
b1e17578c7 API CHANGE Removed assertType() and assertEmpty() workarounds. Use assertInstanceOf()
instead of assertType(), assertEmpty() is available in PHPUnit 3.5+.
PHPUnit 3.4 is no longer supported, so please upgrade your version to
work.

MINOR Removed FullTestSuite which was a workaround for PHPUnit but not
used.
2012-05-09 23:05:39 +12:00
Sean Harvey
8b607db0a2 BUGFIX Fixing bootstrap.php to work with FakeController properly for
running tests using phpunit.xml file.
2012-05-09 23:05:38 +12:00
Ingo Schommer
f546ab2a70 Merge pull request #417 from halkyon/sapphire
---

Ensure the lazy loaded form inside htmleditorfield-dialog is redrawn when lazy loaded. This fixes the initial state for the insert link dialog form.

Also ensure the link form uses "internal" as the default, so the initial state doesnt show all fields, just those associated with the first radio option "internal".

This also fixes http://open.silverstripe.org/ticket/7273.
2012-05-09 11:26:01 +02:00
Ingo Schommer
82db28811d BUGFIX Show progress indicator when uploads are added to AssetUploadField, to ensure that failed uploads (e.g. exceeding max filesize) can actually show their error message to the user 2012-05-09 11:19:06 +02:00
Ingo Schommer
9950fa362e Merge pull request #413 from chillu/urlsegment-multibyte-fix
URLSegment multibyte fixes
2012-05-09 01:32:58 -07:00
Ingo Schommer
1671b9c65c BUGFIX Checking for mbstring PHP extension support in installer, as it has been a documented installation requirement for a while. Removing method_exists() checks from mbstring usage in core for the same reasons 2012-05-09 10:25:31 +02:00
Ingo Schommer
6f9483cafe Merge pull request #415 from halkyon/datamodel_doc_changes
MINOR Updating docs to use Member::get() instead of DataList::create('Member')
2012-05-09 00:27:19 -07:00
Naomi Guyer
d642eee28e ENHANCEMENT: UI Changes to FileUpload Area (TRAC-7219)
1. Add arrows to edit dropdowns
2. Adjust lightened fields so they don't look like input boxes, and fix
rgba colours
3. Add ability to click file names to edit
4. Add feedback when edit button is hovered
5. Add feedback if a file has been opened for editing and shut again
(saved changes, unsaved changes, unchanged)
6. Add ability to open and close all files to edit them all at once
7. Add overall feedback for file uploads, and fix NaN error
8. Fix up area to match design
9. Fix error messages so they fit in the provided space
10. Fix case where a single uploaded file errors
2012-05-09 18:38:21 +12:00