Commit Graph

21702 Commits

Author SHA1 Message Date
Robbie Averill
a1f0d7a3bf
Merge pull request #9016 from sminnee/partial-fix-4622
FIX: Better message when form action handler not found.
2019-05-30 09:22:54 +12:00
Thomas Ocean
e30483a7dc Removed unused use BadMethodCallException statement. 2019-05-30 09:08:33 +12:00
shoosah
80e4886c3f Add getter and change visibility for whitelist_array property 2019-05-28 14:15:12 +12:00
Rafael Marins de Sousa
f7c1be7ac1 Including canCreate in if statement so that button gets removed if user isn't to be able to create new records 2019-05-28 12:28:00 +12:00
shoosah
d740998463 Improve displayQuery and benchmarkQuery functions and whitelist_array variable 2019-05-28 12:00:05 +12:00
shoosah
d684c69f09 Allow displaying partial/full query message for debugging 2019-05-28 12:00:05 +12:00
Andre Kiste
2c8c643ce3 MigrateFileTask now outputs "Done" when it has finished running (#8995) 2019-05-28 09:45:13 +12:00
Maxime Rainville
4f39e59aff BUG Enable file hash caching when running the file migration task (#8993) 2019-05-28 09:37:45 +12:00
Maxime Rainville
5b6d0946f4 API Add extension points to MigrateFileTask (#8994)
* API Add extension points to MigrateFileTask

* Apply suggestions from code review

Co-Authored-By: Guy Marriott <guy@scopey.co.nz>
2019-05-28 09:24:01 +12:00
Maxime Rainville
7ef604807c BUG Enable file hash caching when running the file migration task (#8993) 2019-05-28 09:21:11 +12:00
Maxime Rainville
9bfce8c1a4 API Add extension points to MigrateFileTask (#8994)
* API Add extension points to MigrateFileTask

* Apply suggestions from code review

Co-Authored-By: Guy Marriott <guy@scopey.co.nz>
2019-05-28 09:19:05 +12:00
Guy Marriott
f97ca26e76
Merge pull request #9014 from sminnee/fix-4142
FIX: List default items in the readonly view of ListboxField
2019-05-27 20:13:20 +12:00
Guy Marriott
a01e2496e5
MINOR: Add tests for GroupedDropdownField empty strings (#9015)
MINOR: Add tests for GroupedDropdownField empty strings
2019-05-27 20:05:12 +12:00
Sam Minnee
7407096e99 FIX: List default items in the readonly view of ListboxField
Adds tests for non-readonly default items too.

Fixes #4142
2019-05-27 17:47:09 +12:00
Sam Minnee
2c71daacfe MINOR: Add tests for GroupedDropdownField empty strings
These bugs were never present in SS4 as the relevant code had a
substantial rewrite at the same time they were introduced in SS3.
In SS3, test C still fails.

Fixes #4705
Fixes #4987
Fixes #4793
2019-05-27 17:46:03 +12:00
Sam Minnee
983d36b7ee FIX: Better message when form action handler not found.
Fixes #4622 to some extent, although this fix will be most useful when
https://github.com/silverstripe/silverstripe-errorpage/issues/30 is
addressed also.
2019-05-27 15:00:10 +12:00
Robbie Averill
58791e52b6
Merge pull request #9007 from NightJar/pulls/4.0/headerfield
FIX HeaderField requires the optional Title field
2019-05-27 10:50:15 +12:00
Robbie Averill
d873779956 API checkHistoricalPasswords(), characterStrength() and minLength() are now correctly deprecated from 4.5.0 onwards 2019-05-27 09:12:32 +12:00
blueskies79
c7eede1d66
Reverted DBField & list both [Field] and [DBField]
I changed the list of types to the suggested format for clarity and changed Field back to DBField as suggested.
2019-05-26 15:40:25 +02:00
Dylan Wagstaff
25aa3af032 FIX HeaderField requires the optional Title field
FormField marks the Title constructor argument as optional, and DatalessField does not override the __construct method. HeaderField on the other hand goes against the grain of FormFields as a whole and requires the Title field, seemingly for no good reason (at least, not that the commit message for a68ba38478 indicates) - this seems like an accidental ommision. This commit looks to reinstate the optionality of this constructor argument for consistency's sake.

Plus it broke a module I was investigating.
2019-05-24 13:44:01 +12:00
blueskies79
f08915ccf2
Update 04_Data_Types_and_Casting
This is a suggestion to update the docs to use the actual type names used in code. All the examples use the non-DB type names (ie: 'Wheels' => 'Int') but the bulleted list suggests it should be 'Wheels' => 'DBInt'. This is a bit confusing for new SS developers. Could we change this?
2019-05-23 12:09:59 +02:00
Robbie Averill
5851979096
Merge pull request #9002 from open-sausages/pulls/4/docs-file-access
DOCS Clarified file permission control
2019-05-23 15:38:07 +12:00
Robbie Averill
f06439f81e
Merge pull request #9003 from sminnee/min-php71-ss45
API: Drop PHP 5.6 and PHP 7.0 support in SS 4.5
2019-05-23 13:57:06 +12:00
Sam Minnee
ac35344041 API: Drop PHP 5.6 and PHP 7.0 support in SS 4.5
This was discussed and agreed in #8556. The two changes are 
composer.json and travis. The docs have also been updated. No other
code changes have been made.
2019-05-23 13:10:45 +12:00
Ingo Schommer
75f87ac409 DOCS Grammar fixes 2019-05-23 10:38:56 +12:00
Ingo Schommer
1cb22b665d DOCS Clarify different file access types
[ci-skip]
2019-05-23 09:25:46 +12:00
Ingo Schommer
74c869f362 DOCS Note about custom File->canView()
See https://github.com/silverstripe/silverstripe-framework/issues/8493

[ci-skip]
2019-05-23 09:14:36 +12:00
Ingo Schommer
c82c1520fc DOCS Clarified file permission control
[ci-skip]
2019-05-23 09:08:08 +12:00
Robbie Averill
e948c5eb1e DOCS Update "release numbering" to document the fact that lock step releases are not required (#9000)
* DOCS Update "release numbering" to document the fact that lock step releases are not required

[ci skip]

* DOCS Update "making a SilverStripe core release" to clarify recipe versus module without lock step

Also adds note about peer reviewing the plan before release

[ci skip]
2019-05-22 10:16:24 +12:00
Guy Marriott
b9a8f64ef0
Update wording in example in syntax docs 2019-05-20 16:38:55 +12:00
Robbie Averill
7a85b89817
Merge pull request #8983 from open-sausages/pulls/4/sec-process-clarification
DOCS Clarify CVE process
2019-05-16 11:24:04 +12:00
Robbie Averill
32c04ce765
Merge pull request #8979 from silverstripe-terraformers/feature/add-extension-for-schema-validation
Add extend function in getSchemaValidation function
2019-05-16 11:22:45 +12:00
Guy Marriott
350888bf50 NEW Adding a shuffle method to ArrayList (#8984)
* NEW Adding a shuffle method to ArrayList

* API Add shuffle to DataList for ArrayList parity
2019-05-16 09:26:11 +12:00
Ingo Schommer
71e9f2faad DOCS Clarify CVE process
[skip ci]
2019-05-15 13:30:59 +12:00
Aaron Carlino
3f1479edbb
BUGFIX: DataQuery overwriting _SortColumn selects (#8974)
* BUGFIX: DataQuery overwriting _SortColumn selects

* FIX DataQuery _SortColumn handling
2019-05-15 11:42:10 +12:00
Robbie Averill
ec71cdd103
Merge pull request #8982 from jmfederico/patch-4
Fix link to related lesson
2019-05-15 09:14:32 +12:00
Robbie Averill
b0143a32c8
Merge pull request #8981 from jmfederico/patch-3
Fix link to es6features
2019-05-15 09:11:59 +12:00
Federico Jaramillo Martínez
368c88d59a
Fix link to related lesson 2019-05-14 12:06:17 -05:00
Federico Jaramillo Martínez
207cf75dc4
Fix link to npmjs 2019-05-14 07:20:49 -05:00
Federico Jaramillo Martínez
08e08160c1
Fix link to es6features 2019-05-14 07:18:09 -05:00
shoosah
4da8be3bf5 Add extend function in getSchemaValidation function
This allows to create extensions which add validation list
2019-05-14 09:47:14 +12:00
Loz Calver
7cde15f375
Merge pull request #8854 from sminnee/travis-php74
NEW: Add PHP 7.4’s daily snapshot to the travis suite.
2019-05-13 09:45:11 +01:00
Sam Minnee
3a6a6e4850 NEW: Add PHP 7.4’s daily snapshot to the travis suite.
This will help avoid any inadvertent 7.4 failures; IMO the sooner we
add new releases to the test mix the better.

If this ends up creating intermittent failures outside of our control
I would recommend rolling back entirely rather than adding to
allowed_failures.
2019-05-13 17:37:59 +12:00
Aaron Carlino
dfa90715f7 Merge branch '4.4' into 4 2019-05-13 16:08:05 +12:00
Guy Marriott
abaeeb9432
Merge branch '4.3' into 4.4 2019-05-13 15:56:41 +12:00
Guy Marriott
53cb804929
Merge branch '4.2' into 4.3 2019-05-13 15:56:23 +12:00
Guy Marriott
3a5c14f7c2
FIX password validation min length message (#8976)
FIX password validation min length message
2019-05-13 15:55:31 +12:00
Guy Marriott
80ca7c2531 Commenting the PR template so it's not included in PR messages by default (#8967)
This works as Markdown is just augmented raw HTML
2019-05-13 15:49:07 +12:00
matt-in-a-hat
db0e6f7104 Fix password validation min length message
When relying on static config instead of an explicitly set minLength then this message would show without the value, like "it must be  or more characters long".
2019-05-13 13:43:29 +12:00
Robbie Averill
eaace98629
Merge pull request #8975 from aNickzz/patch-1
Swap argument order for implode
2019-05-11 09:47:49 +12:00