Commit Graph

22444 Commits

Author SHA1 Message Date
Serge Latyntsev
b71b605251
Merge pull request #9730 from creative-commoners/pulls/4/provisional-changelogs
DOC Add note about creating provisional changelogs following minor releases
2020-10-13 13:22:54 +13:00
Garion Herman
256bd53557 DEP Remove unused league/flysystem requirement
This has been shifted to silverstripe/assets instead.
2020-10-13 12:15:56 +13:00
wernerkrauss
941df19e88
ENH Improve YamlReader exception message (#9731)
Fixes #9690
2020-10-12 22:38:13 +13:00
Serge Latyntsev
01b5551a5b
Merge pull request #9733 from creative-commoners/pulls/4.6/fix-tinymce-image-configs
FIX TinyMCEConfig image size presets handle incorrect values
2020-10-12 18:06:27 +13:00
Serge Latyntcev
58ed426653 FIX TinyMCEConfig image size presets handle incorrect values 2020-10-12 17:31:59 +13:00
Serge Latyntsev
e7d52d3f91
Merge pull request #9732 from creative-commoners/pulls/4/fix-tinymce-image-configs
FIX TinyMCEConfig image size presets handle incorrect values
2020-10-12 17:28:17 +13:00
Serge Latyntcev
034bace213 FIX TinyMCEConfig image size presets handle incorrect values 2020-10-12 16:54:29 +13:00
Garion Herman
ce3e642b12
Merge pull request #9729 from creative-commoners/pulls/4/provisional-4.7.0-changelog
DOC Add provisional 4.7.0 changelog
2020-10-12 13:03:19 +13:00
Garion Herman
d8b725dc80 DOC Add provisional 4.7.0 changelog [ci skip] 2020-10-12 11:17:33 +13:00
Garion Herman
1837c19833 DOC Add note about creating provisional changelogs following minor releases 2020-10-09 16:46:30 +13:00
Serge Latyntcev
9a1959607f DOC RFC-9687 Commit Prefixes conventions 2020-10-09 11:09:44 +13:00
Sam Minnée
c5d676fa4e
FIX Avoid test failure on use of narrow-NBSP (#9725)
For whatever reason (different locale version) my local dev env uses
narrow-NBSPs (Unicode 8239) rather than regular NBSP in its localised
strings. This patch makes the tests robust against this difference.

Note that this occurred running the tests in Lando.

Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-10-09 10:33:51 +13:00
Robbie Averill
bb7cf17e3c
Merge pull request #9722 from creative-commoners/pulls/4/fix-versioned-member-auth-tests
FIX Hardcode PasswordValidator config in VersionedMemberAuthenticatorTest
2020-10-05 21:39:58 -07:00
Garion Herman
198b25c900 FIX Hardcode PasswordValidator config in VersionedMemberAuthenticatorTest 2020-10-06 16:07:24 +13:00
Aaron Carlino
544b137328 Merge branch '4.6' into 4 2020-10-05 14:03:05 +13:00
Aaron Carlino
8053bc7a72 Merge branch '4.5' into 4.6 2020-10-05 13:49:06 +13:00
Guy Marriott
a6529dd202
Merge pull request #9719 from creative-commoners/pulls/4/doc-partial-caching-aggregates-gotcha
DOC Document partial template caching aggregates recommendation
2020-10-04 16:41:29 -07:00
Serge Latyntcev
c2d8d2790f DOC Document partial template caching aggregates recommendation 2020-10-05 11:29:19 +13:00
Sam Minnée
4ab36ac210
Merge pull request #9717 from robbieaverill/pulls/4.7/improve-stuff
Update spaces in syntax, single quotes, early returns where possible
2020-10-02 19:45:05 +13:00
Robbie Averill
7184703a57
Merge pull request #9516 from alessandromarotta/isLockectOut-call-LoginAttempt-getByEmail
isLockedOut() in Member.php call LoginAttempt::getByEmail but it passes to it the unique_identifier_field instead $this->Email
2020-10-01 17:43:30 -07:00
Robbie Averill
4d54a2110f Update spaces in syntax, single quotes, early returns where possible 2020-10-01 17:36:14 -07:00
Guy Marriott
478d487f0e
Merge pull request #9707 from robbieaverill/pulls/4.7/exceptions 2020-10-01 17:16:43 -07:00
Daniel Hensby
fe45655a2b
Merge pull request #9698 from sminnee/pulls/symfony4
Symfony 4 support
2020-09-30 23:22:51 +01:00
Sam Minnée
887b7d8af8
Merge pull request #9714 from creative-commoners/pulls/4/did-not-have-namespace
FIX Fix namespace parsing under PHP 8, tweak readability of parser
2020-09-30 17:15:25 +13:00
Garion Herman
8ad4c4e024 FIX Fix namespace parsing under PHP 8, tweak readability of parser
$hadNamespace was ambiguously named, so the original PHP 8 support
update marked it true when it was strictly meant to indicate that a
namespace separator token had been encountered, resulting in bungled
parsing of complex class specs like Class(["arg" => true]).
2020-09-30 16:16:30 +13:00
Aaron Carlino
2042d1c6b0
MINOR: Allow DevelopmentAdmin to have subclasses (#9702) 2020-09-26 21:21:16 +12:00
Dylan Grech
effe5c2e6f
#9706: Updated doc for case-sensitive filter (#9710)
* #9706: Updated doc for case-sensitive filter

* #9706: Updated doc for case-sensitive filter

Co-authored-by: Dylan Grech <dylangrech@innovativecodes.com>
2020-09-26 10:02:21 +12:00
Robbie Averill
ae1e17edec Update exception assertions in tests and remove deprecated annotations 2020-09-25 10:06:49 -07:00
Robbie Averill
27bd5d12e3 ENH Replace E_USER_ERROR errors with exceptions 2020-09-24 23:51:21 -07:00
Robbie Averill
9753d835fd
Merge pull request #9708 from RuthAdele/patch-3
Add namespacing to YAML example
2020-09-24 23:13:30 -07:00
RuthAdele
4e22277c69
Add namespacing to YAML example 2020-09-25 13:58:12 +09:30
Sam Minnee
8b3ef8f85a FIX: recipe-testing is only needed for behat.
The other dependencies that are required are already included in
require-dev.
2020-09-21 19:10:08 +12:00
Sam Minnee
9247bc8b79 NEW: Add Symfony 4 support alongside Symfony 3
- Remove duplicate key in YML file
 - Remove deprecated yaml dump indentation set (the constructor arg works in both ^3 and ^4)

Fixes #9274
2020-09-21 19:09:08 +12:00
Dan Hensby
ae0ece2b02
Merge pull request #9665 from creative-commoners/pulls/4/php8-fqcn-token 2020-09-18 20:44:22 +01:00
Daniel Hensby
8959212cff
Merge pull request #9700 from Michael-HEIW/unit-test-doc
Updated 00_Unit_Testing.md (#9699)
2020-09-18 14:52:34 +01:00
Michael Pritchard
86702f0ad4 Updated 00_Unit_Testing.md (#9699) 2020-09-18 14:13:08 +01:00
Ingo Schommer
ecb03562de
Merge pull request #9572 from sminnee/pulls/manymanylist-add-callback
NEW: Add/remove callbacks for relation lists
2020-09-18 16:56:20 +12:00
Sam Minnee
0d7c5a9ece NEW Add/remove callbacks on RelationList
This provides a mechanism for adjusting the behaviour of these
relations when building more complex data models.

For example the following example has a status field incorporates a
Status field into the relationship:

```php
function MyRelation() {
  $rel = $this->getManyManyComponents(‘MyRelation’);
  $rel = $rel->filter(‘Status’, ‘Active’);

  $rel->addCallbacks()->add(function ($relation, $item, $extra) {
    $item->Status = ‘Active’;
    $item->write();
  });
}
```

Introduces a new library dependency: http://github.com/sminnee/callbacklist
2020-09-18 13:33:42 +12:00
Maxime Rainville
ff18dec2e5
API Add new behat method for interacting with toasts (#9695) 2020-09-17 17:12:35 +12:00
Garion Herman
0746230172
DOC Add process for releasing individual module patches (#9626)
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
2020-09-17 16:37:58 +12:00
Garion Herman
a712000404
Merge pull request #9682 from silverstripe-terraformers/feature/partial-cache-docs
DOCS: Example of partial cache expiry setting.
2020-09-16 15:49:50 +12:00
Sacha Judd
5d38e24dd7
Merge pull request #9692 from open-sausages/pulls/4/remove-boostrap3-class
BUG Remove old boostrap 3 CSS class
2020-09-16 11:46:28 +12:00
Maxime Rainville
acce4c4ce7 BUG Remove old boostrap 3 CSS class 2020-09-16 11:03:27 +12:00
Sam Minnée
90512430d7
Merge pull request #8846 from kinglozzer/template-parser-bugs
Template parser bugs
2020-09-16 09:50:29 +12:00
Loz Calver
bca0f28b62
FIX: Make template parser error on mismatched brackets (fixes #8845) 2020-09-15 16:54:24 +01:00
Loz Calver
bfc3b4b468
FIX: Stop empty comments breaking the template parser (fixes #8742) 2020-09-15 16:54:22 +01:00
Sam Minnee
85252ca05e FIX: Ensure Embed options are always array
This maintains support for embed 3.0.0.
2020-09-15 17:40:42 +12:00
Sam Minnee
24dfe0b026 NEW: Add --prefer-lowest to PHP 7.1 build
This build will ensure that older versions of packages that we claim
work with silverstripe/framework do, in fact, work.

‘Composer install’ changed to ‘composer update’ as that’s what’s being
executed in the absence of a composer.lock, and better clarifies intent.

Note that:

 * Support for nikic/php-parser ^2 was lost in 25759ffc5f.

 * Support for monolog/logger < 1.16 was lost in 7ab55a4948
2020-09-15 17:40:42 +12:00
Garion Herman
099ee2deb7 FIX Remove extraneous @depends annotations 2020-09-15 17:40:42 +12:00
Garion Herman
f1c94e6d54 FIX Allow quotes in expected ReflectionExceptions within tests 2020-09-15 17:40:42 +12:00