tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
2,777 Commits 31 Branches 527 Tags 162 MiB
f18136c130
Commit Graph

1178 Commits

Author SHA1 Message Date
Hayden Smith
338f286642 Added getter to retrieve alternative database name. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69815 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:54 +13:00
Sam Minnee
f28715775d BUGFIX #2342: Database names with hyphens and other special characters can now be used. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69715 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:54 +13:00
Sam Minnee
63de49eab1 BUGFIX #3224 ajshort: Get HTTP::setGetVar() working with variables that contain array indexes 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69700 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:54 +13:00
Sam Minnee
d46cde0ae1 BUGFIX #3165 nicolaas: Fixed Director::history() in some cases. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69697 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:54 +13:00
Sean Harvey
e5bafe0467 MINOR Updated correct HTTPRequest class for @deprecated notice on HTTP::sendFileToBrowser() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69686 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:53 +13:00
Will Rossiter
7b00e015fa MINOR: merge patch from ajshort: allow db build without running requireDefaultRecords 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69562 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:53 +13:00
Sean Harvey
ae2cb53fb1 ENHANCEMENT Add a <span class="highlight"> around all keywords (space delimited) and not just the entire search phrase 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69370 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:53 +13:00
Sean Harvey
42520dff8f MINOR Removed @todo from Text->ContextSummary as it's already done 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69369 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:53 +13:00
Sean Harvey
2ac842538d MINOR Added phpDoc to Text->ContextSummary() $string argument 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69368 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:53 +13:00
Sam Minnee
1a9180abaa ENHANCEMENT: Update ForeignKey and Primary key default fields to use SQLMap for their dropdown source for better performance. 
API CHANGE: Add keyField and titleField arguments to SQLMap
BUGFIX: Get DrodpownField::$emptyString working when used with a SQLMap source

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69360 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sean Harvey
ac83f9d4d9 MINOR Added todo and phpDoc to Text->ContextSummary() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69348 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sean Harvey
316124989d MINOR Added phpDoc to Convert::raw2xml() and Convert::raw2js() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69225 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sean Harvey
05dd641817 ENHANCEMENT Allow choosing ellipsis for truncated text on Text->LimitWordCountXML() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69224 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sean Harvey
5f0bbbc0da BUGFIX Strip potential whitespace from the beginning and end of string before limiting word count in Text->LimitWordCount(), fixing potential interference with truncation process 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69222 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sean Harvey
6a04824ef9 MINOR Removed comment that isn't appropriate 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69221 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sean Harvey
358fbd418e BUGFIX Fixed Text->LimitWordCount() not returning the correct number of words in the truncated text. 
MINOR Added TextTest for testing Text class methods

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69220 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:51 +13:00
Sean Harvey
576f7e15c6 MINOR Updated phpDoc cautionary message on Text->LimitCharacters() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69219 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:51 +13:00
Sean Harvey
9ded3dfd1f MINOR Added documentation to various Text class methods for limiting field values 
ENHANCEMENT Added ability to define the ellipsis for LimitWordCount() setting "..." as the default

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69218 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:51 +13:00
Ingo Schommer
5115c38355 ENHANCEMENT Changed order of array merging in DataObject->db() - contains fields from subclasses at end of the array instead of the beginning. Important because db() is used by FormScaffolder, which shoved custom fields on the front of auto-generated forms. Shouldn't have any effect on the actual content of returned array 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69207 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:51 +13:00
Sam Minnee
5a5bdef2ba BUGFIX: Fixed bug in SQLQuery::unlimitedRowCount() when used with grouped queries, that should fix a lot of pagination situations. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68940 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:51 +13:00
Andrew O'Neil
064a9019b0 BUGFIX: Make sure date is a string before trying to use strtotime 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68834 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:50 +13:00
Ingo Schommer
1cdb9bb61d BUGFIX Fixed sprintf detection bug in SiteTree->getClassDropdown() 
ENHANCEMENT Appending classnames to translated pagetype titles in SiteTree->getClassDropdown() when the cms is loaded in a non-english version - see inline comment

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68817 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:50 +13:00
Andrew O'Neil
915decb1f6 BUGFIX: Check hasChanged method exists before calling it 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68809 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:50 +13:00
Ingo Schommer
5a31a74b6f BUGFIX Fixed label spacing in Date->TimeDiff() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68762 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:50 +13:00
Ingo Schommer
76f4af842e ENHANCEMENT Making Date->Ago() translatable 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68761 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:50 +13:00
Ingo Schommer
7f2f047285 BUGFIX Including all translated language tables by default in i18n::_t() instead of selectively including modules based on filename. This caused bugs where entities were located in language tables in a different module than their filepath would suggest. Example: Page.SINGULARNAME is stored in sapphire/lang/en_US.php, while Page.php is stored in mysite/Page.php 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68751 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:49 +13:00
Ingo Schommer
18a6b34836 ENHANCEMENT Improved translation of SiteTree->getClassDropdown() - setting page name in quotes, using i18n singular/plural titles, using sprintf() to output "change to..." content 
ENHANCEMENT Using i18nEntityProvider on SiteTree to ensure entities in "Page" namespace get stored on sapphire instead of the "module folder" for Page.php - we can't make those properties translatable within core if they are in a custom folder
MINOR translation

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68747 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:49 +13:00
Ingo Schommer
c2009025bf BUGFIX Don't overwrite existing module arrays in i18nTextcollector - fixing bug with entities for "foreign modules" being reset during parsing 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68746 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:49 +13:00
Ingo Schommer
b32226f809 ENHANCEMENT Allowing textcollection of multiple modules selectively 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68745 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:49 +13:00
Sam Minnee
82e7f65c81 API CHANGE: ContentNegotiator is now disabled by default, unless you include the xml header in your template. 
API CHANGE: ContentNegotiator is now disabled by default, unless you include the xml header in your template. (merged from r68482)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68484 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:48 +13:00
Sam Minnee
63aa35092b Merged r67482 to branches/2.3 - let db/build add auto_increment 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68474 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:48 +13:00
Sam Minnee
b26bd547ba BUGFIX: Escape table name in versioned to allow creation of page type classes with the same names as SQL reserved words 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68170 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:48 +13:00
Ingo Schommer
8c7eb98f1e ENHANCEMENT Added support for specifying target module in i18nEntitityProvider->provideEntities() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68160 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:48 +13:00
Ingo Schommer
3f189f3950 ENHANCEMENT Added support for specifying target module in i18nEntitityProvider->provideEntities() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68156 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:48 +13:00
Ingo Schommer
98c00440ad BUGFIX Added stub PDODatabase->renameField() implementation to avoid errors when batch-instanciating singletons 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68155 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:48 +13:00
Ingo Schommer
dcfb88b2e8 BUGFIX Improved DataObjectSet->PaginationSummary() to show full context (instead of halved) when on first or last page 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68039 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:47 +13:00
Sean Harvey
401a6b8e70 MINOR Added whitespace after <!-- end include to be consistent 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68029 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:47 +13:00
Sean Harvey
79baa1b092 BUGFIX Fixed undefined variable $matches in SSViewer::parseTemplateContent() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68026 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:47 +13:00
Sean Harvey
22b1b81843 BUGFIX SSViewer::set_source_file_comments(false) wasn't working because of lack of checking if enabled. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68024 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:47 +13:00
Ingo Schommer
d530706093 ENHANCEMENT Documented and improved DataObjectSet->PaginationSummary(). Removed DataObjectSet->paginationSummaryDots 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67984 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:47 +13:00
Saophalkun Ponlu
06efa9e0c8 Changed ... to html entiries &hellip; 
PaginationSummary return all pages by default

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67877 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:47 +13:00
Saophalkun Ponlu
d5abb2bd87 Added PaginationSummary function that enable DataObjectSet to display a portion of page list 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67793 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:47 +13:00
Sam Minnee
f1c1eb218e BUGFIX: Added check ot i18n::include_by_class() to prevent repeated calls. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67777 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:47 +13:00
Ingo Schommer
d9b3abf8ac MINOR Documented ClassInfo::subclassesFor() and added unit tests 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67689 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:47 +13:00
Sean Harvey
b2c88c2f5b MINOR Updated phpDoc for Requirements::customCSS() and Requirements_Backend::customCSS() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67682 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:46 +13:00
Sean Harvey
e4c0b3779d BUGFIX Method not found error. Requirements::customCSS() should be calling self::backend()->customCSS() not custom() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67678 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:46 +13:00
Sean Harvey
b9e1fc0692 MINOR Added phpDoc to Requirements::customCSS() and Requirements_Backend::customCSS() to be clear about what should be included 
MINOR Code formatting cleanup

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67676 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:46 +13:00
Sam Minnee
0b0908f8a3 BUGFIX: SSDatetime can handle being given a NZ date in dd/mm/yyyy format 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67530 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:45 +13:00
Ingo Schommer
0cacc25a12 BUGFIX Fixed i18n::get_owner_module() to detect template paths in themes (array notation) correctly (see #3022) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67520 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:45 +13:00
Ingo Schommer
6425dd7237 ENHANCEMENT Added SSViewer::get_source_file_comments() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67502 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:45 +13:00
Sean Harvey
c96d891c2c MINOR Removed whitespace after ?> end PHP tag 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67467 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:45 +13:00
Sam Minnee
681c05d088 API CHANGE: Added SSViewer::set_source_file_comments() to allow disabling of comments in SSViewer output 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67426 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:44 +13:00
Ingo Schommer
2381e480c3 ENHANCEMENT Allowing custom methods in DataObjectSet->column() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67345 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:44 +13:00
Sean Harvey
90fb060b58 BUGFIX Since ModelAsController->handleRequest() expects a URLSegment, we make the ErrorPage Link() return a relative URLSegment in ErrorPage->publish() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67304 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:44 +13:00
Sean Harvey
9cf909e6ca MINOR Declared Director::direct() and Director::test() as static functions to avoid confusion 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67301 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:44 +13:00
Sean Harvey
dd0dbddb4b MINOR Code formatting improvements for Director->test() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67300 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:44 +13:00
Sean Harvey
7c03f7364b BUGFIX Changed Director::test($this->URLSegment) to Director::test($this->Link()) in ErrorPage->publish() to be more robust 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67299 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:44 +13:00
Ingo Schommer
1b1b1a1d78 MINOR Re-enabled calls to updateCMSFields() accidentally disabled in r67294 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67295 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:44 +13:00
Ingo Schommer
3b50d5de00 ENHANCEMENT Added SITETREE_GRANT_ACCESS permission code to SiteTree to control editability of the "Access" tab (incl. unit tests) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67294 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:43 +13:00
Sam Minnee
ba0c2380e9 BUGFIX: dev/build should function even when new classes are referenced in _config.php 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67271 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:43 +13:00
Josh Kosmala
d839201092 BUGFIX: Filter on the baseclassid in Hierachy, not the class id, in case the class doesnt have a table (aoneil) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67268 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:43 +13:00
Sam Minnee
e802eaa1d9 ENHANCEMENT: Make it easier to create pageless subclasses of Page_Controller 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67242 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:43 +13:00
Ingo Schommer
958ad1c4e0 MINOR Merged r66794 from trunk (related to #3192) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67213 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:41 +13:00
Andrew O'Neil
c305bf3e1e BUGFIX: Fixed incorrect permission checking when the current member isn't being used 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67199 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:41 +13:00
Andrew O'Neil
2132e8e301 Merged r67152 from trunk 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67194 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:41 +13:00
Ingo Schommer
4469283166 BUGFIX Checking for "$this instanceof VirtualPage" instead of "$this->class == 'VirtualPage' to support subclassing in VirtualPage->onBeforeWrite() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67150 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:41 +13:00
Ingo Schommer
933ade1692 BUGFIX Checking for existence of $this->record in VirtualPage_Controller->init() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67140 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:40 +13:00
Andrew O'Neil
a037a24148 BUGFIX: Fix publishing of error pages 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67137 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:40 +13:00
Sean Harvey
88d7a32017 BUGFIX Put the order of save and publish buttons back to normal (so save and publish are next to eachother) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67078 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:40 +13:00
Ingo Schommer
b1846439a7 MINOR removed debug code 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67075 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:40 +13:00
Ingo Schommer
78406d7c1f ENHANCEMENT Moving "save" and "delete" cms actions from CMSMain->EditForm() into SiteTree->getCMSActions() to make them decoratable (e.g. disallow delete action) and easier to cover with unit tests. Leaving fallback "save" and "delete" actions in CMSMain in case no actions are defined (necessary e.g. for Group class in SecurityAdmin) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67061 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:40 +13:00
Sam Minnee
7671dc644b BUGFIX: Fixed Enum::scaffoldSearchForm() to always include an (All) option 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67045 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:40 +13:00
Sam Minnee
c7a4afee52 BUGFIX: Fixing tests 
ENHANCEMENT: Add <%-- --%> comments

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66946 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:40 +13:00
Ingo Schommer
3d5600c597 MINOR merged from trunk 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66944 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:40 +13:00
Ingo Schommer
3673a604c6 MINOR merged r66670 from trunk 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66942 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:39 +13:00
Sam Minnee
7cce6782bc BUGFIX #3115 ajshort: Fixed backslashes in temp folder location in manifest builder 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66918 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:39 +13:00
Sam Minnee
1aeaed7fc4 Better checking of tabstrip stuff 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66889 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:39 +13:00
Sam Minnee
331a427796 BUGFIX: Better generation of PastMember cookie when you have stale login info 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66888 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:39 +13:00
Sean Harvey
4a145c4e1b MINOR Code formatting conventions in HTTPRequest->param() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66819 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:39 +13:00
Ingo Schommer
322fa2a547 BUGFIX Returning a boolean instead of Permission IDs in specific SiteTree->canEdit() case 
BUGFIX Passing through $member param from SiteTree->canPublish() to SiteTree->canEdit()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66740 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:39 +13:00
Will Rossiter
18178c3e79 BUGFIX: fixed typo in filesystem 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66723 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:38 +13:00
Ingo Schommer
524a003d24 MINOR merged r66672 from trunk 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66700 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:38 +13:00
Ingo Schommer
93dd7600df ENHANCEMENT Renamed tab "Meta-data" to "Metadata" for better readability (see #3142) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66654 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:38 +13:00
Sam Minnee
be6e67a20f DataObject::relObject() throws an exception rather than an error so that it can be caught 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66645 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:38 +13:00
Sean Harvey
7874d09771 MINOR Removed redundant code 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66640 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:38 +13:00
Sean Harvey
0d450e6c3a BUGFIX Fixed flaw logic checking for $member variable, since it's always set the alternative for choosing Member::currentUser() would never work. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66638 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:37 +13:00
Sean Harvey
a2d5a9ac75 MINOR Code formatting of !isset($member) on SiteTree->canAddChildren() for consistency with other can*() methods 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66637 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:37 +13:00
Sean Harvey
8089d7b14c MINOR Renamed to correct updateCMSActions() in php comment 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66636 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:37 +13:00
Sean Harvey
640c50149d BUGFIX Fixed SiteTree->getCMSActions() so it returns a FieldSet, instead of a DataObjectSet. This makes it consistent with DataObject->getCMSActions() as well as SiteTree->getCMSFields() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66635 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:37 +13:00
Sean Harvey
4713842790 BUGFIX Fixed SiteTree->getCMSActions() not extending properly because it was passing an array to the extend() 2nd argument, which expected a FieldSet object 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66632 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:37 +13:00
Sean Harvey
53cef6b435 BUGFIX Fixed incorrect class name in user_error message for deprecated function HTTP::sendFileToBrowser() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66629 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:37 +13:00
Sam Minnee
b877ddb546 Added support to DataObject::relObject() for looking at $casting to get information about the relation - good for dynamic relations 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66582 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Will Rossiter
07e9aaa547 MINOR: added setter function to write_js_on_body() so I can override the settings 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66426 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Normann Lou
92e7071412 APICHANG: if a DataObject has getCMSActions, its model admin should be able to add them. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66392 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Sam Minnee
9d1be81b41 Merge pre-2.3-oct08 into 2.3 (via trunk) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66353 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Sam Minnee
2606f99fb4 ENHANCEMENT: Added comments in rendered templates to indicate the source .ss files, on dev sites only: 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66343 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Ingo Schommer
a9bc9c6845 BUGFIX Fixed ForeignKey->scaffoldFormField() usage of model class instead of relation class to generate dropdown list 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66313 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:35 +13:00
Sean Harvey
76f15e47bf MINOR Removed old references from workflow in SiteTree and VirtualPage (AssignedToID and RequestedByID were old properites of a workflow page type) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66311 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:35 +13:00
Ingo Schommer
647c25ca14 MINOR Added isset($_SERVER['HTTP_HOST']) checks to Director->isDev() and Director->isTest() - these environment variables are not available in CLI mode, and show up as PHP notices in a default cli-script/sake execution 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66302 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:35 +13:00
Sam Minnee
b40dbbb2f0 BUGFIX: Merged from trunk; fix DataObject::hasDatabaseFields() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66269 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Sam Minnee
0eac163b11 API CHANGE: Deprecated Controller::PastVisitor(), it generates a lot of unused cookies 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66268 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Sam Minnee
03c88ba020 Return an HTTPResponse consistently from controllers 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66267 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Sam Minnee
6d5db643ab API CHANGE: Improve encapsulation of cookies in Director::test() 
BUGFIX: Fix test/cookie conflict in ErrorPage rendering

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66266 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Sam Minnee
4f84e92dbf Fixed RequirementsTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66265 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Andrew O'Neil
d76611f380 #2771: Fix SQLQuery::filtersOnID() (wakeless) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66225 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Andrew O'Neil
4c81b8c3a5 BUGFIX #2714 - Cookie::set doesn't operate correctly with expiryDays 0 (wakeless) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66196 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Andrew O'Neil
e3298047c3 #2635 - More informative errors in DataObject (simon_w) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66192 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Ingo Schommer
c6bf307b94 ENHANCEMENT Moving GoogleSitemap functionality (priority dropdown and database fields) from SiteTree to GoogleSitemapDecorator 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66173 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Ingo Schommer
2153737da7 ENHANCEMENT Added SiteTreeDecorator 
ENHANCEMENT Addings hooks in SiteTree for onBeforeUnpublish and onAfterUnpublish
ENHANCEMENT Removed GoogleSitemap references in SiteTree (moving to decorator implementation)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66168 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:34 +13:00
Ingo Schommer
1cdca8a66a BUGFIX Fixed editable formfields not showing up in translation mode (#3083). Updated Translatable->updateCMSFields() by partially merging wakeless' patch from (r64523) 
ENHANCEMENT Added Translatable_Transformation (patched in r64523)
ENHANCEMENT Added TranslatableTest with minimal assertions about existing form fields in translation mode

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66137 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Ingo Schommer
db0815c115 BUGFIX Fixed PHP variable initialization in SiteTree->getClassDropdown() which broke class dropdown in behaviour tab (regression from r66092) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66107 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Ingo Schommer
e99ca1092f MINOR Fixed PHP Notice in SiteTree 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66092 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Ingo Schommer
df9472631e BUGFIX $cache flag wasn't passend through from ViewableData_Customised->XML_val() to ViewableData->XML_val() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66091 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Will Rossiter
a92d2120a1 Merged pre-2.3-oct08 into branches/2.3 (via trunk) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66084 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Sean Harvey
c7307eefad BUGFIX Fixed HTTP->findByTagAndAttribute missing variable error causing HtmlEditorField to break since it used HTTP::getLinksIn() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66070 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Sean Harvey
5df7e70cf8 BUGFIX Fix PHP notice where variable with array didn't exist in HTTP->findByTagAndAttribute() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66043 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Sean Harvey
b9115b8088 BUGFIX Fixed incorrect call to Permission::checkMember() - missing second argument, first argument should've been a Member object or Member ID 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66027 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:32 +13:00
Sean Harvey
3c7a72e22a BUGFIX Fixed PHP notice level error in some circumstances in DataObject->buildDataObjectSet() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66026 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:32 +13:00
Sam Minnee
176a865dc4 Boundary condition check for top-level pages with 'inherit' permission 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66008 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:32 +13:00
Sam Minnee
9a45672aa4 Update sapphire so that it can run with the default .htaccess and mysite/_config.php files provided in the phpinstaller. If database config is missing, then redirect to install.php 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@65981 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:32 +13:00
Sam Minnee
60eafbcd9d Added validation for DataObject::db, has_one, has_many, many_many, belongs_many_many properties, so that improper use of the array syntax doesn't raise strange bugs elsewhere. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@65967 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:32 +13:00
Sam Minnee
f3543e670a BUGFIX #3066: Fix ?isDev=1 option 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@65923 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:32 +13:00
Sam Minnee
daac81e7f1 Set default view/edit permissions 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@65915 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:32 +13:00
Sam Minnee
6463503082 Added notinmenu class to CMS tree items that aren't in menus 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@65912 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:32 +13:00
Sam Minnee
10de47dc74 BUGFIX #2820: Fixed use of buggy reflection in Object::uninherited() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@65899 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:32 +13:00
Sam Minnee
4e2388848b BUGFIX #2232: Prevent requirements from breaking ErrorPage publication 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@65895 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:31 +13:00
Sam Minnee
a0167372f1 BUGFIX: Don't let permission errors on assets/ folder completely prevent javascript from loading 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@65881 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:31 +13:00
Sam Minnee
05e042427b BUGFIX #3061: Text.FirstSentence returns '.' instead of '' on an empty field 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@65842 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:31 +13:00
Sam Minnee
f11d7cc960 #2679: Auto-redirect renamed pages 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65781 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-13 02:10:15 +00:00
Sam Minnee
2f25dda9de Get sapphire to self-allocate at least 64M of memory, if possible. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65778 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-13 02:07:22 +00:00
Sean Harvey
0d5f7d2197 BUGFIX Missing variable in some circumstances caused Requirements::include_in_response() to break 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65763 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-13 01:39:30 +00:00
Sean Harvey
b23dad6c88 BUGFIX Missing variable in some circumstances caused Requirements::include_in_response() to break 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65761 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-13 01:31:31 +00:00
Sam Minnee
7c2861b0f4 BUGFIX: Added support for CSS media types to CSS on demand 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65711 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-12 21:44:35 +00:00
Hayden Smith
ac9eaa3c0d Removed time limit when minifying files and disabled processing of multiple files if on dev. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65709 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-12 21:15:58 +00:00
Sam Minnee
73a075a491 FEATURE #594: Added javascript-on-demand support 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65688 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-12 04:31:33 +00:00
Ingo Schommer
91c0ca0755 BUGFIX Adjusted Translatable to api changes from r65581 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65583 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-11 02:37:01 +00:00
Ingo Schommer
79a7e6d27a ENHANCEMENT Using actual classname in DataObjectSet->debug() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65582 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-11 02:36:30 +00:00
Sam Minnee
9565fec5ad FEATURE #2767 wakeless: Allow popuplation of non-DataObject tables with YamlFixture 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65555 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-10 23:18:31 +00:00
Ingo Schommer
5c9f0f120b BUGFIX Setting correct user locale in ImageField and FileIframeField - the controller is separate from the CMS context, so wasn't initialized with i18n (see #1727) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65539 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-10 19:54:30 +00:00
Ingo Schommer
5d9550c214 BUGFIX Making Metadata fields writeable in translation mode (see #2993) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65536 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-10 11:11:13 +00:00
Sam Minnee
58dbe416ee Merged from branches/2.2 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65523 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-10 03:51:35 +00:00
Ingo Schommer
9c9a461d67 BUGFIX Removed project-specific hack in DataObject->getManyManyComponentsQuery() as it was breaking Translatable saving 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65518 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-10 02:36:21 +00:00
Sam Minnee
648a459060 Ensure that Requirements backend instance is preserved between tests 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65507 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-10 01:13:42 +00:00
Sam Minnee
bf5493d703 #2997 - Added <% require %> tag to SSViewer 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65503 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-10 01:01:55 +00:00
Ingo Schommer
4452e9bb5b ENHANCEMENT Updated UpgradeSiteTreePermissionSchemaTask to rename obsolete database columns 
ENHANCEMENT Calling UpgradeSiteTreePermissionSchemaTask from SiteTree->requireDefaultRecords as a temporary workaround for missing migration infrastructure. This means that upgrading the schema for 2.3 can be done without manual task triggers, just the usual dev/build (see http://open.silverstripe.com/ticket/2847#comment:4)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65495 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-09 23:58:48 +00:00
Ingo Schommer
117806756c ENHANCEMENT Added Database->renameField() and Database->dontRequireField() 
ENHANCEMENT Added DatabaseTest

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65494 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-09 23:56:24 +00:00
Normann Lou
3cfd4d84a9 MINOR: type enviroment -> environment 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65485 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-09 23:25:02 +00:00
Ingo Schommer
e6a95566d9 MINOR Removed obsolete code from MySQLDatabase 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65484 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-09 23:21:16 +00:00
Sam Minnee
b4977f8500 Added default for HTTP_USER_AGENT 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65471 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-09 22:40:08 +00:00
Sam Minnee
4f6170c265 BUGFIX: Better initial-site-setup boundary condition checking needed after the manifest builder update 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65469 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-09 22:11:25 +00:00
Ingo Schommer
c7ff6016b8 BUGFIX Setting Director::set_site_mode('site') in RootURLController in newly added init() method, which fixes Translatable::choose_site_lang(). The original bug was a wrong selected language in the <meta> tags through SiteTree->MetaTags() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65462 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-09 14:20:19 +00:00
Ingo Schommer
192078d3d2 BUGFIX Using uncached DataObject::get_one() calls in ModelAsController to avoid stale data with subsequent Director::test() calls which alter the page relations inbetween 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65456 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-08 00:02:35 +00:00
Ingo Schommer
137b76e271 API CHANGE Deprecated DataObjectDecorator->augmentBeforeWrite(), use DataObjectDecorator->onBeforeWrite() 
API CHANGE Deprecated DataObjectDecorator->augmentPopulateDefaults(), use DataObjectDecorator->populateDefaults()
API CHANGE Deprecated DataObjectDecorator->augmentDefaultRecords(), use DataObjectDecorator->requireDefaultRecords()
API CHANGE Deprecated DataObjectDecorator->alternateCan(), use DataObjectDecorator->can()
API CHANGE Deprecated DataObjectDecorator->alternateCanAddChildren(), use DataObjectDecorator->canAddChildren()
API CHANGE Deprecated DataObjectDecorator->alternateCanView(), use DataObjectDecorator->canView()
API CHANGE Deprecated DataObjectDecorator->alternateCanDelete(), use DataObjectDecorator->canDelete()
API CHANGE Deprecated DataObjectDecorator->alternateCanEdit(), use DataObjectDecorator->canEdit()
API CHANGE Deprecated DataObjectDecorator->alternateCanCreate(), use DataObjectDecorator->canCreate()
ENHANCEMENT Added DataObject->onAfterDelete() and DataObjectDecorator->onAfterDelete()
ENHANCEMENT Added stub methods to DataObjectDecorator for documentation purposes

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65453 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-07 12:18:35 +00:00
Ingo Schommer
c30b5812d1 API CHANGE Don't include NULL returns in decorated methods called through Object->extend(), meaning empty method bodies in decorators won't confuse permission checks through $myObj->extend('canView') etc. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65451 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-07 12:09:39 +00:00
Sam Minnee
429f81ed14 Bugfixes to Requirements alterations 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65438 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-07 02:24:31 +00:00
Sam Minnee
cbbedab5a2 MINOR: Changed die() to user_error() so that correct error level is returned 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65437 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-07 02:07:18 +00:00
Sam Minnee
e6c4d32dbc ARCHITECTURE #3034 wakeless: Make Requirements mockable by pushing the meat of the functionality to Requirements_Backend 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65436 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-07 02:06:28 +00:00
Sam Minnee
bfc7c7717b Removed redundant code 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65397 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-06 21:01:12 +00:00
Sam Minnee
5a0db59850 BUGFIX: Fixed broken dev/build compilation of manifest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65394 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-06 20:57:07 +00:00
Normann Lou
2b0add5c72 APICHANGE: make DataObject::getField() visible to the public 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65388 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-06 06:32:05 +00:00
Sam Minnee
c1d6e82248 API CHANGE: Removed manifest's dependency on database, by removing hastable information [17:47:04] 
dquote> API CHANGE: Deprecate ClassInfo::ready() in favour of Security::database_is_ready()
dquote> API CHANGE: Create DataObject::has_own_table() to determine whether a DataObject has a table without looking at it.
dquote> API CHANGE: Exclude /tests/ directories from the manifest entirely except when tests are being run.
dquote> API CHANGE: Added ?usetestmanifest=1 flag to access the test manifest outside of test execution.
dquote> API CHANGE: Simplified Core.php manifest include to just call ManifestBuilder::include_manifest() - manifest takes care of its own cache file

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65385 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-06 04:51:25 +00:00
Ingo Schommer
728e691a1a BUGFIX Added SSViwer support for i18n namespaces in templates with <% _t('MyNamespace.MyEntity', ... %>, to work around magically added namespaces from the parsed template file. Those auto-namespaces were logically not working in includes, as the parsing context is always the including template. Legacy support for auto-namespaces is still present due to its high usage. 
ENHANCEMENT Added unit tests for i18n template parsing

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65361 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-06 02:50:14 +00:00
Ingo Schommer
ccd149f689 BUGFIX Reverted text replacement performance improvement in SQLQuery - it was replacing more ocurrences via str_replace() than the previous implementation based on arrays, which broke queries augmented by Translatable (originally committed in r60468 and r54044) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65291 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-05 14:23:17 +00:00
Sam Minnee
f3419bf046 BUGFIX #2243: Fixed ViewableData::Odd 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65275 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-05 04:31:53 +00:00
Sam Minnee
33219fcad2 BUGFIX #2954 - Fixed support for negative numbers in decimal fields 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65269 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-05 04:10:48 +00:00
Sam Minnee
020a92eda8 BUGFIX #2992: Fixed T_PAAMAYIM_NEKUDOTAYIM error in RequestHandler 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65250 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-05 01:59:27 +00:00
Will Rossiter
bb20921fef BUGFIX: fixed canPublish() so it actually got the member if none was passed and fixed notice with $results not existing 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65242 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-05 01:05:57 +00:00
Sam Minnee
5f177b9f08 BUGFIX #2056: Removed all references to deprecated Member::isAdmin() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65232 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-04 23:31:33 +00:00
Sam Minnee
72d90ab270 Set default edit rights on pages to be only administrators 
API CHANGE: Use return value of alternateCanPublish()
BUGFIX: Fixed the Link() value for homepage
BUGFIX: Allow DBField::__construct() without a name
API CAHNGE: Allow augmentPopulateDefaults on data object decorators

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65229 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-04 23:17:14 +00:00
Ingo Schommer
ca6d92341e API CHANGE Changed SiteTree->Viewers to SiteTree->CanViewType, Changed SiteTree->Editors to SiteTree->CanEditType (see #2847) 
API CHANGE Changed SiteTree->ViewersGroup has_one relationship to SiteTree->ViewerGroups has_many relationship (see #2847)
API CHANGE Changed SiteTree->EditorsGroup has_one relationship to SiteTree->EditorGroups has_many relationship (see #2847)
ENHANCEMENT Added 'Inherit' flag to SiteTree->CanViewType and SiteTree->CanEditType (see #2419)
ENHANCEMENT Added unit tests for SiteTree permissions
BUGFIX Checking recursively for permissions on children with SiteTree->canDelete()
BUGFIX Disallow SiteTree->canEdit() if SiteTree->canView() is not granted
Note: Use dev/tasks/UpgradeSiteTreePermissionSchemaTask/run to migrate legacy data to the new schema as outlined above

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65150 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-03 14:52:35 +00:00
Sam Minnee
c573d51d4c BUGFIX: Fixed bug with ID-less generation of YamlFixture entries that trigger $this->write() in setters 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65123 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-03 01:28:18 +00:00
Ingo Schommer
65d5cf088f ENHANCEMENT Scaffolding TextField instead of TextareaField in Text DBField due to size 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65092 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-02 21:07:09 +00:00
Ingo Schommer
3edc358ead ENHANCEMENT Added fieldLabels() overloading to various DataObject subclasses. Use this method instead of directly calling _t() in getCMSFields(), and use fieldLabel('MyField') to get the label for a specific FormField. This way, we can transparently support formfield scaffolding and re-use the labels for search fields automatically. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65072 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-02 20:04:10 +00:00
Ingo Schommer
eb4c950655 BUGFIX Reverted auto-detection of i18n statics like $db in DataObject through provideI18nEntities() - was getting too complicated with decorated properties. Overload DataObject->fieldLabels() or DataObjectDecorator->updateFieldLabels() instead 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65071 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-02 20:01:49 +00:00
Ingo Schommer
30f8c74283 API CHANGE Removed DataObjectSet->consolidate(), use DataObjectSet->toNestedArray() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65068 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-02 00:57:25 +00:00
Ingo Schommer
52ed342fc2 MINOR formatting 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65067 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-02 00:55:33 +00:00
Ingo Schommer
eb38e4d9c8 API CHANGE Removed DataObjectSet->consolidateString() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65066 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-02 00:55:12 +00:00
Ingo Schommer
09564b0132 API CHANGE Renamed DataObjectDecorator->loadExtraDBFields() to loadExtraStatics() 
API CHANGE Renamed DataObjectDecorator->extraDBFields() to extraStatics()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65065 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-02 00:36:57 +00:00
Ingo Schommer
4f23d59636 git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65064 467b73ca-7a2a-4603-9d3b-597d59a354a9 2008-11-02 00:29:11 +00:00
Ingo Schommer
b5b11842f9 BUGFIX Checking for array existence before iterating through DataObjectDecorator->provideI18nEntities() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65063 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-02 00:27:33 +00:00
Ingo Schommer
f06ae18409 API CHANGE Moved DataObject::get_by_url() to SiteTree::get_by_url() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65060 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-02 00:24:23 +00:00
Ingo Schommer
d19dd96793 API CHANGE Marked DataObject->filledOut() deprecated 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65059 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-02 00:17:39 +00:00
Ingo Schommer
0465365b51 MINOR Restructured code in Object.php to consistently have properties and important methods like __call() at the top of definitions (no logic changes). Added minor documentation. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65058 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-02 00:12:23 +00:00
Ingo Schommer
d102a902b9 BUGFIX Collecting i18n entities for decorators separately from the decorated classes, as decorated properties like $db have to be stored in the module of the decorated, not in the module of the decorated class. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65057 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-01 23:16:45 +00:00
Ingo Schommer
fd7bc64107 ENHANCEMENT Removed DataObjectDecorator->updateSummaryFieldsExcludeExtra() - was a straight copy of updateSummaryFields()... 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65056 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-01 23:00:50 +00:00
Ingo Schommer
4e567adec9 ENHANCEMENT Using eval() in textcollector to test for valid PHP syntax 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65054 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-01 19:05:16 +00:00
Ingo Schommer
cc9cf5be06 MINOR rearranged methods in i18nTextCollector 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65052 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-01 18:56:39 +00:00
Ingo Schommer
bfb7a0d863 BUGFIX Different class_implements() usage without instanciating the class in i18nTextCollector - not all classes are instanciatable without arguments. This raises the minimum requirement for text collection to PHP 5.1+ 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65030 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-01 14:49:37 +00:00
Ingo Schommer
4ecb895b0a ENHANCEMENT Added i18nEntityProvider interface (see comments in #1625) incl. unit tests 
MINOR documentation for i18nTextCollector

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65022 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-01 13:26:08 +00:00
Ingo Schommer
7239db8c1b ENHANCEMENT Allowing translation of some static properties on DataObject and subclasses through DataObject->fieldLabels(). Part of the provideI18nEntities() work which was started in r64881 (see #1625) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65020 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-01 13:23:38 +00:00
Sam Minnee
ba4a1acc68 BUGFIX: Don't allow calling of magically added methods via URL unless explicitly listed in allowed_actions 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64981 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-31 02:16:25 +00:00
Sean Harvey
e9f65ed8e1 BUGFIX Fixed wrong case of class names for ImageIFrameField causing errors 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64976 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-31 02:09:04 +00:00
Sam Minnee
132957b5c2 API CHANGE #2922: RequestHandler:: now inherit 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64958 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-30 22:28:01 +00:00
Sam Minnee
cd699e3d89 API CHANGE #2857 - Renamed RequestHandlingData to RequestHandler 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64953 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-30 22:03:21 +00:00
Sam Minnee
672ca89c0b API CHANGE #2698 ajshort: URL handler only passes control to subclasses of RequestHandlingData 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64951 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-30 21:51:59 +00:00
Ingo Schommer
84db28eb10 FEATURE Collect i18n Entities from dynamic PHP code - useful to translate statics. Added DataObject->provideI18nEntities() and i18nTextCollector->collectFromEntityProviders(). See #1625 
FEATURE Making DataObject attributes translatable through i18n class, e.g. $db and all relation statics. Use DataObject->fieldLabels() to access translated attributes.
ENHANCEMENT Ignoring entity-names with $ signs (most likely dynamic properties) in i18nTextCollector->collectFromCode()


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64881 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-29 21:07:17 +00:00
Normann Lou
27a868ebf2 APICHANGE: add updateFieldLabels() to DataObjectDecorator, so as that a dataobject could update fieldLables by its decorator. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64805 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-28 03:03:16 +00:00
Normann Lou
bff5942338 BUGFIX: Fix YamlFixture issues when specifying IDs 
BUGFIX: Fix DataObject::write() with a specified ID and forceInsert to be true

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64798 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-28 01:23:41 +00:00
Normann Lou
3966f9a794 APICHANGE: A Text db field, by default, should be rendered as a TextareaField in its scaffoldForm 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64792 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-28 00:32:51 +00:00
Sean Harvey
412df22527 BUGFIX Made ContentController work properly if it doesn't have a dataRecord 
MINOR phpDoc update for ContentController->getMenu()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64771 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-25 11:30:28 +00:00
Sam Minnee
17705be0bc #2957 - Fixed entity decoding in Convert::html2raw 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64768 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-25 06:05:27 +00:00
Ingo Schommer
a51d7184a3 BUGFIX Using include_once() instead of include() for _ss_environment.php in install.php and Core.php to avoid PHP notice errors about double constant defines (see r64561) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64562 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-20 13:26:52 +00:00
Ingo Schommer
a86e42e5ed MINOR Temporarily disabled Debug::message() calls in i18nTextCollector as they're disturbing unit test output and we currently dont have context switches for this 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64560 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-20 12:39:49 +00:00
Ingo Schommer
69d370dfd7 MINOR Adjusted i18nTextCollector to use DataObject->i18nCollectStatics() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64559 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-20 12:38:29 +00:00
Sean Harvey
a6e6a4387d BUGFIX Renamed "Save & Publish" to "Save and Publish" since this value is used in the value attribute of input elements, properly parsed, this would produce &amp; instead of & 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64506 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-19 01:28:30 +00:00
Sean Harvey
7048077184 API CHANGE Removed HtmlOneLineField. This field has been deprecated for some time now, and it does not work. 
API CHANGE Changed HTMLVarchar->scaffoldFormField() to use HtmlEditorField instead of HtmlOneLineField, which does not work.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64504 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-19 00:18:55 +00:00
Sean Harvey
ee5b0e2447 MINOR ErrorPage removal of ShowInMenus explicitly being set - this is done using static $defaults on the class itself. 
MINOR ErrorPage phpDoc updates - removal of non-existant token @usedby, replaced with @see
MINOR Code formatting changes to be more consistent

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64502 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-18 22:31:04 +00:00
Ingo Schommer
12f2457677 BUGFIX Fixed distribution of textcollector files to modules (was collecting all entities into all modules before) - added unit tests 
ENHANCEMENT Using ksort() in textcollector to get alphabetized language master files (=easier to compare and debug)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64494 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-17 17:44:14 +00:00
Ingo Schommer
c4cdc9ce87 ENHANCEMENT Made _t() global function in Core.php an alias for the new i18n::_t() method 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64493 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-17 15:40:59 +00:00
Ingo Schommer
874aaf1d27 ENHANCEMENT Refactored i18nTextCollector and added unit tests 
FEATURE Support for i18n entity namespaces in templates

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64492 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-17 15:21:33 +00:00
Ingo Schommer
2cf70326ae BUGFIX Fixed $module parameter for i18nTextCollectorTask 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64490 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-17 15:19:10 +00:00
Ingo Schommer
23aa23fb60 ENHANCEMENT Added ClassInfo::classes_for_file() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64489 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-17 15:18:26 +00:00
Sam Minnee
c6f6f82f24 FEATURE: Added ?debug_memory=1 flag 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64473 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-17 00:52:58 +00:00
Sam Minnee
6fe79bc1c6 BUGFIX: Fix issue with language files not being included 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64471 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 23:39:19 +00:00
Ingo Schommer
795fdb2169 BUGFIX Removed duplicate setValue() method on Time (was supposed to be deleted instead of renamed from setVal() to setValue()) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64467 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 23:19:39 +00:00
Ingo Schommer
5f70af6d38 ENHANCEMENT Moving i18n->textcollector() and related methods to new class i18nTextCollector and i18nTextCollectorTask - enabling running textcollector through CLI, refactored to instance methods for better testability 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64447 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 20:42:41 +00:00
Sam Minnee
f1f76b22b7 FEATURE: Flush template cache before running tests 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64444 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 19:48:12 +00:00
Ingo Schommer
768fc5a588 BUGFIX Adjusted HeaderField and LabelField implementation to new constructor arguments (see r64421) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64422 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 13:26:50 +00:00
Ingo Schommer
bc28a64e18 MINOR Changed visibility of SiteTree->getClassDropdown() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64418 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 13:00:02 +00:00
Ingo Schommer
edd087f80b API CHANGE Removed SiteTree->makelinksunique() and SiteTree->makelinksuniquequick() - use new SiteTreeMaintenanceTask 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64416 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 12:18:16 +00:00
Ingo Schommer
d80a6899e1 MINOR documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64415 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 12:05:08 +00:00
Ingo Schommer
639dee8926 MINOR Removed unused DatabaseAdmin->makeURL() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64414 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 12:02:57 +00:00
Ingo Schommer
b46250b9dc MINOR documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64413 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 12:02:41 +00:00
Ingo Schommer
4814521e93 MINOR Marked some Convert methods as deprecated, as their purpose is unclear, they're neither documented nor tested. Stuff like Convert::xml2js() is just way too fuzzy 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64412 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 11:58:31 +00:00
Ingo Schommer
b042141634 MINOR Misc Convert documentation 
MINOR Changed visibility of Convert::recursiveXMLToArray

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64409 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 11:49:51 +00:00
Ingo Schommer
e820c88be0 MINOR Moved Controller::init() to top of file 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64403 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 11:08:51 +00:00
Ingo Schommer
049ab468e3 MINOR Misc deprecation notes 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64400 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 11:03:01 +00:00
Sean Harvey
1b09577c31 ENHANCEMENT Versioned::get_one_by_stage() and Versioned::get_by_stage() were missing parameters from their get_one() and get() counterparts in DataObject. Those parameters have been added. See ticket #2965 for the origin of this patch. 
MINOR phpDoc for Versioned::get_by_stage() to be consistent with Versioned::get_one_by_stage()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64397 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 10:14:47 +00:00
Ingo Schommer
9b1db223ce API CHANGE Removed deprecated Datetime class, use SSDatetime instead (was conflicting with PHP 5.2 integrated classes) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64394 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 08:59:40 +00:00
Ingo Schommer
2d44f59816 API CHANGE Removed ViewableData->setVal(), use ViewableData->setValue() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64383 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 08:44:32 +00:00
Ingo Schommer
189501b775 MINOR Misc deprecation notices 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64382 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 08:44:08 +00:00
Ingo Schommer
4b461c2175 API CHANGE Removed Director::getAbsURL(), use Director::absoluteURL() 
API CHANGE Removed Director::isTestMode(), use Director::isTest()
API CHANGE Removed Director::isDevMode(), use Director::isDev()
API CHANGE Removed Director::isLiveMode(), use Director::isLive()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64380 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 08:42:44 +00:00
Ingo Schommer
0199294864 API CHANGE Removed DataObjectSet->append(), use DataObjectSet->push() or DataObjectSet->merge() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64378 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 08:40:55 +00:00
Ingo Schommer
079b491f2e API CHANGE Removed Controller::currentController(), use Controller::curr() 
API CHANGE Removed Controller->LinkTo(), use Controller->join_links()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64377 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 08:40:08 +00:00
Ingo Schommer
f225180511 API CHANGE Removed Image_Saver 
API CHANGE Removed Image->transferlegacycontent()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64376 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 08:38:05 +00:00
Ingo Schommer
62861b091b API CHANGE Removed DataObject->getLastWriteFields(), use DataObject->getChangedFields() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64375 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 08:37:10 +00:00
Ingo Schommer
df19769fd1 API CHANGE Removed Convert::raw2html(), use Convert::raw2xml() 
API CHANGE Removed Convert::html2plain(), use Convert::xml2raw()
API CHANGE Removed Convert::html2text(), use Convert::xml2raw()
API CHANGE Removed Convert::raw2reserveNL(), use Convert::raw2xml()
API CHANGE Removed  Convert::raw2attr(), use Convert::raw2att()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64374 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 08:36:27 +00:00
Sean Harvey
050321cb3c MINOR Removed Group_Unsecure which was never used 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64369 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 05:43:57 +00:00
Sam Minnee
344d6e173c HTTP:add_cache_headers() - don't throw warning when not passed 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64368 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 05:29:32 +00:00
Sam Minnee
b91be01aa8 API CHANGE #551: Move code from CMSMain to SiteTree 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64351 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 03:21:58 +00:00
Sam Minnee
b06d53012a FEATURE #2956 seaeagle1: Added If-Modified-Since support to HTTP::add_cache_headers() [16:00:18] 
dquote> API CHANGE: HTTP::add_cache_headers() now designed to manipulate an HTTPResponse object rather than add headers directly

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64345 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 03:02:29 +00:00
Normann Lou
ec1724cc4d BUGFIX: avoid a CSSClass is added to a veiwable data twice. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64328 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-16 00:52:50 +00:00
Ingo Schommer
5865fd19d1 MINOR fixed php notice error in DataObject 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64319 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-15 22:57:33 +00:00
Ingo Schommer
f58014490c MINOR Moved HTTPRequest constructor to beginning of method definitions 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64261 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-15 00:53:09 +00:00
Ingo Schommer
2d33fd160a BUGFIX Adjusted ForeignKey->scaffoldFormField() to new scaffolding notation ("ajaxSafe" instead of "ajax") 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64239 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-14 21:47:22 +00:00
Sam Minnee
391848f79b FEATURE #2951 simon_w: Use 301 redirect on Director::forceWWW() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64231 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-14 21:06:15 +00:00
Ingo Schommer
be0d3e37c5 ENHANCEMENT Added Controller->redirectBack() 
BUGFIX Storing HTTP "Referer" header from $_SERVER in Director::direct() and passing it along in Director::test()
ENHANCEMENT Storing a "fake referer" in TestSession->lastURL to allow for redirectBack() calls, e.g. after failed form validation

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64229 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-14 19:59:01 +00:00
Ingo Schommer
155fb9c10f BUGFIX Checking for an empty array for $postVars in Director::test() to determine HTTP method - an existing array should cause POST rather than GET, even if its empty 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64228 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-14 19:55:55 +00:00
Ingo Schommer
0fac0752a4 BUGFIX Fixed stupid ommission from r64223 which caused HTTPRequest to construct without a proper URL 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64227 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-14 19:53:59 +00:00
Ingo Schommer
90f3b87f35 ENHANCEMENT Making URL accessible through HTTPRequest->getURL() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64223 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-10-14 18:47:38 +00:00