tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
8,371 Commits 31 Branches 527 Tags 162 MiB
ee53df336d
Commit Graph

8371 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ingo Schommer
5cfbac63a2 MINOR Fixed PJAX panel loading when .cms-content is a split panel with tree and form view (regression caused by 452a507cc9) 2012-04-12 12:29:20 +02:00
Ingo Schommer
5070cb3a8b Merge pull request #308 from mateusz/sapphire 
---

Ref: http://open.silverstripe.org/ticket/6175

Can you review this please and let me know if this is helpful?

Ive attempted to clean up the multitude of the caches on the DataObject, and make them at least more consistent and more visible - although I didnt try to merge them or refactor the code to eliminate them.

Have also explicitly deprecated setComponent - it manipulates "componentCache" which to my eye is no longer used anywhere, and can cause some hidden surprises for people out there. Fixed related CsvBulkLoader problem which was still using setComponent.

Removed $cache_buildSQL_query and $_cache_custom_database_fields, which were not used.

Fixed DataObject::reset to clean all global caches, and DataObject::flushCache to flush the component cache. Both now are doing what it says on the box.

The problem reported in ticket 6175 can now be fixed by doing $this->flushCache(); after the setting the has_one and writing.

Comments welcome :)
 2012-04-12 11:34:16 +02:00
Simon Welsh
b4e155258f API-CHANGE Move tinymce plugins in thirdparty 2012-04-12 20:47:57 +12:00
Sam Minnee
9fdcf345e4 MINOR: Updated PHP requirement in docs (#7129) 2012-04-12 18:22:44 +12:00
Sam Minnée
977e9f3576 Merge pull request #306 from silverstripe-big-o/report-fixes 
API-CHANGE: new GridFieldFooter component
 2012-04-11 22:30:10 -07:00
Mateusz Uzdowski
ae5bd7d65e ENHANCEMENT: refer to cache statics explicitly via DataObject (os6175) 
Unify the usage across the class. Since the intention is to have a
single site-wide cache, calling via DataObject seems to be a better
option - self could theoretically end up calling a redefined field from
a subclass.
 2012-04-12 17:04:24 +12:00
Mateusz Uzdowski
5186a0cea3 BUGFIX: remove unnecessary setComponent call - no longer used (os6175) 2012-04-12 17:04:24 +12:00
Mateusz Uzdowski
aedadebae6 BUGFIX: adjust the cache flush and reset functions to cover all caches (os6175) 2012-04-12 17:04:22 +12:00
Mateusz Uzdowski
8ea2460e50 BUGFIX: make internal DataObject caches more consistent (os6175) 2012-04-12 17:03:18 +12:00
Mateusz Uzdowski
621b2e1888 APICHANGE: deprecate DataObject::setComponent, no longer does anything. 2012-04-12 17:02:09 +12:00
Sam Minnée
66ee494fc2 Merge pull request #307 from halkyon/date_changes 
MINOR Testing extended dates (very far in the past and future) in DateTest
 2012-04-11 21:57:26 -07:00
Sean Harvey
b52c6b4f2b MINOR Testing extended dates (very far in the past and future) in 
DateTest
 2012-04-12 16:38:35 +12:00
Mateusz Uzdowski
360e9df54e MINOR: fix typo 2012-04-12 16:22:36 +12:00
Julian Seidenberg
e9dc610448 API-CHANGE: new GridFieldFooter component 2012-04-12 16:13:47 +12:00
Sam Minnée
21f7eb19e4 Merge pull request #305 from halkyon/e_strict_fixes 
php-peg E_STRICT fixes
 2012-04-11 20:15:53 -07:00
Sean Harvey
0dd4d4386e BUGFIX php-peg E_STRICT fixes 2012-04-12 14:58:21 +12:00
Sam Minnee
77c95b3434 MINOR: Hamish is all class. ;-) 2012-04-12 13:19:48 +12:00
Sam Minnée
d766100335 Merge pull request #304 from halkyon/e_strict_fixes 
Enable E_STRICT by default for development, fix all E_STRICT errors affected by tests.
 2012-04-11 17:54:18 -07:00
Sam Minnee
aa659a2326 MINOR: Fixed classname displayed in Hierarchy::markChildren() error. (#4406) 2012-04-12 12:38:07 +12:00
Sean Harvey
2b8e14fdff API CHANGE Fixing CompositeField/SelectionGroup 
performReadonlyTransformation and performDisabledTransformation to be
consistent and conform with parent FormField. $trans argument is no longer allowed, just uses
DisabledTransformation or ReadonlyTransformation instead.
 2012-04-12 12:24:06 +12:00
Sean Harvey
852ffcf492 MINOR MemberDatetimeOptionsetField::validate() now passes in $validator argument instead of getting it from the form, which is how other FormFields work like CompositeField 2012-04-12 12:23:18 +12:00
Sean Harvey
3c70ea4922 MINOR Fixing broken test MemberDatetimeOptionsetFieldTest, passing in null for $validator argument 2012-04-12 12:20:18 +12:00
Sam Minnée
1189322b41 Merge pull request #302 from robert-h-curry/7113-nested-controls-breaking-last 
BUGFIX: Issue #7113: Recalculate itemIteratorCount when popping viewer state.
 2012-04-11 17:19:46 -07:00
Sean Harvey
865cde0c39 BUGFIX FormField::name_to_label() is now declared as static as it was never used as an instance method 
API CHANGE FormField::validate() $validator argument is now required for FormField classes
 2012-04-12 12:18:55 +12:00
Sean Harvey
8369cded32 MINOR Code formatting in EmailField 2012-04-12 12:17:30 +12:00
Sean Harvey
1e61b76ca8 MINOR ConfirmedPasswordField::validate() now passes in $validator 
argument instead of getting it from the form, which is how other
FormFields work like CompositeField
 2012-04-12 12:14:42 +12:00
Sean Harvey
859f7add20 MINOR TableField_Item::Fields() now conforms to parent 
TableListField_Item::Fields() for E_STRICT compliance
 2012-04-12 12:13:22 +12:00
Sean Harvey
42988ecb18 BUGFIX Argument hinting of FormField instance for TabSet::push() to 
comply with parent CompositeField::push() for E_STRICT compliance
 2012-04-12 12:11:53 +12:00
Sean Harvey
9cf1686786 MINOR Code formatting fixes for CurrencyField 2012-04-12 12:11:22 +12:00
Sean Harvey
fd3de5158d BUGFIX Use of Link() in security classes now refers to $this->controller 
instead of calling the instance method Link statically (which isn't
allowed for E_STRICT compliance.)
 2012-04-12 12:09:39 +12:00
Sean Harvey
6b40377a1c BUGFIX Time::setValue() now conforms to DBField::setValue() for E_STRICT compliance. 2012-04-12 12:08:22 +12:00
Sean Harvey
9a9cebb369 MINOR Versioned::add_to_class() now conforms to parent 
DataExtension::add_to_class() with $args being optional (default to
null). This is for E_STRICT compliance.
 2012-04-12 12:07:35 +12:00
Sean Harvey
972dfee5c3 MINOR Fixing E_STRICT compliance in simpletest 2012-04-12 12:06:47 +12:00
Sean Harvey
41433f1211 BUGFIX Fixing FulltextSearchable and Hierarchy to conform to the parent DataExtension for E_STRICT compliance. 2012-04-12 12:06:02 +12:00
Sean Harvey
9bd7068394 MINOR Fixed class documentation for CompositeDBField 2012-04-12 12:04:58 +12:00
Sean Harvey
a9f95051bc BUGFIX File::ini2bytes() is now declared as static, as it was never an 
instance method
 2012-04-12 12:03:33 +12:00
Sean Harvey
4c1aba8542 BUGFIX Object::get_extensions() is now declared as static, as it was 
never an instance method
 2012-04-12 12:02:13 +12:00
Sean Harvey
630bfcc823 MINOR error_reporting() now defaults to E_ALL | E_STRICT which means 
strict errors are now reported *unless* the site is in live mode (which
supresses everything except fatal errors and warnings)
 2012-04-12 12:01:15 +12:00
Robert Curry
695ae711e7 MINOR: Issue #7113: Add test for nested loops. 2012-04-12 11:56:49 +12:00
Sam Minnée
d34d57a034 Merge pull request #303 from mateusz/os-7126 
BUGFIX: remove form auto-detection from the generic JS state handler.
 2012-04-11 16:51:36 -07:00
Sam Minnée
b435d0a3d2 Merge pull request #288 from jmwohl/patch-1 
For png images with transparency, the imagesaveaplpha() needs to be set ...
 2012-04-11 16:33:02 -07:00
Mateusz Uzdowski
452a507cc9 BUGFIX: remove form auto-detection from the generic JS state handler. 
Forms take care of PJAX state on their own in the submit and load functions (os-7126)
 2012-04-12 11:31:28 +12:00
Sam Minnée
168eaf72d8 Merge pull request #300 from silverstripe-scienceninjas/feature/ssviewer-enhancements 
Feature/ssviewer enhancements
 2012-04-11 16:29:22 -07:00
Robert Curry
0daa76d0b7 BUGFIX: Issue #7113: Recalculate itemIteratorCount when popping viewer state. 2012-04-12 11:16:41 +12:00
Ingo Schommer
6a10ed19c1 MINOR Added TinyMCE language pack 2012-04-11 18:05:29 +02:00
Ingo Schommer
e045ffeb29 Merge pull request #205 from AngryPHPNerd/sapphire 
---

In SS-2.4 you can prefix files with an underscore to exclude them from manifest this can be useful for backups of old classes or huge data files.

I think this behaviour should be readded.

(I will add a unit test for this ...)
 2012-04-11 17:32:34 +02:00
Ingo Schommer
a3d99b082d MINOR Resetting Security::$database_is_ready state during tests (regression from a9509a610d) 2012-04-11 17:22:55 +02:00
Ingo Schommer
ca24120a5e MINOR Install screen visual tweaks, more visible disabled state on install button, conditional version number (to avoid it showing without a version), referencing new theme in install screen, using new layout in install progress screen as well 2012-04-11 16:49:31 +02:00
Ingo Schommer
ac45e5b9c0 Merge branch 'integration' 
Conflicts:
	admin/css/ie8.css
	admin/css/screen.css
	admin/scss/_style.scss
	dev/install/config-form.html
	dev/install/install.css
	dev/install/php5-required.html
 2012-04-11 16:31:12 +02:00
Ingo Schommer
aed5e93da2 Merge pull request #301 from stojg/database-is-ready-checks 
MINOR Security::database_is_ready() check are doing duplicate DB queries...
 2012-04-11 06:38:22 -07:00