Commit Graph

196 Commits

Author SHA1 Message Date
Sam Minnee
132957b5c2 API CHANGE #2922: RequestHandler:: now inherit
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64958 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-30 22:28:01 +00:00
Sam Minnee
cd699e3d89 API CHANGE #2857 - Renamed RequestHandlingData to RequestHandler
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64953 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-30 22:03:21 +00:00
Sam Minnee
672ca89c0b API CHANGE #2698 ajshort: URL handler only passes control to subclasses of RequestHandlingData
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64951 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-30 21:51:59 +00:00
Sean Harvey
412df22527 BUGFIX Made ContentController work properly if it doesn't have a dataRecord
MINOR phpDoc update for ContentController->getMenu()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64771 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-25 11:30:28 +00:00
Sam Minnee
c6f6f82f24 FEATURE: Added ?debug_memory=1 flag
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64473 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-17 00:52:58 +00:00
Ingo Schommer
b042141634 MINOR Misc Convert documentation
MINOR Changed visibility of Convert::recursiveXMLToArray

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64409 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 11:49:51 +00:00
Ingo Schommer
e820c88be0 MINOR Moved Controller::init() to top of file
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64403 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 11:08:51 +00:00
Ingo Schommer
189501b775 MINOR Misc deprecation notices
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64382 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 08:44:08 +00:00
Ingo Schommer
4b461c2175 API CHANGE Removed Director::getAbsURL(), use Director::absoluteURL()
API CHANGE Removed Director::isTestMode(), use Director::isTest()
API CHANGE Removed Director::isDevMode(), use Director::isDev()
API CHANGE Removed Director::isLiveMode(), use Director::isLive()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64380 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 08:42:44 +00:00
Ingo Schommer
079b491f2e API CHANGE Removed Controller::currentController(), use Controller::curr()
API CHANGE Removed Controller->LinkTo(), use Controller->join_links()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64377 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 08:40:08 +00:00
Ingo Schommer
f58014490c MINOR Moved HTTPRequest constructor to beginning of method definitions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64261 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 00:53:09 +00:00
Sam Minnee
391848f79b FEATURE #2951 simon_w: Use 301 redirect on Director::forceWWW()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64231 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 21:06:15 +00:00
Ingo Schommer
be0d3e37c5 ENHANCEMENT Added Controller->redirectBack()
BUGFIX Storing HTTP "Referer" header from $_SERVER in Director::direct() and passing it along in Director::test()
ENHANCEMENT Storing a "fake referer" in TestSession->lastURL to allow for redirectBack() calls, e.g. after failed form validation

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64229 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 19:59:01 +00:00
Ingo Schommer
155fb9c10f BUGFIX Checking for an empty array for $postVars in Director::test() to determine HTTP method - an existing array should cause POST rather than GET, even if its empty
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64228 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 19:55:55 +00:00
Ingo Schommer
0fac0752a4 BUGFIX Fixed stupid ommission from r64223 which caused HTTPRequest to construct without a proper URL
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64227 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 19:53:59 +00:00
Ingo Schommer
90f3b87f35 ENHANCEMENT Making URL accessible through HTTPRequest->getURL()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64223 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 18:47:38 +00:00
Ingo Schommer
e818f89962 ENHANCEMENT Setting default level for ContentController->getMenu($level = 1) to allow for calls without arguments
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64144 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-13 20:08:59 +00:00
Ingo Schommer
c11a9949a4 BUGFIX Bad XHTML in en_US language file (#2624) - thanks tiwoc!
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64099 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-12 16:25:29 +00:00
Ingo Schommer
97fed5ae57 BUGFIX Director::fileExists() fails on windows with absolute paths (#2935) - thanks to ajshort!
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64098 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-12 16:16:25 +00:00
Ingo Schommer
4134f92dad BUGFIX Moved RecordController and CollectionController to external module (see r63905)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64002 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:41:22 +00:00
Andrew O'Neil
e5f3982058 BGFIX: #2587 Fix HTTPS detection on IIS (mackeyn)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63912 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 22:53:20 +00:00
Sam Minnee
7741fdb155 BUGFIX: Don't let Director::test() clobber current stage
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63825 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:37:33 +00:00
Ingo Schommer
711de868c9 BUGFIX Enabled Link() methods for RecordController and CollectionController, and adjusted url handling to ModelAdmin counterparts to avoid linkage handling problems
BUGFIX Requiring a parentController for RecordController
ENHANCEMENT Custom getViewer() methods to use Page main templates if CollectionController is nested in a ContentController

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63681 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-06 19:29:04 +00:00
Ingo Schommer
6878171375 ENHANCEMENT Added SSViewer->getTemplateFileByType() and SSViewer->setTemplateFile()
MINOR Documentation and formatting in SSViewer and Controller

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63680 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-06 19:25:45 +00:00
Ingo Schommer
802317c705 FEATURE Added HTTP method override support to HTTPRequest and Form (through $_POST['_method'] or $_SERVER['X-HTTP-Method-Override']), incl. unit tests
ENHANCEMENT Added Form->FormHttpMethod()
ENHANCEMENT Added HTTPRequest->httpMethod()
ENHANCEMENT Added HTTPRequest::detect_method()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63679 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-06 14:58:01 +00:00
Ingo Schommer
d543305882 FEATURE Frontend CRUD scaffolding with RecordController and CollectionController (not fully functional yet, needs correct Link() methods)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63659 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-06 00:48:25 +00:00
Ingo Schommer
78469b86e6 MINOR Documentation for HTTPRequest and RequestHandlingData
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63657 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-05 22:35:14 +00:00
Ingo Schommer
1bb708377d MINOR Documentation for HTTPRequest and RequestHandlingData
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63655 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-05 22:16:07 +00:00
Ingo Schommer
52ae575630 ENHANCEMENT Added Controller->getRequest()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63653 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-05 19:45:38 +00:00
Ingo Schommer
d53bbb0df1 ENHANCEMENT Added Controller->render($params) as a shortcut for Controller->customise($params)->renderWith(array('MyTemplate','MySubTemplate')) - templates are auto-detected by Controller->getViewer() and Controller->getAction()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63652 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-05 19:27:21 +00:00
Sam Minnee
13b7b4c4e7 Added instructions to try and prevent #2901 issues reoccurring
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63636 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-04 04:45:43 +00:00
Sam Minnee
3167c05395 BUGFIX #2901 - RootURLController didn't properly manipulate the Controller stack
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63635 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-04 04:42:51 +00:00
Sam Minnee
25157f7cf9 API CHANGE: Deprecated HTTP::sendFileToBrowser() in favour of more testable HTTPRequest::send_file()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63579 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 02:23:11 +00:00
Sam Minnee
4cf4dd50a5 Fixed dumb error in my makeRelative change
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63537 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 21:05:33 +00:00
Sam Minnee
61ab10a8d8 ENHANCEMENT #2875: Make CLI execution more robust when FILE_TO_URL_MAPPING not set
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63526 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 09:48:56 +00:00
Ingo Schommer
5d3e815967 API CHANGE Changed parameters for Debug::friendlyError()
ENHANCEMENT Using DebugView class in Debug::friendlyError()
ENHANCEMENT Using Debug::friendlyError() in HTTPResponse class if status code signifies error (only on live environments in non-ajax requests)
ENHANCEMENT Showing contact information in Debug::friendlyError() from Email::getAdminEmail()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63465 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 14:43:43 +00:00
Ingo Schommer
655395a8e7 ENHANCEMENT Added Director::get_environment_type()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63463 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 14:40:29 +00:00
Sean Harvey
b675fbe1ec MINOR Ticket #2869 Fixed PHP notice in Director::forceWWW()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63390 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 03:31:29 +00:00
Sean Harvey
1754e6cf81 Reverted r63388
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63389 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 03:28:50 +00:00
Sean Harvey
813679cc9b ENHANCEMENT Director::forceWWW() now does a 301 redirect for SEO (to be consistent with Director::forceSSL())
MINOR Fix PHP notice in checking $_SERVER['HTTPS']

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63388 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 03:27:49 +00:00
Sam Minnee
2af039785c ENHANCEMENT: Updated cli-script handling to be more in line with web calls, and improved Director::setBaseURL() calls.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63321 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 23:41:50 +00:00
Sam Minnee
85e52eb568 BUGFIX #2529: Fixed HTTP/1.0 support
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63304 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 20:23:47 +00:00
Ingo Schommer
2c11afb2df BUGFIX wrong jsparty PATH references
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63296 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 18:49:55 +00:00
Ingo Schommer
6afad36c39 BUGFIX Don't try to use HTTP_HOST environment variable if its not set in Director::protocolAndHost(). Throw a warning, then return false - before if script execution was not set to stop on WARNING, you'll get a NOTICE as well.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63291 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 12:52:23 +00:00
Ingo Schommer
0da97be4f9 BUGFIX Reverted Director class using BASE_PATH instead of dirname(dirname(['SCRIPT_FILENAME'])), originally committed in r63154
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63157 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-27 17:02:46 +00:00
Ingo Schommer
9371f4688b ENHANCEMENT Introduced constants for system paths like /sapphire in preparation for a more flexible directory reorganisation. Instead of hardcoding your path, please use the following constants: BASE_PATH, BASE_URL, SAPPHIRE_DIR, SAPPHIRE_PATH, CMS_DIR, CMS_PATH, THIRDPARTY_DIR, THIRDPARTY_PATH, ASSETS_DIR, ASSETS_PATH, THEMES_DIR, THEMES_PATH
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63154 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-27 16:02:38 +00:00
Sam Minnee
4b2af337d8 Fixed bug publishing homepage using Director::test
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62756 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-19 05:54:07 +00:00
Ingo Schommer
65e9165905 BUGFIX Allowing HTTPRequest::match() to match rules with extensions (e.g. /sitemap.xml used for GoogleSitemap)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62471 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-16 20:37:46 +00:00
Ingo Schommer
ddc3bab5dc BUGFIX Pushing current controller into stack in RootURLController->handleRequest to Session-usage in Translatable if enabled. Session::get() is dependent on controllers, and is needed to determine the current language for any Translatable queries (like RootURLController::get_homepage_urlsegment())
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62463 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-16 15:53:05 +00:00
Ingo Schommer
a8e70ff1f5 MINOR documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62462 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-16 14:36:31 +00:00