Sam Minnee
e5a07227c2
ENHANCEMENT: Full-text search with double quotes returns too many results. ticket #5733 . Thanks ktauber.
...
Using htmlentities($keywords,ENT_NOQUOTES) instead of proposed solution (from r108417)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112731 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:58:23 +00:00
Sam Minnee
2058ee31ee
BUGFIX: DataObjects without the Versioned decorator cannot have a "Version" field. ticket #5775 . Thanks ajshort (from r108399)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112725 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:53:19 +00:00
Sam Minnee
2ec9234da6
BUGFIX Bypass BasicAuth when in CLI mode so unit tests can run (regression from r104962) (from r108193)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112715 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:42:45 +00:00
Sam Minnee
d30b478690
MINOR: Added test for #5662 (calling delete twice) (from r108025)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112708 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:40:56 +00:00
Sam Minnee
c35349f90d
ENHANCEMENT: added getter to get array back out of an ArrayData instance. MINOR: updated docblocks in ArrayData (from r108012)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112705 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:39:19 +00:00
Sam Minnee
7254c00aef
BUGFIX #5833 Duplicate IDs when two similar date formats in Member_DatetimeOptionsetField containing different delimiters (e.g / and .) replaced to an empty string (from r108001)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112703 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:34:09 +00:00
Sam Minnee
0e3693f99e
BUGFIX: tests now pass when the locale is set to something other than 'en_US' in the mysite's _config.php file (from r107940)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112702 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:33:41 +00:00
Sam Minnee
93eb6214b7
ENHANCEMENT Allowing custom messages and permission codes in BasicAuth::protect_entire_site()
...
ENHANCEMENT Making $permissionCode argument optional for BasicAuth::requireLogin(). If not set the logic only checks for a valid account (but no group memberships)
ENHANCEMENT Using SS_HTTPResponse_Exception instead of header()/die() in BasicAuth::requireLogin() to make it more testable (from r107867)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112701 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:29:35 +00:00
Sam Minnee
c5f4926d4d
BUGFIX Fixed DateField->validate() with keyed, but empty array values
...
MINOR Fixed DateField/TimeField validation message translation (wrong sprintf() nesting) (from r107789)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112696 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:25:41 +00:00
Ingo Schommer
1c54a6dc77
BUGFIX Case insensitive extension checks in File::validate() ( fixes #5781 , thanks simon_w) (from r107539)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112604 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:53:54 +00:00
Ingo Schommer
b64015e2cf
BUGFIX Remove dummy entry created by Versioned if record is first written to Live stage ( fixes #5596 , thanks muzdowski) (from r107537)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112603 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:53:14 +00:00
Ingo Schommer
577e82a123
BUGFIX Fixed Member->PasswordEncryption defaults when writing new Member without setting a password. Fixes critical issue with MemberTableField saving in admin/security, where new members are stored with a cleartext password by default instead of using the default SHA1 (see #5772 ) (from r107532)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112602 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:52:38 +00:00
Ingo Schommer
bd927c9355
ENHANCEMENT: html2raw now properly replace strong tag with asterix #5494 (from r107443)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112600 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:51:55 +00:00
Ingo Schommer
d67c43ad7d
ENHANCEMENT Using jQuery UI datepicker in DateField and DatetimeField instead of outdated DHTML calendar.js ( fixes #5397 )
...
ENHANCEMENT Abstracted optional DateField->setConfig('showcalendar') logic to DateField_View_JQuery (from r107438)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:48:39 +00:00
Ingo Schommer
f097b678d8
ENHANCEMENT: allow adding a new a field to ArrayData (from r107434)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112595 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:47:27 +00:00
Ingo Schommer
556e753fee
ENHANCEMENT: Added documentation and changed static names (from r107429)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112593 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:46:32 +00:00
Ingo Schommer
f179458542
BUGFIX: Added quotes for postgres (from r107428)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112592 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:46:08 +00:00
Ingo Schommer
2f4fe2ff35
ENHANCEMENT: Added static to set regeneration of default pages (ticket #5633 ) (from r107426)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112591 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:44:57 +00:00
Ingo Schommer
bd6e51c87f
BUGFIX: Only highlight strings more than 2 characters long. #4949 (from r107423)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112590 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:44:24 +00:00
Ingo Schommer
aa1553517c
ENHANCEMENT Use array_combine() instead of custom logic for ArrayLib::valuekey() (thanks paradigmincarnate!) (from r107380)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112572 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:24:32 +00:00
Ingo Schommer
47762cdf5b
ENHANCEMENT #5352 Decouple date display from i18n locales, users now have access to change their date and time formats in Member::getCMSFields() using Member_DatetimeOptionsetField field (from r107326)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:23:02 +00:00
Ingo Schommer
706553ee95
MINOR Checking that Folder::findOrMake() can create an assets/assets/ folder (from r107276)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112567 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:21:41 +00:00
Ingo Schommer
5d5bb2618a
API CHANGE Don't reflect changes in File and Folder property setters on filesystem before write() is called, to ensure that validate() applies in all cases. This fixes a problem where File->setName() would circumvent restrictions in File::$allowed_extensions ( fixes #5693 )
...
API CHANGE Removed File->resetFilename(), use File->updateFilesystem() to update the filesystem, and File->getRelativePath() to just update the "Filename" property without any filesystem changes (emulating the old $renamePhysicalFile method argument in resetFilename())
API CHANGE Removed File->autosetFilename(), please set the "Filename" property via File->getRelativePath()
MINOR Added unit tests to FileTest and FolderTest (some of them copied from FileTest, to test Folder behaviour separately) (from r107273)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:20:47 +00:00
Ingo Schommer
8ed5e18085
MINOR Changed ImageTest to use fixture files located in assets/ folder, the filesystem API doesn't support Folder objects with "sapphire/..." paths, which leads to inconsistent results (from r107272)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112561 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:17:14 +00:00
Ingo Schommer
9d227ba2e4
MINOR Making FileTest->setUp()/tearDown() more resilient against in-test file/folder renames (from r107271)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112560 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:16:33 +00:00
Ingo Schommer
8b88f4aaf4
MINOR More identifiable file naming in FileTest (from r107270)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112559 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:16:16 +00:00
Ingo Schommer
96d1625102
MINOR Made File::get_file_extension() more readable, and added unit test (from r107267)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112555 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:14:59 +00:00
Ingo Schommer
25a0c3e7fb
ENHANCEMENT: in referencing a file in combine_files() it should fall back to standard requirement tags if combining has been disabled eg dev mode (from r107091)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112549 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:09:15 +00:00
Ingo Schommer
dcb402479a
MINOR Added FileTest->testValidateExtension() (related to #5693 ) (from r106805)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112539 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:04:54 +00:00
Ingo Schommer
d51627a342
MINOR Fixed hardcoded error message in PasswordValidator ( fixes #5734 )
...
MINOR Added PasswordValidatorTest (from r106687)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112534 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:03:19 +00:00
Ingo Schommer
39b056024f
APICHANGE: moved Group::addToGroupByName to $member->addToGroupByCode. (from r106217)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112528 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:00:48 +00:00
Ingo Schommer
197cdb0f64
BUGFIX: updated tests for Text (from r106205)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112527 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:00:12 +00:00
Ingo Schommer
e36247c1ed
ENHANCEMENT: added prefix and suffix support to ContextSummary (from r106200)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112526 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:59:46 +00:00
Ingo Schommer
f0d03207a6
MINOR: Better checking of safe_mode in MemoryLimitTest (from r106187)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112524 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:58:55 +00:00
Ingo Schommer
02c2af7249
MINOR: Don't run memory limit tests in safe mode, (from r106156)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112523 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:58:39 +00:00
Ingo Schommer
06ba0085dd
MINOR: Added test for Database::hasTable(). (from r106119)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112519 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:57:14 +00:00
Ingo Schommer
c7b47d8a8b
BUGFIX: Don't let deleteFromStage() kill the ID of the original record. (from r106080)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112515 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:55:45 +00:00
Ingo Schommer
09d4d0ccb3
BUGFIX: fixed phpunit directive (from r105907)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112510 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:53:46 +00:00
Ingo Schommer
3b4d0a7422
ENHANCEMENT: Added method for $this->request->latestParam() backwards compatibility with Director::urlParam() (from r105890)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112508 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:53:11 +00:00
Ingo Schommer
3aee3e2b23
BUGFIX: invalid use of @covers annotation (from r105889)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112507 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:52:20 +00:00
Ingo Schommer
91700a3dac
BUGFIX: updated select options classes to work with the dataobjectset returned by selectoptions rather than the array previously (from r105872)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112504 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:33 +00:00
Ingo Schommer
4c2ff4bd0a
APICHANGE: refactored methods in session to use coding conventions (from r105756)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112502 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:50:43 +00:00
Ingo Schommer
567143b3ff
MINOR More solid markup testing in TableListFieldTest through xpath (from r105305)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112496 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:48:27 +00:00
Ingo Schommer
1dc0675abf
MINOR Fixed TableListFieldTest->testSelectOptionsRendering() (from r105297)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112495 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:47:39 +00:00
Ingo Schommer
12fa850986
ENHANCEMENT: Preserve sort options in pagination links in TableListField (from r105275)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112475 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:29:44 +00:00
Ingo Schommer
bcbe9c254d
ENHANCEMENT Allowing batch checkbox selection of TableListField rows with TableListField->Markable and TableListField->addSelectOptions() (from r105266)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112473 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:27:59 +00:00
Ingo Schommer
4c1938fabd
MINOR Added DbDatetimeTest cases to sapphire (these were previously in the sqlite3 module, but they actually test core Database functionality) (from r105196)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112443 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:28:43 +00:00
Ingo Schommer
f22260487a
MINOR: Save and restore lang state in test (from r104835)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112397 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:16:13 +00:00
Ingo Schommer
0eccb61c17
ENHANCEMENT: added plugins to i18n to support modules that provide custom translations. (from r104827)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112395 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:15:54 +00:00
Ingo Schommer
2341f3fdd3
MINOR Fixed SiteTreeTest and SiteTreePermissionsTest to work alongside subsites module (SiteTreeSubsites changes the canEdit() behaviour) (from r104798)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112384 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:14:24 +00:00