tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
16,223 Commits 31 Branches 527 Tags 162 MiB
e04fb5b986
Commit Graph

16223 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ingo Schommer
adbcddee80 Only iterate through dataFields() in FormSchema 
Temporary measure until we implement nested fields
 2016-03-28 21:54:27 +13:00
Ingo Schommer
8ae2894890 Fix form schema ID getter 
Also moved keys of higher importance to start of array,
easier to review this way
 2016-03-28 21:54:24 +13:00
David Craig
5d88950735 Adds schemaDataType to FormFieldSchema 2016-03-28 21:14:06 +13:00
Ingo Schommer
dbe85dff0a Watch admin SCSS files 2016-03-28 21:02:27 +13:00
David Craig
97176581eb Tidy grunt file 
- Don't watch in prod mode
- Use gulp-if instead of if statements
 2016-03-28 21:02:15 +13:00
Daniel Hensby
aeb4aa9565 FIX Dont allow plain text friendly errors 2016-03-28 01:20:18 +01:00
Loz Calver
1e7281a2ba NEW: Add onBeforeRender() hook to GridField 2016-03-27 10:55:58 +01:00
Loz Calver
5ede516c77 FIX: GridField::FieldHolder() should not attempt to parse shortcodes (fixes #5129) 2016-03-27 10:51:46 +01:00
Loz Calver
4353d35c0a Fix code docs for SQLSelect::count() 2016-03-27 10:23:11 +01:00
Daniel Hensby
2b261e226c Merge pull request #5228 from christopherdarling/patch-4 
DOCS: DataList::filter() broken examples
 2016-03-26 21:20:34 +00:00
Daniel Hensby
1bcd755120 Merge pull request #5229 from madmatt/pulls/fix-gridfield-annotations 
MINOR: Fix PHPUnit @covers assertions for GridFieldTest
 2016-03-26 21:15:13 +00:00
Daniel Hensby
3a932c963f Merge pull request #5230 from kinglozzer/1684-textfield 
Deprecate TextField::InternallyLabelledField() (closes #1684)
 2016-03-26 21:14:33 +00:00
Loz Calver
d9798af30c Deprecate TextField::InternallyLabelledField() (closes #1684) 2016-03-26 11:07:33 +00:00
madmatt
41a3a86862 MINOR: Fix PHPUnit @covers assertions for DBStringTest 
This resolves issues when PHPUnit is run strictly, where it exits when
it hits an @covers annotation that references a method that doesn't exist
 2016-03-26 17:58:28 +13:00
madmatt
c972692313 MINOR: Fix PHPUnit @covers assertions for GridFieldTest 
This resolves issues when PHPUnit is run strictly, where it exits when
it hits an @covers annotation that references a method that doesn't exist
 2016-03-26 11:55:01 +13:00
Christopher Darling
4dfe2955e3 DOCS: DataList::filter() broken examples 
missing ' from 'bob'
 2016-03-24 21:32:49 +00:00
Daniel Hensby
0ce257495b Merge pull request #5226 from timkung/pulls/upload-validator-filesize-spelling 
DOCS Upload_Validator fixing file size spelling
 2016-03-24 09:41:35 +00:00
Tim Kung
7867c51388 Upload_Validator fixing file size spelling 2016-03-24 15:45:58 +13:00
Hamish Friedlander
1e53f29f33 Merge pull request #5219 from open-sausages/pulls/4.0/optional-owned-by 
API Improvements to ownership api
 2016-03-24 10:08:40 +13:00
Damian Mooyman
c6c71fa3be Merge pull request #5221 from christopherdarling/patch-1 
remove $CleartextPassword from ChangePasswordEmail.ss
 2016-03-24 10:00:47 +13:00
Damian Mooyman
8abede1339 API Add SS_Database::withTransaction for nice enclosed transactions 2016-03-24 09:57:07 +13:00
Christopher Darling
ceccd9551c remove $CleartextPassword and update wording on 
ChangePasswordEmail.ss

4.x version of https://github.com/silverstripe/silverstripe-framework/pull/5194
 2016-03-23 07:50:36 +00:00
Damian Mooyman
094745ec0f API Formally support custom ownership relations 
API 'owned_by' is no longer mandatory for relations backed by normal db relations
API Extension setOwner/clearOwner is now nested
 2016-03-23 14:49:34 +13:00
Damian Mooyman
5845b6089c Merge pull request #5218 from bummzack/5189-fix-canViewVersioned 
Fixed issue where `canViewVersioned` caused a DB error…
 2016-03-23 10:31:49 +13:00
Damian Mooyman
633eb0163e Merge pull request #4551 from sminnee/php7-support 
PHP7 support
 2016-03-23 09:21:51 +13:00
Daniel Hensby
602b07f403 Merge pull request #5194 from christopherdarling/patch-9 2016-03-22 11:14:49 +00:00
Daniel Hensby
affb3dba03 Merge branch 'patch-9' of https://github.com/christopherdarling/silverstripe-framework into christopherdarling-patch-9 2016-03-22 11:13:35 +00:00
Roman Schmid
25c453fe7b Fixed issue where canViewVersioned caused a DB error when Versioned was used with stages other than the default "Stage" and "Live". 
Updated VersionedTest to also check an Object with a single stage in the canView test.
 2016-03-22 09:42:21 +01:00
Sam Minnee
f5af0c85ba FIX: Don’t use SplFixedArray in PHP 7. 
PHP 7 seems to suffer a segfault when using SplFixedArray. Since LRU is
deprecated anyway, I’m not too fussed about getting to the bottom of
this issue, however, if it turns out that SplFixedArray is corrected in
PHP 7.0.0 stable or a future patch release, we could update this check.
 2016-03-22 18:09:38 +13:00
Sam Minnee
aeccb8b8e0 API: Move DBField subclasses into SilverStripe\Model\FieldType namespace 
API: Deprecate SS_Datetime.

The DBField subclasses are have all been renamed to start with “DB” and
be in the SilverStripe\Model\FieldType namespace. To keep DataObject
definitions concise, the original short variations of their names are
preserved as service definitions. Most of the field generation code
doesn’t need to change, but where field classes are referenced directly,
changes will be needed.

SS_Datetime, which is commonly referenced outside the model system
itself, has been preserved as a subclass of DBDatetime. This has been
marked as deprecated and can be removed in SilverStripe 5.

A few places that referred to $db and $casting values weren’t using
the Injector to instantiate the relevant classes. This meant that the
remapping we have created as part of moving classes into a namespace
didn’t work.
 2016-03-22 18:09:30 +13:00
Sam Minnee
262f487053 MINOR: Avoid access-changing subclass in test. 
Using a subclass to change the visibility of protected items didn’t
seem necessary in this case, if we add a reasonably logical getter
method.
 2016-03-22 17:39:09 +13:00
Sam Minnee
52ca089d0b NEW: Ensure php7 builds pass. 
SilverStripe 4 should work in php7, so we shouldn't accept its failure.
 2016-03-22 17:39:09 +13:00
Sam Minnee
8518fc1425 FIX: Clarify PHP7-incompatible call styles. 
These call signatures have changed their meaning in PHP7. The new
disambiguated form should work in all versions.
 2016-03-22 17:39:09 +13:00
Sam Minnee
083799ec03 FIX: Minimal data-model changes to support PHP7. 
The tidiest fix for this will be to update the namespace/naming of all
field types to follow this pattern. I’ve broken out the minimum
necessary to support PHP7 as its own commit, in case anyone needs to
backport that (e.g. if someone wanted to patch a SS 3 system to get
PHP7 support).

Rather than introduce a new API for fieldtype namespace simplification,
I’ve just used Injector. We may come up with a new configuration tool
that is better, but this has the advantage of existing now, and as such
I think is a good first step.
 2016-03-22 17:39:08 +13:00
Sam Minnee
12a83d70ae FIX: Removed PHP4 syntax from Diff.php 
Like SimpleTest, we should probably replace this for a new library,
but for now this will help us achieve PHP7 support.
 2016-03-22 17:39:08 +13:00
Sam Minnee
0dcccfafb3 MINOR: Whitespace fixes in SimpleTest. 2016-03-22 17:39:08 +13:00
Sam Minnee
680b19a1da FIX: Correct PHP4-style constructors in SimpleTest. 
Note that the best solution to this will be to remove the use of
SimpleTest entirely. This is quick fix is intended to help us get PHP7
tests running without needing to cross that bridge.
 2016-03-22 17:39:08 +13:00
Loz Calver
20d116757a Merge pull request #5217 from dhensby/pulls/3.1/docs-csv-parser 
DOCS Fixing CSV Parser docs - fixes #5004
 2016-03-21 15:02:56 +00:00
Daniel Hensby
c8f2e6702b DOCS Fixing CSV Parser docs - fixes #5004 2016-03-21 14:22:43 +00:00
Christopher Darling
96c586b39d FIX: only output $CleartextPassword if it has a value 
The $CleartextPassword value is never populated as reported https://github.com/silverstripe/silverstripe-framework/issues/3257 and in agreeance with the two comments (cc @kinglozzer) I also don't think plaintext passwords should be included in emails by default. As Loz suggests if somebody wants this it can easily be added by overriding the template.
 2016-03-21 09:48:01 +00:00
Daniel Hensby
03a3244d12 Merge pull request #5173 from tractorcow/pulls/4.0/remove-duplicate 
BUG Remove duplicate extension hook
 2016-03-21 09:35:46 +00:00
Daniel Hensby
863b737717 Merge pull request #5214 from tractorcow/pulls/3.1/fix-array-values 
Do not hang on nested parameters in search context
 2016-03-21 09:21:33 +00:00
Daniel Hensby
d2fa01fb17 Merge pull request #5215 from tractorcow/pulls/3.2/fix-folder-relativepath 
BUG Fix File::getRelativePath() failing if parent folder is renamed
 2016-03-21 09:09:12 +00:00
Damian Mooyman
78f19bd2ed Merge pull request #5175 from Firesphere/pulls/feature-set-owner-allmethods 
Enhancement: Set the owner on an extension
 2016-03-21 17:30:37 +13:00
Damian Mooyman
5f8356d686 BUG Fix File::getRelativePath() failing if parent folder is renamed 
Fixes #4993
 2016-03-21 17:22:38 +13:00
Damian Mooyman
94b0f61957 Merge pull request #3494 from dnadesign/tabForceActive 
fixing issue where 'ss-tabs-force-active' wasn't actually working
 2016-03-21 16:53:49 +13:00
Nicola Fontana
11561aeb54 Do not hang on nested parameters in search context 
Backport of 0b5a573 for 3.2 that does not add a new API, as
required by #5056 to be semver compatible.
 2016-03-21 15:54:22 +13:00
Daniel Hensby
ada12066f3 FIX Autocomplete loading spinner now showing 2016-03-21 15:15:00 +13:00
Damian Mooyman
cdedee130a Merge pull request #5200 from dhensby/pulls/fix-token-redirect 
FIX Parameter tokens now redirect to correct url if mod_rewrite is off
 2016-03-21 14:45:03 +13:00
Simon Erkelens
debe8ba2a3 Improvement: Set the owner on an extension, before getting all the available method names. 
This enhances the extensions to enable certain features like adding wrapper methods instead of having to have them on the object itself.
 2016-03-21 02:36:34 +01:00