Commit Graph

13823 Commits

Author SHA1 Message Date
Sean Harvey
6267d2e51e Fixing broken docs on setting allowed extensions on a FileField
Refers to an invalid variable, and is overriding the entire Upload,
which isn't necessary.
2014-09-09 11:14:38 +12:00
Sean Harvey
aa8c4fd004 Adding some README badges for downloads, license and stable version. 2014-09-09 09:28:43 +12:00
Ingo Schommer
fedad00e00 Merge pull request #3476 from AntonyThorpe/PEAR-PHPUnit
Update PhpUnitWrapper.php & TestRunner.php to recommend PHPUnit installation via Composer
2014-09-08 22:59:42 +12:00
AntonyThorpe
2d0fe7a4aa Update PhpUnitWrapper.php & TestRunner.php to recommend PHPUnit installation via Composer rather than PEAR
Using the PEAR Installer to install PHPUnit is no longer supported.  See https://github.com/sebastianbergmann/phpunit/wiki/End-of-Life-for-PEAR-Installation-Method.

Replace PEAR in a comment and die output message with Composer.

Signed-off-by: AntonyThorpe <antony.thorpe@budget12.com>
2014-09-08 17:46:09 +12:00
Stig Lindqvist
9f3506bf02 Merge pull request #3467 from halkyon/distinct_orm
Adding ability to change query distinct on DataList and DataQuery
2014-09-04 14:08:40 +12:00
Sean Harvey
151b7e9876 Adding ability to change query distinct on DataList and DataQuery 2014-09-04 13:51:43 +12:00
Stig Lindqvist
5168fadbe0 Merge pull request #3468 from halkyon/tidy_fixes
BUG CSSContentParser fails if CLI tidy doesn't output anything.
2014-09-04 11:15:39 +12:00
Simon Welsh
bc5cb4296b Merge pull request #3470 from spekulatius/patch-2
Update templates.md
2014-09-04 09:10:32 +10:00
spekulatius
400bea1ee1 Update templates.md
Remove link to page which wasn't continued since 2.4.
2014-09-04 10:51:02 +12:00
Simon Welsh
64d0a2152b Merge pull request #3469 from stevie-mayhew/patch-1
DataList spelling error
2014-09-04 07:18:42 +10:00
Stevie Mayhew
05379ff188 DataList spelling error
Minor spelling error in DataList
2014-09-04 09:16:13 +12:00
Sean Harvey
fe42abce69 BUG CSSContentParser fails if CLI tidy doesn't output anything.
In cases where CLI tidy fails to recognise HTML with errors or
unknown HTML5 elements, it doesn't output any content and
CSSContentParser fails.

This adds the --force-output parameter so that it always outputs
the input content, even if it wasn't completely fixed by tidy.

It seems that tidy class in PHP already does this, so this just
fixes the CLI use of tidy in CSSContentParser to be consistent.

This fix can be observed on the HHVM travis builds, as tidy isn't
compiled into HHVM as an extension.
2014-09-03 23:08:53 +12:00
Stig Lindqvist
c112c1c69f Merge pull request #3466 from halkyon/showqueries_label
showqueries output incorrectly shows "ms" instead of "s"
2014-09-03 16:27:33 +12:00
Sean Harvey
e93683bfca showqueries output incorrectly shows "ms" instead of "s" 2014-09-03 16:24:56 +12:00
Sean Harvey
55de41b0d5 Merge pull request #3465 from tractorcow/pulls/3.1/fix-query
BUG MySQLDatabase performs queries on wrong DB connection when using connection $name != default
2014-09-03 11:58:30 +12:00
Damian Mooyman
56d84d22a1 BUG MySQLDatabase performs queries on wrong DB connection when using connection $name != 'default' 2014-09-03 11:43:24 +12:00
Nik
6141930f15 Copy SSViewer rewrite_hash_links regexp to SSTemplateParser
As this is meant to represent the same functionality in two different
areas, it should behave the same way in both.
2014-09-02 15:20:47 +12:00
Damian Mooyman
35fcb551d9 Refactor / Cleanup Versioned 2014-09-02 09:17:13 +12:00
Damian Mooyman
c140459ac6 BUG Fix versioned
Versioned is not writing Version to _version tables for subclasses of Version dataobjects which have their own DB fields
- Fix disjoint of ID / RecordID (which should be the same)
- Fix calculation of new record version
- Fix use of empty vs !isset to check for existing version
2014-09-02 09:14:08 +12:00
Ingo Schommer
26d7febe05 Merge pull request #3461 from NightJar/testfix
Fix some edgecase test issues
2014-09-02 08:52:56 +12:00
Nightjar
e4b563e596 Fixing the failure of some tests if the framework dir is named something other than 'framework' (which is a legitimate option) 2014-09-01 13:53:06 +01:00
Ingo Schommer
da61229221 Merge pull request #3430 from kinglozzer/pulls/retina
Add "retina" graphics for high-dpi screens
2014-09-01 23:09:40 +12:00
Will Rossiter
265a34141e GridFieldDeleteAction missing button text without icons
The text on the button is hidden from view via CSS already. This allows the button to have text in the event that the GridField does not provide icons (and likely is better for your screen readers).
2014-09-01 21:58:07 +12:00
Will Rossiter
3644110349 FIX: Ensure that columns are unique within a gridfield 2014-09-01 21:50:36 +12:00
Will Rossiter
0991477e5a Add support for directly saving into a File object
saveInto() assumed you were either saving into a hasOne or if you wanted to create a new object.

This made it impossible to have a FileField on an object that you wanted to upload to. This adds a check so that if the local object is a file, save to that.
2014-08-31 15:59:17 +12:00
Will Rossiter
4b6a03bb0b Fix deprecation warning with word_list 2014-08-31 15:59:16 +12:00
Simon Welsh
7bacaa8c6b Merge pull request #3453 from uniun/patch-1
RSS feed should be sent with charset=utf-8 header
2014-08-30 13:18:47 +10:00
Sean Harvey
98ab540aba Merge pull request #3454 from christopherdarling/patch-1
add .yml indentation
2014-08-29 21:57:04 +12:00
Christopher Darling
d993ea8cd0 add .yml indentation
added some extra rules for any _config/*.yml files so that they use 2 space indents.
2014-08-29 09:48:40 +01:00
Elvinas L.
64490129c2 RSS feed should be sent with charset=utf-8 header 2014-08-29 11:04:44 +03:00
Will Rossiter
7b0ae41916 Merge pull request #3452 from assertchris/add-editorconfig
Add editorconfig.
2014-08-29 15:32:25 +12:00
Christopher Pitt
e391ed5b91 Add editorconfig. 2014-08-29 10:28:05 +12:00
Simon Welsh
6fed1f6791 Merge pull request #3449 from camspiers/patch-2
Fix deprecation warnings in internal SQLQuery usage
2014-08-28 12:43:06 +10:00
Cam Spiers
298017c6d1 Fix deprecation warnings in internal SQLQuery usage 2014-08-28 14:26:17 +12:00
Loz Calver
5f653a00eb Add "retina" styles for high-dpi screens 2014-08-27 17:06:57 +01:00
Simon Welsh
935eabc1f9 Merge pull request #3436 from dnadesign/fixsortonrelations
FIX: Sorting a DataQuery over a relation.
2014-08-26 15:54:38 +10:00
Will Rossiter
7993875f16 FIX: Sorting a DataQuery over a relation.
When sorting a DataQuery over a relation, the SQLQuery automatically included the sort column. The issue with the implement is that potentially the joined record has a field with the same name as the source record causing it to be overridden.

In the attached test case, without the patch the title will be set to 'Bar' rather than 'Foo'.

This patch aliases the sort column. Alternativally a patch would be to
2014-08-26 17:41:38 +12:00
Sean Harvey
70dfc55d34 Minor correction to documentation 2014-08-26 14:55:45 +12:00
Damian Mooyman
e301279358 Merge pull request #3425 from halkyon/removing_deprecated2
Removing deprecated class/functions marked for deprecation in 3.0/3.1
2014-08-26 09:13:08 +12:00
Sean Harvey
89245ef443 Merge pull request #3433 from chillu/pulls/authenticate-backurl-master
Don't clear BackURL after MemberAuthenticator::authenticate()
2014-08-26 08:59:58 +12:00
Ingo Schommer
e56ad9b37c Don't clear BackURL after MemberAuthenticator::authenticate()
It breaks logic flow, e.g. when

Its called by BasicAuth:requireLogin() when basic auth is enabled,
before any controller logic kicks in (on every HTTP request).
This means you can't use session-based BackURLs with basic auth enabled,
breaking flows like redirection after Facebook logins.

I can't see why a clear() was necessary here, looks like a overly
cautious way to prevent infinite loops? Can't see how those
would be caused by requireLogin() though.

Been there since all the way back in 2007: a377a67e54
2014-08-25 23:12:52 +12:00
Sean Harvey
07eef2ece2 Removing deprecated class/functions marked for deprecation in 3.0/3.1 2014-08-25 12:06:05 +12:00
Damian Mooyman
9ec4669a59 Merge remote-tracking branch 'origin/3.1.6' into 3.1 2014-08-25 11:38:13 +12:00
Damian Mooyman
9da3357e3a add 3.1.6 docs 2014-08-25 11:25:01 +12:00
Damian Mooyman
f3974f0e63 Merge pull request #3412 from halkyon/redundant_config
Removing redundant aggregatestore cache config (#3404)
2014-08-25 11:21:18 +12:00
Damian Mooyman
96d0874953 BUG Fix issue with inheritance of Injector service configuration 2014-08-25 10:23:01 +12:00
Damian Mooyman
5b553616dc API DateTime.Ago better infers significance of date units.
BUG Fixes missing i18n translation in Date::TimeDiffIn
BUG Fixes Date::TimeDiffIn not respecting mocked SS_Datetime::now
This provides less vague date periods. I.e. "36 days" has a lot more relevance that "1 month"
Reduced duplication of time period calculation code
(ref: CWPBUG-141)
2014-08-25 10:04:24 +12:00
Sean Harvey
afa6612074 Merge pull request #3428 from chillu/pulls/contrib-docs
Updated contrib docs, mention "DO NOT MERGE" pull requests
2014-08-25 09:00:38 +12:00
Ingo Schommer
5c9e88b9a0 Updated contrib docs, mention "DO NOT MERGE" pull requests
These should be avoided because they undermine the process of
peer review and merging in github, we should strive to have
zero open pull requests, as opposed to treating it as a stage
for work in progress. Intermediary code review can happen in github forks instead.

Also remove some checklist items which were based on the Trac bugtracker,
e.g. its not longer possible to assign yourself to issues because
of github's limited permission abilities.
2014-08-25 08:29:25 +12:00
Sean Harvey
13ca45411c Merge pull request #3427 from dhensby/patch-4
Use injector to create `ValidationResult`
2014-08-23 11:53:57 +12:00