Sean Harvey
56e75b4486
MINOR Revert changes for 5.4
2012-05-10 14:11:33 +12:00
Sean Harvey
f30a3bd760
BUGFIX Database::doesSchemaNeedUpdating() if schemaUpdateTransaction is NULL, then return FALSE. If schemaUpdateTransaction is an array, then return TRUE. This replaces the automatic casting which is not clear.
2012-05-10 13:58:29 +12:00
Stig Lindqvist
bbe3879eaa
BUGFIX: Member::mapInGroups() throws SQL error
...
Renamed the Member::mapInGroups() to Member::map_in_groups() since it's a static method and throws deprecation message if using the old variant.
Rewrote the mapInGroups to use a more ORMy way of fetching Members for a set of groups and included a test for.
2012-05-10 13:53:54 +12:00
Sean Harvey
7dcfdb05fa
MINOR Fixing broken test on PHP 5.4
2012-05-10 13:40:35 +12:00
Sean Harvey
68c5066adf
MINOR Remove old _ALL_CLASSES from old manifest builder (has been replaced since)
2012-05-10 13:25:04 +12:00
Sean Harvey
1f4aa0537b
Merge pull request #421 from silverstripe-scienceninjas/bad-exception-throwing
...
BUGFIX Throwing an InvalidArgumentException without the new keyword results in a Fatal error
2012-05-09 17:56:57 -07:00
Stig Lindqvist
c05e80c9f3
Merge pull request #418 from halkyon/phpunit_fixes
...
Fixing phpunit.xml support, remove PHPUnit 3.4 support
2012-05-09 17:51:04 -07:00
Stig Lindqvist
ce5684c776
BUGFIX Throwing an InvalidArgumentException without the new keyword results in a Fatal error
2012-05-10 11:21:32 +12:00
Ingo Schommer
6655830231
MINOR Upgrading notes around tab rewrites
2012-05-09 17:47:19 +02:00
Ingo Schommer
11f4756225
ENHANCEMENT Auto-hiding tab bar in CMS forms if only a single tab is available (to save screen space and reduce UI clutter) (see #7261 )
2012-05-09 17:19:20 +02:00
Ingo Schommer
8c9560d288
ENHANCEMENT FieldList->setTabPathRewrites() for better backwards compatibility (see #7261 )
2012-05-09 17:18:16 +02:00
Sean Harvey
a1d676d353
BUGFIX Ensure PHPUnit 3.6 is available, show a nice message if not
2012-05-09 23:40:25 +12:00
Sean Harvey
b1e17578c7
API CHANGE Removed assertType() and assertEmpty() workarounds. Use assertInstanceOf()
...
instead of assertType(), assertEmpty() is available in PHPUnit 3.5+.
PHPUnit 3.4 is no longer supported, so please upgrade your version to
work.
MINOR Removed FullTestSuite which was a workaround for PHPUnit but not
used.
2012-05-09 23:05:39 +12:00
Sean Harvey
8b607db0a2
BUGFIX Fixing bootstrap.php to work with FakeController properly for
...
running tests using phpunit.xml file.
2012-05-09 23:05:38 +12:00
Ingo Schommer
f546ab2a70
Merge pull request #417 from halkyon/sapphire
...
---
Ensure the lazy loaded form inside htmleditorfield-dialog is redrawn when lazy loaded. This fixes the initial state for the insert link dialog form.
Also ensure the link form uses "internal" as the default, so the initial state doesnt show all fields, just those associated with the first radio option "internal".
This also fixes http://open.silverstripe.org/ticket/7273 .
2012-05-09 11:26:01 +02:00
Ingo Schommer
82db28811d
BUGFIX Show progress indicator when uploads are added to AssetUploadField, to ensure that failed uploads (e.g. exceeding max filesize) can actually show their error message to the user
2012-05-09 11:19:06 +02:00
Ingo Schommer
9950fa362e
Merge pull request #413 from chillu/urlsegment-multibyte-fix
...
URLSegment multibyte fixes
2012-05-09 01:32:58 -07:00
Ingo Schommer
1671b9c65c
BUGFIX Checking for mbstring PHP extension support in installer, as it has been a documented installation requirement for a while. Removing method_exists() checks from mbstring usage in core for the same reasons
2012-05-09 10:25:31 +02:00
Ingo Schommer
6f9483cafe
Merge pull request #415 from halkyon/datamodel_doc_changes
...
MINOR Updating docs to use Member::get() instead of DataList::create('Member')
2012-05-09 00:27:19 -07:00
Naomi Guyer
d642eee28e
ENHANCEMENT: UI Changes to FileUpload Area (TRAC-7219)
...
1. Add arrows to edit dropdowns
2. Adjust lightened fields so they don't look like input boxes, and fix
rgba colours
3. Add ability to click file names to edit
4. Add feedback when edit button is hovered
5. Add feedback if a file has been opened for editing and shut again
(saved changes, unsaved changes, unchanged)
6. Add ability to open and close all files to edit them all at once
7. Add overall feedback for file uploads, and fix NaN error
8. Fix up area to match design
9. Fix error messages so they fit in the provided space
10. Fix case where a single uploaded file errors
2012-05-09 18:38:21 +12:00
Naomi Guyer
7d5e46cdcf
BUGFIX: IE Colours
...
Replace hard coded colours in IE with variables, and refactored code
so that shared IE7 and IE8 fixes are in one place.
2012-05-09 18:31:25 +12:00
Naomi Guyer
181ea6cbea
BUGFIX: colour Adjustments
...
Change the constructive button colour to match the colour used in the
designs, and fixed up calculations to produce the correct button colour.
2012-05-09 18:24:36 +12:00
Sean Harvey
fdebedd103
BUGFIX Ensure the form inside htmleditorfield-dialog element is redrawn when the form is lazy loaded by AJAX.
2012-05-09 17:11:59 +12:00
Sean Harvey
0f1f8592bd
MINOR Updating docs to use Member::get() instead of DataList::create('Member') syntax
2012-05-09 11:29:24 +12:00
Sean Harvey
ddd5c402b0
Merge pull request #414 from silverstripe-scienceninjas/gridfielddatacolumns-refactor
...
MINOR GridFieldDataColumns Docblocks and functionality to it's own method
2012-05-08 15:51:42 -07:00
Stig Lindqvist
0af2d87bb3
MINOR Cleaned up the GridFieldDataColumns to be easier on the eyes and fixed the some method docblocks for the interface
2012-05-09 10:35:35 +12:00
Ingo Schommer
18dbdd2df9
BUGFIX Loosened character replacement in static-main.php, to allow for multibyte paths (see URLSegmentFilter::$default_allow_multibyte)
2012-05-08 23:43:45 +02:00
Ingo Schommer
41b51a17ce
MINOR Isolating testRaw2URL settings
2012-05-08 22:13:03 +02:00
Ingo Schommer
8281678d4c
BUGFIX Urlencode paths in URLSegmentFilter when $allowMultibyte=true to avoid creating invalid URLs (and breaking assumptions based on ascii-only URLs, such as static publishing filename creation)
2012-05-08 15:32:15 +02:00
Ingo Schommer
59d31c2fc2
MINOR Removed mbstring support checks, its an installation requirement
2012-05-08 15:32:15 +02:00
Ingo Schommer
592d42e477
MINOR Stop using deprecated getTabIndex() in CreditCardField
2012-05-08 14:26:22 +02:00
Ingo Schommer
9052cdc1da
ENHANCEMENT Making "Users", "Groups" and "Roles" tabs in SecurityAdmin bookmarkable.
...
ENHANCEMENT Fixed SecurityAdmin->Breadcrumbs() to include link to individual tab, and disable backlink (signed off by Paul)
2012-05-08 11:25:47 +02:00
Ingo Schommer
2c878f5296
MINOR Template consistency between TabSet.ss and overloaded LeftAndMain tabsets
2012-05-08 11:25:47 +02:00
Ingo Schommer
f2d2f5bb0e
MINOR Changed CMS section name from "Users" back to its 2.4 label, "Security". Mainly to avoid breadcrumb weirdnesses when having a "Users/Users/My User" path. Signed off by Paul.
2012-05-08 11:25:47 +02:00
Ingo Schommer
a2dbd69f2c
ENHANCEMENT Allow Controllers to opt-out or modify the back link behaviour in GridFieldDetailForm
2012-05-08 11:25:47 +02:00
Ingo Schommer
2212363a0f
MINOR Using new extraClass support in tabs for CMSTabSet
2012-05-08 11:25:46 +02:00
Ingo Schommer
6d999aa6ba
ENHANCEMENT addExtraClass() support for Tab and TabSet
2012-05-08 11:25:44 +02:00
Sean Harvey
c507efcfad
MINOR Updated TinyMCE dependency from 3.4.6 to 3.5
2012-05-08 16:29:43 +12:00
Sean Harvey
5bce3425b4
Merge pull request #401 from chillu/is-absolute-url
...
Director::is_absolute_url() security fixes
2012-05-07 18:47:03 -07:00
Ingo Schommer
15e8e10f5e
Merge pull request #411 from ajoneil/blowfish
...
MINOR: Fix coding conventions
2012-05-07 15:56:03 -07:00
Ingo Schommer
82cf93855e
MINOR Reverting padding changes from pull request #377 , way too global - solved through a .cms-panel-padded class in CMSSettingsController instead
2012-05-08 00:53:06 +02:00
Ingo Schommer
76dd6d1636
MINOR Fixed style sprites broken by pull request #402
2012-05-08 00:43:25 +02:00
Andrew O'Neil
0c0a91e3c1
MINOR: Fix coding conventions
2012-05-08 10:33:03 +12:00
Ingo Schommer
7e0d0a4dee
MINOR Tree metadata naming
2012-05-07 14:45:25 +02:00
Ingo Schommer
23148b959a
Merge pull request #402 from ohararyan/sapphire
...
---
http://open.silverstripe.org/ticket/7214
Added watermark to show current state of preview.
Removed button styling from Draft and Preview and added styling to show current selected state.
Designs signed off by Paul
Conflicts:
admin/css/screen.css
2012-05-07 13:01:00 +02:00
Ingo Schommer
f56097a29b
Merge pull request #386 from adrexia/sapphire
...
---
Includes:
* Changes to chosen to include a custom function that will let the drop-down rise-up if there is room and it would otherwise drop beneath the size of the window (changes in coffeescript, jquery output, and chosen css)
* Changes in SCSS to stop the automatic addition of scrollbars, and to limit the extra space at the bottom of the filter div
Issues remaining:
* jLayout is calculating the height of the filter div incorrectly. It is assuming the div is around 70px longer than it is. This height assumption is linked somehow to chosen, as initiating the select box results in a correct height calculation.
2012-05-07 11:21:23 +02:00
Ingo Schommer
bed5655d5e
Merge pull request #409 from normann/sapphire
...
---
Add page icons to the tree node in TreeDropdownField in page add form.
2012-05-07 11:02:59 +02:00
Sean Harvey
7c272d3139
MINOR SQLQuery doc cleanup
2012-05-07 17:11:10 +12:00
Sean Harvey
3bc1da0543
MINOR Tidy up of SQLQuery constructor docs and default args, limit is
...
stored internally as an array, not a string.
2012-05-07 17:07:30 +12:00
Sean Harvey
bb9ffd2eb1
ENHANCEMENT SQLQuery::selectField() returns a SQLQuery object to be
...
consistent with how the other add/set methods work.
MINOR Fixing DbDatetimeTest to use the correct selectField to select an
alias
2012-05-07 16:59:42 +12:00
