Ingo Schommer
d4b8db27af
Marking fake LeftAndMain->redirect() responses as finished
...
Introduce new LeftAndMain_HTTPResponse class for this purpose,
to mark a response as finished regardless of HTTP status.
This is required for ajax responses which do redirects on app layer
rather than HTTP (to avoid double processing).
Specifically required to decorate LeftAndMain->init()
in the 'translatable' module (TranslatableCMSMainExtension),
which marks the response as finished through its redirect,
avoiding further processing after init().
2012-07-16 23:30:59 +02:00
Ingo Schommer
ba9c3c7b8e
BUGFIX Type checking in CMS URL params ( fixes #7187 )
...
Nasty issue where nested requests to sub-controllers within LeftAndMain->EditForm() would fail because of
LeftAndMain->currentPageID() being taken from the URL, even though it was a field action name.
Example: POST /admin/pages/edit/EditForm/field/MyGridField/item/1/ItemEditForm/field/MyUploadField/upload
The current ID would be detected as "field" in this case.
Bug was previously fixed for AssetAdmin.
2012-06-22 17:47:45 +02:00
Sam Minnée
7ce7ac406e
Merge pull request #528 from mango9/master
...
Ticket #5578
2012-06-14 16:43:20 -07:00
Hamish Friedlander
21e7ec61f4
ENHANCEMENT: In dev mode, include some basic leak detection functions in the admin panel
2012-06-15 01:19:19 +02:00
Ingo Schommer
c81d0e1222
MINOR Only set X-Pjax header in redirections if it doesn't already exist in the response
2012-06-14 20:20:29 +02:00
Paul Meyrick
882b4267cb
BUGFIX: Ticket #5578 SiteTree->CanCreateTopLevel() doesn't change dragged tree nodes or ParentID changes
2012-06-14 17:17:27 +12:00
Andrew Short
d9c7bb8eb9
ENHANCEMENT: Implemented help text for form fields.
...
The title attribute is extracted from form fields and displayed inline
below the field.
2012-06-13 13:19:12 +02:00
Ingo Schommer
ce3d48e310
MINOR Supressed dependencies of tree logic on SiteTree elements (not properly isolated to work well with Folder objects)
2012-06-13 00:51:53 +02:00
Ingo Schommer
b1d95cffac
BUGFIX Passing existing SS_HTTPResponse to PjaxResponseNegotiator in LeftAndMain so state like X-Status HTTP headers are retained ( fixes #7427 )
2012-06-13 00:27:03 +02:00
Ingo Schommer
ed9c856442
ENHANCEMENT Strikethrough styling for deleted tree nodes, adding status classes to tree node <li> in addition to the existing <span class="badge"> ( fixes #7410 )
2012-06-12 15:53:38 +02:00
Sam Minnee
267f41bdf4
ENHANCEMENT: Point userhelp link at a new userhelp instance. ( #7430 )
2012-06-07 13:46:47 +12:00
Ingo Schommer
b3164eb2a9
MINOR Disabled jQuery.entwine inspector in dev mode, as it causes side effects due to document.write() before other scripts are loaded
2012-06-06 11:49:32 +02:00
Ingo Schommer
5178954311
UNFINISHED Processing multiple PJAX responses on CMS JavaScript, introducing data-pjax-fragment attribute to identify reloadable template parts
2012-05-30 15:07:13 +02:00
Ingo Schommer
5b03f49245
BUGFIX Respecting server-overrides on X-Pjax responses during ajax redirects. Fixes GridFieldDetailForm redirect after delete, e.g. in ModelAdmin. Partially reverts 8b4b896
. Closes pull request #488
2012-05-29 11:34:47 +02:00
Sean Harvey
45465dca91
Merge pull request #483 from halkyon/cms_ping_keepalive
...
Re-instate CMS ping to ensure sessions are kept alive
2012-05-23 15:55:22 -07:00
Sean Harvey
77c2365b87
MINOR Replacing deprecated static function calls to Director with
...
current Controller instance replacements.
2012-05-23 21:50:02 +12:00
Sean Harvey
ecf847b61c
ENHANCEMENT Re-instate pinging every 5 minutes in the CMS as a measure
...
to keep sessions alive. Moved Security/ping to admin/security/ping
2012-05-23 17:15:17 +12:00
Sean Harvey
3ed9c5f9f8
MINOR Removed getitem allowed action, this method no longer exists in LeftAndMain
2012-05-22 17:33:34 +12:00
Sean Harvey
3f932d6bad
Merge pull request #464 from mateusz/os7299
...
BUGFIX: add capability of redirecting form actions.
2012-05-17 22:44:05 -07:00
Mateusz Uzdowski
8b4b896578
BUGFIX: add capability of redirecting form actions.
...
Form actions assume that they are reloading the form afterwards. But
this is not always the case - for example "delete" action will redirect
back to the panel, so we need to be able to set the X-Pjax headers
accordingly.
2012-05-18 17:36:06 +12:00
Sam Minnee
70a5b49dd6
MINOR: Fixed i18n coding for LeftAndMain save and delete.
2012-05-18 16:15:13 +12:00
Ingo Schommer
5ff282e20a
MINOR Allow extending LeftAndMain->SiteTreeAsUL() (specifically used to add the language drop down for the 'translatable' module)
2012-05-15 21:28:38 +02:00
Ingo Schommer
8e39e7dfba
MINOR Allow extension of LeftAndMain->Link()
2012-05-15 21:27:32 +02:00
Ingo Schommer
d42ea5a9d6
BUGFIX Encoding multibyte characters in custom X-Status HTTP headers used in CMS (headers don't allow multibyte data)
2012-05-14 15:13:49 +02:00
Ingo Schommer
45ae2465e8
Merge pull request #438 from ajshort/sapphire
...
---
These are some enhancements + tweaks I made as part of getting the advanced workflow module running in SS3:
* Added a readonly view button and action to GridField.
* Made LeftAndMain::getResponseNegotiator() public so CMS extensions can use it to generate responses.
* Fixed top tab background, made text more readable (http://i.imgur.com/yDmmY.png ).
* Allow fields in the CMS to not be change tracked using ".no-change-track".
* Made all icons 16x16 (some were different sizes, being cut off), and allow them without .ui-state-default.
* Fixed ToggleCompositeField and tweaked field styling.
2012-05-14 14:25:16 +02:00
Hamish Friedlander
7f05add15e
ENHANCEMENT: Make jQuery.Entwine inspector available in admin panels in dev mode
2012-05-14 16:34:18 +12:00
Andrew Short
1e174b3102
API CHANGE: Made LeftAndMain::getResponseNegotiator() public so extensions can use it.
2012-05-12 18:49:56 +10:00
Mateusz Uzdowski
be06ae7e5f
MINOR: change the tree reorganisation message.
2012-05-11 16:22:56 +12:00
Ingo Schommer
7e0d0a4dee
MINOR Tree metadata naming
2012-05-07 14:45:25 +02:00
Ingo Schommer
4029f96728
ENHANCEMENT Section icons in CMS ( #7269 )
2012-05-03 13:49:19 +02:00
Ingo Schommer
7b18d9d0da
MINOR Switching _t() calls from sprintf() to using injection parameters ( #7170 )
2012-05-01 22:17:00 +02:00
Sean Harvey
1663e96ddb
BUGFIX Fixing stray . in the "Page type: x" tooltip hovering over a page
2012-05-01 15:16:22 +12:00
Sam Minnee
9d36048ada
BUGFIX: Fixed a few references to non-existent $request variable.
2012-04-19 10:11:01 +12:00
Ingo Schommer
d8bb1b2375
MINOR Consistent link method names: LeftAndMain->PreviewLink() changed to LinkPreview()
2012-04-18 22:59:18 +02:00
Ingo Schommer
57ee9bf5e8
MINOR Removed unnecessary jquery.livequery include from CMS, its still processing in the background = performance overhead
2012-04-18 17:37:36 +02:00
Ingo Schommer
972e7ccb1a
MERGE sitetreeasul
2012-04-18 16:55:15 +02:00
Ingo Schommer
473d3a66b8
MINOR Fixed controller contexts in LeftAndMain->SiteTreeAsUL() - needs different context for edit links and determining "current page" (not applicable for CMSPagesController)
2012-04-17 22:33:30 +02:00
Ingo Schommer
0ef5d0b84f
MINOR Moved tree filtering in LeftAndMain from SiteTreeAsUL() into getSiteTreeFor() to allow filtering the initial tree (via GET parameters), rather than just through getsubtree()
2012-04-17 16:07:22 +02:00
Ingo Schommer
9b2b39aaaa
MINOR More specific tree links, to ensure correct CMSMain subclass is used
2012-04-17 11:03:09 +02:00
Andrew O'Neil
3b9f99394b
MINOR: Use config system for cms title, rather than eval.
2012-04-16 11:04:55 +12:00
Ingo Schommer
d44f6b3e1f
MINOR Removed deprecated usage of $priority argument in _t() calls
2012-04-15 17:17:17 +02:00
Will Rossiter
befbd3e6a8
MINOR: remove reference to sapphire in CMSVersion
2012-04-15 15:00:52 +12:00
Simon Welsh
3a6341a251
API-CHANGE sapphire folder can now be renamed.
2012-04-15 10:50:19 +12:00
Ingo Schommer
3572b31a94
MINOR Default app title when SiteConfig object is not present ( fixes #7114 )
2012-04-13 16:21:30 +02:00
Ingo Schommer
85a898e1d5
MINOR Don't assume existence of cms/ folder in LeftAndMain->CMSVersion() (regression from earlier code)
2012-04-09 23:55:23 +02:00
Wolf Vollprecht
3ae0ac7805
ENHANCEMENT: Rightlick submenu styles and ability to add page with pagetype
2012-04-09 21:08:19 +02:00
Sam Minnee
e01b0aa3d0
ENHANCEMENT PjaxResponseNegotiator for more structured partial ajax refreshes, applied in CMS and GridField. Also fixes issues with history.pushState() and pseudo-redirects on form submissions (e.g. from page/add to page/edit/show/<new-record-id>)
2012-04-05 23:00:22 +02:00
Ingo Schommer
a44b67bae2
API CHANGE Moved RequestHandler->isAjax() to SS_HTTPRequest->isAjax()
2012-04-05 23:00:22 +02:00
Ingo Schommer
40d73127ae
MINOR Using late static binding instead of Object::create() calls
2012-04-04 17:10:31 +02:00
Ingo Schommer
6517f4496b
Merge pull request #273 from ajoneil/sapphire
...
---
This allows DataList::create(SiteTree) as equivalent to Object::create(DataList, SiteTree), without
having to have a create() function on DataList.
Required for E_STRICT compliance, as child classes cant override create() if they change the arguments.
DBField::create() is also renamed to DBField::create_field(), as this does not just call the constructor, which all other cases of create() do.
Conflicts:
tests/model/DateTest.php
tests/model/DatetimeTest.php
2012-04-04 16:48:16 +02:00