Commit Graph

4510 Commits

Author SHA1 Message Date
Sam Minnee
61012967cf MINOR Fixed TimeField validation _t() entity name (from r107787)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112695 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:25:17 +00:00
Sam Minnee
171fdd6050 BUGFIX Using actual date format settings in DateField/TimeField->validate() messages (from r107786)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112694 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:23:40 +00:00
Sam Minnee
40bc9ced5d BUGFIX Limit 'showcalendar' javascript option to DateField instances (rather than applying to all available) (from r107785)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112693 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:22:56 +00:00
Ingo Schommer
fd6fa62388 MINOR Fixed merge error
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112616 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 04:02:54 +00:00
Ingo Schommer
a0dd4ff8f0 MINOR Moved class-specific documentation from doc.silverstripe.org back into class-level PHPDoc (from r107725)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:55:22 +00:00
Ingo Schommer
eed13a7384 MINOR: removed whitespace (from r107586)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112607 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:54:31 +00:00
Ingo Schommer
d794381e98 BUGFIX: fixed inclusion of environment file when document root is the web root (from r107585)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112605 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:54:12 +00:00
Ingo Schommer
1c54a6dc77 BUGFIX Case insensitive extension checks in File::validate() (fixes #5781, thanks simon_w) (from r107539)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112604 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:53:54 +00:00
Ingo Schommer
b64015e2cf BUGFIX Remove dummy entry created by Versioned if record is first written to Live stage (fixes #5596, thanks muzdowski) (from r107537)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112603 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:53:14 +00:00
Ingo Schommer
577e82a123 BUGFIX Fixed Member->PasswordEncryption defaults when writing new Member without setting a password. Fixes critical issue with MemberTableField saving in admin/security, where new members are stored with a cleartext password by default instead of using the default SHA1 (see #5772) (from r107532)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112602 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:52:38 +00:00
Ingo Schommer
bd927c9355 ENHANCEMENT: html2raw now properly replace strong tag with asterix #5494 (from r107443)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112600 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:51:55 +00:00
Ingo Schommer
e07d56096d BUGFIX Allowing DatetimeField->saveInto() to save a partial array notation with missing 'time' value (from r107441)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112599 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:51:21 +00:00
Ingo Schommer
52bd0cc4bb API CHANGE Using FieldHolder() instead of Field() for subfields in DatetimeField->FieldHolder(), in order to get configuraton settings for javascript DateField (from r107439)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:49:06 +00:00
Ingo Schommer
d67c43ad7d ENHANCEMENT Using jQuery UI datepicker in DateField and DatetimeField instead of outdated DHTML calendar.js (fixes #5397)
ENHANCEMENT Abstracted optional DateField->setConfig('showcalendar') logic to DateField_View_JQuery (from r107438)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:48:39 +00:00
Ingo Schommer
ab918e8546 MINOR Better error handling in i18n::get_language_name() (from r107437)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112596 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:47:44 +00:00
Ingo Schommer
f097b678d8 ENHANCEMENT: allow adding a new a field to ArrayData (from r107434)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112595 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:47:27 +00:00
Ingo Schommer
cfe9b518a5 MINOR: Fixed Documentation (from r107430)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:46:54 +00:00
Ingo Schommer
556e753fee ENHANCEMENT: Added documentation and changed static names (from r107429)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112593 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:46:32 +00:00
Ingo Schommer
f179458542 BUGFIX: Added quotes for postgres (from r107428)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112592 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:46:08 +00:00
Ingo Schommer
2f4fe2ff35 ENHANCEMENT: Added static to set regeneration of default pages (ticket #5633) (from r107426)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112591 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:44:57 +00:00
Ingo Schommer
bd6e51c87f BUGFIX: Only highlight strings more than 2 characters long. #4949 (from r107423)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112590 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:44:24 +00:00
Ingo Schommer
80eab2a24c BUGFIX: Reverted 107414, wrong patch (from r107417)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112589 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:43:47 +00:00
Ingo Schommer
f63751893b BUGFIX Allowing dev/build in "live" mode when Security::database_is_ready() returns FALSE (typically happens when an existing SilverStripe project is upgraded and database columns in Member/Permission/Group have been added) (fixes #4957)
MINOR Using Object::create() in DevelopmentAdmin to make objects mockable
ENHANCEMENT Added Security::$force_database_is_ready to mock database_is_ready() state
ENHANCEMENT Added permission check exception in TaskRunner and DatabaseAdmin if SapphireTest::is_running_test() returns TRUE (necessary for DevelopmentAdminTest) (from r107415)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112588 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:43:30 +00:00
Ingo Schommer
3b500bb137 BUGFIX: TableListField headings i18n translation (ticket #5742) (from r107414)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112576 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:26:45 +00:00
Ingo Schommer
8f8de04aaf MINOR Documentation in DataObjectSet (from r107400)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112575 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:26:27 +00:00
Ingo Schommer
380e0af8c0 MINOR Changed "no_NO" locale for Norwegian into the more commonly used "nb_NO" in i18n class, meaning translations from translate.silverstripe.com can actually be selected now (fixes #5746) (from r107394)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112574 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:26:11 +00:00
Ingo Schommer
6351b16ab9 BUGFIX Added Locale hidden field to HTMLEditorField->LinkForm() in order to show correct context in "page on the site" dropdown (fixes #5743) (from r107390)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112573 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:25:51 +00:00
Ingo Schommer
aa1553517c ENHANCEMENT Use array_combine() instead of custom logic for ArrayLib::valuekey() (thanks paradigmincarnate!) (from r107380)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112572 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:24:32 +00:00
Ingo Schommer
d99caf31f7 BUGFIX Fixed spelling error of $databaseConfig in cli-script.php causing database configuration to not load (thanks aimcom!) (from r107369)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112571 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:23:57 +00:00
Ingo Schommer
ad7267aa4c ENHANCEMENT Member_DatetimeOptionsetField toggle text is now translatable (from r107365)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112570 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:23:43 +00:00
Ingo Schommer
6959909cb6 ENHANCEMENT #5352 Translatable entities for help text in Member_DatetimeOptionsetField::getFormattingHelpText() (from r107334)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112569 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:23:22 +00:00
Ingo Schommer
47762cdf5b ENHANCEMENT #5352 Decouple date display from i18n locales, users now have access to change their date and time formats in Member::getCMSFields() using Member_DatetimeOptionsetField field (from r107326)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:23:02 +00:00
Ingo Schommer
706553ee95 MINOR Checking that Folder::findOrMake() can create an assets/assets/ folder (from r107276)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112567 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:21:41 +00:00
Ingo Schommer
07494a5f93 MINOR Using Filesystem::makeFolder() instead of mkdir() in Folder for file operations (from r107275)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112566 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:21:23 +00:00
Ingo Schommer
35b41709c2 MINOR Better presentation of extension error message in File and UploadValidator (from r107274)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112565 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:21:04 +00:00
Ingo Schommer
5d5bb2618a API CHANGE Don't reflect changes in File and Folder property setters on filesystem before write() is called, to ensure that validate() applies in all cases. This fixes a problem where File->setName() would circumvent restrictions in File::$allowed_extensions (fixes #5693)
API CHANGE Removed File->resetFilename(), use File->updateFilesystem() to update the filesystem, and File->getRelativePath() to just update the "Filename" property without any filesystem changes (emulating the old $renamePhysicalFile method argument in resetFilename())
API CHANGE Removed File->autosetFilename(), please set the "Filename" property via File->getRelativePath()
MINOR Added unit tests to FileTest and FolderTest (some of them copied from FileTest, to test Folder behaviour separately) (from r107273)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:20:47 +00:00
Ingo Schommer
8ed5e18085 MINOR Changed ImageTest to use fixture files located in assets/ folder, the filesystem API doesn't support Folder objects with "sapphire/..." paths, which leads to inconsistent results (from r107272)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112561 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:17:14 +00:00
Ingo Schommer
9d227ba2e4 MINOR Making FileTest->setUp()/tearDown() more resilient against in-test file/folder renames (from r107271)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112560 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:16:33 +00:00
Ingo Schommer
8b88f4aaf4 MINOR More identifiable file naming in FileTest (from r107270)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112559 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:16:16 +00:00
Ingo Schommer
4d0502822f MINOR Using File::get_file_extension() instead of substr() magic in File->setName()
MINOR Using exceptions instead of user_error() in File->setName() (from r107269)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112557 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:15:38 +00:00
Ingo Schommer
3581a8d5f8 API CHANGE Deprecated File->getLinkedURL()
MINOR Avoiding duplication by using existing getFullPath() in File->getAbsoluteURL() (from r107268)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112556 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:15:26 +00:00
Ingo Schommer
96d1625102 MINOR Made File::get_file_extension() more readable, and added unit test (from r107267)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112555 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:14:59 +00:00
Ingo Schommer
6cf5372bf4 MINOR Removed File->setField(), doesn't have any overloaded functionality (from r107266)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112554 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:13:57 +00:00
Ingo Schommer
2d127753ed MINOR Documentation in File and Folder class (from r107265)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112553 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:12:39 +00:00
Ingo Schommer
ad20ddf24b MINOR: updated generator tag URL (from r107214)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:10:04 +00:00
Ingo Schommer
6bf8fad460 MINOR: force exclusive connection (from r107175)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:09:49 +00:00
Ingo Schommer
6ee6ab4ee7 ENHANCEMENT: abstracted protocol detection out to Director::protocol() #5450 (from r107094)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112550 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:09:32 +00:00
Ingo Schommer
25a0c3e7fb ENHANCEMENT: in referencing a file in combine_files() it should fall back to standard requirement tags if combining has been disabled eg dev mode (from r107091)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112549 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:09:15 +00:00
Ingo Schommer
fbbe0b4b39 BUGFIX: prevented HTTPRequest->shift() throwing notices when shifting multiple elements. APICHANGE: SS_HTTPRequest->shift($multiple) no longer returns an array of size $multiple spaced with nulls, it returns an array up to the size of $multiple. (from r107090)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:08:39 +00:00
Ingo Schommer
7fb414818a BUGFIX: fixed notice level errors getting through (from r107089)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112547 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:08:23 +00:00