Guy Sartorelli
c493485281
MNT Remove unexpected coupling with admin for test ( #11136 )
2024-02-13 17:35:03 +13:00
github-actions
e696e70dc4
Merge branch '5.1' into 5
2024-02-03 14:24:00 +00:00
github-actions
4d96674752
Merge branch '4' into 5.1
2024-02-03 14:23:59 +00:00
Steve Boyd
2e4bc95157
NEW Add UrlField
2024-02-02 13:43:26 +13:00
Steve Boyd
00276373b7
MNT Fix unit test when running without silverstripe/admin installed
2024-01-31 15:02:44 +13:00
github-actions
1eadc84a22
Merge branch '5.1' into 5
2024-01-27 14:24:02 +00:00
Sabina Talipova
afd53d1d6a
FIX HTMLEditorField::setRows with Elemental
2024-01-25 12:07:10 +13:00
Guy Sartorelli
90a57c2aa4
Merge branch '5.1' into 5
2024-01-23 11:58:17 +13:00
github-actions
96241b2db8
Merge branch '4' into 5.1
2024-01-20 14:24:40 +00:00
Guy Sartorelli
b979ce5896
MNT Fix test for required password fields in kitchen sink ( #11111 )
2024-01-19 13:27:32 +13:00
Nick
e456de11b0
Fix clobbering of the upload size validation ( #10059 )
...
* Fix clobbering of the upload size validation
When the validation is set here like this, it overrides validation which has already been setup with a simple '*' rule for the size based on PHP.
If you've defined in the sites yml config something like
SilverStripe\Assets\Upload_Validator:
default_max_file_size:
'[image]': '2m'
'*' : '1m'
then it will not be respected.
If you review SilverStripe\Assets\Upload_Validator and check the getAllowedMaxFileSize method, you'll see the sizing will be populated (if it hasn't been done before).
You can see it fail by;
- Setup a new SilverStripe site.
- Set your PHP to allow max post / max upload size of 10mb.
- Add the above config to your sites yml file and flush.
- In the CMS you'll be able to upload a 5MB file, when you shouldn't.
* Test that FileField will use size validation if defined
Couple of tests which prove a fix so the FileField and others will use the default_max_file_size setting
* Fix variable name in last commit
This is what happens when you refactor in the github window.
Fix the variable names. This will get squashed once merged.
* Updates the pr - white space and non deprecated method for byte conversion
Remove extra white space to appease the CS. Use the non deprecated method for memstring2bytes
* White space fixes for the phpcs
White space fixes for the phpcs
* Ensure that "memstring2bytes" can handle if an empty or value with no number is passed in
* DEP Bump assets constraint to ensure that change is also pulled in
---------
Co-authored-by: Guy Sartorelli <guy.sartorelli@silverstripe.com>
2024-01-08 15:49:41 +13:00
Guy Sartorelli
7dc1a7a12b
FIX Correctly mark ConfirmedPasswordField children as required
2023-12-20 12:35:30 +13:00
Maxime Rainville
6c69d32367
Merge pull request #11049 from creative-commoners/pulls/5/gridfield-with-viewabledata
...
Make GridField components work with ViewableData where possible
2023-12-19 19:55:29 +13:00
Guy Sartorelli
7073246a37
MNT Add tests for using GridField with arbitrary data
...
Note that the main tests are added as behat tests in the admin module
2023-12-18 14:20:33 +13:00
Steve Boyd
23eca53dfb
NEW SearchableDropdownField
2023-12-14 15:28:19 +13:00
Guy Sartorelli
c405ed6cf3
NEW Allow a single has_one to manage multiple reciprocal has_many ( #11084 )
2023-12-12 10:18:25 +13:00
github-actions
c63dca37a8
Merge branch '5.1' into 5
2023-11-28 02:04:54 +00:00
github-actions
4f0dfe8657
Merge branch '4' into 5.1
2023-11-28 02:04:52 +00:00
Steve Boyd
4dbbf04ba5
FIX Add extraEmptyValues to TreedropdownField
2023-11-27 12:42:28 +13:00
Steve Boyd
fdb329913c
ENH Throw exception when no react component
2023-11-22 14:17:47 +13:00
github-actions
92866d9326
Merge branch '5.1' into 5
2023-11-02 20:08:55 +00:00
github-actions
0ac8499ea3
Merge branch '4' into 5.1
2023-11-02 20:08:54 +00:00
Sabina Talipova
f393adf1fc
MNT Fix incorrect expected value in HTMLEditorFieldTest
2023-11-03 08:48:43 +13:00
github-actions
cb520db8b7
Merge branch '5.1' into 5
2023-11-01 20:14:50 +00:00
github-actions
5125be5a30
Merge branch '4' into 5.1
2023-11-01 20:14:46 +00:00
Sabina Talipova
50aaf9a9d5
MNT Table header closed tag position
2023-11-02 08:51:21 +13:00
Guy Sartorelli
0887170115
Merge pull request #11032 from creative-commoners/pulls/5.1/remove-todo
...
MNT Remove TODO comments
2023-10-31 10:11:27 +13:00
Sabina Talipova
56511c8618
MNT Remove TODO comments
2023-10-30 13:21:09 +13:00
github-actions
0556dfe45f
Merge branch '5.1' into 5
2023-10-28 14:23:52 +00:00
github-actions
9a497f54d7
Merge branch '4' into 5.1
2023-10-28 14:23:50 +00:00
Bernie Hamlin
e5eb98cc34
Use field editorconfig when sanitising content
2023-10-25 12:08:46 +13:00
Steve Boyd
159112ca8b
NEW Generate a random password if a blank password is entered
2023-10-20 11:37:25 +13:00
Andrew Paxley
a0cbebb2d1
ENH allow stacked messages on FormMessage
2023-10-09 11:12:03 +13:00
github-actions
c59aa5e13f
Merge branch '5.0' into 5.1
2023-09-02 14:23:40 +00:00
github-actions
a0493cffff
Merge branch '4' into 5.0
2023-09-02 14:23:38 +00:00
Rastislav Brandobur
7ae7e9ff47
added maxLength validation tests
2023-08-30 10:56:21 +02:00
Steve Boyd
c17138b6f5
Merge branch '5.0' into 5
2023-08-28 18:26:22 +12:00
github-actions
69549f2a23
Merge branch '4' into 5.0
2023-08-26 14:23:32 +00:00
Guy Sartorelli
5ee77b69f1
Merge pull request #10924 from kinglozzer/10689-typo-in-test-class-name
...
FIX: Typo in CheckboxSetFieldMultiEnumTest class name (closes #10689 )
2023-08-23 11:11:14 +12:00
Loz Calver
57cb55d6ae
FIX: Typo in CheckboxSetFieldMultiEnumTest class name ( closes #10689 )
2023-08-21 15:49:09 +01:00
github-actions
613dc1620c
Merge branch '5.0' into 5
2023-08-09 23:47:19 +00:00
Guy Sartorelli
15e4cbeb7a
Merge branch '4' into 5.0
2023-08-10 11:46:33 +12:00
Sabina Talipova
597d97bf0a
Merge pull request #10907 from creative-commoners/pulls/4.13/new-fields-validator
...
NEW Add FieldsValidator to ensure fields get validated
2023-08-10 10:50:57 +12:00
Sabina Talipova
037168a4fe
FIX Multi HTML entities in shortcodes
2023-08-08 13:08:19 +12:00
Guy Sartorelli
5a52484d88
NEW Add FieldsValidator to ensure fields get validated
2023-08-08 13:02:27 +12:00
Steve Boyd
f54bbc50f0
Merge branch '5.0' into 5
2023-05-22 12:46:02 +12:00
Guy Sartorelli
1f45607977
Merge branch '4' into 5.0
2023-05-17 10:57:32 +12:00
Guy Sartorelli
234e229098
Merge pull request #9976 from kinglozzer/9975-default-form-action
...
FIX: Form::defaultAction() didn't work if actions were in CompositeFields (fixes #9975 )
2023-05-09 21:45:24 +12:00
Guy Sartorelli
01808a8316
FIX Don't assume searchableFields() exists in gridfield filter
2023-05-09 10:00:07 +12:00
Steve Boyd
0978a43871
Merge branch '5.0' into 5
2023-05-04 13:25:49 +12:00
Guy Sartorelli
6296c06f3a
Merge pull request #10735 from elliot-sawyer/feature/change-search-filter-treedropdownfield
...
NEW: Allow different search filters on TreeDropdownField
2023-05-02 08:30:51 +12:00
Guy Sartorelli
7efde6bf37
Merge branch '4' into 5.0
2023-04-27 14:43:38 +12:00
Guy Sartorelli
908b6f2006
Merge branch '4.12' into 4.13
2023-04-26 11:44:54 +12:00
Guy Sartorelli
fd5d8217e8
[CVE-2023-22728] Check canView before printing from GridField
2023-04-26 09:45:34 +12:00
elliot sawyer
0d9724c708
Update tests/php/Forms/TreeDropdownFieldTest.php
...
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
2023-04-11 10:43:47 +12:00
Steve Boyd
63c2460f72
Merge branch '4' into 5.0
2023-03-30 13:20:03 +13:00
elliot sawyer
280354df08
NEW: Allow different search filters on TreeDropdownField
2023-03-27 18:50:54 +13:00
Steve Boyd
0f40cc38ec
FIX Respect searchable_fields
2023-03-23 10:57:03 +13:00
Loz Calver
0633f2ed0d
Add kitchensink fields to formfield validation test
2023-02-22 16:09:35 +00:00
Loz Calver
97f7be502f
NEW: Add extension hook for field-specific validation
2023-02-20 10:24:41 +00:00
Sabina Talipova
9d13f35040
MNT Update strong typization, tests cases
...
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
2023-02-08 10:59:27 +13:00
Guy Sartorelli
7c20ade548
DEP Replace thirdparty simpletest with symfony domcrawler
2023-02-02 13:31:45 +13:00
Steve Boyd
77301408d8
MNT Remove legacy upgrader config
2023-01-20 17:05:41 +13:00
Guy Sartorelli
b784e243de
Merge pull request #10538 from xini/feature-5-trailing-slash-config-and-redirect
...
SS5: add trailing slash config and redirect
2023-01-20 15:24:45 +13:00
Florian Thoma
fbcf7dc3e7
API Normalise trailing slashes for all paths
...
NOTE: There will be additional related PRs required for at least
silverstripe/cms and silverstripe/admin.
Co-authored-by: Guy Sartorelli <guy.sartorelli@silverstripe.com>
2023-01-20 10:31:14 +13:00
Maxime Rainville
b6b0bcea9f
Merge branch '4' into 5
2023-01-18 22:16:45 +13:00
Guy Sartorelli
5bf6835b3e
Merge pull request #10614 from creative-commoners/pulls/5/php82
...
ENH PHP 8.2 support
2022-12-21 15:39:32 +13:00
Steve Boyd
c1a773310d
ENH PHP 8.2 support
2022-12-21 14:44:47 +13:00
Guy Sartorelli
0d662ba95f
Merge branch '4.12' into 4
2022-12-19 01:38:09 +00:00
Guy Sartorelli
b14de847a5
API Make the public directory mandatory ( #10617 )
2022-12-14 16:08:47 +13:00
Sabina Talipova
53c0147f11
API Remove deprecated code ( #10594 )
2022-12-08 10:44:47 +13:00
Sabina Talipova
a52c7795c7
Merge branch '4' into 5
2022-11-22 11:41:53 +13:00
Steve Boyd
cb76f312a4
Merge branch '4.11' into 4.12-release
2022-11-21 13:44:23 +13:00
Steve Boyd
dc98cad48a
Merge branch '4.10' into 4.11
2022-11-21 13:43:59 +13:00
Steve Boyd
fe13856769
[CVE-2022-37429] Sanitise XSS
2022-11-21 13:06:40 +13:00
Steve Boyd
4308a93cc8
[CVE-2022-38148] Validate SortColumn exists
2022-11-21 13:01:32 +13:00
Steve Boyd
137ebcebec
API Stop using deprecated API
2022-11-15 18:20:54 +13:00
Steve Boyd
a57c7315a2
API Strongly-type action method signatures
2022-10-17 17:58:20 +13:00
Guy Sartorelli
ef8a02dfdc
FIX Update config to support tinymce6
2022-09-30 10:40:52 +13:00
Steve Boyd
2b5420ee7d
[CVE-2022-37430] Sanitise mixed case javascript
2022-08-23 15:36:48 +12:00
Guy Sartorelli
a57eeb614b
MNT Fix broken unit test
2022-08-03 15:47:14 +12:00
Steve Boyd
c466ca5ca5
Merge pull request #9341 from unclecheese/pulls/4/come-on-baby-make-it-search-so-good
...
NEW: Allow search field customisation
2022-08-02 11:59:55 +12:00
Guy Sartorelli
11595952f4
NEW Search across multiple searchable fields by default ( #10382 )
...
* NEW Search across multiple searchable fields by default
* ENH Split search query and search each term separately.
2022-08-01 12:19:02 +12:00
Guy Sartorelli
c7504aa337
Merge pull request #10331 from creative-commoners/pulls/4/gridfield-keep-state
...
ENH Restore gridfield state from get vars (POC)
2022-07-29 11:33:19 +12:00
Sabina Talipova
7a9bc7f577
ENH Keep Request in URL
2022-07-28 10:14:43 +12:00
Aaron Carlino
07a6c1191a
NEW: Allow search field customisation in GridFieldFilterHeader
2022-07-25 17:33:09 +12:00
Steve Boyd
b62c4a9f53
Merge branch '4.11' into 4
2022-07-08 17:13:31 +12:00
Sabina Talipova
babc811381
FIX Remove unexpected message
2022-07-04 16:05:57 +12:00
Steve Boyd
4d662d2dea
Merge branch '4.11' into 4
2022-06-28 17:42:07 +12:00
Steve Boyd
98b985fb91
Merge branch '4.10' into 4.11
2022-06-28 17:41:49 +12:00
Guy Sartorelli
d2c58f3bbc
[CVE-2022-28803] Block XSS in links and iframes.
2022-06-28 17:01:53 +12:00
Guy Sartorelli
5436df57e4
FIX Add polymorphic class on new records for use in forms.
2022-05-11 14:04:52 +12:00
Steve Boyd
511b3bb060
ENH PHP 8.1 compatibility
2022-04-14 13:12:59 +12:00
Steve Boyd
f1678781a2
ENH Various fixes for PHP 8.1 compatibility
2022-04-11 17:22:22 +12:00
Maxime Rainville
3e5a74c6b2
Merge pull request #10273 from creative-commoners/pulls/4/remove-ini-setting
...
ENH Fix deprecation issues for PHP 8.1 compatibility
2022-04-07 13:25:24 +12:00
Steve Boyd
814c5b2fd0
ENH Fix deprecation issues for PHP 8.1 compatibility
2022-04-06 11:34:34 +12:00
Steve Boyd
3202ef7c52
Merge branch '4.10' into 4
2022-04-06 10:42:58 +12:00
Steve Boyd
740d087e97
FIX Default GridField search fields with an index of 0 to use StartWithFilter
2022-03-22 16:17:37 +13:00
Steve Boyd
fc707cc10d
MNT Refactor out missing assertArraySubset ( #10208 )
2022-01-20 12:24:25 +13:00
Steve Boyd
511b8a4c71
Merge branch '4.10' into 4
2022-01-19 16:03:42 +13:00