Dan Hensby
2ef63ddbc1
Remove unused function args
2018-09-29 22:51:26 +01:00
Dan Hensby
7a18cd98e0
Improve assertion type
2018-09-29 22:51:26 +01:00
Dan Hensby
90e74a608e
Throwing and catcing an error in tests is mad
2018-09-29 22:51:26 +01:00
Dan Hensby
3c532cea0c
Minor cleanup of DirectorTest
2018-09-29 22:51:26 +01:00
Dan Hensby
3a007d52e6
Code formatting
2018-09-29 22:51:18 +01:00
Robbie Averill
231d6d9a9f
FIX New members now receive the configured default locale, not the current locale
2018-09-28 16:25:10 +02:00
Robbie Averill
94d534383f
Merge pull request #8422 from hpeide/patch-1
...
Update index.md
2018-09-28 15:53:45 +02:00
Hans Philip Eide
140436692a
Update index.md
...
When exporting path to ~/.bash_profile the change do not take action before you reload the shell. Calling 'source ~/.bash_profile' executes the change.
2018-09-28 15:44:58 +02:00
Robbie Averill
d18b8eb9fb
Add more tests for descending sort orders
2018-09-28 15:42:45 +02:00
Robbie Averill
ac1fe5e9d5
FIX joinClass's default_sort is used when nothing else has been set already
2018-09-28 15:39:24 +02:00
Robbie Averill
4aa7fb70ee
Add tests that show that joinClass default_sort is not used and order is honoured
2018-09-28 15:38:37 +02:00
Robbie Averill
4d14e9b6b1
Merge pull request #8421 from creative-commoners/pulls/4.3/psr-5-deprecations
...
Update deprecation PHPDocs to be PSR-5 compliant
2018-09-28 14:18:54 +02:00
Loz Calver
10ff6c4f81
Merge pull request #8418 from creative-commoners/pulls/4.3/lower-complexity
...
MINOR Reduce some code complexity, update array syntax and injected SQLSelect etc
2018-09-28 12:51:08 +02:00
Robbie Averill
e4768e44b0
Use splat over call_user_func_array and reduce calls to func_get_args()
2018-09-28 12:32:20 +02:00
Robbie Averill
e57edcd060
Merge pull request #8387 from sminnee/fix-start-session-without-headers
...
FIX: Ensure existing session can be accessed if headers_sent()
2018-09-28 10:59:29 +02:00
Robbie Averill
f842ee2eec
Update deprecation PHPDocs to be PSR-5 compliant
...
See: https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-deprecated
2018-09-28 10:49:14 +02:00
Loz Calver
aec562f048
Merge pull request #8419 from 3Dgoo/patch-1
...
minor i18nEntityProvider.php API documentation fix
2018-09-28 10:21:37 +02:00
Loz Calver
289f65fa05
Merge pull request #8413 from open-sausages/pulls/4/classmanifest-exceptions
...
NEW Show file path on PHP parser exceptions
2018-09-28 10:20:38 +02:00
Sam Minnee
b98c87a6c5
FIX: Ensure existing session can be accessed if headers_sent()
...
If a session already exists, and Session::start() isn’t called until
after a large enough block of content is output, then headers_sent()
will be false. The previous code prevented the session from being
started in this case. That might makes sense for the creation of a new
session, but it prevent legitimate access to an existing session.
This mostly manifested when running debugging tools such as showqueries,
which may output content before the session is started.
2018-09-28 13:25:13 +12:00
3Dgoo
785b0c69da
minor i18nEntityProvider.php API documentation fix
...
Fixing documentation typo.
2018-09-28 10:28:00 +10:00
Ingo Schommer
25759ffc5f
NEW Show file path on PHP parser exceptions
2018-09-28 08:58:47 +12:00
Robbie Averill
1b0293d8c5
Replace array syntax, use some strict comparison and remove unnecessary elseif
2018-09-27 17:37:37 +02:00
Robbie Averill
594fa30b82
Remove redundant elseif complexity and switch to short array syntax
2018-09-27 17:29:52 +02:00
Robbie Averill
0c7ced1513
Refactor sorting tests to use a dataprovider
2018-09-27 17:18:19 +02:00
Robbie Averill
c7d522ff6d
Add tests for sorting HasManyList
2018-09-27 17:09:24 +02:00
Robbie Averill
adb4d1f92d
MINOR Reduce some code complexity, update array syntax and injected SQLSelect etc
2018-09-27 16:40:23 +02:00
Robbie Averill
3321c6b39d
Add tests for sorting many many through list without a table alias
2018-09-27 14:34:37 +02:00
Thomas Portelange
fdd5acff5d
raw2att accepts array, but sprintf doesn't
...
it's not very likely to happen (it did in my case :-) ) but if the value is an array, sprintf will fail (because raw2att accepts array, but sprintf doesn't). i suggest to json encode any array data to ensure it's safely included in the html. Or we should throw proper exceptions to make sure invalid values do not result in a php error.
2018-09-27 12:12:59 +02:00
Loz Calver
89df5515ae
Merge pull request #8415 from DorsetDigital/patch-8
...
Doc update - add FQCN to example code
2018-09-27 11:29:42 +02:00
DorsetDigital
da38505446
Doc update - add FQCN to example code
...
Add fully qualified classname to aggregate caching example
2018-09-27 10:21:01 +01:00
Guy Marriott
c54e7317d2
FIX Avoid having search fields with the same names as form elements
2018-09-27 17:39:50 +12:00
Robbie Averill
2f67be61c1
Merge pull request #8410 from lekoala/patch-13
...
FormField::debug should handle all types of values
2018-09-26 14:30:55 +02:00
Thomas Portelange
f103648f8c
value can be something else than a string
...
if the value is not a string (an array for instance), sprintf will fail
2018-09-26 11:35:40 +02:00
Dan Hensby
b3d2d4c1b1
Remove redundant code
2018-09-26 10:11:28 +01:00
Dan Hensby
db43d57618
Remove commented out test
2018-09-26 10:11:28 +01:00
Dan Hensby
fe5b431200
Use Member::actAs rather than setting and unsetting member
2018-09-26 10:11:20 +01:00
Sam Minnée
a31a496362
Merge pull request #8399 from lekoala/patch-12
...
var_export does not handle circular references
2018-09-26 20:58:25 +12:00
Maxime Rainville
77339b7e75
MINOR Add caching to the TreeDropdownField tree action
2018-09-26 17:24:06 +12:00
Dan Hensby
6b618b44c9
Remove regex in favour of simple assertContains
2018-09-26 00:36:58 +01:00
Dan Hensby
cb361e8caf
Remove unused code from ControllerTest
2018-09-26 00:30:20 +01:00
Dan Hensby
15bf13daa9
Dont use willReturn assertions to assert argument types
2018-09-26 00:21:37 +01:00
Dan Hensby
7d15d0af70
Refactor email validation into provider based test
2018-09-25 23:15:18 +01:00
Robbie Averill
f5929d87e0
DOCS Update do blocks for DataQuery::having() to reflect correct input types
2018-09-25 17:46:42 +02:00
Robbie Averill
a8070dcfc3
Merge pull request #8404 from Carlo1139/patch-1
...
Typo in code snippet
2018-09-25 10:39:51 +02:00
Carlo1139
748409e61a
Typo in code snippet
...
Changed $ction to $action
2018-09-25 10:35:19 +02:00
Sam Minnée
5b7a84141b
NEW: Add Hierarchy::prepopulate_numchildren_cache() ( #8380 )
...
* NEW: Add Hierarchy::prepopulate_numchildren_cache()
API: Hierarchy::stageChildren() customisations must be applied to the base class and not include record-specific behaviour.
Adds the ability to prepopulate the cache for Hierarchy::numChildren()
in a batch.
Note that this optimisation means that stageChildren() is not called on
each record in order to calculate numChildren(). This means that the
structure of the stageChildren() query must be the same for all records
and the behaviour cannot be customised only for a subclass of the base
data class. For example, apply your customisations to SiteTree and not
a subclass.
This is an useful part of optimising the query count on tree generation.
See https://github.com/silverstripe/silverstripe-framework/issues/8379
* NEW: Add Hierarchy::prepopulateTreeDataCache()
This provides a more extensible way of preopulating caches for optimised
tree generation.
Fixes https://github.com/silverstripe/silverstripe-framework/issues/8391
2018-09-25 12:25:23 +12:00
Robbie Averill
3eacecbb1c
Merge pull request #8398 from open-sausages/pulls/4/test-flush
...
FIX Don't flush manifests in tests by default
2018-09-25 00:19:32 +02:00
Robbie Averill
f2556ded1c
Merge pull request #8400 from creative-commoners/pulls/4.3/semver-break
...
FIX Revert semver break in adding GridField type hint to method signature
2018-09-24 13:56:15 +02:00
Robbie Averill
0276f6c089
FIX Revert semver break in adding GridField type hint to method signature
2018-09-24 13:39:33 +02:00
Thomas Portelange
72b25d1a97
var_export does not handle circular references
...
this often happens in SilverStripe, a plain print_r is much safer
2018-09-24 12:31:06 +02:00
