silverstripe-framework

tonyair/silverstripe-framework

Fork 0

mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00

Commit Graph

Author	SHA1	Message	Date
Ingo Schommer	7bc6f3ee9f	Enforce JS var declaration with value (#5993 ) This caught us out recently where code did a strict type check for `myVar === undefined`. The var was defined as `let myVar;`, without a value - so the check returned false (it's `null`). To avoid this situation, we've decided to enforce declarations with values. Note that preference should be given to single, immutable assignments via const where possible. See http://eslint.org/docs/rules/init-declarations	2016-09-13 11:02:15 +12:00
Damian Mooyman	6e68f38efb	API Update react sections to use react-router instead of page.js (#5796 ) Fixes #5711	2016-07-14 17:51:01 +12:00
Ingo Schommer	34d40bed5f	Add ESLint support See https://github.com/silverstripe/silverstripe-framework/pull/5108	2016-04-06 10:43:33 +12:00

Author

SHA1

Message

Date

Ingo Schommer

7bc6f3ee9f

Enforce JS var declaration with value (#5993 )

This caught us out recently where code did a strict type check for `myVar === undefined`.
The var was defined as `let myVar;`, without a value - so the check returned false (it's `null`).
To avoid this situation, we've decided to enforce declarations with values.
Note that preference should be given to single, immutable assignments via const where possible.

See http://eslint.org/docs/rules/init-declarations

2016-09-13 11:02:15 +12:00

Damian Mooyman

6e68f38efb

API Update react sections to use react-router instead of page.js (#5796 )

Fixes #5711

2016-07-14 17:51:01 +12:00

Ingo Schommer

34d40bed5f

Add ESLint support

See https://github.com/silverstripe/silverstripe-framework/pull/5108

2016-04-06 10:43:33 +12:00

3 Commits