tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
2,605 Commits 31 Branches 527 Tags 162 MiB
ced1f25a4e
Commit Graph

236 Commits

Author SHA1 Message Date
Sean Harvey
ced1f25a4e BUGFIX Member::inGroup() returns false instead of an error if group doesn't exist. Ticket #3813 - thanks bgribaudo! 
MINOR Updated MemberTest to test a case where a group doesn't exist, and thus we assert Member::inGroup() returns false



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74981 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:16 +13:00
Sean Harvey
f646b864db API CHANGE Deprecated DataObjectSet->toDropDownMap() and made it an alias of map(), copying the functionality of toDropDownMap() into map() 
MINOR Added phpDoc for @deprecated methods - toDropDownMap() and filter_map()

MINOR Added new test class - DataObjectSetTest

MINOR Added tests for map(), toDropDownMap(), Count(), First() and Last() on DataObjectSetTest

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74969 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:16 +13:00
Sean Harvey
3235288080 BUGFIX Fixed error if JS/CSS requirements have arguments. Ticket #3860. Thanks simon_w! 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74961 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:16 +13:00
Normann Lou
3861c33bc1 APICHANGE: add documentation to changeset r74858. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74901 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Normann Lou
5c612beb36 APICHANGE: pass argument $includerelations into DataObject::fieldLabels() default as true; 
APICHANGE: BulkLoader::getImportSpec() call DataObject::fieldLables() with $includerelations as false, so that the relations is separated from column fields

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74858 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Sam Minnee
7dcf20d627 MINOR: Fixed test to get previous change to work 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73764 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Andrew O'Neil
e933d61a1c Merged r71795 from trunk 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73613 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Will Rossiter
84c16c66c8 BUGFIX: updated FormTest with fullstop 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73603 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:11 +13:00
Sam Minnee
b4921db9d7 BUGFIX: Get installer working with php_short_tags off (Merged r73481-3 from trunk) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73484 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:11 +13:00
Sean Harvey
5ddfb9e2e0 BUGFIX Fixed Director::makeRelative() to accept https:// protocol 
BUGFIX Fixed GET-parameter replacement in Director::is_absolute_url()
ENHANCEMENT Added Director::is_relative_url() and Director::is_site_url()
BUGFIX Validating $_FILES array in Director::direct()

(Merged from r73250)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73285 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:10 +13:00
Sam Minnee
2bff3054a1 Improved DataObject validation tests to use PHPUnit's setExpectedException stuff. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71758 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:06 +13:00
Ingo Schommer
931182d0b2 BUGFIX BUGFIX Fixed redirection to external URLs through Security/login with BackURL parameter (merged from trunk 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71709 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:06 +13:00
Sean Harvey
b87a0ae107 MINOR Fixed CSVParserTest with encoding issues 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71194 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:05 +13:00
Sam Minnee
55c7e1c334 Disable basicauth in RestfulServiceTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70995 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:05 +13:00
Sean Harvey
90e6d713f6 MINOR Added basic tests for Date and DateField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70960 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:05 +13:00
Sean Harvey
30bedae1a8 BUGFIX Ensure string "0" is not considered a NULL value when CsvBulkLoader imports values from a CSV file 
MINOR Updated tests to check boolean values in CsvBulkLoaderTest

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70895 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:05 +13:00
Ingo Schommer
a1ce7bf41a MINOR merged r70665 from trunk 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70666 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:02 +13:00
Sean Harvey
66efcd62c7 MINOR Added test for HTTP::getLinksIn() which subsequently tests HTTP::findByTagAndAttribute() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70053 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:58 +13:00
Ingo Schommer
fb113e589e BUGFIX More solid string-parsing through regular expressions in SQLQuery->filtersOnID() and SQLQuery->filtersOnFK(), incl. unit tests 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69951 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:57 +13:00
Ingo Schommer
0ac94ba03e MINOR Added SiteTreeActionsTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69840 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:55 +13:00
Ingo Schommer
52857cce8f MINOR Merged r69409 and r69410 from trunk 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69838 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:55 +13:00
Sam Minnee
63de49eab1 BUGFIX #3224 ajshort: Get HTTP::setGetVar() working with variables that contain array indexes 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69700 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:54 +13:00
Andrew O'Neil
636d2a6225 MINOR: Disable caching in RestfulService test 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69249 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sean Harvey
c5ab033cdd ENHANCEMENT Added renameField() to FieldSet 
MINOR Added test for FieldSet->renameField() to test method behaviour

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69244 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sean Harvey
e24c5801d3 MINOR Added tests for Text->LimitWordCountXML() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69226 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sean Harvey
5f0bbbc0da BUGFIX Strip potential whitespace from the beginning and end of string before limiting word count in Text->LimitWordCount(), fixing potential interference with truncation process 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69222 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:52 +13:00
Sean Harvey
358fbd418e BUGFIX Fixed Text->LimitWordCount() not returning the correct number of words in the truncated text. 
MINOR Added TextTest for testing Text class methods

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69220 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:51 +13:00
Ingo Schommer
4b2b3e3c5b ENHANCEMENT Added RestfulServerTest->testGETRelationshipsXML() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68860 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:50 +13:00
Ingo Schommer
5282119620 BUGFIX Fixed TranslatableTest to instanciate Page instead of SiteTree fixtures - pages in the database should never have ClassName=SiteTree. This was causing failing tests due to the changes in SiteTree->getClassDropdown() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@68752 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:49 +13:00
Ingo Schommer
d9b3abf8ac MINOR Documented ClassInfo::subclassesFor() and added unit tests 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67689 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:47 +13:00
Sean Harvey
3d0f3a6486 MINOR Added test for ErrorPage 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67327 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:44 +13:00
Ingo Schommer
3b50d5de00 ENHANCEMENT Added SITETREE_GRANT_ACCESS permission code to SiteTree to control editability of the "Access" tab (incl. unit tests) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67294 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:43 +13:00
Ingo Schommer
a8bd07380f MINOR Removing custom mock controller from SearchFormTest, now handled in FunctionalTest (see r67291) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67293 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:43 +13:00
Ingo Schommer
8331d52b60 ENHANCEMENT Added CompositeField->makeFieldReadonly() (straight copy from FieldSet) incl. unit tests 
ENHANCEMENT Supporting object parameter in FieldSet->makeFieldReadonly()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67292 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:43 +13:00
Ingo Schommer
bb1f6ad166 BUGFIX Added parent::setUp() and parent::tearDown() calls to various tests, in preparation for push/pop a mock controller the controller-stack 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@67290 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:43 +13:00
Sam Minnee
c7a4afee52 BUGFIX: Fixing tests 
ENHANCEMENT: Add <%-- --%> comments

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66946 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:40 +13:00
Sam Minnee
3d93a23f52 Fixed SiteTreePermissionsTest login failure tests 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66941 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:39 +13:00
Ingo Schommer
ae62681706 MINOR Merged r66681 from trunk 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66939 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:39 +13:00
Sean Harvey
ca2c814cd9 ENHANCEMENT Allow CheckboxSetField to use extra classes as other FormField classes do. Also dded test for this behaviour in CheckboxSetFieldTest. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66625 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:37 +13:00
Sean Harvey
4950fdf0cb MINOR Added tests for checking extra class was added to DropdownField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66624 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:37 +13:00
Sean Harvey
0af4fb3673 MINOR Added tests for checking extra class was added to FormField subclasses (TextField, EmailField and OptionsetField) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66623 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:37 +13:00
Ingo Schommer
916df369d8 BUGFIX Consistenly returning cloned instances for all FormField classes when calling performReadonlyTransformation() or performDisabledTransformation(). Making sure that these instances are actually flagged as readyonly/disabled. Addd unit tests to dynamically instanciate most FormField classes to check for this behaviour. Originally, this bugfix was necessary to avoid changed FormField state when recursively calling replaceField() on FieldSet->dataFields() in Translatable->updateCMSFields() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66505 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Ingo Schommer
e772a4c1d4 ENHANCEMENT Respecting SiteTree->canView() settings in results (see #3052). This causes wrong counts, bugreport in #3120 
ENHANCEMENT Added $data parameter to SearchForm->getResults() to remove dependency on $_REQUEST for better testability
ENHANCEMENT Added SearchForm->numPerPage - this shouldn't need to be passed around methods on every call, its instance specific
ENHANCEMENT Added SearchFormTest
MINOR Documentation for SearchForm


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66322 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:36 +13:00
Ingo Schommer
1cdca8a66a BUGFIX Fixed editable formfields not showing up in translation mode (#3083). Updated Translatable->updateCMSFields() by partially merging wakeless' patch from (r64523) 
ENHANCEMENT Added Translatable_Transformation (patched in r64523)
ENHANCEMENT Added TranslatableTest with minimal assertions about existing form fields in translation mode

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66137 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Ingo Schommer
f4d0fec83b ENHANCEMENT Added support for custom importer methods in CsvBulkLoader 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@66045 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:26:33 +13:00
Sam Minnee
8da5af457e New test for old URL redirection 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65782 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-13 02:18:12 +00:00
Andrew O'Neil
a6ea78a230 Change back to english on teardown 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65673 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-12 03:11:57 +00:00
Ingo Schommer
5df97fba10 ENHANCEMENT Added CompositeField->fieldPosition() 
ENHANCEMENT Supporting recursion into nested sets in FieldSet->insertAfter()/TabSet->insertAfter()/CompositeField->insertAfter()
API CHANGE Deprecated CompositeField->insertBeforeRecursive(), use CompositeField->insertBefore()
ENHANCEMENT Renamed CompositeField->beforeInsert() to CompositeField->onBeforeInsert() to avoid confusion with insertBefore()
ENHANCEMENT Added CompositeFieldTest
ENHANCEMENT Added unit tests for FieldSet->insertBefore()/insertAfter()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65581 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-11 02:35:54 +00:00
Sam Minnee
9565fec5ad FEATURE #2767 wakeless: Allow popuplation of non-DataObject tables with YamlFixture 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65555 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-10 23:18:31 +00:00
Sam Minnee
648a459060 Ensure that Requirements backend instance is preserved between tests 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65507 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2008-11-10 01:13:42 +00:00