Damian Mooyman
6d5d3d8cb7
Rewrote usages of error suppression operator
2014-03-05 14:22:19 +13:00
Stephen Shkardoon
696e6f65ab
MINOR typo where display_errors wasn't checked properly
2013-10-23 16:32:31 +13:00
Ingo Schommer
5235a3f3a2
Installer regression from dd49834
2013-10-16 11:29:44 +02:00
Sean Harvey
dd49834b9e
BUG Fixing installer not checking display_errors correctly.
...
Fixes issue #2479 . Installer sets display_errors on, but it checks
the changed value and not the original one set in php.ini.
2013-10-04 10:05:28 +13:00
Ingo Schommer
b159284c6c
Fixed "session started" error on install.php
2013-08-07 16:28:54 +02:00
Hamish Friedlander
a685a8dee9
FIX Include flushtoken when install redirects to successfullyinstalled
2013-08-02 11:00:26 +12:00
Sam Minnée
f6fbd78cd9
Merge pull request #1786 from colymba/3.0-htaccess-fix
...
vendor folder is blocked only if outside themes
2013-05-24 23:50:41 -07:00
Daniel Hensby
9a6a6ec75d
Arbitrary placement of _ss_environment.php in parent folders
...
Removes hardcoding to three levels
2013-05-14 13:39:43 +02:00
colymba
41c0f8080e
FIX Only block root vendor folder
...
Use RewriteRule instead to take in account any subfolder via RewriteBase. Deny ss-cache and composer via RewriteRule too.
2013-04-27 16:03:35 +03:00
Ingo Schommer
9a52dae207
Removed LOLCAT locale from installer ( fixes #1457 )
2013-04-04 11:18:40 +02:00
Sean Harvey
a99c829ed1
Ensure composer files aren't accessible using IIS
2013-04-03 15:59:14 +13:00
Ingo Schommer
ede381326b
BUG Secure composer files from web access ( fixes #8011 )
...
Already applied to root .htaccess, but required for dynamically
generated file from installer as well. Also added upgrade instructions.
2013-02-17 22:33:04 +01:00
Hamish Friedlander
bec5ae1886
Include code to block yaml files in installer generated .htaccess
2013-01-29 14:20:12 +13:00
Sean Harvey
449cce95a7
Fixing .htaccess to ignore rewriting PHP files directly
2012-12-04 14:36:59 +13:00
Normann Lou
9aaa6b1a7b
ENHANCEMENT: change those harded-coded 'sapphire' to 'framework' either in javascript code or inline document, or a <a> href propty.
2012-10-05 17:00:39 +13:00
Sam Minnee
1f7fc1f76a
FIX Remove instances of lines longer than 120c
...
The entire framework repo (with the exception of system-generated files) has been amended to respect the 120c line-length limit. This is in preparation for the enforcement of this rule with PHP_CodeSniffer.
2012-09-30 17:18:13 +13:00
Ingo Schommer
e2f073f38a
Method visibility according to coding conventions
2012-09-20 10:46:59 +02:00
Naomi Guyer
69182c21ce
BUG: Installer implies empty template used in tutorial
...
Have reworded the template options so that installers know that the
simple template is used for the tutorial
2012-08-22 13:42:53 +12:00
Russell Michell
3ca24a89e9
BUGFIX: Installer failed complaining about rewrite server-capability: XHR response was 3 chars long and therefore !== "OK"
...
MINOR: Added charset <meta> declaration to prevent errors cluttering up browser-based debugger console output
2012-08-15 13:42:54 +12:00
Sam Minnee
2598f6596d
NEW: Enable display_errors = on in the installer to assist with diagnosis.
...
Installation problems often come down to a 'white screen of death' either during installation or after it. The WSOD is generally caused by a PHP error that isn't picked up by SilverStripe's error handler. This change fixes the first of those.
As a bigger fix, I'd like to see us allow the installation of sites in dev mode, the enabling of display_errors=on in dev mode, and perhaps even the ability to easily perform an initial installation in dev mode before switching to live mode. However, that's a bigger change for another time.
2012-06-27 09:44:44 +12:00
Ingo Schommer
3a7128d00c
MINOR Fixed phpdocs
2012-06-20 23:59:16 +02:00
Sean Harvey
105986392b
BUGFIX Supress mkdir() when attempting to create a temp folder, instead
...
of the variable. This gives a nicer error in the installer.
2012-06-15 11:48:42 +12:00
Sean Harvey
aaf91154a2
BUGFIX If there is *any* error connecting to MySQL, expose this to the installer.
2012-05-19 11:29:25 +12:00
Ingo Schommer
eeef41e91f
SECURITY Fixed remote code execution vuln in install.php due to inserting unescaped user data into mysite/_config.php. Not critical because install.php is required to be removed on a SilverStripe installation anyway ( fixes #7205 )
2012-05-16 14:59:42 +02:00
Sean Harvey
e095950a50
BUGFIX Installer checks: warn if finfo class not available, re-instating hash check, and remove duplicate iconv check.
2012-05-14 14:18:49 +12:00
Sean Harvey
20a51d6572
MINOR Ensure finfo class exists in installer checks, we need it for MIME
...
type detection of files.
2012-05-12 10:17:53 +12:00
Sean Harvey
01f8e38eee
MINOR Using correct URL for tutorial in installer
2012-05-11 14:51:23 +12:00
Ingo Schommer
1671b9c65c
BUGFIX Checking for mbstring PHP extension support in installer, as it has been a documented installation requirement for a while. Removing method_exists() checks from mbstring usage in core for the same reasons
2012-05-09 10:25:31 +02:00
Sean Harvey
4e18cc581b
BUGFIX Ensure MySQLi is used consistently in MySQLDatabaseConfigurationHelper, not old mysql functions
2012-05-05 11:22:28 +12:00
Ingo Schommer
e929753992
MINOR Using correct $locale format in installer (regression from last commit)
2012-05-03 00:00:51 +02:00
Ingo Schommer
0068b6d5b6
BUGFIX Showing only actually available languages for selection during install ( fixes #7260 )
2012-05-02 23:35:20 +02:00
Sean Harvey
3ccaa1f864
MINOR Supress any error connecting to the database so the installer
...
doesn't show it in the page header
2012-04-30 11:15:21 +12:00
Sean Harvey
32d4ec837c
Merge pull request #374 from oddnoc/installer-email-password-feedback
...
BUGFIX: Start a PHP session in installer.
2012-04-27 21:49:38 -07:00
Sean Harvey
b03cf04dbd
BUGFIX Updating MySQLDatabaseConfigurationHelper to check for MySQLi
...
instead of mysql_connect and other old function usage, as we've moved to
MySQLi in MySQLDatabase.php now
2012-04-28 12:13:58 +12:00
Fred Condo
b8228271e6
BUGFIX: Start a PHP session in installer.
...
This fixes blank username and password on home/successfullyinstalled
2012-04-27 16:51:47 -07:00
Fred Condo
df6a249bf0
BUGFIX: Change requirement rubrics to remove confusion
...
Resolves #7199
Change all the rubrics to be nouns or questions, rather than a statement of
the desired setting. If the setting is correct, we get a nice green OK; if
not, it was confusing for the rubric to state the opposite of the failure
mode, which is described in the long message.
2012-04-26 15:04:07 -07:00
Sean Harvey
bda849afeb
BUGFIX Check for SimpleXML support in PHP at the installation step
2012-04-22 22:43:06 +12:00
Sean Harvey
cc339c37c4
BUGFIX Ensure the SS3 installer checks for CType support in PHP, as language YAML parser uses this in framework.
2012-04-22 17:45:56 +12:00
Sean Harvey
c55e0b8b95
MINOR Fixing up PHP versions to be consistent with
...
33ae83640b
2012-04-20 15:08:01 +12:00
Sam Minnee
33ae83640b
MINOR: Lowered 5.3.10 recommendation to 5.3.4
2012-04-20 14:45:57 +12:00
Will Rossiter
7a4392ca03
Merge pull request #324 from halkyon/installer_fixes
...
MINOR: Fix install not loading because of Zend/Translate.php dependency in i18n.php
2012-04-16 16:34:53 -07:00
Sean Harvey
5f73643e3f
BUGFIX Hardcoding locales in installer, because we can't include i18n
...
properly, and including core/Core.php is too much.
2012-04-17 11:02:18 +12:00
Sean Harvey
ad2a21cc92
API CHANGE getSysTempDir() is now deprecated, use sys_get_temp_dir()
...
instead!
2012-04-17 10:53:41 +12:00
Sean Harvey
dc0031cf26
BUGFIX Fixed broken installer trying to include i18n thirdparty Zend
...
libs, which depends on Core.php being included first because include
paths are setup there first. This has the effect of removing redundant
code in the installer like temp path discovery, as Core takes care of
that for us.
2012-04-17 10:53:40 +12:00
Sean Harvey
d0984ec897
MINOR Line break after sentence of message
2012-04-17 10:53:40 +12:00
Sean Harvey
bbf04ee7ea
MINOR Removed function_exists() checks which aren't necessary for PHP 5.2+
2012-04-16 13:15:41 +12:00
Sean Harvey
ebe75fefab
MINOR Update locations to server requirements page
2012-04-15 16:29:14 +12:00
Sean Harvey
515a2ccfcc
MINOR Updating old URLs in installer, show message about creating admin
...
account
2012-04-15 16:01:06 +12:00
Sean Harvey
e71b8d6215
MINOR Installer cleanups, removing references to old "command line
...
installation" which is no longer supported.
MINOR Removed stray semi-colon when showing version in installer
template.
2012-04-15 15:05:20 +12:00
Sean Harvey
6405c44bc2
MINOR Enable the highest level of error_reporting() in install, to be
...
consistent with Core.php
2012-04-15 10:50:20 +12:00
