Damian Mooyman
b8e7f9a934
Standardise spelling of "customise"
...
Fixes #3988
2016-03-30 13:17:28 +13:00
Damian Mooyman
fd64fe5572
Merge pull request #5248 from micmania1/patch-10
...
Filter PDO construct on failure
2016-03-30 13:05:32 +13:00
Michael Strong
159dce337d
Filter PDO construct on failure
2016-03-30 11:35:15 +13:00
Ingo Schommer
4714eeee6b
Merge pull request #5146 from chillu/pulls/3.2/disable-xdebug-travis
...
Disable xdebug on Travis runs
2016-03-30 07:49:32 +13:00
Ingo Schommer
fb660225c2
Behat: Wait until CMS loading overlay is removed
...
This makes tests more robust at the expense of an additional
check with every step. The "ajax steps" logic works similarly,
but does not respect the loading indicator. While this logic
waits for a short time after ajax requests are finished,
in some cases that isn't enough time for the browser to
process the response and remove the loading indicator.
Since the "ajax steps" logic applies to operations outside of the CMS
as well, we can't add the loading indicator check there.
2016-03-29 17:24:47 +13:00
Ingo Schommer
85a361444c
Disable xdebug on Travis runs
...
We're not using it for code coverage,
and it's slowing down both composer and phpunit builds.
Recommended by Travis:
https://docs.travis-ci.com/user/speeding-up-the-build/#PHP-optimisations
2016-03-29 17:21:55 +13:00
Ingo Schommer
7ba4b5b6ef
Merge pull request #5241 from timkung/pulls/upload-validator-filesize-spelling
...
BUG changing all cases of filesize spelling to file size
2016-03-29 16:15:27 +13:00
Ingo Schommer
1049288cb5
Merge pull request #5240 from madmatt/pulls/fix-dbstringtest-annotations
...
MINOR: Fix PHPUnit @covers assertions for DBStringTest
2016-03-29 16:13:50 +13:00
Tim Kung
7907d20da7
BUG changing all cases of filesize spelling to file size
2016-03-29 13:38:24 +13:00
Ingo Schommer
2ba4e1dabe
Removed duplicate bootstrap lib
...
Now generated on the fly through framework/admin/scss
2016-03-29 11:28:40 +13:00
scott1702
6b1444709f
Fix menu dropdown icon
2016-03-29 11:28:38 +13:00
David Craig
d4ad1504a9
Fix bottom toolbar height
2016-03-29 11:28:05 +13:00
Hamish Friedlander
700cf9bd56
Merge pull request #5223 from tractorcow/pulls/4.0/transactions
...
API Add SS_Database::withTransaction for nice enclosed transactions
2016-03-29 10:54:04 +13:00
Paul Clarke
dce31d7235
initial updates to main nav styles for 4.0
...
Conflicts:
admin/css/ie7.css
admin/css/ie7.css.map
admin/css/ie8.css.map
admin/css/screen.css
admin/css/screen.css.map
admin/javascript/dist/bundle-leftandmain.js
admin/javascript/src/LeftAndMain.Menu.js
admin/scss/_spritey.scss
css/GridField.css
2016-03-29 10:29:33 +13:00
Ingo Schommer
884c44f596
Removed sourcemaps
...
Will be part of .gitignore in a subsequent commit
2016-03-29 10:29:32 +13:00
scott1702
13d581dea5
Include bootstrap throughout the CMS
2016-03-29 10:29:27 +13:00
Ingo Schommer
3862a7a0a7
Moved FormFieldSchemaTrait into FormField
...
The RFC requires a FormField implementation to override $schemaDataType,
but its defined on the trait - which can't be redefined by a field subclass.
In the end, the trait was never designed to be reuseable on classes other than FormField.
We need to admit that architecturally, we'll have to add all that API weight to the base FormField
class because of the way forms are structured in SilverStripe (mainly due to a missing layer
of indirection in getCMSFields implementations).
Also implemented the $schemaDataType on fields where its known.
See https://github.com/silverstripe/silverstripe-framework/issues/4938
See http://php.net/manual/en/language.oop5.traits.php#language.oop5.traits.properties.example
2016-03-28 21:54:42 +13:00
Ingo Schommer
c3a8159e80
Default to schema response part in LeftAndMain->schema()
...
More of a standard API approach to return data by default, and make customisation
via HTTP headers an optional mode.
2016-03-28 21:54:42 +13:00
Ingo Schommer
adbcddee80
Only iterate through dataFields() in FormSchema
...
Temporary measure until we implement nested fields
2016-03-28 21:54:27 +13:00
Ingo Schommer
8ae2894890
Fix form schema ID getter
...
Also moved keys of higher importance to start of array,
easier to review this way
2016-03-28 21:54:24 +13:00
David Craig
5d88950735
Adds schemaDataType to FormFieldSchema
2016-03-28 21:14:06 +13:00
Ingo Schommer
dbe85dff0a
Watch admin SCSS files
2016-03-28 21:02:27 +13:00
David Craig
97176581eb
Tidy grunt file
...
- Don't watch in prod mode
- Use gulp-if instead of if statements
2016-03-28 21:02:15 +13:00
Daniel Hensby
aeb4aa9565
FIX Dont allow plain text friendly errors
2016-03-28 01:20:18 +01:00
Loz Calver
1e7281a2ba
NEW: Add onBeforeRender() hook to GridField
2016-03-27 10:55:58 +01:00
Loz Calver
5ede516c77
FIX: GridField::FieldHolder() should not attempt to parse shortcodes ( fixes #5129 )
2016-03-27 10:51:46 +01:00
Loz Calver
4353d35c0a
Fix code docs for SQLSelect::count()
2016-03-27 10:23:11 +01:00
Daniel Hensby
2b261e226c
Merge pull request #5228 from christopherdarling/patch-4
...
DOCS: DataList::filter() broken examples
2016-03-26 21:20:34 +00:00
Daniel Hensby
1bcd755120
Merge pull request #5229 from madmatt/pulls/fix-gridfield-annotations
...
MINOR: Fix PHPUnit @covers assertions for GridFieldTest
2016-03-26 21:15:13 +00:00
Daniel Hensby
3a932c963f
Merge pull request #5230 from kinglozzer/1684-textfield
...
Deprecate TextField::InternallyLabelledField() (closes #1684 )
2016-03-26 21:14:33 +00:00
Loz Calver
d9798af30c
Deprecate TextField::InternallyLabelledField() ( closes #1684 )
2016-03-26 11:07:33 +00:00
madmatt
41a3a86862
MINOR: Fix PHPUnit @covers assertions for DBStringTest
...
This resolves issues when PHPUnit is run strictly, where it exits when
it hits an @covers annotation that references a method that doesn't exist
2016-03-26 17:58:28 +13:00
madmatt
c972692313
MINOR: Fix PHPUnit @covers assertions for GridFieldTest
...
This resolves issues when PHPUnit is run strictly, where it exits when
it hits an @covers annotation that references a method that doesn't exist
2016-03-26 11:55:01 +13:00
Christopher Darling
4dfe2955e3
DOCS: DataList::filter() broken examples
...
missing ' from 'bob'
2016-03-24 21:32:49 +00:00
Daniel Hensby
0ce257495b
Merge pull request #5226 from timkung/pulls/upload-validator-filesize-spelling
...
DOCS Upload_Validator fixing file size spelling
2016-03-24 09:41:35 +00:00
Tim Kung
7867c51388
Upload_Validator fixing file size spelling
2016-03-24 15:45:58 +13:00
Hamish Friedlander
1e53f29f33
Merge pull request #5219 from open-sausages/pulls/4.0/optional-owned-by
...
API Improvements to ownership api
2016-03-24 10:08:40 +13:00
Damian Mooyman
c6c71fa3be
Merge pull request #5221 from christopherdarling/patch-1
...
remove $CleartextPassword from ChangePasswordEmail.ss
2016-03-24 10:00:47 +13:00
Damian Mooyman
8abede1339
API Add SS_Database::withTransaction for nice enclosed transactions
2016-03-24 09:57:07 +13:00
Christopher Darling
ceccd9551c
remove $CleartextPassword and update wording on
...
ChangePasswordEmail.ss
4.x version of https://github.com/silverstripe/silverstripe-framework/pull/5194
2016-03-23 07:50:36 +00:00
Damian Mooyman
094745ec0f
API Formally support custom ownership relations
...
API 'owned_by' is no longer mandatory for relations backed by normal db relations
API Extension setOwner/clearOwner is now nested
2016-03-23 14:49:34 +13:00
Damian Mooyman
5845b6089c
Merge pull request #5218 from bummzack/5189-fix-canViewVersioned
...
Fixed issue where `canViewVersioned` caused a DB error…
2016-03-23 10:31:49 +13:00
Damian Mooyman
633eb0163e
Merge pull request #4551 from sminnee/php7-support
...
PHP7 support
2016-03-23 09:21:51 +13:00
Daniel Hensby
602b07f403
Merge pull request #5194 from christopherdarling/patch-9
2016-03-22 11:14:49 +00:00
Daniel Hensby
affb3dba03
Merge branch 'patch-9' of https://github.com/christopherdarling/silverstripe-framework into christopherdarling-patch-9
2016-03-22 11:13:35 +00:00
Roman Schmid
25c453fe7b
Fixed issue where canViewVersioned
caused a DB error when Versioned was used with stages other than the default "Stage" and "Live".
...
Updated VersionedTest to also check an Object with a single stage in the canView test.
2016-03-22 09:42:21 +01:00
Sam Minnee
f5af0c85ba
FIX: Don’t use SplFixedArray in PHP 7.
...
PHP 7 seems to suffer a segfault when using SplFixedArray. Since LRU is
deprecated anyway, I’m not too fussed about getting to the bottom of
this issue, however, if it turns out that SplFixedArray is corrected in
PHP 7.0.0 stable or a future patch release, we could update this check.
2016-03-22 18:09:38 +13:00
Sam Minnee
aeccb8b8e0
API: Move DBField subclasses into SilverStripe\Model\FieldType namespace
...
API: Deprecate SS_Datetime.
The DBField subclasses are have all been renamed to start with “DB” and
be in the SilverStripe\Model\FieldType namespace. To keep DataObject
definitions concise, the original short variations of their names are
preserved as service definitions. Most of the field generation code
doesn’t need to change, but where field classes are referenced directly,
changes will be needed.
SS_Datetime, which is commonly referenced outside the model system
itself, has been preserved as a subclass of DBDatetime. This has been
marked as deprecated and can be removed in SilverStripe 5.
A few places that referred to $db and $casting values weren’t using
the Injector to instantiate the relevant classes. This meant that the
remapping we have created as part of moving classes into a namespace
didn’t work.
2016-03-22 18:09:30 +13:00
Sam Minnee
262f487053
MINOR: Avoid access-changing subclass in test.
...
Using a subclass to change the visibility of protected items didn’t
seem necessary in this case, if we add a reasonably logical getter
method.
2016-03-22 17:39:09 +13:00
Sam Minnee
52ca089d0b
NEW: Ensure php7 builds pass.
...
SilverStripe 4 should work in php7, so we shouldn't accept its failure.
2016-03-22 17:39:09 +13:00