Commit Graph

22312 Commits

Author SHA1 Message Date
Sam Minnee
8b3ef8f85a FIX: recipe-testing is only needed for behat.
The other dependencies that are required are already included in
require-dev.
2020-09-21 19:10:08 +12:00
Sam Minnee
9247bc8b79 NEW: Add Symfony 4 support alongside Symfony 3
- Remove duplicate key in YML file
 - Remove deprecated yaml dump indentation set (the constructor arg works in both ^3 and ^4)

Fixes #9274
2020-09-21 19:09:08 +12:00
Dan Hensby
ae0ece2b02
Merge pull request #9665 from creative-commoners/pulls/4/php8-fqcn-token 2020-09-18 20:44:22 +01:00
Daniel Hensby
8959212cff
Merge pull request #9700 from Michael-HEIW/unit-test-doc
Updated 00_Unit_Testing.md (#9699)
2020-09-18 14:52:34 +01:00
Michael Pritchard
86702f0ad4 Updated 00_Unit_Testing.md (#9699) 2020-09-18 14:13:08 +01:00
Ingo Schommer
ecb03562de
Merge pull request #9572 from sminnee/pulls/manymanylist-add-callback
NEW: Add/remove callbacks for relation lists
2020-09-18 16:56:20 +12:00
Sam Minnee
0d7c5a9ece NEW Add/remove callbacks on RelationList
This provides a mechanism for adjusting the behaviour of these
relations when building more complex data models.

For example the following example has a status field incorporates a
Status field into the relationship:

```php
function MyRelation() {
  $rel = $this->getManyManyComponents(‘MyRelation’);
  $rel = $rel->filter(‘Status’, ‘Active’);

  $rel->addCallbacks()->add(function ($relation, $item, $extra) {
    $item->Status = ‘Active’;
    $item->write();
  });
}
```

Introduces a new library dependency: http://github.com/sminnee/callbacklist
2020-09-18 13:33:42 +12:00
Maxime Rainville
ff18dec2e5
API Add new behat method for interacting with toasts (#9695) 2020-09-17 17:12:35 +12:00
Garion Herman
0746230172
DOC Add process for releasing individual module patches (#9626)
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
2020-09-17 16:37:58 +12:00
Garion Herman
a712000404
Merge pull request #9682 from silverstripe-terraformers/feature/partial-cache-docs
DOCS: Example of partial cache expiry setting.
2020-09-16 15:49:50 +12:00
Sacha Judd
5d38e24dd7
Merge pull request #9692 from open-sausages/pulls/4/remove-boostrap3-class
BUG Remove old boostrap 3 CSS class
2020-09-16 11:46:28 +12:00
Maxime Rainville
acce4c4ce7 BUG Remove old boostrap 3 CSS class 2020-09-16 11:03:27 +12:00
Sam Minnée
90512430d7
Merge pull request #8846 from kinglozzer/template-parser-bugs
Template parser bugs
2020-09-16 09:50:29 +12:00
Loz Calver
bca0f28b62
FIX: Make template parser error on mismatched brackets (fixes #8845) 2020-09-15 16:54:24 +01:00
Loz Calver
bfc3b4b468
FIX: Stop empty comments breaking the template parser (fixes #8742) 2020-09-15 16:54:22 +01:00
Sam Minnee
85252ca05e FIX: Ensure Embed options are always array
This maintains support for embed 3.0.0.
2020-09-15 17:40:42 +12:00
Sam Minnee
24dfe0b026 NEW: Add --prefer-lowest to PHP 7.1 build
This build will ensure that older versions of packages that we claim
work with silverstripe/framework do, in fact, work.

‘Composer install’ changed to ‘composer update’ as that’s what’s being
executed in the absence of a composer.lock, and better clarifies intent.

Note that:

 * Support for nikic/php-parser ^2 was lost in 25759ffc5f.

 * Support for monolog/logger < 1.16 was lost in 7ab55a4948
2020-09-15 17:40:42 +12:00
Garion Herman
099ee2deb7 FIX Remove extraneous @depends annotations 2020-09-15 17:40:42 +12:00
Garion Herman
f1c94e6d54 FIX Allow quotes in expected ReflectionExceptions within tests 2020-09-15 17:40:42 +12:00
Garion Herman
44685eceba FIX Support PHP 8 namespace tokens in i18nTextCollector 2020-09-15 17:40:42 +12:00
Garion Herman
bad0662291 FIX Disable libxml_disable_entity_loader() calls in PHP 8 2020-09-15 17:40:42 +12:00
Sam Minnee
fb9e6e51a6 FIX: Switch to sminnee fork of phpunit 5.7
This provides 5.7.28 with fixes for PHP 8 support.
2020-09-15 17:40:42 +12:00
Sam Minnee
57bdef3b2e FIX: Fix test mistakenly labelling content as name arguments in data provider 2020-09-15 17:40:42 +12:00
Sam Minnee
b3dd27953b NEW: Allow league/csv ^9
Hopefully this has better PHP 8 support.
2020-09-15 17:40:42 +12:00
Sam Minnee
09fb33e657 FIX: Avoid passing non-class to get_parent_class()
Throws errors in PHP 8
2020-09-15 17:40:42 +12:00
Sam Minnee
5cb3d07f44 FIX: Avoid pass-literal-by-reference warning in PHP 8 2020-09-15 17:40:42 +12:00
Steve Boyd
ab50e2cc51 Merge branch '4.6' into 4 2020-09-15 13:44:57 +12:00
Steve Boyd
e339549e0d
Merge pull request #9649 from kinglozzer/9648-security-titles
FIX: Include missing security page titles when CMS not installed (fixes #9648)
2020-09-15 13:43:59 +12:00
Guy Marriott
05e3417249
Merge pull request #9686 from sminnee/pulls/9679-guard-sapphiretest 2020-09-14 17:22:30 -07:00
Guy Marriott
a80f66f11c
Merge pull request #9689 from RuthAdele/patch-2
Update 02_Pagination.md
2020-09-14 16:44:34 -07:00
RuthAdele
bd2f017557
Update 02_Pagination.md
Adding commonly used $FirstItem and $LastItem to the Template Variables list.
2020-09-14 21:26:33 +09:30
Sam Minnee
2143660c3f FIX: Add class_exists() guards to SapphireTest
This test helper has a number of hooks to other parts of the
and required many class_exists() guards to operate without them

This has come out of PoC development work as part of:
https://github.com/silverstripe/silverstripe-framework/issues/9679

But can stand-alone as a mergeable PR.
2020-09-14 13:49:21 +12:00
cloph
13725d2f92
DOC HistoryViewer: explain "magic names" (#9670)
DOC HistoryViewer: explain "magic names"
GraphQL scaffolding uses names consisting of the first part of the namespace and the classname, but to inject it to the HistoryViewer field you need to use the database table name.
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
2020-09-12 12:56:23 +12:00
Steve Boyd
015ea8cfc8 Merge branch '4.6' into 4 2020-09-11 11:54:23 +12:00
Damian Mooyman
ac6f34846e
BUG Resolve issue where TreeMultiSelectField would error loading its value (#9604)
* BUG Resolve issue with TreeMultiSelectField not retaining value in some situations
E.g. in an elemental form
2020-09-11 11:52:36 +12:00
Robbie Averill
de61681dec
Merge pull request #9634 from open-sausages/pulls/4/ellipsis
BUG Use proper ellipsis character in the various summary method.
2020-09-10 14:48:33 -07:00
Mojmir Fendek
2c1cb79156 DOCS: Example of partial cache expiry setting. 2020-09-11 08:58:44 +12:00
Daniel Hensby
b592d2105c
Merge pull request #9681 from open-sausages/pulls/4/better-hash-compare-function
BUG Make PasswordEncryptor::check more resistent to timing attacks
2020-09-10 18:23:22 +01:00
Maxime Rainville
8bcfa57342 BUG Make PasswordEncryptor::check more resistent to timing attacks 2020-09-10 22:17:50 +12:00
Maxime Rainville
acdebcdba7 Fix unit test 2020-09-10 17:08:13 +12:00
Ingo Schommer
089098ffdb
Merge pull request #9676 from creative-commoners/pulls/4/docs-preannouncement-mailing-list-denounce
DOC Clarify the security pre-announcement mailing list usage
2020-09-10 16:51:49 +12:00
Steve Boyd
1a602608ce
Merge pull request #9675 from creative-commoners/pulls/4/docs-partial-template-cache-in-a-loop
DOC Fix Partial Template Cache documentation header
2020-09-10 16:32:50 +12:00
Serge Latyntsev
b13453c88d
Merge pull request #9678 from creative-commoners/pulls/4.6/compare-select
FIX Problem with direct compare in SELECT statement causing incompatibility with SQL Server database
2020-09-10 16:29:21 +12:00
Steve Boyd
02827a6670 FIX Problem with direct compare in SELECT statement causing incompatibility with SQL Server database
Co-authored-by: Tomas Bilek
2020-09-10 14:48:09 +12:00
Serge Latyntcev
a5c1a86dcb DOC Clarify the security pre-announcement mailing list usage 2020-09-10 13:57:27 +12:00
Serge Latyntcev
d9c0b079d1 DOC Fix Partial Template Cache documentation header 2020-09-10 12:58:16 +12:00
Jackson Darlow
2753f823ee
DOC Added a tip to docs describing how to set a cookie for less than a day (#9552)
DOC Added a tip to docs describing how to set a cookie for less than a day
Co-authored-by: Garion Herman <garion@silverstripe.com>
2020-09-10 12:34:33 +12:00
Steve Boyd
589631df00
Merge pull request #9280 from open-sausages/pulls/4/doc-breadcrumb
DOC Update breadcrumb template in theme rather than app.
2020-09-10 09:48:23 +12:00
Garion Herman
c072f7343a
DOCS Add triage resources, document stale PR definition (#9660)
* DOCS Add triage resources, document stale PR definition
Co-authored-by: Steve Boyd <steve@silverstripe.com>
Co-authored-by: Serge Latyntcev <serge.latyntcev@silverstripe.com>
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-09-09 18:06:02 +12:00
Steve Boyd
4c3a5441b2 Merge branch '4.6' into 4 2020-09-09 13:58:35 +12:00