Will Rossiter
31cfcdb08e
Merge pull request #2076 from halkyon/passwordvalidator_translate
...
Allow PasswordValidator to be translated
2013-06-07 16:19:40 -07:00
Sean Harvey
7862ececbd
Allow PasswordValidator to be translated
2013-06-08 10:48:27 +12:00
Ingo Schommer
4ebd5ab740
Merge pull request #2057 from jthomerson/enhancement_3.1_do_not_run_abstract_test_cases
...
ENHANCEMENT: Do not attempt to run abstract test classes
2013-06-07 07:54:05 -07:00
Will Morgan
1c0ae76f8e
Adding passwordless message instead of throwing an exception
2013-06-07 16:52:44 +02:00
Andrew Short
92135acc14
Merge pull request #2063 from g4b0/mysqldatabase-extensible
...
Enhancement: replaced private with protected
2013-06-07 07:51:49 -07:00
Ingo Schommer
c45ae00d01
Merge pull request #2069 from stevie-mayhew/patch-1
...
MINOR: equality check consistency
2013-06-07 07:14:40 -07:00
Ingo Schommer
117b6887c7
Merge pull request #2070 from stevie-mayhew/patch-2
...
MINOR: equality check consistency
2013-06-07 07:14:29 -07:00
Ingo Schommer
7b7d99d3b1
Merge pull request #2071 from tractorcow/3.1-uploadfield-tweaks
...
API Removed user_error UploadField::setConfig
2013-06-07 07:13:41 -07:00
Mike Parkhill
574c11a834
Behat: "Insert image from web" feature
...
Partially fixes https://github.com/silverstripe/silverstripe-cms/issues/628
Modified a bit by Ingo :)
2013-06-07 16:10:21 +02:00
Ingo Schommer
fd6060e7be
Behat: More robust "field should contain" logic
2013-06-07 16:02:29 +02:00
Ingo Schommer
924664527b
Less assumptions in "HTML field contains" step
...
Not using the loose idea of a "field name" in the NamedSelector
sense of the word as "field with id exists".
2013-06-07 15:46:05 +02:00
Ingo Schommer
7dfe5ccbd2
Limit "should see a button" to actually visible elements
2013-06-07 15:45:15 +02:00
Stig Lindqvist
17bca1db86
Behat: Adding context for 'Given I should not see a "xxx" button'
2013-06-07 12:06:01 +02:00
Ingo Schommer
ff5624c57e
BUG Fixed dropdown step definition for "preview" dropdowns
...
Broke after I optimized it to work with a TreeDropdownField
which assumes <li><a> structures that thie "preview" dropdowns
don't have. I also failed at the recursion assignment, causing
infinite loops...
2013-06-07 11:45:09 +02:00
Damian Mooyman
96023079d5
API Removed user_error when setting missing option on UploadField via setConfig. Added documentation to this function as a replacement for the check.
2013-06-07 14:32:30 +12:00
Stevie Mayhew
76f6e0f71e
MINOR: equality check consistency
...
Updated all equality checks to use double equals (==) for consistency.
2013-06-07 12:37:52 +12:00
Stevie Mayhew
6aae3d7d05
MINOR: equality check consistency
...
Updated all equality logic checks to use double == for consistency across the page.
2013-06-07 12:33:57 +12:00
Sean Harvey
59fb88bec7
Merge pull request #2068 from sminnee/cookie-fix
...
Ensure Cookie::get() will immediately return results.
2013-06-06 16:39:52 -07:00
Sam Minnee
a6bd8f8f43
Ensure Cookie::get() will immediately return results.
...
Without this change, a call to Cookie::get() immediately after Cookie::set()
won't return the value provided. This creates some unintuitive edge-cases,
although to date it looks like they have been worked around.
The patch doesn't have a test because our testing framework doesn't deal
with cookies well.
2013-06-07 11:27:15 +12:00
Sean Harvey
c14b7997d6
Merge pull request #2067 from chillu/pulls/sqlquery-zero-limit
...
BUG Accept $limit=0 in SQLQuery->setLimit()
2013-06-06 13:52:37 -07:00
Ingo Schommer
23e51b871b
BUG Accept $limit=0 in SQLQuery->setLimit()
...
SQLQuery->setLimit(0, 99) should result in "SELECT ... LIMIT 0 OFFSET 1".
In fact it does "SELECT ..." without a LIMIT clause at all,
which is unexpected. This is regardless of the $offset value.
2013-06-06 15:27:14 +02:00
Ingo Schommer
4603378e00
Behat: Fixed step notation
2013-06-06 15:26:50 +02:00
g4b0
6618507823
Enhancement: replaced privete with protected in order to have MySQLDatabase class extensible
2013-06-06 09:06:55 +02:00
Ingo Schommer
7791f20f49
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
tests/behat/features/bootstrap/SilverStripe/Framework/Test/Behaviour/CmsUiContext.php
2013-06-05 15:17:06 +02:00
Ingo Schommer
d3a4161a94
Behat: Backport improved dropdown step handler
2013-06-05 14:59:01 +02:00
Ingo Schommer
1d01347fd3
Behat: Use explicit fixtures
2013-06-05 14:32:42 +02:00
Ingo Schommer
f8b1c08c67
Behat: Copy fixture identifier to "Name" or "Title" by default
...
This makes fixture setup less verbose, particularly for behat
tests (e.g. with "Given a page 'About Us'")
2013-06-05 14:32:42 +02:00
Ingo Schommer
bb92e494d7
Behat fixture refactoring (shared factory instance)
2013-06-05 14:32:42 +02:00
Ingo Schommer
a9ed6b34cb
Behat: Support for TreeDropdownField
2013-06-05 14:32:42 +02:00
Ingo Schommer
a39adb46db
Behat: New fixture notation in "manage files" tests
2013-06-05 14:32:41 +02:00
Jeremy Thomerson
80808a1537
ENHANCEMENT: allow disabling of Versioned prepopulate_versionnumber_cache
...
In large sites this can take a very long time, drastically slowing down the CMS
admin. Even though the versions will then need to be queried individually,
this is still significantly faster than loading hundreds of thousands of
version numbers in one query and populating the cache array.
2013-06-04 13:43:58 +00:00
Jeremy Thomerson
4c0b452c0f
ENHANCEMENT: allow overridable JS/CSS minification
...
This allows someone to extends Requirements_Backend and plug in their own minification
of files, including CSS minification. It also allows them to override whether or not
the header comment is written for each file.
2013-06-04 12:52:11 +00:00
Will Rossiter
358988e9c6
Merge pull request #2059 from adrexia/batch-actions
...
Batch actions styling
2013-06-03 19:14:13 -07:00
Will Rossiter
cc7a6eeaed
Merge pull request #2060 from adrexia/preview
...
Preview Background styling
2013-06-03 19:00:02 -07:00
Will Rossiter
4286e4e6ec
Merge pull request #2058 from adrexia/filter-panel
...
Filter notice styling and panel adjustments
2013-06-03 18:59:10 -07:00
Naomi Guyer
aaa8bf0029
Preview Background styling
...
* Added background color to preview for sites that don't have a
background color (based on @clarkepaul's commit:
https://github.com/silverstripe-droptables/sapphire/commit/7750c8f75fc4a
764b384c6e19dbe543c4811cdcb)
2013-06-04 12:57:09 +12:00
Naomi Guyer
91605ca8ad
Batch actions styling
...
* Removed cog icon (usually associated with settings), and tidied up
padding (based on @clarkepaul's commit:
https://github.com/silverstripe-droptables/sapphire/commit/b09cd5f7f8e73
4df1f7ca0d387a5b97a03a3b604)
2013-06-04 12:48:51 +12:00
Naomi Guyer
01e7bfb350
Filter notice styling and panel adjustments
...
* Based on @clarkepaul's commit here:
https://github.com/silverstripe-droptables/sapphire/commit/e5de6c06489f3
449ee8131bf4ee2a4e1b2380bee
* Kept margin adjustments, but avoided implementing tab changes, as
tabs have chnaged a lot since original commit
2013-06-04 12:11:05 +12:00
Will Rossiter
2814e43568
Merge pull request #2056 from willmorgan/dataobj-validate-injector
...
NEW use Injector pattern to create ValidationResult in validate
2013-06-03 15:55:19 -07:00
Jeremy Thomerson
12cade8126
ENHANCEMENT: Do not attempt to run abstract test classes
...
There is no reason to try to run test cases of a class that is abstract. By
skipping them we allow developers to create abstract test case classes that
have test functions in them. This is especially helpful when someone is
testing multiple implementations of the same service interface. Most of their
tests can be in the abstract class, and then they can create concrete test
classes for each of their implementations and inherit all of the testing that
is built into the abstract class.
2013-06-03 20:25:08 +00:00
Will Morgan
2a91d27ccb
NEW use Injector pattern to create ValidationResult in validate
...
helps for custom validation implementations
2013-06-03 17:12:58 +02:00
Ingo Schommer
f61ab7305d
BUG Correct relation saving in DataObject->duplicateRelations()
...
This caused problems when duplicate() was used in the CMS UI
to duplicate a SiteTree object. Since every object of this type
has a ParentID relation, it copied this empty relation into
new "ghost page".
See https://github.com/silverstripe/silverstripe-cms/issues/689
2013-06-03 15:57:20 +02:00
Ingo Schommer
e137d9e2f0
Merge pull request #2039 from g4b0/sitetree-edit-disabled
...
BUG: fixed "regression" adding a new class to SiteTree elem (edit-disabled)
2013-06-03 04:46:48 -07:00
Ingo Schommer
d2eef63b7d
BUG Trigger TinyMCE onChange more frequently
...
Periodically check for inline changes when focused,
since TinyMCE's onChange only fires on certain actions
like inserting a new paragraph, as opposed to any user input.
This also works around an issue where the "save" button
wouldn't trigger if the click is the cause of a "blur" event
after an (undetected) inline change. This "blur" causes onChange
to trigger, which will change the button markup to show "alternative" styles,
effectively cancelling the original click event.
2013-06-03 13:32:43 +02:00
Loz Calver
dcec30f4e3
Fix: Enable delete button for users with canDelete() but no canEdit() permissions
...
$form->makeReadonly(); iterates over all fields/actions, disabling the 'delete' button even when the user has permission
2013-06-03 12:31:40 +01:00
Ingo Schommer
d5510f54b3
Merge pull request #2041 from Mark-M/patch-1
...
FIX Deprecation $manifest not in global scope
2013-06-03 00:30:26 -07:00
Ingo Schommer
fa66593960
Merge remote-tracking branch 'origin/3.0' into 3.1
2013-06-03 00:19:43 +02:00
Ingo Schommer
95a206290f
Updated translations
2013-06-03 00:07:59 +02:00
Ingo Schommer
f5f2864024
Merge pull request #2046 from wilr/leftandmain_requirements
...
FIX LeftAndMain::extra_requirements to accept non associative arrays.
2013-06-02 14:35:40 -07:00
Ingo Schommer
0ecec24688
Merge remote-tracking branch 'origin/3.1'
2013-06-02 23:31:09 +02:00
