Robbie Averill
c76d3a5db1
FIX Protect against undefined index when using nullifyEmpty option
2019-06-26 09:26:36 +12:00
Robbie Averill
188698dcee
Merge branch '4.2' into 4.3
2019-05-30 09:35:17 +12:00
Robbie Averill
7f69cc8f94
Merge branch '4.1' into 4.2
2019-05-30 09:35:06 +12:00
Robbie Averill
02864aba3f
Merge branch '4.0' into 4.1
2019-05-30 09:34:55 +12:00
Dylan Wagstaff
25aa3af032
FIX HeaderField requires the optional Title field
...
FormField marks the Title constructor argument as optional, and DatalessField does not override the __construct method. HeaderField on the other hand goes against the grain of FormFields as a whole and requires the Title field, seemingly for no good reason (at least, not that the commit message for a68ba384781086f902708c7364550cc996c15b16 indicates) - this seems like an accidental ommision. This commit looks to reinstate the optionality of this constructor argument for consistency's sake.
Plus it broke a module I was investigating.
2019-05-24 13:44:01 +12:00
Robbie Averill
32c04ce765
Merge pull request #8979 from silverstripe-terraformers/feature/add-extension-for-schema-validation
...
Add extend function in getSchemaValidation function
2019-05-16 11:22:45 +12:00
Aaron Carlino
3f1479edbb
BUGFIX: DataQuery overwriting _SortColumn selects ( #8974 )
...
* BUGFIX: DataQuery overwriting _SortColumn selects
* FIX DataQuery _SortColumn handling
2019-05-15 11:42:10 +12:00
shoosah
4da8be3bf5
Add extend function in getSchemaValidation function
...
This allows to create extensions which add validation list
2019-05-14 09:47:14 +12:00
Guy Marriott
53cb804929
Merge branch '4.2' into 4.3
2019-05-13 15:56:23 +12:00
matt-in-a-hat
db0e6f7104
Fix password validation min length message
...
When relying on static config instead of an explicitly set minLength then this message would show without the value, like "it must be or more characters long".
2019-05-13 13:43:29 +12:00
Serge Latyntcev
3d777cfb8a
Backward compatible behaviour for SQLConditionalExpression::getJoins
2019-05-02 15:39:36 +12:00
Robbie Averill
523456ae09
Merge pull request #8921 from creative-commoners/pulls/4.3/threshold-count-in-sql
...
FIX Calculate threshold condition with SQL rather than PHP
2019-04-21 01:25:24 +12:00
Guy Marriott
9d6b5048a6
FIX Table aliases are retained on base tables in queries built using SQLConditionalExpression ( #8918 )
...
* Adding failing test for base table aliases using SQLSelect
* FIX Retain table aliases applied to the base table on queries
* FIX Move the trimmed alias outside of the condition so we can use it within the condition
2019-04-16 15:40:09 +12:00
Guy Marriott
7fd6e14423
Adding comment about the === 't' condition for supporting postgres
2019-04-16 12:10:13 +12:00
Guy Marriott
a48beac845
FIX Calculate threshold condition with SQL rather than PHP
...
This is a performance fix. Modern SQL engines can avoid counting a whole result set (potentially thousands of records) when you are only interested if the count exceeds a threshold.
2019-04-15 16:48:44 +12:00
Sheila Bañez
63360f8048
BUG Replace substr with mb_substr to get the correct position
2019-04-15 16:38:52 +12:00
Robbie Averill
f2f28586d9
Merge branch '4.2' into 4.3
2019-04-11 11:37:34 +12:00
Robbie Averill
116ea12783
Merge branch '4.1' into 4.2
2019-04-11 11:37:22 +12:00
Robbie Averill
f4a6115ee6
Merge branch '4.0' into 4.1
2019-04-11 11:36:40 +12:00
Robbie Averill
55cbacca86
Merge branch '4.2' into 4.3
...
# Conflicts:
# src/Forms/GridField/GridFieldLevelup.php
# src/includes/constants.php
2019-04-11 11:21:42 +12:00
Loz Calver
594af77134
FIX: prevent unnecessary field alterations for enums with empty defaults
2019-04-05 16:17:41 +01:00
Robbie Averill
8b4b54f264
PHPCS linting error on indentation
2019-04-05 16:29:24 +13:00
Ian Patel
759968bbe2
Fix Undefined variable: result when catch Exception
2019-04-05 11:33:01 +13:00
Aaron Carlino
9eac374b13
Use strcasecmp
2019-03-27 12:40:56 +13:00
Jonathon Menz
fae19c16b5
FIX has_one File form scaffolding
...
Only allow selection of a single file when scaffolding has_one File relationship (fixes #8862 )
2019-03-26 09:50:59 -07:00
Damian Mooyman
6dc41e50a0
MINOR Linting fixes
2019-03-26 17:35:58 +13:00
Damian Mooyman
83ec0b69fa
BUG Resolve issue where schema changes between enum / non-enum types
2019-03-26 14:16:05 +13:00
Aaron Carlino
f6a7bddd8d
Linting
2019-03-20 15:50:54 +13:00
Aaron Carlino
388baa01b4
Fix linting
2019-03-20 13:19:10 +13:00
Aaron Carlino
aa491d9294
Fix tests
2019-03-20 12:33:00 +13:00
Aaron Carlino
39a29fa2f6
ENHANCEMENT: has_extension() should allow injector overrides
2019-03-20 12:33:00 +13:00
Dan Hensby
a8605b04e0
Merge branch '4.2' into 4.3
2019-03-06 11:04:14 +00:00
Dan Hensby
7e34167ddf
Merge branch '4.1' into 4.2
2019-03-06 11:01:17 +00:00
Dan Hensby
625e6d5f54
Merge branch '4.0' into 4.1
2019-03-06 11:00:41 +00:00
Daniel Hensby
7416ce275b
FIX doInit comparison should be lowercased
2019-03-05 19:01:12 +00:00
Damian Mooyman
d1396b7dfe
BUG Fix writeBaseRecord with unique indexes
...
Fixes #6819
2019-02-27 16:40:12 +13:00
Maxime Rainville
651d537196
Merge branch '4.2' into 4.3
2019-02-27 12:13:24 +13:00
Maxime Rainville
ed013fcfbb
Merge branch '4.1' into 4.2
2019-02-27 12:12:39 +13:00
Maxime Rainville
ac53f77115
Merge branch '4.0' into 4.1
2019-02-27 12:11:47 +13:00
Maxime Rainville
9a59f2f57d
BUG Renable the ability to do dynamic assignment with DBField
2019-02-22 11:08:43 +13:00
Robbie Averill
ed74549c4f
Merge branch '4.2' into 4.3
2019-02-19 08:39:59 +07:00
Robbie Averill
79e44b42fa
Merge branch '4.1' into 4.2
2019-02-19 08:37:07 +07:00
Robbie Averill
cb7f15a681
Merge branch '4.0' into 4.1
2019-02-19 08:36:41 +07:00
Maxime Rainville
25bba49923
[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation
2019-02-19 12:20:24 +13:00
Robbie Averill
7a508af387
Merge pull request #8795 from creative-commoners/pulls/4.3/improve-foreign-key-form-field-scaffolding
...
FIX Caching the result of counting a foreign list for performance
2019-02-12 15:56:11 +07:00
Maxime Rainville
95505db7d6
[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation
2019-02-12 21:08:09 +13:00
Maxime Rainville
fd90cf6ceb
[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation
2019-02-12 20:44:17 +13:00
Guy Marriott
0ac43ce025
FIX Caching the result of counting a foreign list for performance
2019-02-12 15:28:03 +13:00
Robbie Averill
a104b5b48f
Merge pull request #8769 from creative-commoners/pulls/4.0/escape_for_like
...
FIX Escape wildcard characters when matching database name in databaseExists
2019-02-10 08:26:28 +03:00
Guy Marriott
f918dcd36a
FIX Escape wildcard characters when matching database name in databaseExists
2019-01-30 09:31:13 +13:00
