Commit Graph

4194 Commits

Author SHA1 Message Date
Ingo Schommer
a3b49b1566 MINOR: fixed typos in the comments (from r98201)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102625 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:28:13 +00:00
Ingo Schommer
c63256fb0f MINOR: added quotes (from r98199)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102624 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:28:00 +00:00
Ingo Schommer
9f4413421d MINOR: use DB doubles only in MySQL, fall back to float (from r98178)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102623 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:27:46 +00:00
Ingo Schommer
447ec71471 MINOR better error reporting for broken redirector & virtual pages (from r97185) (from r98155)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102622 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:27:30 +00:00
Ingo Schommer
b3e30ac819 MINOR set Print flag correctly on TLF
MINOR custom print template for SSReport TLF's that exposes the report title, and filters set (from r97138) (from r98154)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102621 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:26:52 +00:00
Ingo Schommer
eba6c9b492 MINOR: Fixed TableListField tests that don't set $_REQUEST['url'] (from r97127) (from r98153)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102620 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:26:38 +00:00
Ingo Schommer
19f566675b BUGFIX pagination was being applied (with a limit of NULL) to print and export actions. This was due to $_REQUEST['methodname'] not existing. (from r97114) (from r98152)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102619 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:26:27 +00:00
Ingo Schommer
64da35bca5 BUGFIX TreeMultiselectField_Readonly now posts the correct value to the server (from r97100) (from r98150)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102618 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:25:45 +00:00
Ingo Schommer
87990bdcf4 MINOR Blocked unnecessary revisions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102617 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:22:40 +00:00
Ingo Schommer
169a2f8c2f MINOR: Blocking unnecessary revisions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102615 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:18:39 +00:00
Ingo Schommer
29a778fa45 MINOR: Fixed PermissionTest assertion (from r96642) (from r98142)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102614 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:18:14 +00:00
Ingo Schommer
1e78fbc34c MINOR: Fixed TableListField test to suit changed behaviour. (from r96639) (from r98141)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102613 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:17:51 +00:00
Ingo Schommer
99be47c479 MINOR if the $fieldname to DOS->sort has a direction in it, split it out, and pass it. (from r96482) (from r98140)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102612 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:17:25 +00:00
Ingo Schommer
864a15db8e MINOR redirector link tracking is more intelligent (from r96461) (from r98139)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102611 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:17:11 +00:00
Ingo Schommer
9b650a4e6c MINOR remove sort direction when running canSortBy. Also added test coverage for this. (from r96428) (from r98138)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102610 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:50 +00:00
Ingo Schommer
10537d5133 MINOR move sort column&direction into their own vars, otherwise, canSortBy(Date DESC) will always return false, since DESC is not part of the column name. (from r96411) (from r98137)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102609 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:34 +00:00
Ingo Schommer
be4c42f9d0 BUGFIX still use the correct methods to get a value, even if we're generating a CSV ($xmlSafe = false) (from r96212) (from r98136)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:21 +00:00
Ingo Schommer
4f461e4b99 MINOR fix field escaping in CSV export of TableListField (from r96157) (from r98135)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102607 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:08 +00:00
Ingo Schommer
f60c080337 BUGFIX: Don't default to sorted descending if you already have a different column sorted ascending. (from r96061) (from r98134)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102606 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:15:50 +00:00
Ingo Schommer
83ccc4f6d9 BUGFIX: Don't make ManifestBuilder choke on empty files. (from r96058) (from r98133)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102605 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:15:37 +00:00
Ingo Schommer
d743cdef78 BUGFIX: Make TableListField sort checking use SQLQuery::canSortBy() to let SSReprot_FakeQuery work.
ENHANCEMENT: Allow sort descending as well as ascending. (from r96054) (from r98132)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102604 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:15:23 +00:00
Ingo Schommer
0a7cca3c56 BUGFIX: Correct direction of sort arrows in TableListField (from r96051) (from r98131)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102603 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:15:10 +00:00
Ingo Schommer
049735b7e0 MINOR Update en_US with SiteConfig.THEME and SiteConfig.DEFAULTTHEME translatable entities (from r98128)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102602 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:14:59 +00:00
Ingo Schommer
ac5bb2b527 MINOR Cleanup test folder after SiteConfigTest::testAvailableThemes() is run (from r98127)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102601 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:14:47 +00:00
Ingo Schommer
c045198333 MINOR: added descriptive text to test assert. (from r98115)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102600 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:14:35 +00:00
Ingo Schommer
b8ab017597 BUGFIX: fixed test that was trying to do a assertContains between a DataObjectSet and a Member object. Changed it to an assertEquals between Member and the First item in the Set. Also added an inverse test to check that Set doesn't contain the wrong Member. (from r98114)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102599 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:14:23 +00:00
Ingo Schommer
5044de817e BUGFIX: removing search&replace victim, using unpopulated cache. Reverted to AllChildren, which calls the cache itself. (from r98111)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:13:27 +00:00
Ingo Schommer
21299ba686 ENHANCEMENT Allow user theme selection through SiteConfig, falling back to SSViewer::set_theme() as a default if there are none selected
MINOR Unit tests for SSViewer::current_theme() and SiteConfig::getAvailableThemes() (from r98110)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:13:12 +00:00
Ingo Schommer
334b83dd23 MINOR Added DecimalTest (merged from 2.4)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102595 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:10:13 +00:00
Ingo Schommer
4a2d71ae2a BUGFIX: Allow creation of TreeDropdownFields on forms with querystring URLs.
API CHANGE: Allow passing of an explicit map of dropdown items to a TreeDropdownField.
BUGFIX: Make use of the $this->value setting of TreeMultiselectFields. (from r95910) (from r98101)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:09:32 +00:00
Ingo Schommer
9a56e31bfb MINOR Removed specific removal of temporary directory in ManifestBuilderTest::testThemeRetrieval() and replaced it with Filesystem::replaceFolder() which does the same thing (from r98098)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102593 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:08:35 +00:00
Ingo Schommer
91918ccfe1 MINOR Allow creating fixture records without any columns by checking the fields exist first before doing a foreach() in YamlFixture::writeDataObject() (from r98055)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102592 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:08:08 +00:00
Ingo Schommer
f22ee6939e MINOR: Blocking unnecessary revisions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102590 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:06:31 +00:00
Ingo Schommer
1e20e55c68 MINOR don't HTML-format queries from showqueries if this is an AJAX request. (from r95855) (from r98097)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102589 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:06:24 +00:00
Ingo Schommer
453faed88a API CHANGE: Refactored test for whether a SQLQuery can be sorted by a particular column into SQLQuery::canSortBy($fieldName) (from r95850) (from r98096)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102588 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:06:12 +00:00
Ingo Schommer
a78ffb7532 BUGFIX: Let FieldMap access non-data fields too (from r95825) (from r98095)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102587 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:57 +00:00
Ingo Schommer
da778dd2a9 BUGFIX: Make TableListField rely on SQLQuery for its count-generation.
BUGFIX: Make SQLQuery return an appropriate count if a HAVING clause is used. (from r95814) (from r98094)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102586 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:45 +00:00
Ingo Schommer
2ae6f896e3 Add some nice date formats (from r95772) (from r98093)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102585 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:26 +00:00
Ingo Schommer
6848684334 MINOR: Initialise variables to fix unit test (from r95754) (from r98092)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102584 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:07 +00:00
Ingo Schommer
753a8804ac ENHANCEMENT ManifestBuilder::get_manifest_info() now uses ManifestBuilder::get_themes() instead of doing it's own retrieval of available themes
MINOR Added ManifestBuilderTest::testThemeRetrieval() to test ManifestBuilder::get_themes() (from r98091)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102583 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:02:52 +00:00
Ingo Schommer
72bb124951 MINOR: Edit-case checking of data in ViewableData::$failover for better error message. (from r95560) (from r98090)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102582 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:02:18 +00:00
Ingo Schommer
8ec4c25be7 MINOR: Don't try and access the ORM from ComplexTableField in situations where it shouldn't. (from r95544) (from r98089)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:01:59 +00:00
Ingo Schommer
fa5af56384 MINOR: Boundary condition check in TableListField for more helpful errors. (from r95543) (from r98088)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102580 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:01:39 +00:00
Ingo Schommer
ca2916c948 MINOR: Fixed FileTest execution if the assets/ directory doesn't exist. (from r88353) (from r98086)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102579 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:01:14 +00:00
Ingo Schommer
0ee0244a01 MINOR added direct links to items in the backlinks report (from r88277) (from r98085)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102578 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:00:41 +00:00
Ingo Schommer
39615a4a09 MINOR unit test for getting members by permission via roles (from r88276) (from r98084)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102577 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:00:15 +00:00
Ingo Schommer
5ba037cc04 BUGFIX: reintroducing the forceValue url param, so the TreeDropdownField value can be set via JS (previously if the item was deep within the tree structure it would not be selected) (from r98083)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102576 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:55:24 +00:00
Ingo Schommer
a138531808 ENHANCEMENT: Removed dev/reset, instead encouraging the use of dev/tests/startsession for tests.
ENHANCEMENT: Let people use dev/tests/startsession without a fixture, instead calling requireDefaultRecords (from r98080)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102575 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:55:09 +00:00
Ingo Schommer
8ce43e46ff MINOR Partially reverted accidental commit from r97920 (unconditionally requiring ADMIN login via BasicAuth in DevelopmentAdmin) (from r98079)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102574 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:53:42 +00:00
Ingo Schommer
7bd479156b MINOR Changed MySQLDatabase::now() block comment to be more useful (from r98059)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102572 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:53:25 +00:00