Sam Minnée
8ced5f5437
Merge pull request #531 from silverstripe-rebelalliance/pull/7258
...
#7258 : CMS Memory Leaks
2012-06-14 16:39:31 -07:00
Sean Harvey
72fd0128c4
BUGFIX "Sync files" button doesn't work when syncing the root of the assets folder
2012-06-15 11:28:29 +12:00
carlos barberis
856991d644
BUGFIX: Ticket #6069 Checking of URLSegment can end in an infinite loop (when saving Page in CMS)
2012-06-15 11:27:58 +12:00
Ingo Schommer
deff232567
MINOR Using onadd in preview JS
2012-06-15 01:19:31 +02:00
Hamish Friedlander
acee026875
BUGFIX: Buttons in the cms that didnt have .ss-ui-button werent becoming buttons because we changed buttons to trigger on onadd, but the ss-ui-button class was being added dynamically
2012-06-15 01:19:31 +02:00
Hamish Friedlander
8ae4597a85
BUGFIX: TreeDropdownField wasnt closing, because the closePanel method is in an entwine namespace
2012-06-15 01:19:30 +02:00
Ingo Schommer
40cef4d584
MINOR Fixed event naming
2012-06-15 01:19:21 +02:00
Ingo Schommer
2fa835a027
MINOR Moving edit form focus logic from onadd() to onmatch() to give the form time to become visible (see #7258 )
2012-06-15 01:19:20 +02:00
Ingo Schommer
ecb48bb57c
BUGFIX Force full window reload on IE7/IE8 every 20 pushState requests (see #7258 )
2012-06-15 01:19:20 +02:00
Ingo Schommer
7ba759e77b
MINOR Fixed jQuery.jstree men leaks on 'dnd' and 'context menu' plugins, by removing globally bound event handlers (see #7258 )
2012-06-15 01:19:20 +02:00
Ingo Schommer
5260738148
MINOR Avoid reinitialising tabs (see #7258 )
2012-06-15 01:19:19 +02:00
Ingo Schommer
fa900f70d5
MINOR jQuery UI tabs memory leak (see ##7258)
...
Events with closed in DOM elements get bound to window on tab initialisation,
and never unbound. Will be fixed with jQuery UI 1.9
2012-06-15 01:19:19 +02:00
Ingo Schommer
980686ab75
MINOR Limiting console.log() output to explicit enabling through window.debug to avoid failing IE
2012-06-15 01:19:19 +02:00
Hamish Friedlander
21e7ec61f4
ENHANCEMENT: In dev mode, include some basic leak detection functions in the admin panel
2012-06-15 01:19:19 +02:00
Hamish Friedlander
1085fd29be
BUGFIX: TinyMCE isnt unbinding formatselect or styleselect which leaks memory. We should really fix TinyMCE, but lets just brute-force it for now.
2012-06-15 01:19:19 +02:00
Hamish Friedlander
e58929d52c
ENHANCEMENT: Make ToggleCompositeField use new entwine features
2012-06-15 01:19:18 +02:00
Hamish Friedlander
b86a787521
BUGFIX: Use new jQuery.Entwine event capturing, onadd and onremove features to plug some memory leaks
2012-06-15 01:19:15 +02:00
Hamish Friedlander
bbd1bb7495
API CHANGE: Upgrade jquery entwine
2012-06-15 01:17:55 +02:00
Hamish Friedlander
8177c93c92
BUGFIX: Fix thirdparty library jquery-cookie referencing $ outside a closure, which wont work in noConflict mode
2012-06-15 01:16:49 +02:00
Ingo Schommer
04e5ff09ca
MINOR Hiding CMS-specific badges in TreeDropdownField ( fixes #7456 )
2012-06-14 20:43:29 +02:00
Ingo Schommer
c81d0e1222
MINOR Only set X-Pjax header in redirections if it doesn't already exist in the response
2012-06-14 20:20:29 +02:00
Marcus Nyeholt
77099ddf9d
BUGFIX Moved initialisation of injector to the start of Core.php to make sure that it is initialised correctly before additional code blocks reference it (in particular some of the code introduced by Sam that is triggered during add_extension).
2012-06-14 20:28:20 +10:00
Marcus Nyeholt
56388ef1d8
BUGFIX Make sure to only construct args for prototype object creation if
...
there are actually args passed through to prevent overwriting with null
args if they're passed
MINOR Added __get alias to remove need for explicit ->get() call
MINOR Added the injector instance as an object that can be injected into other classes
BUGFIX Fixed issue described in http://open.silverstripe.org/ticket/7448 whereby using the injector to create an object of a type already registered as a singleton would actually overwrite the stored singleton object
2012-06-14 18:22:02 +10:00
Paul Meyrick
882b4267cb
BUGFIX: Ticket #5578 SiteTree->CanCreateTopLevel() doesn't change dragged tree nodes or ParentID changes
2012-06-14 17:17:27 +12:00
Cam Spiers
9139f737b8
ENHANCEMENT: Added the ability to set a cost (the property was protected before and there were no setters and getters) and enforced the php requirements on the cost string used in the salt of crypt. Specifically, two digit from 04-31. Updated unit tests for blowfish algorithm to actually use the salt generation function and to test the newly implemented cost setting and getting functionality.
2012-06-14 15:13:11 +12:00
Ingo Schommer
e23a7585a7
MINOR Using new jQuery.changetracker.destroy method in LeftAndMain.EditForm.js
2012-06-13 23:16:13 +02:00
Ingo Schommer
0b6d45356e
MINOR Added destroy() method to jQuery.changetracker plugin
2012-06-13 23:16:09 +02:00
Ingo Schommer
6c1f7997a4
ENHANCEMENT HTML titles in TreeDropdownField
...
HTML in tree nodes is already used to render page icons via SiteTree->TreeTitle.
In order to select the initial value correctly via HTML5 data attributes,
we need to encode any HTML values.
2012-06-13 16:04:14 +02:00
Ingo Schommer
2a52ce2ff8
MINOR Fixed duplicate help text on Group->getCMSFields()
2012-06-13 15:04:40 +02:00
Ingo Schommer
4c0a0f95b0
BUGFIX Inlining TinyMCE HTML popup ( fixes #7451 )
...
Doesn't include base TinyMCE logic when used externally,
most likely a TinyMCE bug since the source_editor.html file is unmodified.
2012-06-13 14:39:50 +02:00
Ingo Schommer
9cdc787935
Merge branch 'stylingfixes' of https://github.com/ajshort/sapphire into ajshort-stylingfixes
2012-06-13 13:23:24 +02:00
Ingo Schommer
db076c0f02
MINOR Using new setDescription() styling in HtmlEditorField
2012-06-13 13:21:41 +02:00
Andrew Short
9e4b526213
MINOR: Include the title attribute on tree and readonly fields.
2012-06-13 13:19:16 +02:00
Andrew Short
d9c7bb8eb9
ENHANCEMENT: Implemented help text for form fields.
...
The title attribute is extracted from form fields and displayed inline
below the field.
2012-06-13 13:19:12 +02:00
Ingo Schommer
43483090b4
Merge branch 'tabstyling' of https://github.com/ajshort/sapphire into ajshort-tabstyling
2012-06-13 10:37:59 +02:00
Ingo Schommer
8ecdd0b082
Merge branch 'pjax-set-fragments' of https://github.com/mateusz/sapphire into mateusz-pjax-set-fragments
2012-06-13 10:31:09 +02:00
Ingo Schommer
666fa7a26e
Merge branch 'togglecompositefield' of https://github.com/ajshort/sapphire into ajshort-togglecompositefield
2012-06-13 10:23:22 +02:00
Andrew Short
160d516699
BUGFIX: Consistently style custom defined page icons.
...
* Apply page icon styling to .page-icon, rather than specific elements.
2012-06-13 18:22:43 +10:00
Will Rossiter
78c15ea882
BUGFIX: Fix correct input type for ImageFormAction replaces.
...
ImageFormAction is deprecated, using the new API results in a submit input rather than an image input being generated. Added hasAttribute helper to FormField as well as test coverage.
2012-06-13 09:57:54 +02:00
Andrew Short
86bb491f2a
MINOR: Consistently style tabs in various CMS interfaces.
2012-06-13 15:10:48 +10:00
Andrew Short
aa67b56b10
ENHANCEMENT: Refactored ToggleCompositeField.
...
* Use jquery ui accordion for the field, and implemented an admin theme.
* Made the setting of configuration consistent with other form fields.
* ToggleComposteField->startClosed() has been deprecated in favour of
setStartClosed().
* Removed public access to the heading level, instead use getHeadingLevel()
or setHeadingLevel().
2012-06-13 14:20:27 +10:00
Andrew Short
513737097b
MINOR: Fixed tab border being shown when tabs were hidden.
2012-06-13 13:46:00 +10:00
Mateusz Uzdowski
377ac50773
ENHNANCEMENT: allow overriding of PJAX fragments included in the response.
2012-06-13 12:57:11 +12:00
Ingo Schommer
ce3d48e310
MINOR Supressed dependencies of tree logic on SiteTree elements (not properly isolated to work well with Folder objects)
2012-06-13 00:51:53 +02:00
Ingo Schommer
b1d95cffac
BUGFIX Passing existing SS_HTTPResponse to PjaxResponseNegotiator in LeftAndMain so state like X-Status HTTP headers are retained ( fixes #7427 )
2012-06-13 00:27:03 +02:00
Ingo Schommer
9b3d3123b6
Merge branch 'tabstyling' of https://github.com/ajshort/sapphire into ajshort-tabstyling
2012-06-12 19:40:21 +02:00
Ingo Schommer
896d198890
BUGFIX Correct DOM structure on updating tree nodes from edit forms, adding badge classes to force strike-through styling on deleted nodes (see #7410 )
2012-06-12 19:16:34 +02:00
Ingo Schommer
2637969bcd
API CHANGE Renamed JS event from 'reloadeditform' on 'aftersubmitform', 'beforesave' to 'beforesubmitform'. Listening to bubbled event on container to avoid binding to forms which are removed before the event is triggered.
2012-06-12 17:13:36 +02:00
Andrew Short
8976c82a35
MINOR: Fixed nested tab styling.
...
* Added and styled border below nested tabs.
* Fixed duplicate nested tabset divs being created.
2012-06-13 00:43:04 +10:00
Ingo Schommer
ed9c856442
ENHANCEMENT Strikethrough styling for deleted tree nodes, adding status classes to tree node <li> in addition to the existing <span class="badge"> ( fixes #7410 )
2012-06-12 15:53:38 +02:00
