Steve Boyd
8b3bec9c68
Merge branch '4.9' into 4.10
2021-12-16 10:58:13 +13:00
Steve Boyd
d5f0c78262
Merge branch '4.8' into 4.9
2021-12-16 10:57:58 +13:00
Michal Kleiner
645e1f14bd
Merge pull request #10173 from GuySartorelli/patch-2
...
FIX Allow custom SELECT to be used for sorting in DataQuery::column()
2021-12-14 10:23:48 +13:00
GuySartorelli
0b0c13764b
FIX allow custom SELECT to be used for sorting in DataQuery::column().
...
If a custom select clause (using special features such as `CASE`) is used, and it was added using `SQLSelect::selectField`, the custom select clause should be retained when calling DataQuery::column().
2021-12-14 08:01:02 +13:00
Lukas
552cf5944d
MNT Fix various typos with codespell ( #10177 )
2021-12-13 21:05:33 +13:00
Steve Boyd
e11820d44f
FIX Look for existing modules in vendor folder rather than base folder
2021-12-13 17:27:23 +13:00
Maxime Rainville
27d7c2fe85
Merge pull request #9749 from gurucomkz/patch-9453-mysql8-ints
...
FIX Don't use int width for mysql >= 8.0.17 #9453
2021-12-13 12:39:12 +13:00
Maxime Rainville
9ea608d0f2
Merge pull request #10021 from xini/fix-login-marker-cookie
...
remove login marker cookie on logout
2021-12-13 10:48:32 +13:00
Thomas Portelange
97ab957de8
ENH Use ::create to get DropdownField instance in DBEnum ( #10175 )
...
This allows using alternate dropdown implementation.
2021-12-11 20:12:07 +13:00
Sergey Shevchenko
9e2d661689
FIX: Make MySQLSchemaManager::shouldUseIntegerWidth() private
2021-12-08 11:19:47 +13:00
Sergey Shevchenko
e68e65badc
feat: added config value to force certain behaviour & added a note to the docs
2021-12-08 11:18:00 +13:00
Sergey Shevchenko
2c9ba8bc45
fix: conform with linter
2021-12-08 11:18:00 +13:00
Sergey Shevchenko
62725a5db3
fix: added exception for MariaDB
2021-12-08 11:18:00 +13:00
Steve Boyd
a3d9648687
FIX Ensure tmpItem has a value before calling method_exists on it
2021-11-25 15:52:51 +13:00
Maxime Rainville
e0197191b8
Rename "Ignore CI Configs" to "Ignored CI Config"
2021-11-22 11:02:27 +13:00
Maxime Rainville
7c3fddfc8a
Anwser Peer review feedback
2021-11-18 23:16:03 +13:00
Maxime Rainville
cbc4593ab4
ENH Don't index test from PHPUNit 5.7 module wdon using PHPUnit 9.5
2021-11-18 21:45:53 +13:00
Maxime Rainville
640a7e3eea
ENH Improve ManifestFileFinder so it can ignore test based on the testing library
2021-11-18 21:45:53 +13:00
Maxime Rainville
2922370d81
API Add Module::getCILibrary function
2021-11-18 21:45:53 +13:00
Maxime Rainville
1bc1e85f68
DOC Fix minor typos in Module
2021-11-18 21:44:26 +13:00
Steve Boyd
d2cbf5bc2a
Merge branch '4.9' into 4
2021-11-18 17:24:41 +13:00
Maxime Rainville
b43d68f9b4
API Add an AttributesHTML trait
2021-11-18 15:31:01 +13:00
Loz Calver
29fa365d10
Fix support for setting TEMP_PATH in .env ( fixes #8099 ) ( #10138 )
2021-11-16 09:35:28 +13:00
Sergey Shevchenko
5e26757a9e
Merge branch 'silverstripe:4' into 4
2021-11-15 22:07:11 +13:00
LiamKearn
a08f43b762
DOC Fix misleading code docblocks ( #10145 )
2021-11-09 14:55:06 +13:00
Loz Calver
b1eb9514d4
FIX Prioritise posix_getuid() when attempting to find current process owner ( #10137 )
2021-11-08 11:56:44 +13:00
Loz Calver
20134e6a4f
NEW Add FirstPage() and LastPage() to PaginatedList ( #10129 )
2021-11-08 09:26:21 +13:00
Loz Calver
d6866af7e5
Fix broken tests
2021-11-04 10:53:42 +00:00
Kirk Mayo
b8d37f9ae4
NEW Validate the Title on Group is not empty ( #10113 )
2021-11-03 14:26:16 +13:00
GuySartorelli
fc349db511
API Add a way to check if a form or form field has an extra css class ( #10112 )
...
Required for silverstripe/silverstripe-admin#1252
2021-11-01 17:01:17 +13:00
Sergey Shevchenko
04b7ad51b8
Merge branch 'silverstripe:4' into 4
2021-11-01 13:12:59 +13:00
Florian Thoma
31668e8acf
fix: remove login marker cookie on logout
...
Apply suggestions from code review
Co-authored-by: Michal Kleiner <mk@011.nz>
2021-11-01 10:04:18 +11:00
Steve Boyd
cd076542f4
API Upgrade SapphireTest to work with phpunit 9 ( #10028 )
2021-10-27 15:39:47 +13:00
GuySartorelli
059d8aac0a
NEW Add afterUpdateCMSFields method to DataObject. ( #9819 )
2021-10-26 16:05:11 +13:00
GuySartorelli
49a7f08c07
ENH: Display validation messages for GridFields ( #10015 )
...
* FIX: Display validation messages for GridFields
* ENH: Add test for GridField validation messages.
2021-10-19 12:03:40 +13:00
Steve Boyd
3a852bed36
Merge branch '4.9' into 4
2021-10-19 11:14:19 +13:00
Steve Boyd
766a024a03
Merge branch '4.8' into 4.9
2021-10-19 11:13:50 +13:00
Steve Boyd
04f9a80c0e
Merge branch '4.7' into 4.8
2021-10-19 11:13:31 +13:00
Steve Boyd
0361f10f4c
Merge pull request #9869 from chrispenny/bugfix/composite-validator-calls-php
...
CompositeValidator::validate() to call validate() instead of php(). Fixes #9868
2021-10-19 11:10:43 +13:00
Thomas Portelange
6e2955fe14
BUG Allow extension of getAttributes for Tab and TabSet ( #9954 )
2021-10-18 23:22:01 +13:00
Mo Alsharaf
2c1ef4df23
MNT Update URL in docs for ICU documentation ( #10118 )
2021-10-15 11:28:16 +13:00
Michal Kleiner
38fe326262
MNT Fix minor typos
2021-09-25 00:23:43 +12:00
Michal Kleiner
1e5414eac7
FIX Use correct ancestor class when querying for stage and live children
...
The right ancestor class that has the Hierarchy extension applied needs to be used
since it doesn’t have to be the class directly extending from DataObject, which means
the ID and ParentID columns might be in different tables.
2021-09-25 00:23:43 +12:00
Maxime Rainville
1c698348a2
BUG When asserting an email was sent, sanitise both the To and From field
2021-09-09 19:23:37 +12:00
Steve Boyd
0a389112ca
FIX Only send email if email address set
2021-09-07 11:20:29 +12:00
Steve Boyd
00e29758ff
DOC Add information regarding Security::setCurrentUser()
2021-09-06 14:04:53 +12:00
Steve Boyd
b5c3b60502
Merge pull request #10047 from madmatt/pulls/extend-hydrate
...
NEW Add extension point to DataObject->hydrate()
2021-08-27 10:41:06 +12:00
Maxime Rainville
02c9736e23
Merge branch '4.8' into 4
2021-08-26 16:58:09 +12:00
Matt Peel
f99ba5d716
NEW Add extension point to DataObject->hydrate()
2021-08-25 16:07:02 +12:00
Steve Boyd
de87d91d22
FIX Trim email addresses to comply with RFC 2822, 3.6.2
2021-08-24 10:06:15 +12:00
Steve Boyd
92f47da08b
API Update SwiftMailer from v5 to v6 ( #10048 )
...
* Update SwiftMailer from v5 to v6
- Fixes #9834
- Update default Swift_Transport to use Swift_SendmailTransport
- Update version restraint for Swiftmailer
- Address new parameter type for Swift_Message::setDate()
- Update class references in docblocks
Co-authored-by: Danaë Miller-Clendon <danae.millerclendon@silverstripe.com>
2021-08-18 12:16:45 +12:00
Steve Boyd
0ea36ad5d6
Merge pull request #10027 from chrometoasters/pulls/director-extension-point-4.8
...
NEW Add extension point to Director::is_site_url
2021-08-07 09:56:31 +12:00
Daniel Hensby
83b458ff59
Merge pull request #10022 from xini/fix-session-destroy
...
take current request protocol into account when deleting session cookie
2021-08-06 10:06:08 +01:00
Florian Thoma
9a7c99fc4b
FIX Take current request protocol into account when deleting session cookie
2021-08-06 10:55:05 +10:00
Michal Kleiner
f8a9431152
NEW Add extension point to Director::is_site_url
2021-08-06 12:54:18 +12:00
Steve Boyd
e0548b208e
Merge pull request #10044 from TheBnl/patch-1
...
Fix error when executing method SSViewer::templates() when $subTempla…
2021-08-06 09:49:00 +12:00
Steve Boyd
9b42624616
Merge pull request #9994 from GuySartorelli/patch-1
...
ENH Provide onBeforeRenderHolder extension hook in GridField.
2021-08-06 09:47:53 +12:00
Bram de Leeuw
ecb233012d
Fix error when executing method SSViewer::templates() when $subTemplates is still null
...
Without the fix this causes the framework to throw a 500 error:
`ERROR [Warning]: array_merge(): Expected parameter 2 to be an array, null given`
I noticed the error while doing a search with the `GridFieldAddExistingAutocompleter`. The error probably gets supressed on live environments.
2021-08-05 12:10:06 +02:00
Steve Boyd
d120367b5a
Merge pull request #9999 from GuySartorelli/patch-2
...
ENH Use text field's title for validation messages.
2021-08-05 15:47:03 +12:00
Steve Boyd
6b514ebd0c
Merge pull request #10040 from GuySartorelli/patch-5
...
ENH: Avoid "new" keyword to instantiate CompositeValidator
2021-08-05 13:39:43 +12:00
Steve Boyd
dc3b907f5f
Merge pull request #10029 from creative-commoners/pulls/4/titletip
...
NEW Title tips for form fields
2021-08-03 14:04:55 +12:00
GuySartorelli
cacd762357
Avoid "new" keyword to instantiate CompositeValidator
...
The CompositeValidator is Injectable, so we should allow project code to replace it here via the Injector.
2021-08-02 12:46:53 +12:00
Steve Boyd
a90d46dbc4
NEW Title tips for form fields
2021-07-31 14:45:24 +12:00
Daniel Hensby
507c70e2f5
Merge pull request #10023 from xini/fix-destroy-session-on-logout
2021-07-20 09:13:20 +01:00
Florian Thoma
3e2ca3027b
destroy session on logout instead of restarting it
2021-07-20 12:05:16 +10:00
GuySartorelli
4cd6b1434a
ENH Reduce duplication of code in GridField view and edit buttons. ( #9953 )
...
* ENH Reduce duplication of code in GridField view and edit buttons.
* Fix syntax error
Co-authored-by: Daniel Hensby <dhensby@users.noreply.github.com>
Co-authored-by: Daniel Hensby <dhensby@users.noreply.github.com>
2021-07-18 16:54:22 +01:00
Nicolaas
c8c7ee4a08
DOCS better docblock for TinyMCEConfig::removeButtons
2021-07-18 11:30:29 +01:00
GuySartorelli
5699db306d
FIX: Remove limits in removeAll method.
...
Keeping a limit here results in a DatabaseException "This version of MariaDB doesn't yet support 'LIMIT & IN/ALL/ANY/SOME subquery'"
2021-07-12 17:14:46 +12:00
Ingo Schommer
b2a85e7a02
FIX BASE_PATH fallback assumed wrong file location ( #9977 )
...
The file was moved back in 2017 with 3873e4ba00 (diff-8ce3f007bef0668c2c08320160362229abce9614025dc2a5b729d1b2b56ed3f7)https://github.com/silverstripe/silverstripe-graphql-composer-plugin
2021-07-08 11:11:39 +12:00
Steve Boyd
f6e8d6e591
Merge branch '4.8' into 4
2021-07-07 14:03:02 +12:00
Steve Boyd
87d076faa6
FIX Cast DBInt value to int
2021-07-06 16:43:54 +12:00
Ingo Schommer
e8c14a9d5b
Merge pull request #10005 from creative-commoners/pulls/4.8/10k
...
FIX Parse Enums with dots in their values
2021-07-02 09:33:29 +12:00
Steve Boyd
8e803bbcfc
FIX Parse Enums with dots in their values
2021-07-01 16:00:08 +12:00
GuySartorelli
e4e4b0924d
ENH Use text field's title for validation messages.
...
Where a field has a title, this is preferred over the field name in validation messages, as that is the "name" of the field as presented to the user.
2021-06-29 17:45:01 +12:00
Steve Boyd
0b979dc345
FIX Cache duplicate embeds separately
2021-06-29 12:17:07 +12:00
Guy Sartorelli
365998f445
ENH Add extension point for modifying readonly GridFields.
...
Developers may want to amend a gridfield (either by modifying its
components or amending the list) after it has been transformed to be
readonly.
One such modification may be replacing the GridFieldViewButton
with something else - because components are instantiated with the "new"
keyword this would be the only way to do that.
2021-06-29 11:23:58 +12:00
Guy Sartorelli
009a32fbec
ENH Allow GridField readonly components to be globally modified.
2021-06-29 11:21:41 +12:00
GuySartorelli
d710990e13
ENH Provide onBeforeRenderHolder extension hook.
...
GridField has onBeforeRender in its Field method, but that hardly ever gets called.
This commit adds the onBeforeRenderHolder extension hook that is normally available via FormField::FieldHolder().
2021-06-25 13:21:49 +12:00
Steve Boyd
325021c2f8
Merge branch '4.8' into 4
2021-06-21 14:59:01 +12:00
Steve Boyd
e812999632
Merge branch '4.7' into 4.8
2021-06-21 14:58:40 +12:00
Steve Boyd
b625ba99b3
ENH Remove wording for authenticated devices being manageable
2021-06-18 09:50:13 +12:00
Steve Boyd
7ed7ad0254
FIX Ensure changing a password to blank is validated
2021-06-17 12:05:20 +12:00
Steve Boyd
06dbd5237b
[CVE-2020-26138] Validate custom multi-file uploads
2021-06-09 09:34:37 +12:00
Steve Boyd
3bb435c241
[CVE-2020-25817] Prevent loading of xml entities
2021-06-09 09:34:26 +12:00
Steve Boyd
9463aaf571
Merge branch '4.8' into 4
2021-06-08 11:49:01 +12:00
Steve Boyd
fb0d769049
Merge pull request #9969 from creative-commoners/480-tag
...
Security fixes from 4.8.0
2021-06-08 11:47:35 +12:00
David Peck
28b5b803be
FIX Defensively copy mocked datetime
2021-06-05 16:46:19 +12:00
Steve Boyd
8024551376
[CVE-2020-26138] Validate custom multi-file uploads
2021-06-02 16:24:23 +12:00
Steve Boyd
7f97734a20
[CVE-2020-25817] Prevent loading of xml entities
2021-06-02 16:24:17 +12:00
Michal Kleiner
2017a20433
FIX Use empty array as a fallback for preg_split within dbtext summary
...
If the content is invalid for whatever reason e.g. when instantiating
a DBText field to get a summary of text through
`DBField::create_field('Text', $content)->Summary(10)`, preg_split returns
false and the rest of the code expects an array.
This tweak ensures an array is always returned even when preg_split fails.
2021-06-02 15:17:58 +12:00
Steve Boyd
a3df66860f
Merge branch '4.8' into 4
2021-05-31 17:05:11 +12:00
Steve Boyd
9ccdb8efb2
Merge branch '4.7' into 4.8
2021-05-31 17:04:54 +12:00
Maxime Rainville
472fc4ebb4
BUG Update DataQuery::exists to return false when limit causes no result to be returned ( #9946 )
...
* BUG Update DataQuery::exists to return false when limit causes no result to be returned
* Update comment
* Fixing linting issue
2021-05-31 16:50:58 +12:00
Ingo Schommer
196752566f
Merge pull request #9655 from sminnee/pulls/9647-find-lost-records
...
NEW: Add GridFieldDetailForm::setRedirectMissingRecords()
2021-05-21 13:53:18 +12:00
Sam Minnee
8883413ba7
NEW: Add GridFieldDetailForm::setRedirectMissingRecords()
...
This new opt-in setting will let grid field detail forms redirect to the
“Correct” URL of a GridField if it’s not found in the current list.
This works by:
* Looking for the item in the database
* If it exists, check for a CMSEditLink() method that returns a value
* If so, redirect to that
This is useful if you have a number of grid fields that each show a
partial list of records, and it’s possible for the user to make changes
such the item no longer appears in the list, but does appear in another
list.
It’s an opt-in feature as I think all changes like this should be
opt-in, based on previous experiences improving GridField and in turn
breaking SecurityAdmin and slowing versioned-data-browsing down. ;-)
2021-05-21 13:16:00 +12:00
Ingo Schommer
8c0efd3980
Extension hooks for CsvBulkLoader
...
Required for versioned-snapshots integration
2021-05-21 11:17:46 +12:00
Ingo Schommer
ad4e488dcf
Merge pull request #9192 from sminnee/fix-9163
...
NEW: Support dot syntax in form field names
2021-05-21 10:34:15 +12:00
Dylan Wagstaff
a5fc61a23a
Merge pull request #9948 from open-sausages/4
...
FIX Tidy extension and cli fix for tests
2021-05-21 09:19:22 +12:00
Guy Marriott
766df06f23
Merge pull request #9631 from open-sausages/pulls/4/custom-sort-gridfield-autocompleter
2021-05-20 14:02:44 -07:00
Ingo Schommer
8806b3befc
Fixes required for dot notation support in fields
...
See #9163
2021-05-20 20:32:25 +12:00
