Commit Graph

72 Commits

Author SHA1 Message Date
Andrew O'Neil
808d6875cb #941 - Security flaw: SS prone to CSRF attack
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43901 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-28 21:44:38 +00:00
Sean Harvey
26be9e739d ->setRightTitle didn't show because $RightTitle was misnamed with a lowercase r
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43896 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-27 02:39:30 +00:00
Romain Louis
0eafb6d08e Commits to solve a ManyManyComplexTable problem with heritage
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43892 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-26 05:45:39 +00:00
Andrew O'Neil
dc1775169d #941 - Security flaw: SS prone to CSRF attack
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43876 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-26 02:23:55 +00:00
Ingo Schommer
393caf4287 FEATURE made sapphire i18n-capable
FEATURE a little bit of german translation

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43842 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-25 02:47:45 +00:00
Ingo Schommer
d21a49afb8 BUGFIX array_flip() for $usedLangs was not necessary any more (delivered as indexed array)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43780 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-24 04:27:54 +00:00
Ingo Schommer
74f154fcda changed PureName() to Name() (see r40757)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43669 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-22 19:56:26 +00:00
Ingo Schommer
35fb0cd0c5 #92 MoreLessField: Switch to ToggleField and remove
FEATURE Refactored MoreLessField->ToggleField
FEATURE Refactored TogglePanel->ToggleCompositeField
FEATURE Degrading gracefully (javascript), using behaviour+classes+prototype, partially i18ned, improved markup

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43660 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-21 23:05:46 +00:00
Ingo Schommer
0da5773278 reverted "BUGFIX: overloaded FieldHolder() to avoid DefaultFieldHolder.ss usage"
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-18 01:44:37 +00:00
Ingo Schommer
3bb267bd83 ENHANCEMENT: changed <p class="Actions"> to <div class="Actions">
ENHANCEMENT: Better linebreaks, markup formatting

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43560 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-18 01:07:35 +00:00
Ingo Schommer
eeb79fde9c FEATURE: respect $extraClass
BUGFIX: overloaded FieldHolder() to avoid DefaultFieldHolder.ss usage

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43559 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-18 01:06:21 +00:00
Ingo Schommer
53f75e957d ENHANCEMENT: allowing empty children
ENHANCEMENT: added Fields()
ENHANCEMENT: added linebreaks for html

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43558 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-18 01:05:52 +00:00
Romain Louis
0a85936f2f FileIFrame Saving method problem fixing
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43542 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-17 23:10:04 +00:00
Romain Louis
c485a70354 Saving bug fixing with when value equals undefined
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43537 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-17 22:50:08 +00:00
Romain Louis
cf7adf02da Saving bug fixing with when value equals undefined
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43536 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-17 22:48:17 +00:00
Ingo Schommer
3cd1a621b5 preparing CTF for usage outside of CMS
BUGFIX: provide fallback for ajax-errors if not in CMS context
BUGFIX: re-added middle-alignment to greybox if not in CMS context
BUGFIX: added basic requirements to be independent of cms-inclusion
FEATURE: better transformation of save-button (replaced indicator with "saving..." label)
ENHANCEMENT: moved String-lib to prototype_improvements.js

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43491 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-17 02:29:42 +00:00
Ingo Schommer
baba1b45f0 documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43119 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-04 22:17:44 +00:00
Andrew O'Neil
f4dd20b979 Fixed CustomRequiredFields (merged from 2.1.0-textme branch, r42959)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@43116 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-10-04 21:58:10 +00:00
Ingo Schommer
6ec4b77cd5 ENHANCEMENT: Coding conventions, wording
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42730 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-27 20:59:46 +00:00
Ingo Schommer
1e332e6dbe !!BUGFIX: Refactored CSS and Requirements: Created more specific css-files to reduce side-effects and ease debugging, moved generic form-styling from cms/css/cms_*.css into sapphire/css/Form.css.
!!BUGFIX: Ordered Requirement-inclusions in CMSMain/LeftAndMain to be more coherent (avoiding duplicate Requirement-calls)
ENHANCEMENT: Removed some css-rules disabled by comments
ENHANCEMENT: coding-conventions (see r42726)
FEATURE: Added Profile-page with LeftAndMain->myprofile()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42728 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-27 20:56:55 +00:00
Ingo Schommer
0e968ca308 Fixed ticket #85: Dropdown on /status/CMS should be sorted alphabetically. Now all language dropdowns are sorted by language name rather than language code (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42576 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-25 21:57:54 +00:00
Ingo Schommer
e7bc735774 mlanthaler: The validators for the Member extensions didn't work until now, these changes fix that issue.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42144 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 16:55:47 +00:00
Ingo Schommer
970a453cb8 bfojcapell: Added function insertBeforeRecursive (see www.silverstripe.com/google-summer-of-code-forum/show/3005). This function is only called in Translatable.php at this moment, so if finally insertBefore gets a recursive behaviour then the call can be renamed and insertBeforeRecursive deleted.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42113 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 16:06:52 +00:00
Ingo Schommer
20f14f04af bfojcapell: Added initializations to avoid notices
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42112 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 16:06:24 +00:00
Ingo Schommer
490d8a0b0a bfojcapell: Added function insertBeforeRecursive (see www.silverstripe.com/google-summer-of-code-forum/show/3005). This function is only called in Translatable.php at this moment, so if finally insertBefore gets a recursive behaviour then the call can be changed and insertBeforeRecursive deleted.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42111 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 16:05:59 +00:00
Ingo Schommer
864c0ba021 bfojcapell: Added function SmallFieldHolder? to properly render fields when this function is called in a FieldGroup?.
Also added function insertBeforeRecursive (see www.silverstripe.com/google-summer-of-code-forum/show/3005). This function is only called in Translatable.php at this moment, so if finally insertBefore gets a recursive behaviour then the call can be changed and insertBeforeRecursive deleted.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42110 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 16:05:05 +00:00
Ingo Schommer
a8433baee2 bfojcapell: Added new field type LanguageDropdownField?
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42109 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 16:03:32 +00:00
Ingo Schommer
9e7eeece04 bfojcapell: Added new field type MoreLessField?
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42108 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 16:02:26 +00:00
Ingo Schommer
c35c83bad7 elofgren: USABILITY: Make Page URL input field wider as part of fix for http://support.silverstripe.com/gsoc/ticket/35
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42034 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:00:59 +00:00
Ingo Schommer
265a853c2a elofgren: BUGFIX: Fix trac ticket: #1411 'Layout problems with search box in IE' http://open.silverstripe.com/ticket/1411
by only creating a 'label' tag if a 'Title' is set in FormField?->FieldHolder?() 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42031 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:59:33 +00:00
Ingo Schommer
f5e24e3512 mlanthaler: Bugfix: Initialized variable to prevent E_NOTICE error.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42026 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:55:04 +00:00
Ingo Schommer
76797c02a6 mlanthaler: Bugfix: Added isset() to prevent E_NOTICE error.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42023 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:52:35 +00:00
Ingo Schommer
cf2ea6ea60 mlanthaler: Bugfix: Added check if variable is set.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42021 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:50:43 +00:00
Ingo Schommer
db42713e1c mlanthaler: Bugfix: Class created invalid HTML (<td>...</t>).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42020 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:50:07 +00:00
Ingo Schommer
44a74482e0 mlanthaler: Bugfix: Fixed E_NOTICE error "Trying to get property of non-object".
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41955 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:40:28 +00:00
Ingo Schommer
35c5b08b37 mlanthaler: Bugfix: Fixed E_NOTICE error due to uninitialized variable.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41954 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:39:23 +00:00
Ingo Schommer
59fbe53120 mlanthaler: In PasswordField::performReadonlyTransformation() was an E_NOTICE error. Instead of fixing it, I changed also the behavior.
There are displayed now always five stars, so it is impossible to use the information of the password length for brute-force attacks. 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41953 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:38:05 +00:00
Ingo Schommer
71f9ac0c10 mlanthaler: Bugfix: Added isset() to prevent E_NOTICE error.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41952 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:36:17 +00:00
Ingo Schommer
b0d65bba2e elofgren: Add description to TogglePanel? class.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41936 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:03:27 +00:00
Ingo Schommer
fc26c64f63 elofgren: Add extraClass parameter to InlineFormAction? so that 'Delete Selected Files' button can have the 'delete' class assigned to it so it turns red on hover.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41833 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:18:21 +00:00
Ingo Schommer
4a0b7e1d6d elofgren: BUGFIX: Edge case fix to prevent execution timeout if a page has 50 identical broken links by only highlighting them once.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41822 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 00:05:49 +00:00
Ingo Schommer
ef54473d1b elofgren: Add 'extraClass' parameter to FormAction? and use it to assign the 'delete' CSS class to the 'Unpublish' and 'Cancel draft changes' buttons so that their background turns red on hover.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41820 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 23:43:02 +00:00
Ingo Schommer
e452de966c elofgren: VAR FIX: Fix a large amount of undefined variable errors when creating and editing a 'newsletter subscription form' page by adding needed issets and initializations.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41817 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 23:31:08 +00:00
Ingo Schommer
461f9e2af0 elofgren: VAR FIX: Fix EditableRadioField? 'optionNumber' and 'optionData' undefined variable errors by initializing 'optionNumber' and using 'newOption' instead of 'optionData'. These errors were
encountered when adding a new 'newsletter subscription form' type page. 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41816 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 23:22:23 +00:00
Ingo Schommer
568489ede7 elofgren: USABILITY: Increase height of ImageField? iframe to make room for padding around fieldset. Also increase width of 'Replace Image' block to make the image drop-down fit. This change goes with r37020
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41792 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 19:20:43 +00:00
Ingo Schommer
6b2b21e735 elofgren: VAR FIX: Change first concatation to an assignment in CompositeField::debug() (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41781 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 18:05:21 +00:00
Ingo Schommer
282b8292a4 elofgren: In TableField::sortData() initialize 'dataObjects' to an empty array to prevent undefined variable errors when editing the name of a Security group that has no members. (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41780 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 18:03:15 +00:00
Ingo Schommer
ff2f8fa7f4 elofgren: Remove padding:0; margin:0; accidentally committed in r36714 (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41774 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 17:38:38 +00:00
Ingo Schommer
1d07b6b254 elofgren: Change width of 'HtmlEditorField? textareas' from 100% to 97% to prevent horizontal scrollbars at 1024x768 using IE7. (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41773 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 17:37:48 +00:00
Ingo Schommer
f3018529ac elofgren: Add 2 needed isset() calls: in forms/Form.php and security/Member.php (merged from branches/gsoc)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41770 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-14 17:10:37 +00:00