Ingo Schommer
3bfb82d25f
Merge pull request #2203 from camspiers/config-memory
...
Improve memory performance when generating config static and class caches
2013-07-08 06:35:31 -07:00
Cam Spiers
2d30592f72
Improve memory performance when generating config static and class caches
2013-07-08 21:24:14 +12:00
Damian Mooyman
0e443bafa0
Deprecate Aggregate and DataObject::getComponentsQuery
2013-07-08 15:27:13 +12:00
Hamish Friedlander
10b55170ea
Merge pull request #2139 from jthomerson/pulls/template_includes_with_scope
...
FEATURE: <% include %> inherits scope of parent template
2013-07-07 14:01:40 -07:00
Jeremy Thomerson
f6ff39369f
FEATURE: <% include %> inherits iterator scope of parent template
2013-07-07 12:39:42 +00:00
Sam Minnée
596934b107
Merge pull request #2133 from jthomerson/pulls/fix_testcase_comments_setting
...
MINOR: fix Email class modifying SSViewer.source_file_comments config val
2013-07-06 20:32:44 -07:00
Sam Minnée
0173707cd1
Merge pull request #2164 from tractorcow/3.1-datetimefield-fixes
...
BUG Fixed DateTimeField where time value was being parsed incorrectly.
2013-07-06 19:03:33 -07:00
Sam Minnée
ecf8f273c0
Merge pull request #2201 from hafriedlander/fix/session
...
Fixes to session, primarily around cookie_secure
2013-07-06 18:59:07 -07:00
Sam Minnée
aee786b221
Merge pull request #2169 from camspiers/yml-parse-modulename
...
Allow module directories to be named with more valid characters ensuring that module names in fragment meta-data are correct
2013-07-06 16:11:31 -07:00
Hamish Friedlander
d629d9422f
FIX Session::$cookie_secure so Sessions still work via HTTP
...
Session::$cookie_secure adds the secure property to the session Set-Cookie
command, so that the browser wouldnt send it to the server over an unencrypted
link. However the server would still send the cookie to the browser
unencrypted. Also Sessions would stop working properly in HTTP,
but SilverStripe needs them for several things, such as form validation
This patch effectively causes HTTP and HTTPS requests to each have
their own session when cookie_secure is true. The two sessions are
independant from each other, so information set in the session via
HTTPS is safe from attacks on the session via HTTP, but parts
of the site that use HTTP and the session will still work
2013-07-07 09:12:10 +12:00
Hamish Friedlander
2886f6ee14
FIX Session was started every time, even if no data set
...
Session tracks the user agent in the session, to add some detection of
stolen session IDs. However this was causing a session to always be
created, even if this request didnt store any data in the session.
2013-07-07 09:12:10 +12:00
Sam Minnée
be311f72a5
Merge pull request #2191 from kinglozzer/uploadfield-disable-on-edit
...
FIX: UploadField action buttons aren't disabled when editing an item
2013-07-05 23:04:49 -07:00
Sam Minnée
da936dd45e
Merge pull request #2200 from hafriedlander/fix/varies
...
FIX Director::forceSSL and forceWWW not setting Vary header
2013-07-05 22:59:04 -07:00
Hamish Friedlander
c6b4d993cc
FIX Director::forceSSL and forceWWW not setting Vary header
...
If you have a Varnish box in front of a SilverStripe install, and
you call forceSSL, the Vary header wouldnt get sent. As a result
Varnish would respond with the same redirect reponse after the
redirect, leading to an infinite loop
2013-07-06 15:24:01 +12:00
Cam Spiers
0aeb2293bb
Allow module directories to be named with more valid characters ensuring that module names in fragment meta-data are correct.
...
Unit tests for ConfigManifest reference path parsing
2013-07-06 14:16:59 +12:00
Loz Calver
041f5f51a5
FIX: UploadField action buttons aren't disabled when editing an item
...
Toggle disabled classes/attributes based on form visibility instead of .toggle()
Use jQuery.attr() simply because it looks nicer
2013-07-05 09:39:09 +01:00
Simon Welsh
ff45f7ce4d
DataListTest should not rely on order of values when not explictly sorting
2013-07-05 11:45:34 +12:00
Ingo Schommer
573ec9d58b
Merge pull request #2198 from simonwelsh/pgtest
...
Quote table/column names when falling back to $fullName
2013-07-04 15:50:01 -07:00
Simon Welsh
5dc5e0b4c5
Quote table/column names when falling back to $fullName
2013-07-05 10:41:18 +12:00
Ingo Schommer
c3e9e44204
Merge pull request #2197 from hafriedlander/fix/dbapichange
...
FIX Recent patch to DataObject#db changed API which broke core
2013-07-04 15:20:52 -07:00
Simon Welsh
d844c74e3c
Merge branch '3.0' into 3.1
...
Conflicts:
.travis.yml
control/HTTP.php
email/Mailer.php
tests/control/HTTPTest.php
2013-07-05 10:17:14 +12:00
Hamish Friedlander
ca63e33c19
FIX Recent patch to DataObject#db changed API which broke core
2013-07-05 10:11:35 +12:00
Mateusz U
3ac22ed638
Merge pull request #2182 from hafriedlander/fix/sanitise
...
FIX HtmlEditorField not re-checking sanitisation server side
2013-07-04 14:56:37 -07:00
Sam Minnée
7f461ddd75
Merge pull request #2192 from dangerdan/patch-1
...
Fixed broken github issue tracker link
2013-07-04 14:55:08 -07:00
Simon Welsh
fb457e47eb
Removes PHP 5.5 from allowed failures
2013-07-05 09:45:30 +12:00
Damian Mooyman
11f4b2c620
API HTTP::urlRewriter with (string)$code deprecated in 3.1. Fixed regressions and CSS urls.
...
urlRewriter will expect a callable as a second parameter,
but will work with the current api and simply raise a deprecation error.
HTTP::absoluteURLs now correctly rewrites urls into absolute urls. Resolves introduced in c56a80d6ce
HTTP::absoluteURLs now handles additional cases where urls were not translated.
Test cases for HTTP::absoluteURLs added for both css and attribute links.
Cleaned up replacement expression and improved documentation.
2013-07-05 09:08:58 +12:00
Simon Welsh
9deb11f9a0
Use preg_replace_callback over preg_replace with e modifier
2013-07-05 09:08:58 +12:00
Ingo Schommer
c809bd7183
Merge pull request #2196 from chillu/pulls/travis-matrix
...
PHP 5.5 CI, don't allow failures for sqlite3 and postgres
2013-07-04 13:59:33 -07:00
Ingo Schommer
2845f76ade
PHP 5.5 CI, don't allow failures for sqlite3 and postgres
2013-07-04 22:55:49 +02:00
Ingo Schommer
067a94bd93
Postgres compat in MemberCsvBulkLoaderTest and GroupTest
2013-07-04 22:46:23 +02:00
Ingo Schommer
cf20923fd6
Postgres compat in SQLQueryTest
2013-07-04 22:28:13 +02:00
Dan Brooks
409be9a840
Fixed broken github issue tracker link
2013-07-04 16:41:53 +01:00
Damian Mooyman
a862b4da99
BUG Fixed missing allowed_actions on UploadField_SelectHandler
2013-07-04 12:38:57 +12:00
Hamish Friedlander
dacb2aa638
FIX HtmlEditorField not re-checking sanitisation server side
2013-07-04 08:53:23 +12:00
Ingo Schommer
d003c96c62
Fixed HTMLEditorField extension call ("updateFieldsForOembed")
2013-07-03 10:15:46 +02:00
Simon Welsh
29c2b21a2a
Merge pull request #2175 from jthomerson/fix_2174
...
FIX #2174 : SearchFilter needs casting helper for DataObject base fields
2013-07-02 20:15:47 -07:00
Jeremy Thomerson
50e9eee2e9
FIX #2174 : SearchFilter needs casting helper for DataObject base fields
...
Commit 964b3f2
fixed an issue where dbObject was returning casting helpers for
fields that were not actually DB objects, but had something in $casting config.
However, because dbObject was no longer calling DataObject->castingHelper, this
exposed a bug that the underlying function db($fieldName) was not returning
field specs for the base fields that are created by SS automatically on all
DataObjects (i.e. Created, LastEdited, etc).
This commit fixes the underlying issue that DataObject->db($fieldName) should
return the field specs for *all* DB fields like its documentation says it will,
including those base fields that are automatically created and do not appear in
$db.
2013-07-03 03:03:40 +00:00
Ingo Schommer
429bbc5223
Merge pull request #2137 from jthomerson/pulls/fix_viewable_data_wrapped_value
...
FIX: ViewableData wasn't setting values when using default cast
2013-07-02 00:40:56 -07:00
Mateusz Uzdowski
21844a8a07
Merge branch 'pr/2173' into 3.1
2013-07-02 15:52:31 +12:00
Mateusz Uzdowski
f9ede95e5b
Add configuration system tests for Only and Except combinations.
2013-07-02 15:51:53 +12:00
Hamish Friedlander
df218d76da
Clarify how Only and Except rules combine
2013-07-02 14:09:11 +12:00
Hamish Friedlander
5484283a25
FIX changing environment in config.php changes matched yaml rules
2013-07-02 13:21:27 +12:00
Hamish Friedlander
e74c002647
FIX Only and Except rules in Configs not working
2013-07-01 15:47:37 +12:00
Ingo Schommer
a6c3d1e269
Flag "insert image" behat test as @assets
...
Required in order to run them remotely, which currently
doesn't support file upload through Selenium
2013-06-28 12:21:00 +02:00
Ingo Schommer
a9f150126c
Fix CMSBatchActionHandler::$allowed_actions
...
Regression from earlier API change to deny actions unless specified
2013-06-28 10:07:57 +02:00
Damian Mooyman
feb03f5443
BUG Fixed issue where time value was being parsed incorrectly in some locales
2013-06-28 16:45:33 +12:00
Hamish Friedlander
03aa9e4b41
FIX ConfigManifest caching to not use existing cache from wrong $base
2013-06-28 11:25:14 +12:00
Andrew Short
973a23fac8
Merge pull request #2162 from simonwelsh/sec-redirect
...
Only redirect on logout if we're not already redirecting
2013-06-26 15:56:56 -07:00
Simon Welsh
1d5ac5876b
Only redirect on logout if we're not already redirecting
2013-06-27 09:49:10 +12:00
Ingo Schommer
bcc09deb08
Merge pull request #2153 from chillu/pulls/form-fortemplate-access
...
Allow Form->forTemplate() URL access (fixes #788 )
2013-06-26 13:56:56 -07:00