tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-09-29 20:59:23 +02:00
Code Issues Projects Releases Wiki Activity
23,979 Commits 30 Branches 526 Tags 158 MiB
b8f0b8ca4f
Commit Graph

2739 Commits

Author SHA1 Message Date
github-actions
7e30e38ae6 Merge branch '5.1' into 5 2024-02-14 22:58:30 +00:00
Guy Sartorelli
d33332cb9e
FIX Add eagerloaded data to ALL relevant lists (#11139) 2024-02-15 11:57:22 +13:00
Steve Boyd
51fd1d6b7e FIX Handle __TRAIT__ in i18nTextCollector 2024-02-13 16:33:24 -07:00
Guy Sartorelli
a00bdd727f
MNT Run module-standardiser (#11121) 2024-02-13 14:33:23 +13:00
Guy Sartorelli
343c8ff787
Merge branch '5.1' into 5 2024-02-13 13:55:30 +13:00
Thomas Portelange
b56e771ed5
FIX add missing rawurlencode (#11105) 2024-02-13 10:08:28 +13:00
Guy Sartorelli
9c4266c8f3
Merge pull request #11127 from lekoala/patch-45 
FIX Unknown column 'ClassName' in field list
 2024-02-13 09:51:52 +13:00
Thomas Portelange
e0107e0202
Update src/ORM/DataQuery.php 
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
 2024-02-08 09:14:27 +01:00
Thomas Portelange
2ac68a55a4
rename var 2024-02-08 09:13:40 +01:00
Guy Sartorelli
5e53dbcdbc
NEW Add a trace comment for queries in dev mode (#11065) 2024-02-08 16:29:55 +13:00
Guy Sartorelli
e87c724700
FIX Don't assume mysql handle is an object (#11129) 2024-02-08 15:07:33 +13:00
Thomas Portelange
1dd81488aa
fix unknown table 
Fixes https://github.com/silverstripe/silverstripe-framework/issues/10737
 2024-02-07 17:38:14 +01:00
Guy Sartorelli
26273bf371
TLN Update translations (#11125) 2024-02-07 10:16:25 +13:00
Steve Boyd
2e4bc95157 NEW Add UrlField 2024-02-02 13:43:26 +13:00
Guy Sartorelli
7f71695335
NEW Wire up symfony/validator (#11123) 2024-02-02 13:15:32 +13:00
Steve Boyd
6ccdd10c60 MNT Remove unused import 2024-01-31 16:15:36 +13:00
Steve Boyd
9d335f73d6 NEW HasOneRelationFieldInterface 2024-01-31 10:34:25 +13:00
Antony Thorpe
90a3d60b59
Update DropdownField.php 
Update the enum example with a namespaces classname
 2024-01-30 19:02:05 +13:00
github-actions
1eadc84a22 Merge branch '5.1' into 5 2024-01-27 14:24:02 +00:00
Sabina Talipova
afd53d1d6a FIX HTMLEditorField::setRows with Elemental 2024-01-25 12:07:10 +13:00
Guy Sartorelli
98951c088e
Merge branch '5.1' into 5 2024-01-23 12:04:23 +13:00
github-actions
312ee58292 Merge branch '4' into 5.1 2024-01-22 22:58:52 +00:00
Guy Sartorelli
90a57c2aa4
Merge branch '5.1' into 5 2024-01-23 11:58:17 +13:00
Sabina Talipova
6fe377e69d
Merge pull request #11113 from creative-commoners/pulls/4.13/cve-2023-48714 
[CVE-2023-48714] Don't show or add records the member isn't allowed to
 2024-01-23 11:46:28 +13:00
Guy Sartorelli
873b721b6b
[CVE-2023-48714] Don't show or add records the member isn't allowed to 
see
 2024-01-23 11:11:36 +13:00
Guy Sartorelli
4b1b487041
[CVE-2023-49783] Allow permission checks in BulkLoader 2024-01-23 11:01:25 +13:00
github-actions
96241b2db8 Merge branch '4' into 5.1 2024-01-20 14:24:40 +00:00
Guy Sartorelli
357ed7ad7e
ENH Add generic types (#11108) 
There are also a few general corrections to PHPDocs that I noticed along
the way (e.g. adding `|null` when the method is returning a null value.

There are some cases where either the return type or the whole PHPDoc
was duplicated from the parent class - in those cases I've simply
removed the duplication.
 2024-01-17 17:08:26 +13:00
Guy Sartorelli
8b427f4e74
API Deprecate some unused API 2024-01-17 14:00:47 +13:00
github-actions
56086121a2 Merge branch '5.1' into 5 2024-01-13 14:24:50 +00:00
Sabina Talipova
ff3a6f72df
FIX HTMLEditorField::setRows minimal hieght (#10965) 2024-01-11 15:00:24 +13:00
Steve Boyd
9bfb731bc3 FIX Handle polymorphic relationships that use Owner instead of Parent 2024-01-10 11:43:26 +13:00
Guy Sartorelli
b1a1d4b951
Merge pull request #11100 from creative-commoners/pulls/5/split-summary-by-punctuation 
ENH Split sentences by configurable punctuation for summary
 2024-01-09 09:01:44 +13:00
Nick
e456de11b0
Fix clobbering of the upload size validation (#10059) 
* Fix clobbering of the upload size validation

When the validation is set here like this, it overrides validation which has already been setup with a simple '*' rule for the size based on PHP.

If you've defined in the sites yml config something like

    SilverStripe\Assets\Upload_Validator:
      default_max_file_size:
        '[image]': '2m'
        '*' : '1m'

then it will not be respected.

If you review SilverStripe\Assets\Upload_Validator and check the getAllowedMaxFileSize method, you'll see the sizing will be populated (if it hasn't been done before).

You can see it fail by;
- Setup a new SilverStripe site.
- Set your PHP to allow max post / max upload size of 10mb.
- Add the above config to your sites yml file and flush.
- In the CMS you'll be able to upload a 5MB file, when you shouldn't.

* Test that FileField will use size validation if defined

Couple of tests which prove a fix so the FileField and others will use the default_max_file_size setting

* Fix variable name in last commit

This is what happens when you refactor in the github window.
Fix the variable names. This will get squashed once merged.

* Updates the pr - white space and non deprecated method for byte conversion

Remove extra white space to appease the CS. Use the non deprecated method for memstring2bytes

* White space fixes for the phpcs

White space fixes for the phpcs

* Ensure that "memstring2bytes" can handle if an empty or value with no number is passed in

* DEP Bump assets constraint to ensure that change is also pulled in

---------

Co-authored-by: Guy Sartorelli <guy.sartorelli@silverstripe.com>
 2024-01-08 15:49:41 +13:00
Finlay Metcalfe
2487c4085d
ENH Create Requirements::customScriptWithAttributes (#11076) 
* ENH Create Requirements::customScriptWithAttributes

* MNT PHP Lint failures corrected

* ENH Refactored attribute handling to avoid API changes, auto lowercase, strong typing

* FIX Updated default value handling for type in customScriptWithAttributes

* DOC Removed white space

* MNT PHP Lint Failures Corrected

* Update src/View/Requirements_Backend.php

Co-authored-by: Steve Boyd <emteknetnz@gmail.com>

* Update src/View/Requirements_Backend.php

Co-authored-by: Steve Boyd <emteknetnz@gmail.com>

* Update tests/php/View/RequirementsTest.php

Co-authored-by: Steve Boyd <emteknetnz@gmail.com>

* FIX Removed extra closing brace in customScriptWithAttributes

* Update src/View/Requirements_Backend.php

Co-authored-by: Steve Boyd <emteknetnz@gmail.com>

* Update src/View/Requirements.php

Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>

* MNT Fixed left over content definition and created tests for uniquenessIDs

* MNT Fixed PHP Lint Error

* MNT Fix PHP Lint Error

* FIX Remove attribute when calling customScript with the same uniquenessID

---------

Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
 2023-12-22 12:00:33 +13:00
Guy Sartorelli
bf629dfabd
ENH Split sentences by configurable punctuation for summary 
Co-authored-by: Lukas Erni <le@kraftausdruck.ch>
 2023-12-20 15:08:01 +13:00
Guy Sartorelli
7dc1a7a12b
FIX Correctly mark ConfirmedPasswordField children as required 2023-12-20 12:35:30 +13:00
Maxime Rainville
6c69d32367
Merge pull request #11049 from creative-commoners/pulls/5/gridfield-with-viewabledata 
Make GridField components work with ViewableData where possible
 2023-12-19 19:55:29 +13:00
Guy Sartorelli
e7775a6133
Merge pull request #11071 from creative-commoners/pulls/5/foreign-key-field-scaffold 
ENH Use SearchableDropdownField for autoscaffolded has_one relationships
 2023-12-19 10:42:12 +13:00
Steve Boyd
e66c1aec06 ENH Use SearchableDropdownField for autoscaffolded has_one relationships 2023-12-19 10:04:01 +13:00
Guy Sartorelli
c96f37ea93
Merge branch '5.1' into 5 2023-12-18 15:20:02 +13:00
Guy Sartorelli
3d64eac129
NEW Make most GridField components work with arbitrary data 2023-12-18 12:41:42 +13:00
Guy Sartorelli
ad8cf9902c
Merge pull request #11093 from creative-commoners/pulls/5.1/docblock 
MNT Update @methods on class docblocks
 2023-12-15 12:38:38 +13:00
Guy Sartorelli
3acd6d3147
Merge pull request #11091 from edwilde/patch-16 
Remove unused lines in `findTab()`
 2023-12-15 10:36:45 +13:00
Guy Sartorelli
dd3a0dba24
FIX Don't break the page if password recover email fails to send 2023-12-15 09:05:18 +13:00
Steve Boyd
23eca53dfb NEW SearchableDropdownField 2023-12-14 15:28:19 +13:00
Guy Sartorelli
446810bc5e
FIX Allow new password to save even if there's an error sending email 2023-12-14 12:47:05 +13:00
Steve Boyd
db69a1f83c MNT Update @methods on class docblocks 2023-12-14 11:04:08 +13:00
Ed Wilde
b6c646ffbe
Also remove the unused $last_idx assignment 2023-12-13 10:42:06 +13:00
Ed Wilde
81541db892
Remove unused line in findTab() 
This line doesn't appear to be of any use
 2023-12-13 10:28:03 +13:00
Guy Sartorelli
ff38ff1d63
Merge pull request #11073 from creative-commoners/pulls/5/limit-int 
API Use correct param types
 2023-12-12 10:55:59 +13:00
Guy Sartorelli
c405ed6cf3
NEW Allow a single has_one to manage multiple reciprocal has_many (#11084) 2023-12-12 10:18:25 +13:00
Guy Sartorelli
5838772b19
ENH Explicitly require DataObject for some gridfield components 
These components simply cannot work with non-DataObjects. They have
explicit DataObject queries, and allowing arbitrary callbacks for these
components would be a case of diminishing returns.
 2023-12-11 12:34:00 +13:00
Guy Sartorelli
b1295af281
NEW Provide an easy way to filter arbitrary ViewableData in gridfields 2023-12-11 12:33:56 +13:00
github-actions
c890d79ea9 Merge branch '5.1' into 5 2023-12-09 14:24:25 +00:00
github-actions
bf45b0c44b Merge branch '4' into 5.1 2023-12-09 14:24:24 +00:00
Steve Boyd
3fe42b84af API Use correct param types 2023-12-08 16:50:34 +13:00
Loz Calver
40b888eaf3 FIX: UnsavedRelationList::last() sometimes returned an ID instead of an item 2023-12-04 11:44:34 +00:00
Loz Calver
e28af9a5a7 FIX: UnsavedRelationList first/last to return null if list is empty (fixes #11083) 2023-12-04 11:32:08 +00:00
github-actions
809f9e7ae0 Merge branch '5.1' into 5 2023-11-29 22:52:10 +00:00
Guy Sartorelli
eb245a1f83
Merge branch '4' into 5.1 2023-11-30 11:51:36 +13:00
Guy Sartorelli
6d903848ab
FIX Don't replace config manifest for nested kernels (#11082) 2023-11-30 11:39:14 +13:00
github-actions
c63dca37a8 Merge branch '5.1' into 5 2023-11-28 02:04:54 +00:00
github-actions
4f0dfe8657 Merge branch '4' into 5.1 2023-11-28 02:04:52 +00:00
Steve Boyd
4dbbf04ba5 FIX Add extraEmptyValues to TreedropdownField 2023-11-27 12:42:28 +13:00
github-actions
1347fcd563 Merge branch '5.1' into 5 2023-11-25 14:24:28 +00:00
github-actions
6f6b2650ec Merge branch '4' into 5.1 2023-11-25 14:24:26 +00:00
Steve Boyd
fdb329913c ENH Throw exception when no react component 2023-11-22 14:17:47 +13:00
Guy Sartorelli
7eab49f850
FIX Ensure environment is checked before enabling deprecations (#11055) 2023-11-22 09:30:08 +13:00
Guy Sartorelli
bc47d65cc5
DEP Deprecate configurable silent failures in GridField components 2023-11-20 16:50:32 +13:00
github-actions
cfd8f05a04 Merge branch '5.1' into 5 2023-11-18 14:24:16 +00:00
github-actions
1ae7e9262d Merge branch '4' into 5.1 2023-11-18 14:24:15 +00:00
Guy Sartorelli
05f1d9ab86
FIX Make deprecation enabled check faster 2023-11-17 10:41:02 +13:00
github-actions
f22282acb2 Merge branch '5.1' into 5 2023-11-13 04:42:01 +00:00
github-actions
fe9b7699a2 Merge branch '4' into 5.1 2023-11-13 04:42:00 +00:00
Guy Sartorelli
a1eee2a9ef
Merge pull request #10979 from andrewandante/ENH_add_buildtask_permissions 
Add buildtask and dev URL permissions
 2023-11-10 13:20:06 +13:00
Andrew Paxley
b9da08a301 Update task-not-found messaging 2023-11-10 09:40:16 +13:00
Andrew Paxley
c77a77d584 Flip canView logic and combine into taskEnabled check 2023-11-09 20:22:59 +13:00
Sabina Talipova
d883719c16 FIX ModelAdmin toast elements 2023-11-09 09:39:52 +13:00
Andrew Paxley
b9b891d050 ENH handle sub-urls 2023-11-03 17:10:08 +13:00
Andrew Paxley
5d4327b238 ENH replace permission checks with canView check on TestDBTask 2023-11-03 09:19:29 +13:00
github-actions
cb520db8b7 Merge branch '5.1' into 5 2023-11-01 20:14:50 +00:00
Andrew Paxley
78444a44ca ENH add DevAdminConfirmationMiddleware 2023-10-31 17:35:55 +13:00
Guy Sartorelli
0887170115
Merge pull request #11032 from creative-commoners/pulls/5.1/remove-todo 
MNT Remove TODO comments
 2023-10-31 10:11:27 +13:00
Sabina Talipova
56511c8618 MNT Remove TODO comments 2023-10-30 13:21:09 +13:00
github-actions
0556dfe45f Merge branch '5.1' into 5 2023-10-28 14:23:52 +00:00
github-actions
9a497f54d7 Merge branch '4' into 5.1 2023-10-28 14:23:50 +00:00
Andrew Paxley
3244b44a54 ENH add permissions for build tasks 
ENH add granular dev url permissions
 2023-10-27 12:34:25 +13:00
Bernie Hamlin
e5eb98cc34 Use field editorconfig when sanitising content 2023-10-25 12:08:46 +13:00
Steve Boyd
159112ca8b NEW Generate a random password if a blank password is entered 2023-10-20 11:37:25 +13:00
Andrew Paxley
a0cbebb2d1 ENH allow stacked messages on FormMessage 2023-10-09 11:12:03 +13:00
Guy Sartorelli
44b170098e
NEW Add ORM abstraction for "WITH" clauses (#10943) 2023-10-02 15:25:14 +13:00
github-actions
11c0198b9d Merge branch '5.1' into 5 2023-09-30 14:24:05 +00:00
github-actions
cf78a9d785 Merge branch '5.0' into 5.1 2023-09-30 14:24:03 +00:00
github-actions
3d60e1e77e Merge branch '4' into 5.0 2023-09-30 14:24:00 +00:00
Guy Sartorelli
7d5c62ed5f
NEW Add rightJoin method to DataList (#10961) 2023-09-27 15:24:32 +13:00
Guy Sartorelli
55e42683f8
FIX Match multi-line JOIN statements (#10960) 2023-09-26 10:30:55 +13:00
Guy Sartorelli
7bb72eb7c5
FIX Ensure all fixed fields are added 2023-09-25 15:35:34 +13:00
Guy Sartorelli
76da701b6b
NEW Add sql UNION abstraction 2023-09-25 12:33:30 +13:00
Guy Sartorelli
fac3356739
ENH Enable allowing collisions for field statements (#10957) 2023-09-25 12:32:40 +13:00