Andre Kiste
460715197d
Merge pull request #9190 from open-sausages/pulls/4/test-state
...
Don't include default value in url grid state
2020-11-18 12:31:50 +13:00
Steve Boyd
ad839fdd6e
Merge branch '4.6' into 4.7
2020-11-16 12:10:48 +13:00
Steve Boyd
0e064300d9
ENH Add disabled attribute to SelectionGroup
2020-10-22 21:15:50 +13:00
Serge Latyntcev
58ed426653
FIX TinyMCEConfig image size presets handle incorrect values
2020-10-12 17:31:59 +13:00
Serge Latyntcev
034bace213
FIX TinyMCEConfig image size presets handle incorrect values
2020-10-12 16:54:29 +13:00
Robbie Averill
27bd5d12e3
ENH Replace E_USER_ERROR errors with exceptions
2020-09-24 23:51:21 -07:00
Dan Hensby
ae0ece2b02
Merge pull request #9665 from creative-commoners/pulls/4/php8-fqcn-token
2020-09-18 20:44:22 +01:00
Sam Minnee
b3dd27953b
NEW: Allow league/csv ^9
...
Hopefully this has better PHP 8 support.
2020-09-15 17:40:42 +12:00
Steve Boyd
015ea8cfc8
Merge branch '4.6' into 4
2020-09-11 11:54:23 +12:00
Damian Mooyman
ac6f34846e
BUG Resolve issue where TreeMultiSelectField would error loading its value ( #9604 )
...
* BUG Resolve issue with TreeMultiSelectField not retaining value in some situations
E.g. in an elemental form
2020-09-11 11:52:36 +12:00
Maxime Rainville
5226d961e8
Fix unit test
2020-08-18 10:29:57 +12:00
Maxime Rainville
a43414dedb
Make sure GridState always outputs a JSON Object string
2020-08-17 23:23:42 +12:00
Maxime Rainville
70ffb3297a
API Only include gridfield state value that differ from the expected default
2020-08-17 12:11:56 +12:00
Steve Boyd
8287fad24d
Merge branch '4.6' into 4
2020-07-29 11:38:49 +12:00
Nicolaas
f264ff8616
PATCH: improving @return values in docblocks
2020-07-23 22:40:14 +12:00
Martin Heise
404f450ac3
BUG Readonly version of GroupedDropdownField
...
GroupedDropdownField was showing empty values in Readonly mode due to not correctly handling the hierarchical source array.
Uses flattened source now in GroupedDropdownField->performReadonlyTransformation()
2020-07-21 09:23:30 +02:00
Robbie Averill
84b4057a9a
Merge pull request #9406 from chrispenny/feature/standardise-get-cms-validator
...
v4 improvement: Standardise getCMSValidator for DataObjects/Forms
2020-07-16 15:58:33 -07:00
Ingo Schommer
8d6a248431
Merge remote-tracking branch 'origin/4.6' into 4
2020-07-11 09:07:39 +12:00
Ingo Schommer
1f0a78e57b
FIX More context for GridFieldDataColumns callbacks
...
This emulates the callback signature from
GridFieldEditableColumns in the symbiote/silverstripe-gridfieldextensions module, which extends GridFieldDataColumns. In case canEdit() fails, this component passes control back to the parent (rendering a standard column content rather than a formfield). Which can become an issue if you've defined custom 'callback' handlers on setDisplayFields() - GridFieldDataColumns passes in only one arg (`$record`), while GridFieldEditableColumns passes in three (`$record`, `$col` and `$grid`).
While you could argue that this is a bug in the other module,
I think this additional context is beneficial for the main
GridFieldDataColumns use case as well, and it just happens to fix that bug.
2020-07-09 09:33:21 +12:00
Tom Yrjas
00ee8d8abf
BUGFIX: Re-declare $items to be an ArrayList if it's null
...
getBackLink() modified to tolerate empty ArrayList
2020-06-29 16:07:24 +03:00
Tom Yrjas
824b5e0b67
BUGFIX: Ensure $items isn't null in GridFieldDetailForm_ItemRequest->Breadcrumbs() prior to performing operations on it.
2020-06-29 14:13:49 +03:00
Guy Marriott
1a6e2da995
Merge pull request #9543 from jakxnz/pulls/4.6/undeclared-private-statics
2020-06-15 23:16:57 -07:00
Jackson Darlow
dadac00c19
Added array declaration to GridFieldDetailForm_ItemRequest::$formActions
...
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-06-15 11:45:33 +12:00
Steve Boyd
7d87ba72d5
Merge branch '4.6' into 4
2020-06-12 11:20:53 +12:00
Steve Boyd
4daccfab67
Merge branch '4.5' into 4.6
2020-06-12 11:20:13 +12:00
Jackson Darlow
84235c6518
Adjusted missing definitions to only include definitions referenced by framework
2020-06-11 14:28:47 +12:00
Christopher Darling
4303917ac5
DOCS Form::loadDataFrom constants in docblock
...
... missing MERGE_ prefix as defined in this class
2020-05-28 16:40:12 +01:00
Adrian Humphreys
d320026375
Remove recursive write until its fixed
2020-05-28 14:34:55 +12:00
cpenny
d4165db690
Update getter name to getCMSCompositeValidator
2020-05-28 12:23:35 +12:00
cpenny
8ba65313e9
Add internal note for protected method
2020-05-28 11:18:46 +12:00
cpenny
bca4be77ed
Update name to CompositeValidator. Add docblocks
2020-05-28 11:18:46 +12:00
cpenny
a2b57f0801
Update DefaultFormFactory extension point. Use array for validators
2020-05-28 11:18:46 +12:00
cpenny
b45a3561df
Implemented PR feedback. Added some initial test cov
2020-05-28 11:18:46 +12:00
cpenny
d7dd93f7a7
Standardise getCMSValidator for DataObjects/Forms
2020-05-28 11:18:46 +12:00
Daniel Hensby
080ce157ce
Fix various typos in comments
2020-05-16 10:34:53 +01:00
Michal Kleiner
21129b1624
Use short array syntax across the framework's codebase
2020-05-16 10:34:45 +01:00
Matt Clegg
153e2383e6
DOCS: Minor typo
2020-05-10 08:01:10 +05:45
Andre Kiste
3a424747df
Merge pull request #9332 from shoosah/feature/add-error-message-into-field
...
Allow to add error message into a specific field
2020-05-01 15:46:29 +12:00
Andre Kiste
ec51f98adb
Merge pull request #8870 from jinjie/4
...
Fix: Allow editing of relation if item is created.
2020-05-01 15:37:52 +12:00
Daniel Hensby
42cee6f5fb
Merge pull request #9489 from mattclegg/1587548067
...
DOCS: Fix typos
2020-04-22 12:28:02 +01:00
mattclegg
d521a52a33
DOCS: Fix typos
2020-04-22 15:20:11 +05:45
Daniel Hensby
237b2d5f74
Convert array delcarations to short array syntax
2020-04-20 18:58:09 +01:00
Serge Latyntcev
cb36aab80c
Merge branch '4.5' into 4
2020-04-15 14:49:19 +12:00
mattclegg
5585f6633f
DOCS: Update typos
2020-04-14 15:00:08 +05:45
Robbie Averill
f77f725355
Merge pull request #9447 from mattclegg/docs__GridFieldDetailForm_ItemRequest-httpError
...
[DOCS] Better debug text for errors generated by GridFieldDetailForm_ItemRequest
2020-04-02 13:05:49 -07:00
Robbie Averill
d3b19069b3
Apply suggestions from code review
...
Add double quotes around object title
2020-04-02 12:51:13 -07:00
Dan Hensby
d1075f29b8
Remove empty parameter as per feedback
2020-04-02 12:11:35 +01:00
Dan Hensby
9e0ed0a50a
Fix spaces around concatenation operator
2020-04-02 12:09:22 +01:00
mattclegg
24bc80ed35
[DOCS] Better debug text for errors generated by GridFieldDetailForm_ItemRequest
2020-03-31 12:09:16 +05:45
Ramon Lapenta
9c7eac481e
Add "option" to list elements that belong to "listbox"
...
The accessibility attribute `role="listbox"` requires its immediate children to be set as `role="option"`, currently they don't have this option and accessibility tests are failing.
2020-03-10 11:10:04 -06:00
