Commit Graph

18794 Commits

Author SHA1 Message Date
Simon Erkelens
3e97b99e22 [BUG] Fix issues with multiple authenticators for a single task (#7149)
Using multiple 2FA authenticators, logging out, resetting password etc. proved to be handled wrong.
Example scenario:
The result is an error, because the `renderWrappedController` was called, despite the responses being a set of either array with Content or Form, or a redirect action.

The default action should be followed and not try to render if there is nothing to render

Because the logout (or changepassword, or resetpassword, etc.) has already been handled, the first response is the default authenticator's response. This _could_ be a form (in case of logout without valid token), a content set (reset password) or a form (change password).

This edge case only happens when there are multiple authenticators supporting the requested method that is _not_ login.
2017-07-14 09:20:58 +12:00
Robbie Averill
b16896f22b FIX Ignore exceptions thrown when deleting test databases
This will prevent long runnings builds (e.g. code coverage) from failing when the test database connection is gone (MySQL server has gone away) by the time the shutdown handler runs.
2017-07-13 23:33:51 +12:00
Robbie Averill
823e49526f NEW Allow SSViewer and SSViewer_FromString to be injectable 2017-07-13 20:48:58 +12:00
Christopher Joe
ccda816f90 API added flatList argument for generating the json tree list with a context string property 2017-07-13 17:04:35 +12:00
Chris Joe
243304c633 Merge pull request #7168 from open-sausages/pulls/4.0/chain-out-there
BUG Fix registered shutdown function not handling responsibility for outputting redirection response
2017-07-13 16:10:57 +12:00
Damian Mooyman
5fcd7d084f
BUG Fix registered shutdown function not handling responsibility for outputting redirection response 2017-07-13 15:32:39 +12:00
Chris Joe
10f93b71ae Merge pull request #7166 from open-sausages/pulls/4.0/fix-modules
BUG Incorrect module delimited
2017-07-13 15:04:00 +12:00
Aaron Carlino
16b66440c2 BUG: Incorrect module delimiter 2017-07-13 13:15:01 +12:00
Damian Mooyman
4898c0a4ad
BUG Incorrect module delimited 2017-07-13 12:15:12 +12:00
Aaron Carlino
2b266276c2 API Implement new module sorting pattern 2017-07-13 10:27:27 +12:00
Chris Joe
695e0483aa Merge pull request #7143 from open-sausages/pulls/4.0/test-docs
Update sapphiretest docs
2017-07-12 17:00:30 +12:00
Robbie Averill
48d9088ab4 Separate composer.lock load method and add test mocking it 2017-07-11 12:22:25 +12:00
Damian Mooyman
10fd7813ed Merge pull request #7153 from kinglozzer/file-ini2bytes
Fix: Make File::ini2bytes() compliant with binary prefixes (fixes #7145)
2017-07-11 11:29:05 +12:00
Daniel Hensby
b2831b809c Merge pull request #7133 from kinglozzer/cache-classname
Cache ClassInfo::class_name() calls
2017-07-10 13:23:45 +01:00
Loz Calver
960a0f8343
Fix: Make File::ini2bytes() compliant with binary prefixes (fixes #7145) 2017-07-10 09:41:36 +01:00
Roman Schmid
a6db16b229 Fix OS X issue with Convert::html2raw, HTMLText::FirstSentence, HTMLText::Summary and Text::FirstSentence.
Use unicode modifier for regular expressions that deal with whitespace.
Added unit-tests to ensure no invalud utf-8 gets generated by these methods.
2017-07-10 09:49:55 +02:00
Robbie Averill
ee0bd1a541 DOCS Update requirements and error handling, fix typos and markdown rendering bugs 2017-07-10 11:00:25 +12:00
Robbie Averill
a7bf0e49ec DOCS Fix typos and formatting in middleware documentation 2017-07-10 10:19:17 +12:00
Damian Mooyman
7032c4a478
Update sapphiretest docs 2017-07-07 10:45:39 +12:00
Chris Joe
0b09a510f4 Merge pull request #7136 from open-sausages/pulls/4.0/fix-installer-create-admin
BUG Ensure that installer can create an initial admin account
2017-07-07 09:15:41 +12:00
Chris Joe
0f02c67b8c Merge pull request #7112 from open-sausages/feature/form-injector-simplify
Documentation updates for new form injector API
2017-07-06 17:06:56 +12:00
Damian Mooyman
85359ad59e
BUG Ensure that installer can create an initial admin account
Fixes #7124
2017-07-06 13:30:04 +12:00
Loz Calver
e3e16fe835 Cache ClassInfo::class_name() calls 2017-07-05 15:15:08 +01:00
Daniel Hensby
f769d9a13f Merge pull request #7059 from mfendeksilverstripe/3.5
Html editor selection is now properly stored while the dialog is open
2017-07-05 15:03:18 +01:00
Daniel Hensby
aafa054cf7 Merge pull request #7129 from mfendeksilverstripe/master
Limited nodes with too many children are no longer accessible
2017-07-05 12:37:26 +01:00
Daniel Hensby
2c5e237a93
Merge pull request #7103 from dnadesign/fix-numericfield-null 2017-07-05 11:45:45 +01:00
Daniel Hensby
2f551c91d7 Merge pull request #6922 from kinglozzer/debugview-styles
Update DebugView styles
2017-07-05 11:35:04 +01:00
Daniel Hensby
24a7a64c39
Merge pull request #6440 from open-sausages/pulls/4.0/requirements-module-resource-port 2017-07-05 11:31:43 +01:00
Aaron Carlino
2b1587894a
Documentation updates for new form injector API 2017-07-05 11:09:18 +01:00
Loz Calver
713b01ebc7 Update DebugView styles 2017-07-05 09:14:26 +01:00
Damian Mooyman
55dc3724db FIX Invalid composer.json 2017-07-05 16:24:15 +12:00
Christopher Joe
6492b8edae Update composer alias 2017-07-05 16:22:06 +12:00
Aaron Carlino
c836a2e2d2 BUGFIX: Module resource regex does not allow ports 2017-07-05 13:26:30 +12:00
Mojmir Fendek
3f2d217a45 Limited nodes that have more children than allowed limit are no longer accessible to the user. 2017-07-05 11:34:24 +12:00
John Milmine
f14e6bae2c fix numeric field for null values 2017-07-05 07:35:13 +12:00
Daniel Hensby
c472957bd2 Merge pull request #7126 from andrewandante/patch-1
FIX remove info div to fix formatting
2017-07-04 13:46:18 +01:00
Daniel Hensby
64005bff91 Merge pull request #6440 from open-sausages/pulls/4.0/json-detection
ENHANCEMENT: Debug class emits plain text for application/json requests
2017-07-04 13:42:42 +01:00
Andrew Aitken-Fincham
7812f34a2d remove info div to fix formatting 2017-07-04 12:50:57 +01:00
Robbie Averill
ee4d8b4d4e NEW Add new SilverStripeVersionProvider to provider module versions 2017-07-04 23:29:29 +12:00
Daniel Hensby
9552527904 Merge pull request #7119 from open-sausages/pulls/4.0/fix-i18n
Fix unnamespaced i18n keys
2017-07-04 11:22:58 +01:00
Damian Mooyman
ed26b251c8
ENHANCEMENT: Better output type detection for debugging 2017-07-04 17:33:49 +12:00
Damian Mooyman
4b23205838
Fix unnamespaced i18n keys
Fixes https://github.com/silverstripe/silverstripe-framework/issues/6862
2017-07-04 14:18:47 +12:00
Daniel Hensby
41b8df0ec7
Merge branch '3.6' into 3 2017-07-03 16:44:20 +01:00
Daniel Hensby
5f17c7fb58
Merge branch '3.5' into 3.6 2017-07-03 16:44:06 +01:00
Damian Mooyman
14db11b1cd Added 4.0.0-beta1 changelog 2017-07-03 17:41:25 +12:00
Damian Mooyman
cbe9edc468 Update translations 2017-07-03 17:17:41 +12:00
Damian Mooyman
5ed91970f6 Remove obsolete branch-alias 2017-07-03 16:53:53 +12:00
Chris Joe
1c84daf74a Merge pull request #7109 from open-sausages/pulls/4.0/update-doc-services
Update docs for new service aliases
2017-07-03 16:39:36 +12:00
Damian Mooyman
6f24a16dcd Update docs for new service aliases 2017-07-03 16:04:30 +12:00
Chris Joe
74e52332ad Merge pull request #7106 from open-sausages/pulls/4.0/upgrader-tweaks
BUG Implement or exclude all pending upgrader deltas
2017-07-03 16:03:54 +12:00