Sean Harvey
4a3070757b
MINOR Fixed tests
2012-04-17 10:53:40 +12:00
Robert Curry
5686392a67
BUGFIX: Fixes #7071 . Change gridfield tests to not assume ids are always
...
in order of addition.
2012-04-16 15:47:35 +12:00
Ingo Schommer
d57e864110
MINOR Fixed tests related to i18nLegacyAdapter changes
2012-04-15 18:46:02 +02:00
Ingo Schommer
cbcee57496
ENHANCEMENT New i18nTextCollector_Writer_RailsYaml
2012-04-15 18:08:59 +02:00
Ingo Schommer
fca2c205b7
API CHANGE Removed $priority arguments from _t(), use module priorities instead.
...
ENHANCEMENT Refactored i18nTextCollector collection logic alongside $priority removal, from regex to (slightly more maintainable) PHP tokenizer. Using var_export() for generating PHP, which auto-escapes strings more robustly.
ENHANCEMENT Refactored i18nTextCollector into pluggable writers (in preparation of new YML output format)
2012-04-15 17:17:17 +02:00
Ingo Schommer
d44f6b3e1f
MINOR Removed deprecated usage of $priority argument in _t() calls
2012-04-15 17:17:17 +02:00
Ingo Schommer
bd23a07bba
API CHANGE Using Zend_Translate with YAML translation files, replacing the $lang global and PHP files in the /lang folders.
2012-04-15 17:17:15 +02:00
Ingo Schommer
0a0be63ee2
ENHANCEMENT Added $exclusive flag to SS_ClassLoader->pushManifest() to allow for multiple manifests co-existing (useful for tests which rely on core classes but also want to test their own manifests)
2012-04-15 17:17:15 +02:00
Sean Harvey
8949dfa691
ENHANCEMENT Replaced locations of sapphire with $ModulePath(framework) in templates, based off Controller which implements TemplateGlobalProvider
2012-04-15 10:50:20 +12:00
Sean Harvey
01e0ce7b24
MINOR Ensure assertions of RequirementsTest use "framework" as the
...
FRAMEWORK_DIR, otherwise assertions of require() calls in
RequirementsTest_Conditionals template fail
2012-04-15 10:50:20 +12:00
Sean Harvey
c45027d247
MINOR Fix tests to check against dynamic FRAMEWORK_DIR and $project
...
instead of hardcoding these checks
2012-04-15 10:50:20 +12:00
Simon Welsh
f07258f3cf
MINOR Update @package values to match renaming sapphire
2012-04-15 10:50:19 +12:00
Simon Welsh
3a6341a251
API-CHANGE sapphire folder can now be renamed.
2012-04-15 10:50:19 +12:00
Simon Welsh
f8082e4814
MINOR Add newline to end of files without one
2012-04-15 10:50:19 +12:00
Will Rossiter
07d2d5273a
ENHANCEMENT: populate FormField:: on the fly based on class name of field rather than requiring explict definition.
2012-04-14 17:36:19 +12:00
Will Rossiter
907568b182
ENHANCEMENT: move hard coded template HTML for composite field and field group out to separate template files.
2012-04-14 17:36:08 +12:00
Ingo Schommer
8ba9c3ca6b
API CHANGE Removed $params argument to DataObject->getCMSFields(), please use FormScaffolder directly ( fixes #7135 )
2012-04-13 15:46:47 +02:00
Hamish Friedlander
521742aaf8
ENHANCEMENT: Split arguments passed to SSViewer into underlay and overlay arguments to control precedence. Also fixes breakage of SecurityAdmin
2012-04-13 12:15:34 +12:00
Sean Harvey
b52c6b4f2b
MINOR Testing extended dates (very far in the past and future) in
...
DateTest
2012-04-12 16:38:35 +12:00
Sam Minnée
d766100335
Merge pull request #304 from halkyon/e_strict_fixes
...
Enable E_STRICT by default for development, fix all E_STRICT errors affected by tests.
2012-04-11 17:54:18 -07:00
Sean Harvey
3c70ea4922
MINOR Fixing broken test MemberDatetimeOptionsetFieldTest, passing in null for $validator argument
2012-04-12 12:20:18 +12:00
Sam Minnée
1189322b41
Merge pull request #302 from robert-h-curry/7113-nested-controls-breaking-last
...
BUGFIX: Issue #7113 : Recalculate itemIteratorCount when popping viewer state.
2012-04-11 17:19:46 -07:00
Robert Curry
695ae711e7
MINOR: Issue #7113 : Add test for nested loops.
2012-04-12 11:56:49 +12:00
Sam Minnée
168eaf72d8
Merge pull request #300 from silverstripe-scienceninjas/feature/ssviewer-enhancements
...
Feature/ssviewer enhancements
2012-04-11 16:29:22 -07:00
Ingo Schommer
e045ffeb29
Merge pull request #205 from AngryPHPNerd/sapphire
...
---
In SS-2.4 you can prefix files with an underscore to exclude them from manifest this can be useful for backups of old classes or huge data files.
I think this behaviour should be readded.
(I will add a unit test for this ...)
2012-04-11 17:32:34 +02:00
Ingo Schommer
6cd91ff449
Merge pull request #299 from ajoneil/sapphire
...
---
Conflicts:
forms/NumericField.php
2012-04-11 15:36:35 +02:00
Ingo Schommer
800d5fbc01
Merge pull request #291 from halkyon/pg_fixes
...
MINOR Fixed failing tests on pgsql
2012-04-11 06:14:57 -07:00
Hamish Friedlander
e4a043ac0b
ENHANCEMENT: Allow arguments to be passed to templates via an array passed to SSViewer#process and via keyword=value pairs in the <% include %> tag
2012-04-11 21:34:27 +12:00
Andrew O'Neil
bdb312c665
API CHANGE: DBField::hasValue() conflicts with ViewableData::hasValue(), use DBField::exists() instead.
2012-04-11 14:48:06 +12:00
Sean Harvey
6c9a3ba9f0
MINOR Fixed failing tests on pgsql
2012-04-10 17:07:41 +12:00
Stig Lindqvist
0d031a5045
API CHANGE Use Config for registering default password encryptors
...
Using the config system for registering password encryptors
Remove the eval on password encryptor construction by using reflection
Throws deprecation messages when using static register / unregister
2012-04-07 19:14:00 +12:00
Sam Minnee
e01b0aa3d0
ENHANCEMENT PjaxResponseNegotiator for more structured partial ajax refreshes, applied in CMS and GridField. Also fixes issues with history.pushState() and pseudo-redirects on form submissions (e.g. from page/add to page/edit/show/<new-record-id>)
2012-04-05 23:00:22 +02:00
Ingo Schommer
a44b67bae2
API CHANGE Moved RequestHandler->isAjax() to SS_HTTPRequest->isAjax()
2012-04-05 23:00:22 +02:00
Ingo Schommer
40d73127ae
MINOR Using late static binding instead of Object::create() calls
2012-04-04 17:10:31 +02:00
Ingo Schommer
6517f4496b
Merge pull request #273 from ajoneil/sapphire
...
---
This allows DataList::create(SiteTree) as equivalent to Object::create(DataList, SiteTree), without
having to have a create() function on DataList.
Required for E_STRICT compliance, as child classes cant override create() if they change the arguments.
DBField::create() is also renamed to DBField::create_field(), as this does not just call the constructor, which all other cases of create() do.
Conflicts:
tests/model/DateTest.php
tests/model/DatetimeTest.php
2012-04-04 16:48:16 +02:00
Sean Harvey
db65704639
MINOR Removed PHP 5.2 check in DateTest
2012-04-03 09:54:55 +12:00
Sean Harvey
8ae474b182
API CHANGE Remove use of Services_JSON and replace with json_encode() and json_decode()
...
API CHANGE Convert::json2array() will convert nested JSON structures to array as well for easier traversal, instead of array with nested objects.
2012-03-31 13:17:36 +13:00
Ingo Schommer
d0d23dc591
Merge pull request #271 from halkyon/group_changes
...
BUGFIX Nested Group records should be removed, along with the parent.
2012-03-28 02:52:52 -07:00
Sean Harvey
bd95bcaf61
BUGFIX Nested Group records should be removed, along with the parent.
2012-03-28 22:49:58 +13:00
Ingo Schommer
f0ee711f52
Merge pull request #275 from halkyon/e_strict_support
...
First round of fixes for E_STRICT compliance
2012-03-28 02:42:26 -07:00
Sean Harvey
e097f6e1a8
MINOR Fixes to method arguments in core classes for E_STRICT support.
...
API CHANGE Remove abstract static function and just use static functions
in Authenticator (PHP 5.3+ doesn't support abstract static functions)
2012-03-28 22:41:42 +13:00
Ingo Schommer
f81ad47239
Merge pull request #272 from halkyon/date_fixes
...
DateField::setValue() with dmyfields sets erroneous date in valueObj
2012-03-28 02:38:03 -07:00
Fred Condo
5954774530
BUGFIX: Use UTC consistently across all tests for date/time calculations
...
This ensures that tests will not pass or fail based on whether the test
machine is on NZ time.
This partially reverts df050eda5d
, which has
already been merged. Instead of finding tests that use date calculations, we
are now setting the default time zone in SapphireTest so it will apply to the
whole test suite and any future tests.
Adjust expected values in certain tests for UTC, where the expected values had
previously been expressed in NZ time.
When creating a temp DB for test fixtures, create the DB connection with
timezone UTC.
2012-03-27 10:29:07 -07:00
Fred Condo
82bb12b5d3
MINOR: Explicitly declare $adapter in DbDatetimeTest
2012-03-27 10:28:10 -07:00
Andrew O'Neil
1a36f92bb9
MINOR: Fix tests on PHPUnit 3.4
2012-03-27 15:38:36 +02:00
Andrew O'Neil
de2832e65f
ENHANCEMENT: Allow Object::create() to be called with late static binding.
...
This allows DataList::create('SiteTree') as equivalent to Object::create('DataList', 'SiteTree'), without
having to have a create() function on DataList. Required for E_STRICT compliance.
2012-03-27 17:57:42 +13:00
Sean Harvey
c02b4418bb
BUGFIX Using DateField "dmyfields" option, if you set empty
...
day/month/year values, valueObj on DateField will contain erroneous values.
Check that all the value inputs aren't null or empty values BEFORE
calling Zend_Date on the value.
2012-03-27 14:46:09 +13:00
Sam Minnee
2576944a45
API CHANGE: Added DataObject::relField(), which pushes the "relation dot syntax" code of TableListField/GridField back to the model.
...
BUGFIX: Made DataObject::relObject() more flexible; allowable thanks to new ORM.
2012-03-24 14:04:08 +13:00
Nicolaas
dee3939cf7
BUGFIX: Fix the broken perform readonly transformation which was always showing NO ( #6453 )
2012-03-24 13:35:19 +13:00
Sean Harvey
02c8019bb8
ENHANCEMENT Introduce Database::prepStringForDB(), used by
...
DBField::prepValueForDB() and StringField::prepValueForDB() to ensure
the field value is escaped correctly for the database. This means
databases like MSSQL can introduce an "N" prefix (marking text as
unicode to be saved correctly) by overloading the
prepStringForDB method. MySQL, PostgreSQL and SQLite3
operate as usual.
2012-03-20 21:20:35 +13:00
Sean Harvey
9b0009643a
MINOR Added tests for SS_Map testing value method instead of value field
2012-03-15 17:42:42 +13:00
Ingo Schommer
71c026c75a
MINOR Removed SiteTree dependency from SSViewerTest ( fixes #6907 )
2012-03-14 16:11:23 +01:00
Andrew O'Neil
6db08cbc36
MINOR: Fix tests on PHPUnit 3.4
2012-03-14 16:05:19 +13:00
AngryPHPNerd
42f8d9f77a
- Readded check for _config.php in ClassManifest.
...
- Added UnitTest for files with underscore prefix.
2012-03-13 23:38:34 +01:00
Ingo Schommer
73efe8522b
MINOR Fixed hardcoded fixture IDs in GridFieldDetailFormTest
2012-03-12 11:15:06 +01:00
Sam Minnee
7de5bf55e0
API CHANGE: Updated throwExceptionOnBadDataType setter to be standard setThrowExceptionOnBadDataType(), added getThrowExceptionOnBadDataType().
2012-03-10 14:44:12 +13:00
Sam Minnee
f670576cad
MINOR: Fix test to rely less on known test data keys (breaks SQLite)
2012-03-10 14:42:25 +13:00
Fred Condo
df050eda5d
BUGFIX: Correct testSetNullAndZeroValues() of DatetimeTest
...
- Code was assuming NZ time zone
- Set the default timezone to UTC for the test
- Correct the expected times for the epoch from noon to 00:00:00 UTC
2012-03-09 15:41:11 -08:00
Fred Condo
6e6890f689
Clarify failure messages to distinguish string and numeric zero tests
2012-03-09 15:41:11 -08:00
Ingo Schommer
4e1c8bdb32
Merge branch 'fieldlist-fortemplate' of https://github.com/sminnee/sapphire
...
Conflicts:
forms/FieldList.php
2012-03-09 17:03:02 +01:00
Sam Minnee
317756d92a
Merge branch 'feature/config' of https://github.com/silverstripe-scienceninjas/sapphire into config
2012-03-09 19:22:34 +13:00
Sam Minnee
d896c7dc03
MINOR: Removed PHP 5.3-only code from SSViewerTest.
2012-03-09 18:32:10 +13:00
Hamish Friedlander
d89544f3f6
MINOR: Disable tests in ObjectStaticTest that break
2012-03-09 18:16:45 +13:00
Hamish Friedlander
bc3f5ac329
BUGFIX: DataObjectTest needs its extensions to use the new static-on-object method to keep the ordering as it expects
2012-03-09 18:16:45 +13:00
Hamish Friedlander
d355cd5baf
ENHANCEMENT: Add config layer - the Config access class itself, and the ConfigManfiest builder which parses in the yaml config files
2012-03-09 18:13:56 +13:00
Sam Minnee
37684837b8
MINOR: Fixed tests to suit GridField and DataList API changes
2012-03-09 18:11:50 +13:00
Sam Minnee
f288575919
MINOR: Removed obsolete test.
2012-03-09 18:11:26 +13:00
Sam Minnée
9302137125
Merge pull request #233 from halkyon/master
...
Fixed regression where PasswordEncryption field not set on Member
2012-03-08 20:49:21 -08:00
Sean Harvey
d28da56e19
BUGFIX Fixed regression where Member::PasswordEncryption field wouldn't be set to the default
2012-03-09 17:29:57 +13:00
Stig Lindqvist
34e7e9a05e
MINOR Fix of GridFieldDefaultConfigTest
2012-03-09 17:07:41 +13:00
Sam Minnee
a55e06f6b5
API CHANGE: Introduce SS_Limitable class for adding to SS_Lists that have limit capability.
...
API CHANGE: Deprecated SS_List::getRange() in favour of SS_Limitable::limit().
API CHANGE: Introduce SS_Limitable::limit($limit, $offset = 0) as the only modern way of specifying limits; deprecate all others.
2012-03-09 17:07:40 +13:00
Sean Harvey
033a1e593a
MINOR Fixed naming of test classes
2012-03-09 16:55:20 +13:00
Sean Harvey
e78419cef1
MINOR Fixed tests for GridFieldToolbarHeaderTest
2012-03-09 16:47:35 +13:00
Sean Harvey
9b4b34c4f9
MINOR Fixed broken tests in GridFieldDetailFormTest
2012-03-09 16:37:25 +13:00
Stig Lindqvist
2ab12affec
Merge pull request #210 from sminnee/form-visiblefields
...
Form::VisibleFields() and FieldList::VisibleFields()
2012-03-08 19:24:25 -08:00
Sam Minnée
f01982a829
Merge pull request #219 from halkyon/master
...
Fixed HtmlEditorField not inserting file/page links correctly due to broken shortcodes
2012-03-08 18:46:03 -08:00
Sam Minnee
ba93028b01
API CHANGE: Added Form::VisibleFields() and FieldList::VisibleFields(), which list everything except hidden fields, to assist with the creation of custom form layouts.
2012-03-09 15:41:42 +13:00
Sean Harvey
0df958f81d
MINOR Fixed tests to use commas as delimiter for shortcodes, also test spaces still work as well
2012-03-09 15:00:03 +13:00
Sam Minnee
a071456837
Merge branch 'master' of github.com:silverstripe/sapphire
...
Conflicts:
tests/forms/gridfield/GridFieldDetailFormTest.php
tests/forms/gridfield/GridFieldPopupFormsTest.yml
2012-03-09 14:37:32 +13:00
Sean Harvey
49267dbbc4
ENHANCEMENT Shortcodes now support commas as delimiter for attributes (thanks aoneil for help with the regex!) (trac #6868 )
...
BUGFIX HtmlEditorField not inserting shortcodes correctly (trac #6868 )
2012-03-09 14:25:42 +13:00
Stig Lindqvist
09d6fa7bb3
API CHANGE Renamed GridFieldDefaultColumns to GridFieldDataColumns #6921
2012-03-09 14:07:40 +13:00
Stig Lindqvist
6d0b0d6788
API CHANGE Removing GridFieldDeleteAction and moved functionality into GridFieldRemoveButton #6921
2012-03-09 13:55:49 +13:00
Stig Lindqvist
8b82dae06c
API CHANGE: Renaming of gridfield components #6921
2012-03-09 12:54:02 +13:00
Ingo Schommer
e5f02337cd
MINOR Testing nested detail forms in GridField
2012-03-09 00:06:14 +01:00
Stig Lindqvist
8b2213d56c
MINOR Added per-record canView, canDelete, canCreate and canEdit checks on gridfield and gridfield components #6890
2012-03-09 10:58:01 +13:00
Ingo Schommer
f9323b398c
BUGFIX Type-safe checks for Controller::join_links(), allowing arguments with a value of "0"
2012-03-08 22:20:37 +01:00
Sam Minnee
5800db0239
API CHANGE: Allow for the creation of custom GridField fragments. ( #6911 )
2012-03-09 10:03:53 +13:00
Ingo Schommer
e4a6dd5850
Merge branch 'integration'
...
Conflicts:
forms/gridfield/GridField.php
2012-03-08 20:25:21 +01:00
Ingo Schommer
ac20bfaf99
MINOR Renamed GridFieldAction_Edit to GridFieldEditAction, GridFieldAction_Delete to GridFieldDeleteAction, to make it clearer that there's no parent class/concept called "GridFieldAction". There's only the GridFieldActionProvider interface, as well as the GridField_FormAction (which is a related, but different kettle of fish).
2012-03-08 18:22:25 +01:00
Normann Lou
d35d7507ff
FEATURE SSF-25 : enable to remove component from a GridFieldConfig.
2012-03-08 20:29:18 +13:00
Sam Minnee
1fd8d19e28
API CHANGE: FormAction::FieldHolder() now returns just the Field(), so that a FieldList::forTemplate() returns a sensible result for an action list.
2012-03-08 10:02:57 +13:00
Sam Minnee
e4dbf8065b
API CHANGE: Added FieldList::forTemplate(), so that by default a FieldList will be rendered in its template as a concatenation of FieldHolder values.
...
API CHANGE: Removed unnecessary HiddenFieldList class.
2012-03-08 10:00:54 +13:00
Ingo Schommer
8690e531a5
MINOR Reverted MemberTest assertion, previously broken by recent ManyManyList and Member foreign key refactoring
2012-03-07 01:23:41 +01:00
Andrew O'Neil
58309cb2ec
MINOR: Tests for add and edit forms of GridField
2012-03-07 10:48:09 +13:00
Ingo Schommer
51bae9e4a6
ENHANCEMENT Allowing to save ManyManyList with multiple foreign keys (e.g. required to add to an overloaded Group->Members() relationship)
2012-03-06 21:38:33 +01:00
Ingo Schommer
1201f6c8bb
BUGFIX Saving records in ListboxField->saveInto() and PermissionCheckboxSetField->saveInto() so we have a database ID to relate to (was previously customised in MemberTableField->saveComplexTableField(), which is now deprecated)
2012-03-06 01:23:34 +01:00
Ingo Schommer
bb6d4c506e
BUGFIX Fixed HasManyList and ManyManyList queries for relationships on new records (was returning all available records due to the SQL filtering ignoring ID=0)
2012-03-06 01:23:34 +01:00
Julian Seidenberg
a715785a42
ENHANCEMENT: SSF-106 adding the ability to turn off and on the "add new" button on the GridFieldTitle
2012-03-06 11:19:46 +13:00
Hamish Friedlander
374ed19406
API CHANGE: Change variable expose method in TemplateGlobalProvider and TemplateIteratorProvider to (a) not clash with each other and, (b) be less generic
2012-03-06 09:31:57 +13:00
Hamish Friedlander
2c65d3a398
BUGFIX: Add casting support to global and iterator variable injection
2012-03-06 09:31:57 +13:00