Sam Minnee
6cec0a083e
BUGFIX: Don't include web.config in the assets tracked in the File table.
...
MINOR: Add documentation to File::$allowed_extensions explaining that there are config files to edit in assets/ (from r112961)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114496 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 00:05:05 +00:00
Jean-Fabien Barrios
5dbddba41b
BUGFIX File upload not working when open_basedir is set #5547
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114471 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-03 00:28:30 +00:00
Ingo Schommer
396f297acb
API CHANGE Using i18n::validate_locale() in various Translatable methods to ensure the locale exists (as defined through i18n::$allowed_locales)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114470 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-03 00:28:24 +00:00
Ingo Schommer
17ac4753fd
BUGFIX Check for valid locale in i18n::set_locale()/set_default_locale()/include_locale_file()/include_by_locale() (as defined in i18n::$allowed_locales). Implicitly sanitizes the data for usage in controllers.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114469 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-03 00:27:41 +00:00
Ingo Schommer
640b504ebe
BUGFIX Don't allow HTML formatting in RequestHandler->httpError() by sending "Content-Type: text/plain" response headers.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114444 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-02 08:03:17 +00:00
Ingo Schommer
07b6d1870a
MINOR Checking for class_exists() before SapphireTest::is_running_tests() to avoid including the whole testing framework, and triggering PHPUnit to run a performance-intensive directory traversal for coverage file blacklists
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114332 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-30 05:13:09 +00:00
Geoff Munn
a5fff6deab
ENHANCEMENT: new schema constant supported, used by Postgres at the moment
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114184 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-25 03:50:11 +00:00
Ingo Schommer
16a80b3808
MINOR: Remove empty legend on search form. It should be description or no tag at all
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114141 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:53 +00:00
Ingo Schommer
41dad508e4
MINOR Documentation in FunctionalTest and TestSession
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114140 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:52 +00:00
Ingo Schommer
eeed9ce189
BUGFIX Don't call LinkTracking/ImageTracking relationships in HTMLEditorField->saveInto() unless we have internal links/files to save. This helps to improve CMS saving times on records with many HTMLEditorField instances
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114139 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:51 +00:00
Ingo Schommer
19f7484144
BUGFIX Don't rely on existence of REQUEST_URI in LogErrorEmailFormatter (not set on CLI calls)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114138 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:51 +00:00
Ingo Schommer
07c821c4a7
ENHANCEMENT Added $argCharLimit to SS_Backtrace::full_func_name(), to avoid printing really long strings its set to 10,000 by default
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114137 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:50 +00:00
Ingo Schommer
7be01d3d10
BUGFIX Fixed saving of files in IE6/IE7 in SS_HTTPRequest::send_file() by adding custom "Cache-Control" HTTP headers
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114136 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:50 +00:00
Ingo Schommer
ab563c1418
MINOR Using built-in ORM methods for GroupTest
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114135 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:49 +00:00
Ingo Schommer
196cabb2f0
MINOR: unique indexes on versioned tables now changed to 'index'
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114134 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:49 +00:00
Ingo Schommer
f1bf0d0fc4
BUGFIX Aborting marking in Hierarchy->markPartialTree() before loading nodes, if the expected node count would exceed the totals (regardless of the in-memory marking state)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114133 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:48 +00:00
Ingo Schommer
3ffa3bfe42
ENHANCEMENT: user-friendly error now present for unwanted upload file types
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114132 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:47 +00:00
Ingo Schommer
b15019a95f
ENHANCEMENT Added SS_HTTPResponse->setStatusDescription() as equivalent to setStatusCode(). Added documentation.
...
BUGFIX Strip newlines and carriage returns from SS_HTTPResponse->getStatusDescription() (fixes #6222 , thanks mattclegg)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114082 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-23 19:38:15 +00:00
Ingo Schommer
3725ab77a0
BUGFIX Removed double quoting of $where parameter in Translatable::get_existing_content_languages() ( fixes #6203 , thanks cloph)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114080 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-23 19:21:44 +00:00
Ingo Schommer
6ccd6d61bd
MINOR Documentation for Aggregate caching
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114077 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-23 05:43:59 +00:00
Sean Harvey
9ac991636e
MINOR Merged r113933,113936-113937 from branches/2.4
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114001 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-22 02:02:11 +00:00
Ingo Schommer
73c6f1fa08
MINOR Removed duplicate b/ directory, regression from r113918
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113992 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-22 00:48:39 +00:00
Saophalkun Ponlu
efda708708
MINOR: Make sure that Translatable creates a translated parent of SiteTree only when the parent is not translated
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113955 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-19 02:49:41 +00:00
Geoff Munn
7d96dcd02b
MINOR: dev/build message fixed to explain changes more clearly
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113931 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-18 23:29:30 +00:00
Ingo Schommer
ab92919b27
ENHANCEMENT Allowing i18nTextCollector to discover entities in templates stored in themes/ directory (thanks nlou)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113918 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-18 19:00:13 +00:00
Ingo Schommer
854cbe79c8
API CHANGE Don't partially URI encode strings in SiteTree->RelativeLink(), rely on XML casting in templates instead ( fixes #6125 , thanks paradigmincarnate)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113694 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-13 02:54:13 +00:00
Ingo Schommer
7700b223a3
MINOR Documentation for MoneyField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113691 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-13 02:05:34 +00:00
Geoff Munn
4215b2f434
ENHANCEMENT: full text search indexes now identified more clearly in dev/build
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113657 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-11 19:06:18 +00:00
Carlos Barberis
bf8afd6cac
MINOR: call jquery-ui from thirdparty folder instead google api (see ticket 5915)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113656 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-11 04:45:31 +00:00
Geoff Munn
ea631824e0
BUGFIX: 'Relevance' column now quoted
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113596 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-10 03:39:02 +00:00
Geoff Munn
92c7419767
BUGFIX: unique versioned indexes are now converted to standard indexes
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113299 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-01 02:58:43 +00:00
Ingo Schommer
46dcd20e34
BUGFIX Add PHPUnit includes to SapphireTest class (can be loaded outside of TestRunner for static calls, in which case the PHPUnit autoloaders/includes aren't in place yet)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113156 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-27 19:59:38 +00:00
Sam Minnee
e531379b13
MINOR: Blocking unnecessary revisions
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112952 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:09:23 +00:00
Sam Minnee
72037a8c5d
MINOR Removed "In line of " text in CLI test reporter which did not work. Details are in the backtrace below anyway, so it's not required (from r112321)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112951 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:09:13 +00:00
Sam Minnee
4665369e31
BUGFIX Renamed MySQLQuery::__destroy() renamed to __destruct() so that it is called properly after the object is destroyed (from r112288)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112950 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:08:59 +00:00
Sam Minnee
75101d329f
MINOR Reverted regression in r112272 (from r112278)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112949 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:08:46 +00:00
Sam Minnee
2699eb3b5b
ENHANCEMENT MySQLDatabase::renameField() no longer checks that the field exists in fieldList(). alterField() does no such check, so it should be consistent. Removing this should provide a small performance improvement as well (from r112272)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112948 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:08:32 +00:00
Sam Minnee
65713da5d7
MINOR Comment about HTMLValue::setContent() stripping out of carriage returns (from r111950)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112947 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:07:45 +00:00
Sam Minnee
f0dc6c65ca
BUGFIX Ensure that \r carriage return characters get stripped out before setting content in HTMLValue::setContent(). DOMDocument will transform these into 
 entities, which is apparently XML spec, but not necessary for us as we're using HTML (from r111949)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112946 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:07:27 +00:00
Sam Minnee
c2989908c8
BUGFIX #6089 Avoid javascript error when "Allow drag & drop reordering" enabled, and attempt to drag a file from one folder to another is performed (from r111932)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112945 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:07:06 +00:00
Sam Minnee
be40e11c72
BUGFIX #6096 RSSFeed::feedContent() restores previous state of SSViewer::get_source_file_comments() after temporarily disabling it (thanks paradigmincarnate!) (from r111914)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112944 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:06:53 +00:00
Sam Minnee
8222d72d39
MINOR #6083 FileTest doesn't remove test folders and files created during test (from r111903)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112943 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:06:39 +00:00
Sam Minnee
31f0ceac07
BUGFIX Filesystem::removeFolder() did not remove files that ended with a "." when this is a valid file. Remove the regex and replace with specific case for "." and ".."
...
MINOR Code syntax formatting of Filesystem::removeFolder() (from r111898)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112942 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:06:25 +00:00
Sam Minnee
ef8419f11d
ENHANCEMENT #4903 MemberLoginForm field for "You are logged in as %s" message customisation (thanks walec51!) (from r111891)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112941 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:05:23 +00:00
Sam Minnee
b40544e694
BUGFIX #6066 Form::__construct() should respect hasMethod on passed in Controller instance if it's available (thanks paradigmincarnate!) (from r111890)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112940 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:04:58 +00:00
Sam Minnee
bb183add33
BUGFIX #3910 Setting timezone parameter to MySQLDatabase::__construct() should use $this->query() to be consistent (from r111889)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112939 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:04:40 +00:00
Sam Minnee
aa1d6c72f0
MINOR Moved GD::set_default_quality() function to the top of the file to align with conventions (from r111888)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112938 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:04:14 +00:00
Sam Minnee
6d423c9f9b
ENHANCEMENT #3775 Added getter to GD so you can retrieve the internal GD resource being used. Made setGD public so you can override the GD yourself as well (from r111887)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112937 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:04:00 +00:00
Sam Minnee
3c681b0324
#4029 On the fly form validation works in Opera as well (from r111880)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112936 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:03:47 +00:00
Sam Minnee
f51f5bc958
BUGFIX Ensure that windows-style newlines ("\r\n") don't get converted to their XML entity representation through DOMDocument in SS_HTMLValue->setContent() (from r111878)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112935 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:03:29 +00:00