Commit Graph

2006 Commits

Author SHA1 Message Date
Sam Minnee
9d72145ee1 MINOR Warning about install.php existing for root site tree node as well (SiteConfig form) (from r110440)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112841 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:31:07 +00:00
Sam Minnee
d0c9fe908a MINOR: added missing closing tag (from r110243)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112839 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:29:55 +00:00
Sam Minnee
32783ef0e8 MINOR Make dev/build not constantly show a changed index because of whitespace between VersionID and Version in the index spec (from r110205)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112837 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:29:25 +00:00
Sam Minnee
6e8bf5617a MINOR: only call next() in iterator validation on initialisation or after reset NOT if current value is invalid (from r110190)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112834 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:27:51 +00:00
Sam Minnee
0154fbae0f BUGFIX: makeRelative would return "false" for the root path, empty string is expected - fix that
BUGFIX: change the check in forceSSL to work on Windows - it sets the $_SERVER['https'] to off, instead of null (from r109712)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112828 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:25:50 +00:00
Sam Minnee
ac33763d05 BUGFIX: getItem didn't consider the PostgreSQL SQL syntax. Columns with Capital letters must be quoted. Added quotes to the where clause in getItem. I didn't added quotes to the baseTable because it causes PostgreSQL errors (tables can not be double quoted, just single quoted). (from r109591)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112827 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:25:32 +00:00
Sam Minnee
458f3b1197 MINOR: neatly quote identifiers (from r109405)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112826 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:25:19 +00:00
Sam Minnee
99fde26091 MINOR CSSContentParser::__construct() now gives a better error if the content could not be parsed. This will mostly happen if tidy isn't present. (from r109274)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112821 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:23:00 +00:00
Sam Minnee
496e9bcef6 API CHANGE #5873 DataObjectSet::shift() now performs a proper shift instead of unshift (wrong). Please use DataObjectSet::unshift($item) if unshifting was intended!
API CHANGE Added DataObjectSet::pop()
MINOR Unit tests for DataObjectSet::shift(), DataObjectSet::unshift() and DataObjectSet::pop() (from r109156)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112817 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:20:56 +00:00
Sam Minnee
fcc20b5e1a BUGFIX Fixed ContentNegotiator to handle HTML and XHTML base tags properly when converting, regression from r108413 (from r108421)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112815 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:20:07 +00:00
Sam Minnee
a588ae305c BUGFIX #5855 SSViewer::get_base_tag() should produce a properly closed base tag for XHTML (thanks smorris!) (from r108413)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112813 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:06:25 +00:00
Sam Minnee
ea1157f5b2 MINOR Doc update for Director::forceSSL() (from r109152)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112788 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:58:52 +00:00
Sam Minnee
634a3afeff MINOR: Applied patch from walec51 for <% control %> on empty set (#5579) Also added unit tests by ischommer (from r109127)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112785 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:58:23 +00:00
Sam Minnee
215cbb6b36 ENHANCEMENT Session::set_cookie_path() and Session::set_cookie_domain() are now possible. This is useful for sharing cookies across all subdomains, for example. (from r109101)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112779 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:55:02 +00:00
Sam Minnee
d6fdc57db7 BUGFIX SiteTree decorated canView() checks not being passed through to SiteTree::canView() (from r109082)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112775 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:54:02 +00:00
Sam Minnee
adfab98adb BUGFIX StringField::setNullifyEmpty() should assign the given value boolean, not evaluate whether it's true or not (from r109081)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112774 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:53:46 +00:00
Sam Minnee
58d6cbf81a MINOR: remove SQL table alias keyword AS (from r108961)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112769 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:51:53 +00:00
Sam Minnee
43f4500cd6 MINOR Fixed tests not working on the web side as redirection to https would occur (from r108666)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112765 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:50:37 +00:00
Sam Minnee
d295d682c5 ENHANCEMENT #3828 500 server error page is created by default on dev/build (from r108644)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112763 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:49:53 +00:00
Sam Minnee
9a036a6fad MINOR: allow $icon to be overridden on ErrorPages. PATCH via martljn (#5875). (from r108640)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112761 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:48:04 +00:00
Sam Minnee
60c78eb54d ENHANCEMENT New Member records are populated with the currently set default through i18n::set_locale() (from r108499)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112753 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:37:43 +00:00
Sam Minnee
50e9025bbb BUGFIX Undefined variable destURL in Director::forceWWW() (regression from r107094) (from r108492)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112752 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:37:22 +00:00
Sam Minnee
4aa299c4f2 MINOR Making "todo" tab title translatable (from r108441)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112751 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:37:07 +00:00
Sam Minnee
6a83da1455 MINOR Fixed Director::forceSSL() breaking unit tests because headers were already sent (from r108435)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112749 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:36:06 +00:00
Sam Minnee
63e425b418 ENHANCEMENT #2856 Limiting of relative URLs for Director::forceSSL() using a map of PCRE regular expressions (from r108428)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112745 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:32:42 +00:00
Sam Minnee
684e76e36b ENHANCEMENT Added argument to SQLQuery->leftJoin()/innerJoin() (#5802, thanks stojg) (from r108418)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112732 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:58:43 +00:00
Sam Minnee
e5a07227c2 ENHANCEMENT: Full-text search with double quotes returns too many results. ticket #5733. Thanks ktauber.
Using htmlentities($keywords,ENT_NOQUOTES) instead of proposed solution (from r108417)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112731 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:58:23 +00:00
Sam Minnee
ca7edd5ca5 BUGFIX Undefined variable when calling DataObject::many_many_extraFields() and relation name couldn't be found for the component (from r108400)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112726 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:53:59 +00:00
Sam Minnee
2058ee31ee BUGFIX: DataObjects without the Versioned decorator cannot have a "Version" field. ticket #5775. Thanks ajshort (from r108399)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112725 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:53:19 +00:00
Sam Minnee
c4a72efd52 BUGFIX: Added condition to avoid error creating "PastMember" cookie on dev/build (ticket #5780) Thanks simon_w (from r108397)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112724 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:53:03 +00:00
Sam Minnee
cc15a7935e MINOR Added warning about Director::set_dev_servers() (from r108049)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112714 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:42:31 +00:00
Sam Minnee
298a6d320b BUGFIX: Don't have any host-based dev servers set by default. (from r108027)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112711 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:41:51 +00:00
Sam Minnee
bcdf352a71 ENHANCEMENT: Show a warning inside the the CMS if you've neglected to delete install.php (from r108024)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112707 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:40:18 +00:00
Sam Minnee
c35349f90d ENHANCEMENT: added getter to get array back out of an ArrayData instance. MINOR: updated docblocks in ArrayData (from r108012)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112705 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:39:19 +00:00
Sam Minnee
93eb6214b7 ENHANCEMENT Allowing custom messages and permission codes in BasicAuth::protect_entire_site()
ENHANCEMENT Making $permissionCode argument optional for BasicAuth::requireLogin(). If not set the logic only checks for a valid account (but no group memberships)
ENHANCEMENT Using SS_HTTPResponse_Exception instead of header()/die() in BasicAuth::requireLogin() to make it more testable (from r107867)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112701 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:29:35 +00:00
Sam Minnee
ad68943003 BUGFIX dev/build always reporting index change because of a whitespace in the index column names (from r107831)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112700 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:27:12 +00:00
Ingo Schommer
a0dd4ff8f0 MINOR Moved class-specific documentation from doc.silverstripe.org back into class-level PHPDoc (from r107725)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:55:22 +00:00
Ingo Schommer
eed13a7384 MINOR: removed whitespace (from r107586)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112607 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:54:31 +00:00
Ingo Schommer
d794381e98 BUGFIX: fixed inclusion of environment file when document root is the web root (from r107585)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112605 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:54:12 +00:00
Ingo Schommer
b64015e2cf BUGFIX Remove dummy entry created by Versioned if record is first written to Live stage (fixes #5596, thanks muzdowski) (from r107537)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112603 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:53:14 +00:00
Ingo Schommer
bd927c9355 ENHANCEMENT: html2raw now properly replace strong tag with asterix #5494 (from r107443)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112600 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:51:55 +00:00
Ingo Schommer
ab918e8546 MINOR Better error handling in i18n::get_language_name() (from r107437)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112596 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:47:44 +00:00
Ingo Schommer
f097b678d8 ENHANCEMENT: allow adding a new a field to ArrayData (from r107434)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112595 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:47:27 +00:00
Ingo Schommer
cfe9b518a5 MINOR: Fixed Documentation (from r107430)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:46:54 +00:00
Ingo Schommer
556e753fee ENHANCEMENT: Added documentation and changed static names (from r107429)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112593 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:46:32 +00:00
Ingo Schommer
2f4fe2ff35 ENHANCEMENT: Added static to set regeneration of default pages (ticket #5633) (from r107426)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112591 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:44:57 +00:00
Ingo Schommer
bd6e51c87f BUGFIX: Only highlight strings more than 2 characters long. #4949 (from r107423)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112590 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:44:24 +00:00
Ingo Schommer
f63751893b BUGFIX Allowing dev/build in "live" mode when Security::database_is_ready() returns FALSE (typically happens when an existing SilverStripe project is upgraded and database columns in Member/Permission/Group have been added) (fixes #4957)
MINOR Using Object::create() in DevelopmentAdmin to make objects mockable
ENHANCEMENT Added Security::$force_database_is_ready to mock database_is_ready() state
ENHANCEMENT Added permission check exception in TaskRunner and DatabaseAdmin if SapphireTest::is_running_test() returns TRUE (necessary for DevelopmentAdminTest) (from r107415)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112588 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:43:30 +00:00
Ingo Schommer
8f8de04aaf MINOR Documentation in DataObjectSet (from r107400)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112575 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:26:27 +00:00
Ingo Schommer
380e0af8c0 MINOR Changed "no_NO" locale for Norwegian into the more commonly used "nb_NO" in i18n class, meaning translations from translate.silverstripe.com can actually be selected now (fixes #5746) (from r107394)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112574 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:26:11 +00:00