Commit Graph

379 Commits

Author SHA1 Message Date
Sam Minnee
25af09b0f6 MINOR #5943 Debug::text() boolean values are amended with (bool) so they don't get confused with "true" or "false" which could be strings (thanks Pigeon!) (from r111676)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112918 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:52:33 +00:00
Sam Minnee
b9ab0e6e1c BUGFIX Force tidy to avoid wrapping long lines in CSSContentParser, it breaks our FunctionalTest string assertions (from r111176)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112899 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:48:25 +00:00
Sam Minnee
47f27bef87 BUGFIX Fixed regression where coverage report request did not get passed through to runTests() in TestRunner::all() (from r111092)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112893 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:45:26 +00:00
Sam Minnee
0d7d983c14 BUGFIX Fixed regression of dev/tests/all running a coverage report instead of just unit tests (from r111091)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112892 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:44:52 +00:00
Sam Minnee
ea2b86cd1d ENHANCEMENT Added custom test listener for PHPUnit in order to call setUpOnce() and tearDownOnce() on SapphireTest (from r111050)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112888 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:43:01 +00:00
Sam Minnee
67b5116702 BUGFIX: Allow execution of a test without a current controller. (from r111044)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112882 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:36:12 +00:00
Sam Minnee
cb283acb9b MINOR: added phpdoc to the new PHPUnitWrapper classes. (from r111042)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112880 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:35:14 +00:00
Sam Minnee
3006b6ac36 ENHANCEMENT: refactored runTests, using the new phpunit wrapper classes. (from r111041)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112878 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:33:51 +00:00
Sam Minnee
ce92190465 API-CHANGE: remove include which is not required. (from r111040)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112872 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:07:15 +00:00
Sam Minnee
eeb9e36e7a ENHANCEMENT: Created a phpunit wrapper class to ensure that Sapphire's test framework is capable of running unit tests, coverage report and retrieve clover-statistics for PHPUnit 3.4 and PHPUnit 3.5 (from r111039)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112871 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:06:55 +00:00
Sam Minnee
d8a8635374 API CHANGE Member->canEdit() returns false if the editing member has lower permissions than the edited member, for example if a member with CMS_ACCESS_SecurityAdmin permissions tries to edit an ADMIN (fixes #5651) (from r110856)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112861 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 02:46:26 +00:00
Sam Minnee
9107cf950b ENHANCEMENT: added the ability to toggle the use draft site setting (from r110757)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112844 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:32:17 +00:00
Sam Minnee
e5dd8c13d3 ENHANCEMENT: disable basic auth by default, tests run on the assumption it is disabled. (from r110211)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112838 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:29:39 +00:00
Sam Minnee
2c7d88aade MINOR: repair installer for sqlite (from r109787)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112830 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:26:27 +00:00
Sam Minnee
99fde26091 MINOR CSSContentParser::__construct() now gives a better error if the content could not be parsed. This will mostly happen if tidy isn't present. (from r109274)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112821 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:23:00 +00:00
Sam Minnee
f929d2ee6d MINOR phpDoc updates for SS_LogFileWriter and SS_LogEmailWriter (from r109165)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112819 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:21:32 +00:00
Sam Minnee
f20e83eeaf MINOR: Fix links etc, and remove www. from SS urls (from r109105)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112783 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:56:25 +00:00
Sam Minnee
cda6638281 ENHANCEMENT: Added -v / --verbose option to dev/tests/*, to make it output every single test name before it starts that test. (from r109104)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112782 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:56:02 +00:00
Sam Minnee
0d6cb295c4 Added dev/tests/emptydb to clear out test session databases. (from r109099)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112777 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:54:31 +00:00
Sam Minnee
b2c7c944de BUGFIX SapphireTest::create_temp_db() should restore the SS error handler from the PHPUnit one temporarily in case there's any errors building (from r108509)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112755 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:42:53 +00:00
Sam Minnee
d28d7510af MINOR Fixed failing tests because of locale not being set to the default in SapphireTest::setUp() (from r108500)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112754 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:37:55 +00:00
Sam Minnee
c52dfd1e03 BUGFIX Database password input in installer should be password, so that the password is obfuscated when input (from r108432)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112746 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:33:12 +00:00
Sam Minnee
229bea6dd4 MINOR: Add trailing slash to image tag (thanks to mattclegg) (from r108376)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112722 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:51:05 +00:00
Sam Minnee
aa4503845f MINOR Documentation in CSVBulkLoader (from r108048)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112712 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:42:12 +00:00
Sam Minnee
a707f925ad BUGFIX: Don't allow reinstalling without first making the user manually delete mysite/_config.php (from r108026)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112710 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:41:32 +00:00
Ingo Schommer
a0dd4ff8f0 MINOR Moved class-specific documentation from doc.silverstripe.org back into class-level PHPDoc (from r107725)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:55:22 +00:00
Ingo Schommer
f63751893b BUGFIX Allowing dev/build in "live" mode when Security::database_is_ready() returns FALSE (typically happens when an existing SilverStripe project is upgraded and database columns in Member/Permission/Group have been added) (fixes #4957)
MINOR Using Object::create() in DevelopmentAdmin to make objects mockable
ENHANCEMENT Added Security::$force_database_is_ready to mock database_is_ready() state
ENHANCEMENT Added permission check exception in TaskRunner and DatabaseAdmin if SapphireTest::is_running_test() returns TRUE (necessary for DevelopmentAdminTest) (from r107415)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112588 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:43:30 +00:00
Ingo Schommer
47762cdf5b ENHANCEMENT #5352 Decouple date display from i18n locales, users now have access to change their date and time formats in Member::getCMSFields() using Member_DatetimeOptionsetField field (from r107326)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:23:02 +00:00
Ingo Schommer
f7e61e0d11 ENHANCEMENT Added TestRunner::$coverage_filter_dirs to exclude certain directories from PHPUnit test coverage reports (from r106877)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112542 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:07:08 +00:00
Ingo Schommer
9b177ec458 BUGFIX Making status description in Debug::friendlyError() compatible to HTTP 1.1 spec (removing any markup and newlines) (from r106867)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112540 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:06:31 +00:00
Ingo Schommer
5fe548f7b5 MINOR Fixed memory limit setting in SapphireTest (regression from r106128) (from r106190)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112525 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:59:10 +00:00
Ingo Schommer
3c18a9f1f6 MINOR: Preserve memory_limit between tests (for better PHP5.1 behaviour) (from r106128)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112521 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:58:02 +00:00
Ingo Schommer
7eaca248e2 MINOR Removed db/build legacy wording in DevelopmentAdmin (fixes #5676) (from r106083)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112517 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:56:21 +00:00
Ingo Schommer
b839ab2b9f BUGFIX MySQLDatabaseConfigurationHelper::getVersion() will fallback to trying to get the version using a query if mysql_get_server_info() returns nothing (from r106071)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112512 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:54:18 +00:00
Ingo Schommer
74036f9642 ENHANCEMENT Added MySQLDatabaseConfigurationHelper::getDatabaseVersion() which abstracts the version number away from the version check the installer requires (from r105712)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112501 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:50:06 +00:00
Ingo Schommer
cf4a722cc8 MINOR Show better message if couldn't find MySQL version in MySQLDatabaseConfigurationHelper (from r105516)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112499 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:49:35 +00:00
Ingo Schommer
e44ba25714 ENHANCEMENT Added CSSContentParser->getByXpath() (from r105126)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112440 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:26:24 +00:00
Ingo Schommer
163b358bdf BUGFIX Fixed correct input ID in install.js due to change in r105029 (from r105030)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112437 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:23:00 +00:00
Ingo Schommer
55f1df0f6d BUGFIX Fixed inconsistent styling of reinstall actions at the bottom of the installer, and if using IIS, warn that this will overwrite the web.config file, not .htaccess (from r105029)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112436 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:22:44 +00:00
Ingo Schommer
86cae58d4c BUGFIX: TestSession::submitForm throws proper error if form not found (from r104972)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112413 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:18:22 +00:00
Ingo Schommer
d135ae6837 MINOR Reverted r104923, as current database releases of mssql and sqlite3 modules don't support this yet (from r104924)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112406 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:17:25 +00:00
Ingo Schommer
84b74a6d23 API CHANGE Added interface method DatabaseConfigurationHelper::requireDatabaseVersion(), all database helpers that implement DatabaseConfigurationHelper must now have this method, which as of now is MySQL, PostgreSQL, SQL Server and SQLite (from r104923)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112405 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:17:08 +00:00
Ingo Schommer
8ea659be69 ENHANCEMENT Added MySQLDatabaseConfigurationHelper::requireDatabaseVersion() to check whether the connected instance is using version 5.0+ (from r104706)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112375 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:10:10 +00:00
Ingo Schommer
0e99090bc7 MINOR Tweaks to positioning of help text in installer (from r104704)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112373 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:04:53 +00:00
Ingo Schommer
bfb7dab1fb FEATURE: Add dev/tests/sessionloadyml to load a yml fixture into an existing test session (from r104231)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112340 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 00:01:23 +00:00
Ingo Schommer
d50097e905 FEATURE: Add dev/build/defaults to call requireDefaultRecords (from r104093)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112334 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-14 23:57:02 +00:00
Sam Minnee
35378e577e BUGFIX CSSContentParser now reports better errors by using simplexml_load_string() instead of SimpleXMLElement directly (from r103552)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112147 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:57:07 +00:00
Sam Minnee
2948bc1c64 MINOR: Misc merges from branches/2.4
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112142 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:53:12 +00:00
Sam Minnee
7fc63deda0 MINOR: use red font instead of gray when displaying error (from r101729)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112029 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:03:46 +00:00
Sam Minnee
d25e326ba0 MINOR Removed fullstop where it wasn't needed (from r101688)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112023 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:00:24 +00:00