tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
2,749 Commits 31 Branches 527 Tags 162 MiB
98a75735ee
Commit Graph

2749 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ingo Schommer
9999f8edd8 BUGFIX Moving Requirements for TableField, TableListField, ComplexTableField, ScaffoldComplexTableField and HasManyComplexTableField from __construct() into FieldHolder() and renderWith(), which means inclusion closer to render time, and less side-effects by a previous Requirements::clear(), e.g. in a CTF popup 
ENHANCEMENT Removed constructor overloading in ScaffoldingComplexTableField, was reconstrcuting its own Requirements (with lots of unnecessary jQuery plugins) which should really be done by the individual form fields and the parent popup class

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74919 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Ingo Schommer
a869951638 BUGFIX Re-added Requirements::clear() to ComplexTableField_Popup initialization to avoid including the dozens of javascript files required by CMSMain and LeftAndMain, they're not needed in a popup, and cause side-effects like missing scrollbars, weird CSS styling and generally slow loading time. 
BUGFIX Removed overflow:autio CSS rule in ComplexTableField.css which was causing double scrollbars in a popup. This was a hack to work around <body style="overflow:hidden"> which was set by LeftAndMain.js - this file is no longer included in the popup HTML.
BUGFIX Removed unnecessary requirements from ComplexTableField_Popup: LeftAndMain.js, LeftAndMain_right.js, TableField.js, ComplexTableField.js - they will be included by the fields if necessary

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74904 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Ingo Schommer
2cb4b43320 BUGFIX Making sure all input fields inside a newly added TableField row have unique HTML ids. This was causing problems when javascript logic was acting on those (previously ambiguous fields), e.g. when trying to use a jQuery UI datepicker 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74902 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Normann Lou
3861c33bc1 APICHANGE: add documentation to changeset r74858. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74901 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Sean Harvey
859bbb2eaa Reverted r74899 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74900 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Sean Harvey
b6d6dfb76b BUGFIX If validator doesn't exist on Form, don't attempt to call setForm() on it or you'll get a non-object error 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74899 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Hamish Friedlander
ba6649a24f MINOR: Inline images by setting ContentLocation on Attached Files 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74893 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Sean Harvey
40a7d711be BUGFIX Removed additional $ sign that isn't supposed to be there that broke GroupTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74879 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Normann Lou
5c612beb36 APICHANGE: pass argument $includerelations into DataObject::fieldLabels() default as true; 
APICHANGE: BulkLoader::getImportSpec() call DataObject::fieldLables() with $includerelations as false, so that the relations is separated from column fields

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74858 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Will Rossiter
67918d0873 MINOR: code formatting improvements 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74740 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Will Rossiter
3ff0fc139f FEATURE: hooks into form field to allow custom error messages. Note does not currently apply to the behaviour / js. Just the PHP validation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74739 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:15 +13:00
Ingo Schommer
fe5e722313 BUGFIX Fixing CurrencyField serverside and javascript validation to accept numbers with leading or trailing spaces 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74725 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Ingo Schommer
c0a7241812 BUGFIX Fixing NumericField serverside validation to accept numbers with leading or trailing spaces by using trim() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74721 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Sean Harvey
5b78832de3 MINOR Changed misleading test result explanation from "exact", even though it was for a partial match 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74703 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Ingo Schommer
6a51018f50 BUGFIX Fixed NumericField javascript validation to not fail on numbers with trailing or leading whitespace 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74657 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Sean Harvey
03a66309d6 BUGFIX Added missing default english text for "No items found" in TableListField.ss 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74620 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Normann Lou
786b777e0e FEATURE: make PasswordField and ConfirmedPasswordField able to either readonly or disabled. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74538 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Normann Lou
12e2c9cda1 FEATURE: make PasswordField and ConfirmedPasswordField able to either readonly or disabled. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74503 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Normann Lou
f5117782ee Undoing changeset committed in r74490 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74501 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Normann Lou
15c4b90132 git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74490 467b73ca-7a2a-4603-9d3b-597d59a354a9 2011-02-02 14:27:14 +13:00
Normann Lou
2889ab115a BUGFIX: add more condition before $this->form is used as Caller since $this->form can still not be set yet in a certain circumstance. 
ENHANCEMENT: add the ability that a SimpleImageField could be disabled.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74489 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Normann Lou
d78fecdfe6 BUGFIX: A SoapServer will cache the wsdlFile when it is first initialized and never get updated if the constructor is not explicitly passed in 'cache_wsdl' as WSDL_CACHE_NONE. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74487 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Will Rossiter
a7cd85b06a BUGFIX: fixed typos in ResetFormAction 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74477 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Will Rossiter
d7aead3f71 MINOR: refactored dulicate code in ResetFormField, who knew we had a reset form field... 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74462 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Normann Lou
cfbda47e25 fix the bug in Mingle (SC #234):Users reporting a parse error when trying to open grants. also HD(1571). 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74416 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:14 +13:00
Will Rossiter
df6ab637d2 BUGFIX: fixed overflow being hidden 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74391 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:13 +13:00
Will Rossiter
181105aaa9 FEATURE: added $Var.UpperCase support to DBField 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74327 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:13 +13:00
Will Rossiter
fbdabff60c FEATURE: allow you to disable ?m suffixing of requirements 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74326 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:13 +13:00
Hamish Friedlander
672d68a51d BUGFIX: Allows DataObjectDecorators and other extensions to specify setters (setFoo) in the same manner as the already working Getters (getFoo). 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74322 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:13 +13:00
Sam Minnee
b65e2a3a82 Added SiteTree onAfterRevertToLive handler 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74304 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:13 +13:00
Sam Minnee
89e45b67a2 BUGFIX: Allow testing of emails when Email::send_all_emails_to() is set 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74303 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:13 +13:00
Will Rossiter
23044a94dd BUGFIX: fixed issue with greyscale GD - patch from camspiers 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74272 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:13 +13:00
Will Rossiter
4b12d00697 MINOR: added base tag to email template - merged patch from Henk_Poley. Not that base url does alot - gmail will strip it it, same with hotmail... 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74270 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:13 +13:00
Will Rossiter
d016b2cf75 FEATURE: optionally allow sorting toDropdownMap() function. Patched from #3829 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74248 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Hamish Friedlander
8a38580159 MINOR: Add disabled class to InlineFormAction, adjust Folder to use InlineFormAction rather than LiteralField for "Delete unused thumbnails" button. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74168 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Will Rossiter
e799219724 MINOR: as title does not exist we fail validation without alt tags take at least the filename 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@74114 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Ingo Schommer
20a77500f3 MINOR merged r73836 from trunk 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73837 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Will Rossiter
61a9389710 BUGFIX: fixed cropping of TreeDropdownField popups and Date popups within complextablefield popups 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73775 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Sam Minnee
7dcf20d627 MINOR: Fixed test to get previous change to work 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73764 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Sam Minnee
6c2b2c2e67 BUGFIX #3798 ajshort: Let searchcontext be used on sitetree 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73758 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Ingo Schommer
2964cb625d MINOR merged from trunk (r73749) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73750 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Saophalkun Ponlu
531c7b1d4d FEATURE: added after uploading notify method 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73670 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Andrew O'Neil
e933d61a1c Merged r71795 from trunk 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73613 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:12 +13:00
Will Rossiter
84c16c66c8 BUGFIX: updated FormTest with fullstop 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73603 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:11 +13:00
Will Rossiter
09bd69cdd4 MINOR: added full stop to required labels for consistency 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73596 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:11 +13:00
Sean Harvey
bb583293a6 BUGFIX Fix call to undefined "_12Hour" function (merged from r73523) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73533 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:11 +13:00
Michael Andrewartha
07ef4d77f9 MINOR check for existing file object 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73529 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:11 +13:00
Sam Minnee
b4921db9d7 BUGFIX: Get installer working with php_short_tags off (Merged r73481-3 from trunk) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73484 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:11 +13:00
Sean Harvey
4513631a54 BUGFIX Fixed possible SQL injection in file name part for File::find() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73437 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:11 +13:00
Normann Lou
3973a6a47e ENHANCEMENT: more robust conditional check before we go to foreach loop, more robust conditional checking before we call a FormField function where we are not sure the caller is a FormField object. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@73435 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:27:11 +13:00