Maxime Rainville
8c396eb1f6
MNT Remove bad PHPDoc comments on test
2023-02-17 18:53:42 +13:00
Maxime Rainville
7bc4c9dbc3
MNT Tweak some test to account for slightly different sorting logic in PostgreSQL
2023-02-17 18:47:20 +13:00
Guy Sartorelli
ab566b0a15
API Add new deprecation notices. ( #10691 )
...
These are removed in CMS 5.
2023-02-15 13:26:36 +13:00
Florian Thoma
54fc4ee9d2
fix directory separator in i18nTextCollector on Windows ( #10681 )
...
* fix directory separator in i18nTextCollector for Windows
* fix typo
2023-02-09 19:09:48 +13:00
Sabina Talipova
1f7adab62e
Merge pull request #10677 from creative-commoners/pulls/4/deprecate-diff
...
API Deprecate Diff in favour of CMS5's HtmlDiff
2023-02-08 16:36:58 +13:00
Sabina Talipova
6a6a7849c0
Merge pull request #10641 from creative-commoners/pulls/5/change-diff-lib
...
API Replace thirdparty difflib with maintained lib
2023-02-08 16:32:40 +13:00
Guy Sartorelli
7930fb87ae
MNT small indentation change
2023-02-08 16:20:25 +13:00
Guy Sartorelli
9a5ccdba51
ENH Protect against possible unexpected values
2023-02-08 16:18:13 +13:00
Guy Sartorelli
557421a245
MNT Fix linting issue
2023-02-08 16:18:00 +13:00
Guy Sartorelli
603723e8f3
API Rename Diff to HtmlDiff
...
This class doesn't diff anything other than HTML, really. For anything
else, SebastianBergmann\Diff\Differ should be used directly.
2023-02-08 14:59:34 +13:00
Guy Sartorelli
99dc6df38a
API Replace thirdparty difflib with maintained lib
2023-02-08 14:59:33 +13:00
Guy Sartorelli
0ff7623230
Merge pull request #10643 from creative-commoners/pulls/5/replace-simpletest
...
DEP Replace thirdparty simpletest with symfony domcrawler
2023-02-08 12:15:57 +13:00
Guy Sartorelli
3a14aafc7f
API Deprecate Diff in favour of CMS5's HtmlDiff
2023-02-08 11:15:28 +13:00
Sabina Talipova
9d13f35040
MNT Update strong typization, tests cases
...
Co-authored-by: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com>
2023-02-08 10:59:27 +13:00
Guy Sartorelli
ce9fa05dc7
Merge pull request #10678 from creative-commoners/pulls/4/depr
...
API Deprecate code
2023-02-08 10:44:44 +13:00
Sabina Talipova
5236b0a9df
Merge pull request #10666 from creative-commoners/pulls/5/security-extensions
...
NEW migrate functionality from security-extensions module
2023-02-07 13:50:56 +13:00
Guy Sartorelli
af72f4adad
ENH Add translations from security-extensions module
2023-02-07 13:36:42 +13:00
Guy Sartorelli
fecb7ba4d8
NEW Add sudo mode service
2023-02-07 13:36:42 +13:00
Guy Sartorelli
8ddedb038e
NEW Allow admins to require password reset for members
...
This came from silverstripe/silverstripe-security-extensions
2023-02-07 13:36:21 +13:00
Steve Boyd
4e9c74243d
API Deprecate code
2023-02-07 11:56:04 +13:00
Steve Boyd
a74e9d3ecd
Merge branch '4' into 5
2023-02-03 10:14:36 +13:00
Steve Boyd
23efed1802
Merge branch '4.12' into 4
2023-02-02 16:20:00 +13:00
Guy Sartorelli
7c20ade548
DEP Replace thirdparty simpletest with symfony domcrawler
2023-02-02 13:31:45 +13:00
Guy Sartorelli
738ca487ac
FIX Allow public extension getter methods to work ( #10676 )
...
Accidentally broke this in #10670
2023-02-01 16:05:54 +13:00
Guy Sartorelli
826028082b
FIX Sort without specifying a table name ( #10675 )
...
Using a table name in sort() is not allowed in CMS 5. We could use
orderBy() here but member is the table it will sort on by default anyway
so there's no need.
Also added unit tests, which should have caught this ages ago.
2023-02-01 13:52:13 +13:00
Guy Sartorelli
2274b3e765
Merge pull request #10670 from creative-commoners/pulls/5/no-private-viewabledata
...
FIX Don't try to access private properties/methods
2023-01-31 15:50:35 +13:00
Guy Sartorelli
14a449feaa
FIX Don't try to access private properties/methods
2023-01-31 14:59:17 +13:00
Guy Sartorelli
dca4e0bcb8
FIX Remove unused action from allowed_actions ( #10672 )
...
This action was used in CMS 3, but has since been replaced with
/Security/lostpassword/passwordsent which is a separate set of actions.
2023-01-31 13:59:12 +13:00
Michal Kleiner
20e4aae25b
Merge pull request #10663 from lekoala/patch-33
...
FIX Prevent backslash in CSS class name
2023-01-30 22:51:09 +13:00
Thomas Portelange
3e5d99dedc
Prevent backslash in class name
...
since the default code is using get_called_class, you can end up with \ in the class name which is an escape character for css selectors
this update convert for example
even valCMS_ACCESS_SilverStripe\VersionedAdmin\ArchiveAdmin
to
even valCMS_ACCESS_SilverStripe-VersionedAdmin-ArchiveAdmin
ArchiveAdmin class should probably implement private static $required_permission_codes = 'CMS_ACCESS_ArchiveAdmin '; also
2023-01-30 10:26:22 +01:00
Guy Sartorelli
0f4014650c
NEW Add easy way to dismiss all toasts in behat ( #10661 )
2023-01-30 10:30:54 +13:00
Sabina Talipova
0fee1aa584
Merge pull request #10652 from creative-commoners/pulls/5/limit-0
...
ENH Zero limit no results
2023-01-27 10:51:55 +13:00
Maxime Rainville
fc6c45df57
MNT Add test to SQLSelect for Zero limit
2023-01-27 10:00:56 +13:00
Maxime Rainville
5090f49ecc
MNT Add more test coverage to DataList::limit()
2023-01-27 10:00:56 +13:00
Maxime Rainville
d1e0e1e305
ENH Make limit method return no results when zero is provided
2023-01-27 10:00:41 +13:00
Guy Sartorelli
4e92d25b86
Merge pull request #10639 from creative-commoners/pulls/5/no-return-type-will-change
...
API Removed #[\ReturnTypeWillChange] annotations
2023-01-27 09:49:38 +13:00
Maxime Rainville
944722f34f
API Removed #[\ReturnTypeWillChange] annotations
2023-01-26 18:10:05 +13:00
Guy Sartorelli
8d6fa44a54
Merge pull request #10658 from creative-commoners/pulls/5/array-email
...
API Allow array style email addresses
2023-01-26 15:55:52 +13:00
Steve Boyd
ec4a8b88e5
API Allow array style email addresses
2023-01-26 14:40:13 +13:00
Maxime Rainville
5e2293109a
Merge pull request #10653 from creative-commoners/pulls/5/remove-legacy-upgrader
...
MNT Remove legacy upgrader config
2023-01-23 10:35:36 +13:00
Steve Boyd
77301408d8
MNT Remove legacy upgrader config
2023-01-20 17:05:41 +13:00
Guy Sartorelli
b784e243de
Merge pull request #10538 from xini/feature-5-trailing-slash-config-and-redirect
...
SS5: add trailing slash config and redirect
2023-01-20 15:24:45 +13:00
Florian Thoma
fbcf7dc3e7
API Normalise trailing slashes for all paths
...
NOTE: There will be additional related PRs required for at least
silverstripe/cms and silverstripe/admin.
Co-authored-by: Guy Sartorelli <guy.sartorelli@silverstripe.com>
2023-01-20 10:31:14 +13:00
Guy Sartorelli
a8c374becb
Merge pull request #10651 from creative-commoners/pulls/5/merge-up-from-4
...
Merge up from 4 to 5
2023-01-19 09:46:09 +13:00
Maxime Rainville
b6b0bcea9f
Merge branch '4' into 5
2023-01-18 22:16:45 +13:00
Maxime Rainville
a65d470e93
Merge pull request #10647 from creative-commoners/pulls/5/dom-crawler
...
ENH Use masterminds/html5 for HTMLValue
2023-01-18 11:38:07 +13:00
Steve Boyd
d7ddb00254
ENH Use masterminds/html5 for HTMLValue
2023-01-18 10:58:53 +13:00
Maxime Rainville
c430011f19
Merge pull request #10648 from creative-commoners/pulls/4/deprecate-html5
...
API Deprecate HTML4Value
2023-01-17 22:20:07 +13:00
Michal Kleiner
77df71f2f2
Merge pull request #10650 from creative-commoners/pulls/5/remove-translatable
...
ENH Remove unused Translatable code
2023-01-17 20:30:58 +13:00
Steve Boyd
1a59bf50d1
ENH Remove unused Translatable code
2023-01-17 14:42:40 +13:00
