Commit Graph

824 Commits

Author SHA1 Message Date
Ingo Schommer
dd64cc06b9 elofgren: BUGFIX: Fix error: Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to
enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42069 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 14:22:26 +00:00
Ingo Schommer
8c3a21baa4 fixed bugs introduced during merging
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42068 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:44:10 +00:00
Ingo Schommer
74f2009f6c hsmith: Merged Permission changes from NZCT
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42036 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:15:16 +00:00
Ingo Schommer
4ce7cf9403 elofgren: Fix Trac Ticket: 'Page name and Navigation label improvements' http://support.silverstripe.com/gsoc/ticket/35 by making it so that 'If you type in Page name, the Navigation Label and Meta Title
should automatically update the first time' 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42035 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:01:34 +00:00
Ingo Schommer
c35c83bad7 elofgren: USABILITY: Make Page URL input field wider as part of fix for http://support.silverstripe.com/gsoc/ticket/35
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42034 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:00:59 +00:00
Ingo Schommer
ffa33aef74 elofgren: *Blacklist bounced newsletter recipient emails by default* in order to comply with spec: 'Bounces report with tickboxes ticked by default (to not send to in the future, unticking resends)'
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42033 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 02:00:28 +00:00
Ingo Schommer
3520afc7e8 elofgren: Add: 'Note: This does not seem to be used anywhere.' next to 'Bounced' => 'Boolean' Member 'db' definition.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42032 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:59:59 +00:00
Ingo Schommer
265a853c2a elofgren: BUGFIX: Fix trac ticket: #1411 'Layout problems with search box in IE' http://open.silverstripe.com/ticket/1411
by only creating a 'label' tag if a 'Title' is set in FormField?->FieldHolder?() 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42031 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:59:33 +00:00
Ingo Schommer
3c7bcfe813 mlanthaler: Bugfix: Since title was not escaped right, the RSS feed is invalid if there is an tag like <whatever> in the title of an entry.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42030 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:59:05 +00:00
Ingo Schommer
8521832df4 mlanthaler: Workaround: This will fix a conflict of the built-in DB class with PEAR's DB class. These changes can be reverted as soon as the developers of OpenID applied my patch to their library.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42029 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:58:39 +00:00
Ingo Schommer
390d71785f mlanthaler: August 3, 2007 - will@willnorris.com: prevent error 'call to member function of a non-object'
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42028 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:57:49 +00:00
Ingo Schommer
86f59268c8 mlanthaler: Refactored the created code since the coding conventions for static methods were changed (ticket #49).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42027 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:57:21 +00:00
Ingo Schommer
f5e24e3512 mlanthaler: Bugfix: Initialized variable to prevent E_NOTICE error.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42026 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:55:04 +00:00
Ingo Schommer
4622ce38fc elofgren: BUGFIX: Fix Email_BlackList::isBlocked() to check the Email_BlackList.BlockedEmail? field instead of non-existant Email field so that it will actaully return true when an email is blocked.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42025 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:54:32 +00:00
Ingo Schommer
f4f6eb0333 elofgren: BUGFIX: In Member->setBlacklistedEmail(bool) call this->write() so that the BlacklistedEmail? field state will be saved to the Member database table.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42024 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:53:02 +00:00
Ingo Schommer
76797c02a6 mlanthaler: Bugfix: Added isset() to prevent E_NOTICE error.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42023 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:52:35 +00:00
Ingo Schommer
fd795f83bb mlanthaler: Added small OpenID logo used as background image in text fields like the login form.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42022 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:51:08 +00:00
Ingo Schommer
cf2ea6ea60 mlanthaler: Bugfix: Added check if variable is set.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42021 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:50:43 +00:00
Ingo Schommer
db42713e1c mlanthaler: Bugfix: Class created invalid HTML (<td>...</t>).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42020 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:50:07 +00:00
Ingo Schommer
8d89050618 mlanthaler: Refactored the created code since the coding conventions for static methods were changed (ticket #49).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@42019 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 01:48:38 +00:00
Ingo Schommer
83c60460cf mlanthaler: Moved the OpenID specific files to a sub folder to make the directory structure clearer and set a "standard" for new authentication methods.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41983 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:46:51 +00:00
Ingo Schommer
7d600b025d mlanthaler: Refactored the created code since the coding conventions for static methods were changed (ticket #49).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41982 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:44:30 +00:00
Ingo Schommer
cbe32dca20 elofgren: NEW FEATURE: If the contents of the X-SilverStripeMessageID header is sent to /Email_BounceHandler in the 'SilverStripeMessageID' _GET variable, then it will be logged in the Newsletter_SentRecipient table so that the bounce report will show up on the 'Sent Status Report' tab of the Newsletter. @TODO: Add checkboxes checked by default to the 'Bounced' tab of the 'Mailing List' to not send to in the future (use Email_BlackList?), unticking resends. In addition, add ability to remove bounced emails from mailing list.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41981 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:40:29 +00:00
Ingo Schommer
481781c797 elofgren: Display a 'Sorry, this bounce report has already been logged, not logging this duplicate bounce.' on duplicate bounce logs instead of a blank screen to aid in debugging.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41980 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:39:04 +00:00
Ingo Schommer
f3dde5bf6b elofgren: If the access key for Email_BounceHandler is not given, display a 'No "Key" specified' error instead of 'Invalid "Key" specified' to make things clearer.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41979 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:38:41 +00:00
Ingo Schommer
1c044df977 elofgren: Add note to comments above 'EMAIL_BOUNCEHANDLER_KEY' that 'you can override it in mysite/_config.php to ease upgrades'
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41978 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:38:14 +00:00
Ingo Schommer
87a0535439 elofgren: Define 'EMAIL_BOUNCEHANDLER_KEY' in sapphire/_config.php and require its value to be sent as 'Key' $_GET var in pings to /Email_BounceHandler to prevent fake email bounce pings.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41977 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:35:09 +00:00
Ingo Schommer
f54e9db8b9 mlanthaler: Newly implemented "I've lost my password" feature that works also with encrypted passwords (ticket #48).
There are some (cosmetically) things that should be fixed, but everything work as it should. 
Will fix those things after my vacation. 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41976 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:32:48 +00:00
Ingo Schommer
357c18b692 mlanthaler: Bugfix: Little typo. The database indexes were in the wrong format.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41975 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:23:40 +00:00
Ingo Schommer
12afad7f1e mlanthaler: Check if TEMP_FOLDER was already defined before defining it so that the user can set the temporary folder himself.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41974 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:23:00 +00:00
Ingo Schommer
9af317a264 mlanthaler: Bugfix: Indexes and defaults were not supported in DataObjectDecorators?.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41973 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:20:31 +00:00
Ingo Schommer
9b75ec925a mlanthaler: Bugfix: Fixed bug "Fatal error: Access to undeclared static property: Controller::$db in ../sapphire/core/Object.php(282) : eval()'d code on line 1". Could be implemented better if we require support for PHP 5.1 because then we can avoid the exception by calling ReflectionClass::hasProperty() respectively ReflectionClass::getStaticPropertyValue() (http://www.php.net/manual/en/language.oop5.reflection.php).
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41972 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-16 00:19:54 +00:00
Ingo Schommer
7be8460917 mlanthaler: Added support for password encryption (http://support.silverstripe.com/gsoc/ticket/34).
See http://www.silverstripe.com/google-summer-of-code-forum/flat/2417 for more information.  
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41959 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:51:37 +00:00
Ingo Schommer
1119948ec4 mlanthaler: Reverted changes from r38216 which was an invalid fix. Also adjusted the method so that now cookies are accessed exclusively over the Cookie class.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41958 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:43:04 +00:00
Ingo Schommer
6d5eb70625 elofgren: BUGFIX: Add missing 'GenericEmail?.ss' template which is used in RecipientImportField::notifyChanges() as part of fix for bug 'Errors when Importing Recipients to Newsletter Mailing List' Reported here: http://www.silverstripe.com/bugs/flat/1470
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41957 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:42:23 +00:00
Ingo Schommer
d6a68f8993 mlanthaler: Bugfix: *Permission_groupList* is not a defined constant.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41956 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:41:54 +00:00
Ingo Schommer
44a74482e0 mlanthaler: Bugfix: Fixed E_NOTICE error "Trying to get property of non-object".
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41955 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:40:28 +00:00
Ingo Schommer
35c5b08b37 mlanthaler: Bugfix: Fixed E_NOTICE error due to uninitialized variable.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41954 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:39:23 +00:00
Ingo Schommer
59fbe53120 mlanthaler: In PasswordField::performReadonlyTransformation() was an E_NOTICE error. Instead of fixing it, I changed also the behavior.
There are displayed now always five stars, so it is impossible to use the information of the password length for brute-force attacks. 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41953 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:38:05 +00:00
Ingo Schommer
71f9ac0c10 mlanthaler: Bugfix: Added isset() to prevent E_NOTICE error.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41952 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:36:17 +00:00
Ingo Schommer
b358c50f2f mlanthaler: Bugfix: If DataObject::add_extension() is used more than once per class, previously the extensions were overwritten and so only the last one was usable.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41951 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:34:40 +00:00
Ingo Schommer
efd51a2b1e mlanthaler: Add support for _manifest_exclude files (http://support.silverstripe.com/gsoc/ticket/36).
Now it is possible to exclude directories from their inclusion by the ManifestBuilder? by simply adding a "_manifest_exclude" file. This file can be placed in any directory and then that directory and all its subdirectories won't be included anymore.
ischommer: merged with current ManifestBuilder, lots of differences 
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41950 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:29:52 +00:00
Ingo Schommer
56853999bb elofgren: VAR FIX: Prevent 'auth' from being undefined in HTTP::sendRequest()
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41941 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:07:51 +00:00
Ingo Schommer
180c06fd15 elofgren: BUGFIX: Make 'Remember me next time?' setting work even if the ':' in _COOKIEalc_enc? is converted to '%3a' by calling urldecode($_COOKIEalc_enc?) See: http://www.silverstripe.com/google-summer-of-code-forum/flat/1826#post1832
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41940 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:07:24 +00:00
Ingo Schommer
5a06cb4684 elofgren: Add note 'The constant 'BOUNCE_EMAIL' should be defined as a valid email address for where bounces should be returned to.' because I was unsure what BOUNCE_EMAIL should be set to until I found reference to it on: http://doc.silverstripe.com/assets/classes/default/_sapphire_core_Email_php.html
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41939 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:06:22 +00:00
Ingo Schommer
49fa87cceb elofgren: VAR FIX: Prevent errors when sending newsletter drafts by initializing variables and calling isset() and empty() where needed in core/Email.php
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41938 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:05:58 +00:00
Ingo Schommer
67743359a1 elofgren: Add needed isset($_GETshowtemplate?) to SSViewer_FromString::process() to prevent errors when sending a newsletter draft.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41937 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:04:33 +00:00
Ingo Schommer
b0d65bba2e elofgren: Add description to TogglePanel? class.
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41936 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:03:27 +00:00
Ingo Schommer
7256d2dfdc elofgren: USABILITY: Add + and - toggle icons to TogglePanel? and use 'cursor: pointer;' to make it obvious that it is clickable. Move toggle images to sapphire/images/
(merged from branches/gsoc)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41935 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:03:01 +00:00
Ingo Schommer
1c90231f45 mlanthaler: Reverted change of r38052.
DataObject::addExtension() is now again DataObject::add_ex
(merged from branches/gsoc)
ischommer: naming change already reverted


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@41934 467b73ca-7a2a-4603-9d3b-597d59a354a9
2007-09-15 21:02:33 +00:00