Ingo Schommer
931182d0b2
BUGFIX BUGFIX Fixed redirection to external URLs through Security/login with BackURL parameter (merged from trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71709 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:06 +13:00
Andrew O'Neil
4cbf0d60ae
BUGFIX: Disable DataObject validation temporarily while importing yaml fixtures
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71642 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:06 +13:00
Normann Lou
3778a67274
BUGFIX: i18n::include_by_locale() should skip check the web root level and ../webroot level for language file, this is not only "not necessary" but also "must" because some server configuration prevent from any file access above the site root folder.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@71499 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:06 +13:00
James Kirkus-Lamont
ed0905870b
BUGFIX removed extra colon appearing in SilverStripeNavigator
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70891 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:04 +13:00
Sam Minnee
65e3917fef
Don't let content negotiator clobber the mime types of things other than HTML & XHTML
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70845 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:04 +13:00
Sam Minnee
3131b476a6
Replaced HTTPReponse settings of Content-type header with Content-Type, to match RestfulServer
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70844 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:04 +13:00
Sean Harvey
d53962ade9
MINOR Ensure that $result is defined before calling array functions on it in SiteTree::getClassDropdown()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70833 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:04 +13:00
Sean Harvey
67d6d81e76
BUGFIX $hide_ancestor hides Page as well when set from multiple subclasses of Page. Thanks dio5!
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70832 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:04 +13:00
Sam Minnee
abcf34ef98
BUGFIX #3415 ajshort: Requesting root page via ajax now preserves isAjax value.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70784 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:03 +13:00
Normann Lou
dec5108f16
BUGFIX:
...
1. If DataObjectDecorator::extraFields() return an numeric array for its summary field, it need to convert to associative array like what DataObject did.
2. Not all DataObject has a 'Title' database field, but all DataObject has a 'Title' field due to function DataObject::getTitle() exists.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70725 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:03 +13:00
Normann Lou
01e715212c
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70696 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:02 +13:00
Will Rossiter
d0da8b8796
MINOR: fix for ticket 3384. Instead of messing round with added requirements back if you cannot merge them just return
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70587 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:01 +13:00
Normann Lou
e855e4d126
MINOR: in-line documentation correction
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70571 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:01 +13:00
Will Rossiter
91ded94943
BUGFIX: merged patch from ajshort. Fixed getURL() so it preserved the extension
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70497 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:01 +13:00
Will Rossiter
ee77297762
MINOR: merged patch from simon_w. Removed unnesscary comments
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70494 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:01 +13:00
Will Rossiter
80fe8fff03
MINOR: merged patch from simon_w. Changed can*() methods to check they are sent valid member objects rather then arrays
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70493 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:01 +13:00
Will Rossiter
8c014c55f3
MINOR: merged patch from simon_w: added check to Children() to make sure user has canView() rights
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70483 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:01 +13:00
Will Rossiter
15f73e7fae
FEATURE: added silverstripe version number to meta generator tag
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70422 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:00 +13:00
Will Rossiter
64e61cc250
MINOR: added empty statics to allow decoration
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70409 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:00 +13:00
Will Rossiter
fd482d66a4
MINOR: SilverStripeNavigator toolbar is now i18n friendy
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70400 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:00 +13:00
Sean Harvey
af4637ae61
MINOR phpDoc for DataObjectDecorator->updateCMSActions()
...
MINOR Whitespace removal at end of DataObjectDecorator class
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70255 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:00 +13:00
Sean Harvey
56162a4683
MINOR Update phpDoc for DataObject->getFrontEndFields()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70252 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:27:00 +13:00
Sean Harvey
8c65cf88f1
MINOR Renamed DataObjectDecorator->updateFormFields() to updateFrontEndFields() to be more accurate to the extended method
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70251 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:59 +13:00
Sean Harvey
ebd5087b31
ENHANCEMENT Added nicer (and more useful) error message if ErrorPage cannot open the error HTML file for writing
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70190 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:59 +13:00
Sean Harvey
ec5ed83512
MINOR If the error-404.html or error-500.html file can't be opened, supress the warning so an error isn't shown in the CMS
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70188 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:59 +13:00
Andrew O'Neil
efde576662
BUGFIX: Add workaround for PHP bug #46753
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70160 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:59 +13:00
Sean Harvey
efefdd7444
MINOR phpDoc for Varchar->getName()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70154 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:59 +13:00
Sean Harvey
e85c00f0c7
MINOR Removed redundant code from Varchar
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70153 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:59 +13:00
Sean Harvey
0cb9633bbf
MINOR Fix potential undefined variable errors in Query->column() and Query->keyedColumn() by always returning an array, even if it's empty. This now conforms to the phpDoc for these two functions, instead of returning null if there's no $column variable set
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70133 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:58 +13:00
Sean Harvey
6555d08b11
MINOR Defined $column as an array so "undefined variable" error is supressed
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70132 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:58 +13:00
Sean Harvey
dd4228fc1d
ENHANCEMENT Creation of a new page type now uses a consistent source of classes that respect $hide_ancestor on SiteTree.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70131 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:58 +13:00
Hayden Smith
2c9ed2dfcc
Added missing Decimal->nullValue method.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70090 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:58 +13:00
Sean Harvey
e06da464aa
BUGFIX Removed ID for back links table which is ambiguous, unncessary and caused the CSV export to break
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70063 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:58 +13:00
Sean Harvey
87c47227ef
MINOR Removed redundant code
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70061 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:58 +13:00
Sean Harvey
cabf2c8a5e
ENHANCEMENT Added a table for showing linked pages in the Report -> BackLinks tab
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70060 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:58 +13:00
Hayden Smith
3d6a492e93
API CHANGE: Decimal->requireField now includes 'not null' constraint, as Sapphire doesn't expect the value to be null. MySQL switches null values to 0.00 on build.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70057 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:58 +13:00
Sean Harvey
53bc0a28dc
BUGFIX Deleted setting of $content variable that broke HTTP::findByTagAndAttribute()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70052 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:58 +13:00
Normann Lou
f46517fe19
MINOR: fix on-line documentation syntax so that phpDocumentor can creating automatically the API doc
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70048 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:57 +13:00
Sam Minnee
cf9aba3944
Removed unnecessary db query in CMS tree generation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69983 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:57 +13:00
Sam Minnee
1057f9621f
Added Versioned::prepopulate_versionnumber_cache() to allow for querying efficiencies
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69981 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:57 +13:00
Ingo Schommer
53e2a035f9
ENHANCEMENT Calling augmentSQL() on decorators in DataObject::get(), which is necessary (among others) to limit ContentController->getMenu() with Translatable enabled to the currently active language. Was previously just implemented in DataObject::get_one()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69954 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:57 +13:00
Ingo Schommer
464cd2c129
ENHANCEMENT Passing through same arguments in SiteTree::get_by_url() than in the wrapped DataObject::get_one()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69953 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:57 +13:00
Ingo Schommer
0cd41ac16d
ENHANCEMENT Removing specialized routing for Translatable from Director->currentPage() and ModelAsController->getNestedController. Calls SiteTree::get_by_url() now, which abstracts out the Translatable handling.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69952 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:57 +13:00
Ingo Schommer
fb113e589e
BUGFIX More solid string-parsing through regular expressions in SQLQuery->filtersOnID() and SQLQuery->filtersOnFK(), incl. unit tests
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69951 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:57 +13:00
Sam Minnee
cabe233e61
EHANCEMENT #3326 hamish: Added Image::getOrientation()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69925 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:56 +13:00
Ingo Schommer
10cdb8e05c
BUGFIX Allowing to pass $context into Hierarchy->markPartialTree() and Hierarchy->markChildren()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69910 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:56 +13:00
Ingo Schommer
e25a15893e
ENHANCEMENT Allowing for passing of $context in Hierarchy->markChildren()
...
BUGFIX Making sure a valid DataObjectSet is returned from Hierarchy->stageChildren()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69909 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:56 +13:00
Ingo Schommer
941a9eb7bd
ENHANCEMENT Allowing more arguments in Object->extend() (merged from branches/translatable in r64523, thanks wakeless!)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69896 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:56 +13:00
Ingo Schommer
e07094adad
ENHANCEMENT Added SQLQuery->filtersOnFK() (merged from branches/translatable in r64523, thanks wakeless!)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69895 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:56 +13:00
Ingo Schommer
2df8b0a13e
BUGFIX Fixed Translatable::get_existing_content_languages() SQLQuery generation (was assuming a -yet unimplemented- $Lang property on SiteTree instead of SiteTree_lang).
...
BUGFIX Using baseDataClass() in Translatable::get_existing_content_languages()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69894 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:26:56 +13:00