tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
4,238 Commits 31 Branches 527 Tags 162 MiB
90514f2ae3
Commit Graph

388 Commits

Author SHA1 Message Date
Sam Minnee
6387f735e3 BUGFIX Only replace double slashes in SS_HTTPRequest->__construct() for relative- its a failsafe against wrongly formatted URLs like 'admin//assets' instead of 'admin/assets', but breaks absolute URLs with 'http://' prefix (from r103099) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112120 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 03:31:53 +00:00
Sam Minnee
eef3ff8021 BUGFIX: disallow numeric actions - numeric array indexes are incorrectly picked up as allowed actions (#5331) (from r103092) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112118 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 03:30:54 +00:00
Sam Minnee
83f117f58c MINOR Using canView() instead of deprecated can('view') in ContentController (from r102909) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112070 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 01:46:33 +00:00
Sam Minnee
64a561f96c BUGFIX Fixing RquestHandler->checkAccessAction() on PHP 5.2 - ReflectionMethod->class returns inconsisent results in older PHP versions. (see r102003) (from r102730) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112069 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 01:46:02 +00:00
Sam Minnee
e8e7065ff4 MINOR Fixed indentation (from r102009) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112055 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 01:26:16 +00:00
Sam Minnee
1d61bf7100 BUGFIX Prevent handling of controller actions which return $this avoid infinite loops in RequestHandler->handleRequest (thanks Hamish!) (from r102004) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112054 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 01:24:53 +00:00
Sam Minnee
740e49061f API CHANGE Disallow methods/actions in RequestHandler->checkAccessAction() which are implemented on parent classes (e.g. ViewableData and Object), unless access is controlled through $allowed_actions. This limits information exposure from getters used in template contexts. (from r102003) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112053 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 01:24:15 +00:00
Sam Minnee
28c2c67355 BUGFIX Checking for existing redirections in FormResponse::respond (fixes #5208) (from r101958) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112050 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 01:21:45 +00:00
Sam Minnee
2996e2a60d BUGFIX: disable function re-enabled (from r101792) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112036 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 01:07:35 +00:00
Sam Minnee
1e860727db BUGFIX: put back into the SSNavigator the archived site link (#5251) (from r101623) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112011 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:55:11 +00:00
Sam Minnee
9246add340 MINOR: fixed notice level error (from r101600) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112005 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:50:16 +00:00
Sam Minnee
559a05b059 MINOR Removed rewritest.php places in sapphire since it's no longer part of the phpinstaller/branches/2.4 package (from r101353) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111995 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-13 00:43:39 +00:00
Sam Minnee
1dcc5401f6 MINOR Fixed missing closing <div> in ContentController->successfullyinstalled() (from r101254) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111977 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-12 21:58:09 +00:00
Sam Minnee
51e34da550 BUGFIX Don't delete index.php after successful installation - in ContentController->deleteinstallfiles(). URL routing might rely on it without mod_rewrite. 
BUGFIX Require ADMIN permissions for ContentController->deleteinstallfiles() - together with retaining index.php this removed a vulnerability where unauthenticated users can disrupt mod_rewrite-less URL routing. (from r101227)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111974 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-12 21:56:06 +00:00
Sam Minnee
9f2ca79c67 BUGFIX Cookies set to a value other than NULL (effectively unsetting the cookie) will now use the httpOnly parameter by default for better XSS protection (from r101045) (from r101046) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111570 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:40:50 +00:00
Sam Minnee
94d98b18ac ENHANCEMENT Redirecting to translated page when original is requested with a 'locale' GET parameter (e.g. 'about-us/?locale=de_DE' will redirect to 'ueber-uns' with a 301 HTTP response). Implemented in ContentController->handleRequest(). (see #5001) (from r100937) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111545 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:24:01 +00:00
Sam Minnee
ddce6c2210 BUGFIX RequestHandler::handleRequest is now compatible with Controller::handleRequest in that SS_HTTPRequest is the type hint for the $request parameter (from r100919) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111540 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-04 04:20:49 +00:00
Andreas Piening
e59e0431e4 MINOR: Director::currentPage() is deprecated but shouldn't throw a notice-level error until the next major release. (from r100670) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@108761 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-08-02 00:43:51 +00:00
Ingo Schommer
56ba78b2a5 API CHANGE Removed deprecated function RootURLController::get_homepage_urlsegment(), please use RootURLController::get_homepage_link() instead! (from r100493) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105579 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 03:58:22 +00:00
Ingo Schommer
584e8a5ee6 MINOR Changed @deprecated note for Director::redirectBack to 2.5 as it's still widely used (from r100483) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105573 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-05-25 03:54:29 +00:00
Ingo Schommer
3dc4486f3b MINOR Added Requirements for SilverStripeNavigator (see r99080) (from r99097) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102845 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 04:08:02 +00:00
Ingo Schommer
14fb2a387f BUGFIX: Only show live link when page has been published (from r97839) (from r99089) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102844 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 04:07:26 +00:00
Ingo Schommer
ab9dffb735 BUGFIX: Make sure draft/published links go to the right subsite (from r97747) (from r99087) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102842 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 04:06:43 +00:00
Ingo Schommer
fc6ffa5e94 FEATURE: Add Link to silverstripe navigator (from r97407) (from r99080) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102839 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 04:03:40 +00:00
Ingo Schommer
54330495a2 APICHANGE: Use the same navigator items in the CMS that are used on the frontend (from r97395) (from r99079) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102837 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 04:00:43 +00:00
Ingo Schommer
8bdeeba73e BUGFIX: Ensure that ModelAsController::init() can trigger redirections. (from r98702) (from r99067) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102834 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:59:37 +00:00
Ingo Schommer
87b98eaa66 BUGFIX: fix incorrect link in CMS (from r97408) (from r99050) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102826 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:53:19 +00:00
Ingo Schommer
c1165c2ca0 BUGFIX: Make sure CMS link knows when its currently in the CMS (from r97403) (from r99049) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102825 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:52:52 +00:00
Ingo Schommer
9284d63827 FEATURE: Make navigator items more overloadable (from r97376) (from r99047) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102824 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:52:28 +00:00
Ingo Schommer
8a781341c9 FEATURE: Refactor links in $SilverStripeNavigator so modules can add extras (from r97299) (from r99046) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102823 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:51:56 +00:00
Ingo Schommer
d3e45dfc7a BUGFIX Fixed quoting on ContentController::successfullyinstaller() - this broke certain databases like PostgreSQL (from r98777) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102796 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:31:20 +00:00
Ingo Schommer
b54937e5dd MINOR Removed debug code 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102783 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-14 03:05:18 +00:00
Ingo Schommer
e43f6d8a0d MINOR Documentation (from r98372) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102646 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 03:20:59 +00:00
Ingo Schommer
c5fda512d6 BUGFIX: Don't force SSL when running from CLI (from r98272) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102639 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 03:19:00 +00:00
Ingo Schommer
0a4d5ca990 BUGFIX: Updated SiteConfig-based theme selection to remove inappropriate coupling from SSViewer (from r98263) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102636 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 03:18:10 +00:00
Ingo Schommer
b7c59241df BUGFIX: Let ModelAsController::init() extensions trigger redirections. (from r97767) (from r98221) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102628 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 02:29:24 +00:00
Ingo Schommer
37e9c9e569 BUGFIX: remove the possibility that Director::isDev() could be recursively called when putting isDev=1 in $_GET, addressed in ticket #4978 (http://open.silverstripe.org/ticket/4978) (from r97926) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102556 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 01:45:00 +00:00
Ingo Schommer
ee4174c0e2 Added values for new permission code 'VIEW_DRAFT_CONTENT' test (from r97898) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102551 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 01:43:29 +00:00
Ingo Schommer
9a04ca62d2 Added test for new permission code. (from r97897) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102550 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 01:42:50 +00:00
Ingo Schommer
54d166c4ce ENHANCEMENT: 2.4 tickets (#4670), new permission code to view draft stage w/o CMS access (from r97895) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102548 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 01:33:49 +00:00
Ingo Schommer
930b051182 BUGFIX Checking that URL controller in HTTPRequest->match() is a subclass of Controller, not RequestHandler (which would include nested controllers like Form or FormField subclasses that shouldn't be accessible on their own toplevel URL namespace) (from r97881) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102547 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 01:30:43 +00:00
Ingo Schommer
d43c990e56 BUGFIX Using i18n::get_locale() in ContentController->ContentLocale() to ensure the correct locale can be used in templates withouth Translatable enabled (broken in r97207, thanks DesignCity) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102544 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-13 01:05:45 +00:00
Ingo Schommer
29ea7e0b98 BUGFIX Use BASE_PATH and BASE_URL instead of data from $_SERVER. 
API CHANGE: Determine default BASE_PATH/BASE_URL from the __FILE__ content, so that the script that initiated the Sapphire process doesn't matter.  This means that index.php doesn't need to manipulate those variables. (from r97731)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102528 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 23:15:04 +00:00
Ingo Schommer
40899c3bfb BUGFIX: Don't rely on the current working directory for any file access; use BASE_PATH. (from r97728) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102527 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 23:14:36 +00:00
Ingo Schommer
e717044628 API CHANGE Deprecated ContentController->LangAttributes(). Use ContentLocale() instead and write attribute names suitable to XHTML/HTML templates directly in the template. 
ENHANCEMENT Added ContentController->ContentLocale() to allow XHTML/HTML specific lang= attribute settings in custom template code (see #4858). Removed <meta http-equiv="Content-Language"...> tag in SiteTree->MetaTags().
ENHANCEMENT Updated blackcandy theme to use new $ContentLocale attribute to set the locale of the current page (in Page.ss) (from r97207)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102433 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 03:39:35 +00:00
Ingo Schommer
02353639d6 BUGFIX: Amended some references to HTTPResponse, replacing with SS_HTTPResponse (from r96746) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102373 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 02:35:58 +00:00
Ingo Schommer
d56bc3e4dc BUGFIX: Added better handling of rendering SiteTree objects, to prevent test errors. (from r89963) (from r96729) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102351 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-04-12 01:53:16 +00:00
Andrew Short
0c13c7a091 BUGFIX: Fixed nested URLs operation for pages more than 4 levels deep. 
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95902 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-12-18 05:19:28 +00:00
Sean Harvey
bb14045626 BUGFIX Fixed ModelAsController::findOldPage() failing on MSSQLDatabase using "sqlsrv" driver (from r94885) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95628 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-12-16 05:43:54 +00:00
Sean Harvey
e64443b50d MINOR: added cookies to Director::test() (from r94684) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95620 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2009-12-16 05:42:43 +00:00