Commit Graph

12762 Commits

Author SHA1 Message Date
Igor
7f39fb50a6 updating comments for HTTPRequest - immutability
SS_HTTPRequest can be read like an array, e.g. echo $request['a'], but cannot be written like an array, e.g. $request['a'] = 5; Added comment to caution people.

See line 375:
==================================================================
	/**
	 * @ignore
	 */
	public function offsetSet($offset, $value) {}
	
	/**
	 * @ignore
	 */
	public function offsetUnset($offset) {}
==================================================================

Might be good to write something about how you are supposed to modify a request, or what you are supposed to do instead (a redirect?).
2014-03-05 13:21:54 +13:00
Devlin
3c1e82b42c Upload: retrieve existing File if an object without an ID is given and replaceFile=true 2014-03-04 18:02:33 +01:00
Damian Mooyman
23f5f08eda BUG Fix DataObject::loadLazyFields discarding original query parameters
BUG Fix Versioned::writeToStage failing to write object with unchanged fields
2014-03-04 16:12:07 +13:00
Damian Mooyman
1cc366fe23 Merge pull request #2850 from kinglozzer/2827-member-extend
FIX: Rewrite Member getCMSFields to ensure updateCMSFields is only run once (fixes #2827)
2014-03-04 13:42:17 +13:00
Damian Mooyman
53b5adbcd9 BUG Prevent unnecessary reconstruction of ClassName field after default records are generated 2014-03-04 12:03:45 +13:00
Simon Welsh
ccb791995e Merge pull request #2894 from wilr/3.1-manymanyyaml
Add support for many_many_extraField in YAML
2014-03-04 11:35:58 +13:00
Simon Welsh
4f0ee925d1 Merge pull request #2911 from silverstripe-iterators/pulls/reset-failedlogincount
Reset FailedLoginCount on successful password reset
2014-03-04 11:35:18 +13:00
Simon Welsh
697a010e5a Merge pull request #2915 from torleif/patch-2
Update preview.md
2014-03-04 11:34:22 +13:00
torleif
c3994f4ce7 Update preview.md
The JavaScript entwine example contains an extra jQuery wrapper
2014-03-04 11:32:45 +13:00
Colin Richardson
7b13041449 Remove trailing dashes from URLSegment 2014-03-03 22:22:03 +00:00
Andrew Short
78678acdad Merge pull request #2912 from sanjaymundhra/patch-5
Update 1-building-site
2014-03-03 20:54:55 +11:00
sanjay
fb0fe3e689 Update 1-building-site
Possessive pronoun "your" was misspelled as "you"...so the required change performed.
2014-03-03 15:24:10 +05:30
Will Rossiter
fb0d349cee Merge pull request #2910 from mullerivan/patch-1
Update css.md
2014-03-03 17:54:30 +13:00
Ingo Schommer
c047a7b990 Reset FailedLoginCount on successful password reset 2014-03-03 17:47:16 +13:00
mullerivan
a7d1991f70 Update css.md 2014-03-03 02:40:33 -02:00
Simon Welsh
41cdacba06 Merge pull request #2893 from silverstripe-iterators/pulls/forgot-password-veto
Allow vetoing forgot password requests
2014-03-03 12:19:09 +13:00
Ingo Schommer
ae31362e21 Merge pull request #2867 from oddnoc/form-docs-consolidation
Combine form validation topic with forms topic
2014-03-03 10:32:04 +13:00
Ingo Schommer
c4ca3b1da4 Merge pull request #2870 from svandragt/patch-1
Better visibility of key phrasing
2014-03-03 10:30:55 +13:00
Ingo Schommer
3023639354 Merge pull request #2886 from KarlKl/patch-1
Silverstripe.com is not this version
2014-03-03 10:30:35 +13:00
Ingo Schommer
f00672bb83 Merge pull request #2889 from howardgrigg/patch-1
MINOR Corrected links for 'Topics' documentation index
2014-03-03 10:30:07 +13:00
Ingo Schommer
edd9738957 Merge pull request #2898 from torleif/patch-1
Update shortcodes.md
2014-03-03 10:29:56 +13:00
Ingo Schommer
c3fcb916f6 Merge pull request #2899 from IgorNadj/patch-1
Update File.php
2014-03-03 10:29:39 +13:00
Ingo Schommer
b489f40866 Added 3.0.9 changelog 2014-03-03 10:19:08 +13:00
Damian Mooyman
f543041b9c Merge pull request #2905 from feejin/urlsegment-leading-dashes
Fix: remove all leading dashes from URLSegments
2014-03-03 09:56:47 +13:00
Ingo Schommer
ead3e26378 Added 3.1.3 changelog 2014-03-03 08:54:18 +13:00
Colin Richardson
1795b21df0 Remove redundant underscore and update the comment 2014-03-02 15:03:02 +00:00
Will Rossiter
c74137e679 FIX: getMessageFromSession returning null on first access 2014-02-28 21:24:16 +13:00
Damian Mooyman
c1e0f98f87 BUG Fix case where setFolder('/') would break UploadField::fileexists
BUG Prevent Upload from writing to the site root folder
2014-02-27 14:23:32 +13:00
Igor
3e5ac7cdcc Update File.php
Adding warning, took me a couple hours to figure this out...

The file does not get moved because of this line:
https://github.com/silverstripe/silverstripe-framework/blob/3.1/filesystem/File.php#L515

Maybe add to the method doc, telling people to set ParentId and Name instead if they want to change the location of a file (if that's the correct method).
2014-02-26 14:09:09 +13:00
torleif
56e0c72cb0 Update shortcodes.md
Trying to link to [embed] causes the parser to break. (see: http://doc.silverstripe.org/framework/en/reference/shortcodes)
2014-02-26 13:39:14 +13:00
Ingo Schommer
9afcf8f01a Allow vetoing forgot password requests 2014-02-25 13:05:32 +13:00
Will Rossiter
8b92300622 Add support for many_many_extraField in YAML
Format is

RelationName:
  - =>Obj.name:
    ExtraFieldName: "Foo"
2014-02-24 22:03:53 +13:00
Ingo Schommer
8ab0fd879d Merge pull request #2892 from silverstripe/log_formatter_defaults
Adding defaults for unhandled event priorities in log formatters.
2014-02-24 21:48:10 +13:00
Sean Harvey
af01d7f024 Adding defaults for unhandled event priorities in log formatters.
Unhandled types wouldn't show up in the error format message, and a
notice "undefined $errtype" is displayed on these cases.
2014-02-24 15:41:03 +13:00
Ingo Schommer
d6b75acbc4 Added 3.1.3-rc2 changelog 2014-02-24 10:08:09 +13:00
Damian Mooyman
d7a8b0fca4 Merge pull request #2884 from TomSpeak/patch-2
DOC: SapphireTest `objFromFixture`
2014-02-24 08:08:03 +13:00
Ingo Schommer
85972dcf6d Merge pull request #2878 from tractorcow/pulls/fix-folder-find-illegalpath
BUG Fixed critical issue with Folder::find_or_make failing to handle invalid filename characters
2014-02-22 20:57:09 +13:00
Howard Grigg
733bc42dd7 MINOR Corrected links for 'Topics' documentation index 2014-02-22 17:16:07 +10:00
Thomas Speak
437cbe0d91 DOC: SapphireTest objFromFixture
The current docs for `objFromFixture` cause PHPStorm to generate an error because of the mismatched data types.

`$product = $this->objFromFixture('ProductPage', 'StandardSpecs');`

Causes: `Expected The, got string`.
2014-02-21 10:21:18 +00:00
KarlKl
2ae65a6f3d Silverstripe.com is not this version
On Silverstripe.com(http://doc.silverstripe.com/framework/en/3.0/topics/shortcodes) is an older version of this file.
From the "Built-in Shortcodes"-heading down to the bottom the page is marked as code.

Cheers
K
2014-02-21 09:04:53 +01:00
Damian Mooyman
194393d705 Merge pull request #2883 from TomSpeak/patch-1
DOC: DropdownField __construct
2014-02-21 12:36:08 +13:00
Thomas Speak
c7e57e0087 DOC: DropdownField __construct
Current docs make PHPStorm spew errors about data types.

`new CheckboxSetField('Countries'...);`

Causes `Expected The, got string`.

Simple restructure.
2014-02-20 23:04:53 +00:00
Damian Mooyman
042e7a5e5c Merge pull request #2882 from sanjaymundhra/patch-4
update dataobject.md
2014-02-21 10:06:53 +13:00
Damian Mooyman
ebeb663ddf BUG Fixed critical issue with Folder::find_or_make failing to handle invalid filename characters
BUG Fix UploadField duplicate checking with invalid folderName
2014-02-21 09:11:34 +13:00
sanjay
fff9222dd3 update dataobject.md
fixex typo
2014-02-20 16:40:47 +05:30
Fred Condo
46695d3b4b Combine form validation topic with forms topic
- Proofread entire file (forms & form validation topics)
- Re-wrap paragraphs to 80 columns
- Correct/update links from other doc files
2014-02-19 13:43:17 -08:00
Loz Calver
90952e7bd4 FIX: Ensure valid CSS classes for GridField header (fixes #2361) 2014-02-19 21:17:52 +00:00
Ingo Schommer
429fdfaa72 Merge pull request #2873 from kinglozzer/2872-ie8-jquery-ondemand
FIX: IE8 support in jquery.ondemand.js (fixes #2872)
2014-02-20 07:19:35 +13:00
Loz Calver
a681bd7bd2 FIX: IE8 support in jquery.ondemand.js (fixes #2872) 2014-02-19 16:57:27 +00:00
Sander van Dragt
ced49d9090 Better visibility of key phrasing 2014-02-19 11:25:44 +00:00