Commit Graph

1876 Commits

Author SHA1 Message Date
Sam Minnee
c4b358e26e Work to decouple the ManifestBuilder from the database, so that you can run manifest builder tests without an active database existing
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61152 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:47:48 +00:00
Sean Harvey
29ccb18fac BUGFIX ComplexTableField_popup.css "overflow: auto" should only be applied to the container HTML element instead of HTML and BODY which can
introduce double scrolling and thus poor usability



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61151 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:44:24 +00:00
Sean Harvey
7f6be42004 ENHANCEMENT Added getter method for CompositeField->children
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61149 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:41:55 +00:00
Sean Harvey
dc5607d8f0 ENHANCEMENT If title not passed into TextareaField constructor, it defaults to the name value
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61147 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:36:45 +00:00
Saophalkun Ponlu
cad9147916 Fixed bug with CsvBulkLoader
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61136 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:01:41 +00:00
Saophalkun Ponlu
f6754178d9 uncommmented processRecord that process each record because it was mistakenly commented previously
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61135 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 03:55:23 +00:00
Saophalkun Ponlu
727a1f52fc change the return type of processAll of CsvBulkLoader from DataObjectSet to int, the number of affected row
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61122 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 02:38:45 +00:00
Saophalkun Ponlu
802b93be2e modified csv import function documention. It returns number of affected records.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61120 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 02:29:37 +00:00
Sam Minnee
ed07c0acf2 Made some methods on SearchFilter public so that SearchFilters can be co-opted for other purposes. Really, moving the magic to a DataQuery object would be better
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61067 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-19 10:09:28 +00:00
Sam Minnee
ec9a40ee50 Fixed bug in TableListField sort links
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61065 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-19 10:07:28 +00:00
Sam Minnee
292140897a Allow querystrings in arguments passed to Controller::join_links()
Fix FormField::Link() to allow querystrings in the form's action


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61064 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-19 10:06:43 +00:00
Sam Minnee
23d6fb8952 Turn off default caching
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61063 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-19 10:05:52 +00:00
Sean Harvey
aca28b981b MINOR Added FieldSetTest to the test library
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60949 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 05:13:46 +00:00
Saophalkun Ponlu
505fef0791 Removed double quoute from the from fields as it means field terminator
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60937 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 04:23:24 +00:00
Will Rossiter
900baba303 BUGFIX: #1458 - GEOIP now does not return any error if it cannot look up the ip address (as it uses a shell command this is not enabled on many WAMP systems)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60920 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 03:13:40 +00:00
Sam Minnee
8d62fbf1aa Fixed bug in Member::mapInCMSGroups()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60912 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:51:55 +00:00
Sam Minnee
53cc576dab Reverted Folder::CanEdit() to its original behaviour; that of returning a many-many join. Note that this conflicts with DataObject::CanEdit() now.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60911 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:51:35 +00:00
Sam Minnee
3fe588bbf5 Added ComplexTableField::getCustomFieldsFor() that you can overload in subclasses of ComplexTableField to create alternative pop-up forms
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60910 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:50:39 +00:00
Sam Minnee
2d0233f2b1 Added table references to many-many join used by scaffolder, to remove 'ambiguous column' bugs
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60909 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:49:44 +00:00
Saophalkun Ponlu
ffb5d82bc2 replaced <br /> with newline for CSV export
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60907 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:41:38 +00:00
Sam Minnee
75ae9859ae API CHANGE: Added Validator::set_javascript_validation_handler() and ->setJavscriptValidatorHandler(), to choose a different way of dealing with javascript validation. Currently 'none' and 'prototype' are the only legal options, but 'jquery' would be an obvious thing to implement.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60894 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:07:37 +00:00
Sam Minnee
b4c593e63d Added warnings for parts of Member that require the newsletter module. Note that this code should really be moved to the newsletter module at some stage.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60885 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-17 22:24:57 +00:00
Sam Minnee
76797cc5e1 Made all sapphire/thirdparty classes _manifest_exclude'd
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60874 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-17 01:08:10 +00:00
Sam Minnee
25f8cd78c5 Renamed illegal function that was hiding in Time.php
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60873 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-17 01:07:26 +00:00
Sam Minnee
b92b2a5887 Fixed saving of blank values to the has_one relations on versioned objects
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60830 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-15 03:08:03 +00:00
Sam Minnee
72c9bdda5a Fixed HasManyComplexTableField and ManyManyComplexTableField in trunk
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60829 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-15 02:43:51 +00:00
Sam Minnee
1cc1fb2805 Fixed bugs with Image upload fields
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60779 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 22:20:32 +00:00
Sam Minnee
4acd84a837 Trap potential data-integrity bug
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60778 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 22:20:14 +00:00
Ingo Schommer
c706dbdcc1 BUGFIX Fixed TableListField->Link() to allow for instanciation without a form/controller (e.g. for unit tests)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60757 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 08:19:02 +00:00
Ingo Schommer
d38d7208b7 BUGFIX Fixed ScaffoldINGComplexTableField file name
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60756 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 07:12:25 +00:00
Ingo Schommer
125ca5801b BUGFIX Fixed DataObject::fieldLabels() to detect labels on inherited database fields
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60726 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 04:43:47 +00:00
Ingo Schommer
4dc20e699d ENHANCEMENT Removed recently added DataObject::$result_permissions and replaced with more specific TableListField::permissions_for_object()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60724 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 04:43:15 +00:00
Ingo Schommer
16a5b9b745 BUGFIX Fixed partial merge from nzct (originally from r47039, partially merged in r60440)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60723 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 04:38:22 +00:00
Sam Minnee
3942a9b609 Ensure that a theme template is tried before getting a non-theme template
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60717 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 03:57:46 +00:00
Sam Minnee
50790d8098 Added logging of SSViewer and Controller behaviour when using ?debug_request=1
API CHANGE: Template precedence changed.  Page_results now takes precedence over HomePage.  That is, all action templates of parent classes take precedence over the actionless templates.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60711 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 03:35:13 +00:00
Ingo Schommer
e7cbdbc07d BUGFIX Fixed $this reference in static Member call
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60710 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 03:30:32 +00:00
Saophalkun Ponlu
7063547b58 API CHANGE: Allow DataObject searchablefields to be decorated with updateSearchableFields
API CHANGE: Allow Group CMS fields to be decorated with updateCMSFields
API CHANGE: TableListField utility links no longer have target=_blank

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60665 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 23:57:53 +00:00
Saophalkun Ponlu
e020ff3f25 Removed error when saving checkboxsetfield with no values.
Added tests for CheckboxSetField

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60664 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 23:56:27 +00:00
Ingo Schommer
cb2919f56d ENHANCEMENT Added Maori to i18n::$common_languages
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60645 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 22:09:06 +00:00
Ingo Schommer
67e427cdf6 BUGFIX Reinstated error_handling(E_ALL) for dev environments in main.php after clarifying with sam - we want to force developers to recard notice-level errors unless they expicitly opt-out in their _config.php
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60643 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 21:49:52 +00:00
Ingo Schommer
3663221773 ENHANCEMENT Showing error level in custom error handlers on DebugView and CliDebugView
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60637 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 08:40:02 +00:00
Ingo Schommer
be2d56e7d7 BUGFIX Disabled mandatory override of default PHP error handler to E_ALL when in dev mode (which means you have no way of overriding error_reporting() in your _config.php, and by that no way of disabling e.g. E_NOTICE level errors)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60636 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 08:24:14 +00:00
Sam Minnee
8b3056fcd0 Removed notice level error when ArrayLib::valuekey() is passed an empty array
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60612 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 04:33:33 +00:00
Sam Minnee
7f72a0120b Correct line numbers in error source fragment view
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:54:50 +00:00
Sam Minnee
ab6d6dd32f Ensure that MySQLDatabase::tableList() always returns an array
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60607 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:54:04 +00:00
Sam Minnee
26f3dc26da Fix error in Geoip when REMOTE_ADDR isn't set
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60606 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:43:37 +00:00
Sam Minnee
300dfa9d07 Include full traces in unit test failures, for easier debugging
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60605 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:42:45 +00:00
Sam Minnee
ec96a10a20 Removed unnecessary chatter from test runner
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60604 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:41:54 +00:00
Sam Minnee
cad5130fb5 Improved db/build output for CLI
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60603 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:41:21 +00:00
Sam Minnee
45ee7149d7 Improved robustness of FunctionalTest HTML testing.
Removed junk output from stderr

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60602 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:40:56 +00:00