tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
8,581 Commits 31 Branches 527 Tags 162 MiB
8c9560d288
Commit Graph

696 Commits

Author SHA1 Message Date
Ingo Schommer
95eedee6d6 BUGFIX Force tidy to avoid wrapping long lines in CSSContentParser, it breaks our FunctionalTest string assertions 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111176 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:53 +13:00
Sean Harvey
2002073fcc BUGFIX Fixed regression where coverage report request did not get passed through to runTests() in TestRunner::all() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111092 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:52 +13:00
Sean Harvey
3c51c0cd71 BUGFIX Fixed regression of dev/tests/all running a coverage report instead of just unit tests 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111091 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:52 +13:00
Ingo Schommer
3d820173ce ENHANCEMENT Added custom test listener for PHPUnit in order to call setUpOnce() and tearDownOnce() on SapphireTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111050 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:52 +13:00
Ingo Schommer
23590932fa BUGFIX: Allow execution of a test without a current controller. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111044 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:51 +13:00
Ingo Schommer
73784b416a MINOR: added phpdoc to the new PHPUnitWrapper classes. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111042 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:51 +13:00
Ingo Schommer
bdd57f3e75 ENHANCEMENT: refactored runTests, using the new phpunit wrapper classes. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111041 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:51 +13:00
Ingo Schommer
2343465df4 API-CHANGE: remove include which is not required. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111040 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:51 +13:00
Ingo Schommer
73824f3a24 ENHANCEMENT: Created a phpunit wrapper class to ensure that Sapphire's test framework is capable of running unit tests, coverage report and retrieve clover-statistics for PHPUnit 3.4 and PHPUnit 3.5 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111039 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:50 +13:00
Ingo Schommer
12c3bfb1fb MINOR Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110847 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:50 +13:00
Will Rossiter
3191f4d46a ENHANCEMENT: added the ability to toggle the use draft site setting 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110757 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:49 +13:00
Mateusz Uzdowski
2d264d4f40 ENHANCEMENT: disable basic auth by default, tests run on the assumption it is disabled. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110211 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:48 +13:00
Andreas Piening
5ba5c88248 MINOR: repair installer for sqlite 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109787 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:48 +13:00
Sean Harvey
c86d297b0d MINOR CSSContentParser::__construct() now gives a better error if the content could not be parsed. This will mostly happen if tidy isn't present. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109274 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:47 +13:00
Sean Harvey
a9e965283d MINOR phpDoc updates for SS_LogFileWriter and SS_LogEmailWriter 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109165 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:47 +13:00
Sam Minnee
96294391e0 MINOR: Fix links etc, and remove www. from SS urls 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109105 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:46 +13:00
Sam Minnee
edeeb2f077 ENHANCEMENT: Added -v / --verbose option to dev/tests/*, to make it output every single test name before it starts that test. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109104 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:46 +13:00
Sam Minnee
22d9c1fb4e Added dev/tests/emptydb to clear out test session databases. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109099 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:45 +13:00
Sean Harvey
6671b03ecf BUGFIX SapphireTest::create_temp_db() should restore the SS error handler from the PHPUnit one temporarily in case there's any errors building 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108509 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:43 +13:00
Sean Harvey
375696a964 MINOR Fixed failing tests because of locale not being set to the default in SapphireTest::setUp() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108500 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:43 +13:00
Sean Harvey
1b52224622 BUGFIX Database password input in installer should be password, so that the password is obfuscated when input 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108432 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:42 +13:00
Saophalkun Ponlu
818ef70018 MINOR: Add trailing slash to image tag (thanks to mattclegg) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108376 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:41 +13:00
Ingo Schommer
3d901bb0cc MINOR Documentation in CSVBulkLoader 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108048 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:40 +13:00
Sam Minnee
8a7578e08e BUGFIX: Don't allow reinstalling without first making the user manually delete mysite/_config.php 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108026 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:39 +13:00
Ingo Schommer
71a9ff089d MINOR Moved class-specific documentation from doc.silverstripe.org back into class-level PHPDoc 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107725 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:38 +13:00
Ingo Schommer
8dee93b523 BUGFIX Allowing dev/build in "live" mode when Security::database_is_ready() returns FALSE (typically happens when an existing SilverStripe project is upgraded and database columns in Member/Permission/Group have been added) (fixes #4957) 
MINOR Using Object::create() in DevelopmentAdmin to make objects mockable
ENHANCEMENT Added Security::$force_database_is_ready to mock database_is_ready() state
ENHANCEMENT Added permission check exception in TaskRunner and DatabaseAdmin if SapphireTest::is_running_test() returns TRUE (necessary for DevelopmentAdminTest)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107415 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:36 +13:00
Sean Harvey
3be26a4cec ENHANCEMENT #5352 Decouple date display from i18n locales, users now have access to change their date and time formats in Member::getCMSFields() using Member_DatetimeOptionsetField field 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107326 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:35 +13:00
Ingo Schommer
34ec202c0d ENHANCEMENT Added TestRunner::$coverage_filter_dirs to exclude certain directories from PHPUnit test coverage reports 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106877 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Ingo Schommer
4eb8a346a8 BUGFIX Making status description in Debug::friendlyError() compatible to HTTP 1.1 spec (removing any markup and newlines) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106867 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Ingo Schommer
a50d4fbc10 MINOR Fixed memory limit setting in SapphireTest (regression from r106128) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106190 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:31 +13:00
Sam Minnee
2f9dddc0ea MINOR: Preserve memory_limit between tests (for better PHP5.1 behaviour) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106128 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Ingo Schommer
d7efcc4aaf MINOR Removed db/build legacy wording in DevelopmentAdmin (fixes #5676) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106083 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sean Harvey
7cc9709123 BUGFIX MySQLDatabaseConfigurationHelper::getVersion() will fallback to trying to get the version using a query if mysql_get_server_info() returns nothing 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106071 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:29 +13:00
Sean Harvey
83a433894a ENHANCEMENT Added MySQLDatabaseConfigurationHelper::getDatabaseVersion() which abstracts the version number away from the version check the installer requires 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105712 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:28 +13:00
Sean Harvey
8c99b2ec18 MINOR Show better message if couldn't find MySQL version in MySQLDatabaseConfigurationHelper 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105516 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:28 +13:00
Ingo Schommer
3cfc9ed744 ENHANCEMENT Added CSSContentParser->getByXpath() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105126 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:26 +13:00
Sean Harvey
761a73b958 BUGFIX Fixed correct input ID in install.js due to change in r105029 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105030 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:26 +13:00
Sean Harvey
d602d55477 BUGFIX Fixed inconsistent styling of reinstall actions at the bottom of the installer, and if using IIS, warn that this will overwrite the web.config file, not .htaccess 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105029 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:26 +13:00
Luke Hudson
849992a7fa BUGFIX: TestSession::submitForm throws proper error if form not found 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104972 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:25 +13:00
Sean Harvey
376ee3c665 MINOR Reverted r104923, as current database releases of mssql and sqlite3 modules don't support this yet 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104924 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:25 +13:00
Sean Harvey
559dd5992e API CHANGE Added interface method DatabaseConfigurationHelper::requireDatabaseVersion(), all database helpers that implement DatabaseConfigurationHelper must now have this method, which as of now is MySQL, PostgreSQL, SQL Server and SQLite 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104923 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:25 +13:00
Sean Harvey
25e6f8c08f ENHANCEMENT Added MySQLDatabaseConfigurationHelper::requireDatabaseVersion() to check whether the connected instance is using version 5.0+ 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104706 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:23 +13:00
Sean Harvey
cea5cf86ea MINOR Tweaks to positioning of help text in installer 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104704 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:23 +13:00
Luke Hudson
4b9b1dd928 FEATURE: Add dev/tests/sessionloadyml to load a yml fixture into an existing test session 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104231 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:20 +13:00
Luke Hudson
281e22b71e FEATURE: Add dev/build/defaults to call requireDefaultRecords 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104093 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:20 +13:00
Sean Harvey
f92e9d42ac BUGFIX CSSContentParser now reports better errors by using simplexml_load_string() instead of SimpleXMLElement directly 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103552 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:16 +13:00
Ingo Schommer
1f1dda8643 MINOR Fixed phpdoc documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103398 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:15 +13:00
Ingo Schommer
df671a35f3 MINOR Fixed phpdoc documentation (from r103390) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103391 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:15 +13:00
Ingo Schommer
6f0df9eb19 MINOR Fixed phpdoc documentation (from r103385) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103388 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:15 +13:00
Sean Harvey
3ddf6c7d5b MINOR Fixed phpDoc @package and @subpackage for MySQLDatabaseConfigurationHelper 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102149 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:11 +13:00
Will Rossiter
ba88bc4419 MINOR: use red font instead of gray when displaying error 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101729 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:08 +13:00
Sean Harvey
f225418065 MINOR Removed fullstop where it wasn't needed 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101688 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:07 +13:00
Sean Harvey
83554f4102 MINOR Tidied up the layout of the Themes area of the installer slightly - now consistent helptext as other areas 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101687 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:07 +13:00
Sean Harvey
19273e2cd6 MINOR Updated CMS Admin Account text to be more precise 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101686 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:07 +13:00
Sean Harvey
98d64916ed MINOR Altered wording in installer for localised interface 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101683 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:07 +13:00
Will Rossiter
19b7bf2077 ENHANCEMENT: tidied up installer process to streamline process. Moved requirements to top and button to bottom and added visual seperation of the individual steps 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101661 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:06 +13:00
Will Rossiter
5804a20a18 ENHANCEMENT: refactored requirements section to hide successful tests 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101381 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:05 +13:00
Sean Harvey
bd41a235e3 ENHANCEMENT Added links to installation introduction text for sources of help and suggested web hosts 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101378 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:05 +13:00
Sean Harvey
bc728ae194 MINOR Made reinstall message more precise by adding web.config to the files that will get overwritten 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101341 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:05 +13:00
Sean Harvey
6e4a3b6a8f ENHNACEMENT Installer no longer asks for firstname and surname for default CMS admin account, this can be changed later on and doesn't need to be entered for installation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101314 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:05 +13:00
Ingo Schommer
3fd6d47e86 MINOR Moved "theme" section further down in the installer, its much less likely to be changed than the database connection and admin account fields. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101282 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:04 +13:00
Ingo Schommer
4511f0a57d MINOR Fixed regression in install.js option selection (see r101173) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101251 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:04 +13:00
Ingo Schommer
82ce507baf ENHANCEMENT Improved wording and styling in installer. Added links to server requirements, themes download, tutorial. Decreased vertical space before the "install" button to make it more obvious. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101246 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:04 +13:00
Sean Harvey
0d12dd7532 BUGFIX Don't run click() on all inputs, but input:radio only 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101173 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:03 +13:00
Sam Minnee
9f27260d02 MINOR: Fix output format of buildbot test runs to not include colour control codes. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101172 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:03 +13:00
Sean Harvey
4b191bdaba BUGFIX #5216 Installer has issues with click handlers applied to the entire li, be more specific and apply it to the label and input instead 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101167 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:03 +13:00
Sam Minnee
4d19553254 API CHANGE: Allow on_db_reset() methods on DataObjects as well as DataObjectDecortators 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101119 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:02 +13:00
Sean Harvey
d5124fc43e BUGFIX #5202 Installer now properly populates database configuration inputs from request after user clicks "Re-check requirements" 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101087 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:01 +13:00
Ingo Schommer
e5326c18ca ENHANCEMENT Allowing SQLite selection in installer 
ENHANCEMENT Moved all Javascript containedin  install.php and config-form.html to install.js, and using jQuery to simplify logic
ENHANCEMENT Allow installer to attach custom form fields based on the install driver (as defined in _register_database.php)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101054 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:00 +13:00
Tom Rix
8764524695 MINOR tests can now require default records on classes 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101025 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:59 +13:00
Sean Harvey
4f3f7f7dcf MINOR Updated required version to 5.1 in php5-required template 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100988 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:58 +13:00
Sean Harvey
399de6abdd MINOR Removed whitespace from "Development servers" textarea for installer 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100978 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:58 +13:00
Ingo Schommer
cf56c444ff MINOR Fixed "disabled" styling for database options in config-form.html (showed all as green when "use _ss_environment" was ticked 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100965 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:58 +13:00
Ingo Schommer
76db86d5cb ENHANCEMENT Added help text for "locale" setting in installer 
MINOR Changed <div> hierarchy in config-form.html to allow right-aligned help texts which horizontically align with their respective field sets on the left.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100940 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:57 +13:00
Ingo Schommer
1ec5c18ab5 BUGFIX Allow DatabaseAdmin to run dev/build in live mode when not Security::is_database_ready(), and avoid broken login due to broken db queries (selecting unknown columns before dev/build) (see #4957) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100924 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:57 +13:00
Sean Harvey
5c79ee20fa ENHANCEMENT Added DatabaseAdapterRegistry::unregister() to remove a database from the registry 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100908 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:57 +13:00
Sean Harvey
cac5cd0c84 MINOR Changed the way DatabaseAdapterRegistry accepts databases 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100898 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:56 +13:00
Sean Harvey
a887aa3042 BUGFIX #5176 Javascript error in IE for the installer - use "this" instead of e.target which doesn't work 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100866 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:55 +13:00
Sean Harvey
878bb894c4 MINOR Supress notice if $_REQUEST['url'] doesn't exist in Debug::showError() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100832 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:53 +13:00
Andreas Piening
7b3255af5d MINOR: removed sqlite msg 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100801 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:53 +13:00
Tom Rix
27f20c5948 ENHANCEMENT you can now choose your site locale at install time 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100769 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:52 +13:00
Tom Rix
74293ba3d7 BUGFIX allow selection of database adpater 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100727 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:51 +13:00
Tom Rix
fa761d32b4 BUGFIX misspelled variable 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100726 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:51 +13:00
Ingo Schommer
83675fc248 BUGFIX Fixed SapphireTest->loginWithPermission() and MemberAuthenticatorTest to use existing Members based on their unique_identifier_field (if existing) to accommodate recent Member->onBeforeWrite() changes (see r100705) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100723 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:51 +13:00
Tom Rix
1a3225f4f0 MINOR remove the sqlite databases from the installer list. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100697 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:51 +13:00
Tom Rix
015336e54d ENHANCEMENT show all database systems we support, along with messages if the user cannot use them. Also allow 3rd parties to register their own database classes to appear in this list. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100696 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:51 +13:00
Sean Harvey
f6b40002ff MINOR Added note about other databases 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100669 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:50 +13:00
Sean Harvey
d1294f5026 MINOR When the installer is using the environment for configuration, disable the development servers textarea as it's automatically configured from environment 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100622 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:49 +13:00
Sean Harvey
b35fb2b5ad BUGFIX #4572 Fixed Windows failure on SS_Cli::supports_colour() because posix functions are not supported 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100560 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:49 +13:00
Sean Harvey
1e46412cdb MINOR Wording change in installer for database details not correct 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100552 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:48 +13:00
Sean Harvey
1e59be7137 MINOR Fixed undefined variable $error in MySQLDatabaseConfigurationHelper 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100550 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:48 +13:00
Sean Harvey
87c03b4750 BUGFIX If fixture file is NULL don't cause the test framework to break down because of it 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100548 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:48 +13:00
Sean Harvey
149496dda4 MINOR Use "email" instead of username for validation of admin account during install 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100418 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:45 +13:00
Sean Harvey
bdb3af9177 BUGFIX #5136 Ensure $coverage argument to TestRunner::runTests() has a strict check before running coverage tests, as sometimes an SS_HTTPRequest object can be passed into this argument 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100415 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:45 +13:00
Sean Harvey
f851803652 MINOR Updated installer to use "CMS / Framework" instead of just "CMS" 
MINOR Updated copyright year to current year



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100387 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:44 +13:00
Luke Hudson
1caedebafe BUGFIX: Fix TestRunner coverage pattern to work as documented (Fixes QA scripts too) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100116 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:44 +13:00
Tom Rix
8a929e07a4 ENHANCEMENT you can now do coverage tests of single/multiple tests, or entire modules 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@99954 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:43 +13:00
Sean Harvey
e3bf1384e7 ENHANCEMENT #4043 Allow setting the from address for debug information in SS_LogEmailWriter - thanks Hamish! 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@99845 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:42 +13:00
Sean Harvey
3f3962f041 ENHANCEMENT #5024 Installer now checks that the user has entered a username and password correctly for the default admin, an additional button for re-checking requirements is now found at the bottom of the admin configuration section 
ENHANCEMENT Error messages for database AND admin configuration are now in the same place at the top of the installer


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@99841 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:42 +13:00
Ingo Schommer
e4463092cb BUGFIX Fixed DataObject->fieldLabels() to respect flag (from r98748) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@99640 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:39 +13:00
Ingo Schommer
508ead95e9 MINOR Fixed SapphireTest->logInWithPermission() spelling 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@99491 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:38 +13:00
Ingo Schommer
7a6da70076 BUGFIX Enforcing creation of temp database in SapphireTest->setUp() to avoid writing to production databases. This check should only kick in for single test case runs, as the temp database connection should be set in a dev/tests/all run after the first db-related test anyway. (see #5034) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@99342 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:37 +13:00
Ingo Schommer
d335bf671b API CHANGE: Let any DataObjectDecorator define an on_db_reset() method that is called by tests, like in Versioned. (from r97734) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@99051 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:34 +13:00
Sean Harvey
c72186917c BUGFIX Development server list should be retained when user submits installer form and gets redirected back 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@99005 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:33 +13:00
Mateusz Uzdowski
9769a488dc BUGFIX: testing framework needs to be reset to a clean state after each test: now also nested urls and redirection state will be reverted 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98944 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:32 +13:00
Mateusz Uzdowski
f3da2c48bf REVERT: reverse merging the change, it breaks some tests. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98873 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:32 +13:00
Sean Harvey
9aa0f3dd48 MINOR Fixed clearing issue in installer that was recently removed 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98872 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:32 +13:00
Mateusz Uzdowski
78ec32508e BUGFIX: restore the original nested_urls state after running the test, so we can enable and disable nested URLs within the tests safely. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98860 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:32 +13:00
Sean Harvey
e5666748f6 MINOR Removed return of connection and changed variables to conincide with r98795 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98800 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:31 +13:00
Sean Harvey
c71588868c MINOR Removed whitespace in textarea value that caused an empty string in the development servers list in installer (regression from recent change) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98792 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:31 +13:00
Sean Harvey
14859e16a9 API CHANGE Installer now uses a database configuration helper class which isolates the logic of checking the database away from the installer, this interface can be used by other databases like MSSQL and PostgreSQL. The installer now looks for a specific file inside each database module, provided it's configured in install.php MySQL is provided by default, as it lives in sapphire 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98786 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:31 +13:00
Sean Harvey
84917bfa7e MINOR Styling on installer 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98781 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:31 +13:00
Ingo Schommer
f9f2ed9c8f ENHANCEMENT Added BulkLoader->deleteExistingRecords(), removed unnecessary parameters from BulkLoader->load() (merged from r94250) 
ENHANCEMENT Decreased memory usage in BulkLoader->load() when deleting all records before importing  (merged from r94250)
MINOR Re-enabled CsvBulkloaderTest cases, were disabled by accident (merged from r94250)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98713 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:30 +13:00
Sean Harvey
b947d13cc8 BUGFIX Checkbox for overriding the install from environment now checks for the file existance properly 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98688 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:30 +13:00
Sean Harvey
c5d6316699 MINOR Reverted broken variables in installer for checking environment 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98679 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:30 +13:00
Sean Harvey
a9d5198882 BUGFIX Fixed initial state of "use environment" checkbox in installer 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98678 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:30 +13:00
Sean Harvey
627c106a77 ENHANCEMENT Added checkbox to switch off using the environment during install if it's available 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98677 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:30 +13:00
Sean Harvey
8d7b6d71a9 MINOR Install template cleanup 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98670 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:30 +13:00
Sean Harvey
8945fa7467 MINOR Styling for help text in the installer 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98668 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:29 +13:00
Sean Harvey
04eb782632 MINOR Styling fixes for installer 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98667 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:29 +13:00
Sean Harvey
b152e79de3 MINOR Tidy up of install template 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98666 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:29 +13:00
Sean Harvey
1273092d71 MINOR Changed config-form to HTML 4.01 and validated the page minus a few issues with the form field placement 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98662 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:29 +13:00
Sean Harvey
9d15cb4f38 ENHANCEMENT #3903 Initial changes to installer to support selection of different database drivers 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98659 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:29 +13:00
Tom Rix
0cffea71e9 MINOR disable form fields if they are set from _ss_environment. See #5054 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98643 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:29 +13:00
Ingo Schommer
cb4ec2b3d2 MINOR: Make pass use a password field, dont require call by reference (merged from r72930) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98326 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:26 +13:00
Sam Minnee
e26333e3c9 APICHANGE: Refactor Versioned so a single state is kept for stage, archived date, or any module specific reading modes (from r98161) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98224 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:24 +13:00
Sam Minnee
eba7aa8fc0 ENHANCEMENT: Removed dev/reset, instead encouraging the use of dev/tests/startsession for tests. 
ENHANCEMENT: Let people use dev/tests/startsession without a fixture, instead calling requireDefaultRecords

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98080 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:20 +13:00
Ingo Schommer
c8cefb5d6c MINOR Partially reverted accidental commit from r97920 (unconditionally requiring ADMIN login via BasicAuth in DevelopmentAdmin) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@98079 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:19 +13:00
Sam Minnee
0b8fddc316 MINOR: Preserve theme settings in tests 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@97920 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:18 +13:00
Sam Minnee
c212f40bb5 BUGFIX Use BASE_PATH and BASE_URL instead of data from $_SERVER. 
API CHANGE: Determine default BASE_PATH/BASE_URL from the __FILE__ content, so that the script that initiated the Sapphire process doesn't matter.  This means that index.php doesn't need to manipulate those variables.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@97731 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:15 +13:00
Sam Minnee
9ac547d32d BUGFIX: Don't rely on the current working directory for any file access; use BASE_PATH. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@97728 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:15 +13:00
Sam Minnee
46b9ce6988 BUGFIX: Another bugfix for r97583 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@97593 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:14 +13:00
Sam Minnee
aacaa2569b BUGFIX: Fixed bug that was caused by r97583 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@97589 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:14 +13:00
Sam Minnee
717a7c5062 ENHANCEMENT: Don't set up the test db if database tests aren't being run. 
From: Sam Minnee <sam@silverstripe.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@97583 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:14 +13:00
Sam Minnee
8d3968c637 BUGFIX: Fix display of exception backtrace in CLI view. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@97038 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:09 +13:00
Sam Minnee
078412eedd MINOR: Fixed bugs with test execution. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96829 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:08 +13:00
Sam Minnee
252fbf0ba7 BUGFIX: Don't let Versioned archive tables clutter the global state when testing. 
BUGFIX: Don't let mocked datetimes clutter the global state when testing. (from r96640) (from r96648)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96774 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:07 +13:00
Sam Minnee
ab40216c4a MINOR: Give all test ADMIN privileges by default (from r92208) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96747 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:05 +13:00
Sam Minnee
63096cfefb API CHANGE: Don't generate TestOnly DataObjects in the database immediately; instead let test developers specify them in SapphireTest::$extraDataObjects. 
API CHANGE: Added SapphireTest::resetDBSchema() (from r90054)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96734 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:04 +13:00
Sam Minnee
18a71a3fdb MINOR: Flush get_one cache after rebuilding database schema. (from r89966) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96730 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:04 +13:00
Sam Minnee
5296f59d23 API CHANGE: Renamed SapphireTest::set_up_once/tear_down_once to setUpOnce/tearDownOnce, and made them instance methods. 
API CHANGE: Added SapphireTest::$illegalExtensions and SapphireTest::$requiredExtensions for making tests depending on particular extension sets (from r89958)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96727 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:03 +13:00
Sean Harvey
b359180355 BUGFIX If running a BuildTask via AJAX, e.g. Filesystem::sync() is run from AssetAdmin, don't show the message "Running [task] ..." 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@95169 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:00 +13:00
Andreas Piening
999995b83a MINOR: added cookies to Director::test() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@94684 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:17:58 +13:00
Sam Minnee
974b25920d MINOR: Don't use test manifest for dev/startsession and dev/endsession (from r93528) (from r94431) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@94432 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:17:58 +13:00
Sean Harvey
7b17559ded ENHANCEMENT Allow passing in an Exception object to SS_Log::log() in addition to an array describing the error context (line number, file, trace etc) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@94423 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:17:57 +13:00
Sean Harvey
753cafb240 MINOR Documentation updates to SS_Log 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@94418 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:17:57 +13:00
Sean Harvey
3d8918fdeb ENHANCEMENT Added FunctionalTest::findAttribute() as a helper for getting an attribute from a SimpleXMLElement object by it's name 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@94381 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:17:57 +13:00
Will Rossiter
f1a3e35fa1 MINOR: Tweak to test name display on the test runner 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@94336 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:17:56 +13:00
Sean Harvey
1bdba39dda BUGFIX Fixed newlines for Windows when logging errors in LogErrorFileFormatter 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@93161 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:17:38 +13:00
Ingo Schommer
3b794bb97a MINOR Changed silverstripe.com references to silverstripe.org 
MINOR Fixed broken wiki links (#4672)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@90886 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:17:31 +13:00
Ingo Schommer
949cadf377 MINOR Fixed broken links in docblocks 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115949 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-01 20:05:47 +00:00
Sean Harvey
b3bb0a721a MINOR Make test database name all lowercase in case some databases like PostgreSQL have issues trying to detect temp database in use 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115251 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-12-21 04:46:43 +00:00
Sean Harvey
7395271f7e MINOR Ensure php5-required.html template shows correct minimum and recommended PHP versions (thanks mattcleg!) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114915 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-12-13 23:39:04 +00:00
Will Rossiter
815e9efd94 APICHANGE: removed page comments from core. Please see the github.com account for page comments functionality 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114821 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-12-11 05:43:08 +00:00
Sean Harvey
ec2ce32245 ENHANCEMENT #5442 SapphireTest now creates a "tmpdb" database name with a prefix, changed by defining SS_DATABASE_PREFIX. Defaults to "SS_" to namespace SilverStripe temporary database names 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114819 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-12-11 05:27:34 +00:00
Sam Minnee
e340ccb1ad MINOR Fixed PHP strict standard where non-variables cannot be passed by reference (from r113968) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114541 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-12-05 08:39:31 +00:00
Sam Minnee
a2475141c6 MINOR Fixed output spelling mistake and formatting in SapphireTest::delete_all_temp_dbs() (from r113450) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114536 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-12-05 08:35:48 +00:00
Sam Minnee
9ec31acacb ENHANCEMENT Added SecurityToken to wrap CSRF protection via "SecurityID" request parameter (from r113272) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114525 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-12-05 08:22:57 +00:00
Sam Minnee
ecaa735db2 BUGFIX ModelViewer doesn't work due to minor bug introduced by making $_CLASS_MANIFEST keys lowercase (fixes #6144, thanks daniel.lindkvist) (from r113249) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114524 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-12-05 08:20:33 +00:00
Sam Minnee
fc869c1d86 MINOR: Fix to SapphireInfo for git-svn checkouts. (from r112962) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114518 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-12-05 08:06:29 +00:00
Ingo Schommer
07b6d1870a MINOR Checking for class_exists() before SapphireTest::is_running_tests() to avoid including the whole testing framework, and triggering PHPUnit to run a performance-intensive directory traversal for coverage file blacklists 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114332 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-11-30 05:13:09 +00:00
Ingo Schommer
41dad508e4 MINOR Documentation in FunctionalTest and TestSession 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114140 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-11-24 06:23:52 +00:00
Ingo Schommer
19f7484144 BUGFIX Don't rely on existence of REQUEST_URI in LogErrorEmailFormatter (not set on CLI calls) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114138 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-11-24 06:23:51 +00:00
Ingo Schommer
07c821c4a7 ENHANCEMENT Added $argCharLimit to SS_Backtrace::full_func_name(), to avoid printing really long strings its set to 10,000 by default 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114137 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-11-24 06:23:50 +00:00
Ingo Schommer
46dcd20e34 BUGFIX Add PHPUnit includes to SapphireTest class (can be loaded outside of TestRunner for static calls, in which case the PHPUnit autoloaders/includes aren't in place yet) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113156 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-27 19:59:38 +00:00
Sam Minnee
72037a8c5d MINOR Removed "In line of " text in CLI test reporter which did not work. Details are in the backtrace below anyway, so it's not required (from r112321) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112951 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 05:09:13 +00:00
Sam Minnee
fd7babe5a0 ENHANCEMENT Show "Database Configuration" section of installer requirements for reference (collapsed by default) (from r111873) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112934 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 05:03:16 +00:00
Sam Minnee
25af09b0f6 MINOR #5943 Debug::text() boolean values are amended with (bool) so they don't get confused with "true" or "false" which could be strings (thanks Pigeon!) (from r111676) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112918 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 04:52:33 +00:00
Sam Minnee
b9ab0e6e1c BUGFIX Force tidy to avoid wrapping long lines in CSSContentParser, it breaks our FunctionalTest string assertions (from r111176) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112899 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:48:25 +00:00
Sam Minnee
47f27bef87 BUGFIX Fixed regression where coverage report request did not get passed through to runTests() in TestRunner::all() (from r111092) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112893 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:45:26 +00:00
Sam Minnee
0d7d983c14 BUGFIX Fixed regression of dev/tests/all running a coverage report instead of just unit tests (from r111091) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112892 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:44:52 +00:00
Sam Minnee
ea2b86cd1d ENHANCEMENT Added custom test listener for PHPUnit in order to call setUpOnce() and tearDownOnce() on SapphireTest (from r111050) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112888 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:43:01 +00:00
Sam Minnee
67b5116702 BUGFIX: Allow execution of a test without a current controller. (from r111044) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112882 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:36:12 +00:00
Sam Minnee
cb283acb9b MINOR: added phpdoc to the new PHPUnitWrapper classes. (from r111042) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112880 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:35:14 +00:00
Sam Minnee
3006b6ac36 ENHANCEMENT: refactored runTests, using the new phpunit wrapper classes. (from r111041) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112878 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:33:51 +00:00
Sam Minnee
ce92190465 API-CHANGE: remove include which is not required. (from r111040) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112872 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:07:15 +00:00
Sam Minnee
eeb9e36e7a ENHANCEMENT: Created a phpunit wrapper class to ensure that Sapphire's test framework is capable of running unit tests, coverage report and retrieve clover-statistics for PHPUnit 3.4 and PHPUnit 3.5 (from r111039) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112871 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 03:06:55 +00:00
Sam Minnee
d8a8635374 API CHANGE Member->canEdit() returns false if the editing member has lower permissions than the edited member, for example if a member with CMS_ACCESS_SecurityAdmin permissions tries to edit an ADMIN (fixes #5651) (from r110856) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112861 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 02:46:26 +00:00
Sam Minnee
9107cf950b ENHANCEMENT: added the ability to toggle the use draft site setting (from r110757) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112844 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:32:17 +00:00
Sam Minnee
e5dd8c13d3 ENHANCEMENT: disable basic auth by default, tests run on the assumption it is disabled. (from r110211) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112838 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:29:39 +00:00
Sam Minnee
2c7d88aade MINOR: repair installer for sqlite (from r109787) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112830 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:26:27 +00:00
Sam Minnee
99fde26091 MINOR CSSContentParser::__construct() now gives a better error if the content could not be parsed. This will mostly happen if tidy isn't present. (from r109274) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112821 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:23:00 +00:00
Sam Minnee
f929d2ee6d MINOR phpDoc updates for SS_LogFileWriter and SS_LogEmailWriter (from r109165) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112819 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 01:21:32 +00:00
Sam Minnee
f20e83eeaf MINOR: Fix links etc, and remove www. from SS urls (from r109105) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112783 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:56:25 +00:00
Sam Minnee
cda6638281 ENHANCEMENT: Added -v / --verbose option to dev/tests/*, to make it output every single test name before it starts that test. (from r109104) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112782 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:56:02 +00:00
Sam Minnee
0d6cb295c4 Added dev/tests/emptydb to clear out test session databases. (from r109099) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112777 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:54:31 +00:00
Sam Minnee
b2c7c944de BUGFIX SapphireTest::create_temp_db() should restore the SS error handler from the PHPUnit one temporarily in case there's any errors building (from r108509) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112755 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:42:53 +00:00
Sam Minnee
d28d7510af MINOR Fixed failing tests because of locale not being set to the default in SapphireTest::setUp() (from r108500) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112754 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:37:55 +00:00
Sam Minnee
c52dfd1e03 BUGFIX Database password input in installer should be password, so that the password is obfuscated when input (from r108432) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112746 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-19 00:33:12 +00:00
Sam Minnee
229bea6dd4 MINOR: Add trailing slash to image tag (thanks to mattclegg) (from r108376) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112722 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:51:05 +00:00
Sam Minnee
aa4503845f MINOR Documentation in CSVBulkLoader (from r108048) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112712 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:42:12 +00:00
Sam Minnee
a707f925ad BUGFIX: Don't allow reinstalling without first making the user manually delete mysite/_config.php (from r108026) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112710 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-18 22:41:32 +00:00
Ingo Schommer
a0dd4ff8f0 MINOR Moved class-specific documentation from doc.silverstripe.org back into class-level PHPDoc (from r107725) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112608 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:55:22 +00:00
Ingo Schommer
f63751893b BUGFIX Allowing dev/build in "live" mode when Security::database_is_ready() returns FALSE (typically happens when an existing SilverStripe project is upgraded and database columns in Member/Permission/Group have been added) (fixes #4957) 
MINOR Using Object::create() in DevelopmentAdmin to make objects mockable
ENHANCEMENT Added Security::$force_database_is_ready to mock database_is_ready() state
ENHANCEMENT Added permission check exception in TaskRunner and DatabaseAdmin if SapphireTest::is_running_test() returns TRUE (necessary for DevelopmentAdminTest) (from r107415)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112588 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:43:30 +00:00
Ingo Schommer
47762cdf5b ENHANCEMENT #5352 Decouple date display from i18n locales, users now have access to change their date and time formats in Member::getCMSFields() using Member_DatetimeOptionsetField field (from r107326) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112568 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:23:02 +00:00
Ingo Schommer
f7e61e0d11 ENHANCEMENT Added TestRunner::$coverage_filter_dirs to exclude certain directories from PHPUnit test coverage reports (from r106877) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112542 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:07:08 +00:00
Ingo Schommer
9b177ec458 BUGFIX Making status description in Debug::friendlyError() compatible to HTTP 1.1 spec (removing any markup and newlines) (from r106867) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112540 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 03:06:31 +00:00
Ingo Schommer
5fe548f7b5 MINOR Fixed memory limit setting in SapphireTest (regression from r106128) (from r106190) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112525 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:59:10 +00:00
Ingo Schommer
3c18a9f1f6 MINOR: Preserve memory_limit between tests (for better PHP5.1 behaviour) (from r106128) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112521 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:58:02 +00:00
Ingo Schommer
7eaca248e2 MINOR Removed db/build legacy wording in DevelopmentAdmin (fixes #5676) (from r106083) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112517 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2010-10-15 02:56:21 +00:00