Commit Graph

19417 Commits

Author SHA1 Message Date
Ingo Schommer
5027af3926 Consistent 4.0 changelog presentation
- Use "Removed/Changed/Added/Moved" prefixes to make content more scannable
- Removed "change" vs "remove" distinction in subheadings (hard to separate, and not meaningful in practice)
- Linearised messages, less nesting - easier to parse (don't need to remember context from a few lines above)
- Simplified language (e.g. "use" instead of "please use")
- Simplified headline wording (remove repetitive "upgrade code that uses X")
- More anchor links across sections
- More use of diffs to clearly communicate before/after states
- Consistently apply backtick code formatting
- Consistently use "()" to denote methods (easier to read)
- Removed duplicate SQLQuery instructions (and simplified the augmentSQL example)
- Add new composer.json intro
2017-10-24 22:18:46 +13:00
Damian Mooyman
56b49dad34 DOCS Improve high level file documentation (#7501)
* DOCS Improve high level file documentation
Fixes https://github.com/silverstripe/silverstripe-assets/issues/62

* Updates based on feedback
2017-10-24 22:12:28 +13:00
Ingo Schommer
13d2350ad9 More upgrade rules 2017-10-24 21:18:52 +13:00
Damian Mooyman
a4b88c776f Merge pull request #7505 from open-sausages/pulls/4/ch-ch-ch-ch-ch-angesets
Document changesets
2017-10-24 17:05:35 +13:00
Aaron Carlino
4039a2ab61 Remove revert() method reference 2017-10-24 16:13:40 +13:00
Aaron Carlino
47917856c1 Revisions per Damian 2017-10-24 16:08:20 +13:00
Damian Mooyman
e76f01ebfa Merge pull request #7496 from open-sausages/pulls/4/inspect-upgrade-warnings
Upgrading rules for new inspect/warning capabilities
2017-10-24 15:25:34 +13:00
Ingo Schommer
7938b842cc More upgrader rules 2017-10-24 14:26:24 +13:00
Damian Mooyman
ff992de231 Merge pull request #7493 from kinglozzer/require-me-some-isolation
FIX: Use isolated scope when requiring files for module activation
2017-10-24 14:19:37 +13:00
Will Rossiter
ff32f99d1b Tidy up view record button 2017-10-24 14:05:40 +13:00
Damian Mooyman
093e69f6e5 Merge pull request #7506 from NightJar/patch-2
Remove dead code from GridFieldDetailForm
2017-10-24 13:30:26 +13:00
Dylan Wagstaff
7c354525fb Remove dead code from GridFieldDetailForm
There is no action for 'autocomplete', there is no method 'handleAutocomplete', and out of the box there is no extension that applies it.
Manually testing the URL that would take us through such a handler does not give an exception about missing details from the URI (such as a required query string), but instead gives us an exception on there not being a handler for such.
`[Emergency] Uncaught BadMethodCallException: Object->__call(): the method 'handleAutocomplete' does not exist on 'SilverStripe\Forms\GridField\GridFieldDetailForm'`
@ e.g. `http://localhost/admin/pages/edit/EditForm/1/field/ElementalArea/autocomplete`.

Auto complete should be (and is) handled in it's own component code, such as https://github.com/silverstripe/silverstripe-framework/blob/4.0/src/Forms/GridField/GridFieldAddExistingAutocompleter.php#L210
2017-10-24 12:57:08 +13:00
Damian Mooyman
59cc45565b Merge pull request #7503 from andrewandante/patch-4
Spelling in DataQueryTest
2017-10-24 12:04:41 +13:00
Aaron Carlino
dee0754b5a document changesets 2017-10-24 10:30:37 +13:00
Damian Mooyman
13afd6f0d5 Merge pull request #7502 from open-sausages/pulls/4.0/i-converted-an-apple-to-an-orange
Fix switch to using the Convert class for decoding
2017-10-24 10:25:53 +13:00
Andrew Aitken-Fincham
c4a50a3d10 Spelling in DataQueryTest 2017-10-20 12:00:35 +01:00
Sam Minnee
4bec62ba51 Merge branch '4.0' into 4 2017-10-20 18:45:16 +13:00
Damian Mooyman
b9cb1e69e6 BUG Replace phpdotenv with thread-safe replacement 2017-10-20 18:43:11 +13:00
Christopher Joe
4caf34506a Fix switch to using the Convert class for decoding 2017-10-20 14:43:19 +13:00
Chris Joe
b20bfd28a6 Merge pull request #7499 from open-sausages/pulls/4.0/imagick-retry
ENHANCEMENT Don't fail immediately on imagick install
2017-10-20 11:46:21 +13:00
Damian Mooyman
04b4596bec ENHANCEMENT Don't fail immediately on imagick install 2017-10-20 11:04:59 +13:00
Loz Calver
bb9501797f FIX: Use isolated scope when requiring files for module activation 2017-10-20 09:11:00 +13:00
Damian Mooyman
d0ca9bd17a Merge pull request #7490 from open-sausages/pulls/4.0/my-email-children-deserve-the-best
BUG Fix enable email subclasses to use their respective templates
2017-10-19 16:30:37 +13:00
Damian Mooyman
87371ecb4c Merge pull request #7495 from nathanbrauer/patch-1
Adding 308 HTTP Response as n redirect code
2017-10-19 14:44:41 +13:00
Christopher Joe
dabdc905ce
BUG Fix enable email subclasses to use their respective templates 2017-10-19 14:44:04 +13:00
Ingo Schommer
297253170c Upgrading rules for new inspect/warning capabilities 2017-10-19 08:51:18 +11:00
Nathan J. Brauer
bcc2cc6a0b Adding 308 HTTP Response as an redirect code
https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
Often times, 308 are preferred over 301 redirects, as they tell the requester to, for example, re-POST a form submission on the final URL.
2017-10-18 12:27:00 -07:00
Daniel Hensby
6a8540d6d6 Merge pull request #7488 from open-sausages/pulls/4.0/you-have-my-permission-to-htaccess
BUG Fix documentation for permissions
2017-10-18 15:33:30 +01:00
Daniel Hensby
a98782bb99 Merge pull request #7494 from martinduparc/patch-6
Small fix to nginx.conf
2017-10-18 15:30:48 +01:00
Martin D
adfe275cde Small fix to nginx.conf
Source: https://github.com/silverstripe/silverstripe-framework/blob/4.0/docs/en/00_Getting_Started/01_Installation/How_To/Setup_Nginx_and_HHVM.md
2017-10-18 05:52:45 -04:00
Loz Calver
2f4f601497 Merge pull request #7489 from open-sausages/pulls/4.0/many_many_queries_for_images
BUG cache the cacheKey in TreeDropdownField, so it doesn't need to query for it multiple times in the same request
2017-10-18 09:26:51 +01:00
Daniel Hensby
749f74b0d5 Merge pull request #7491 from SilbinaryWolf/doc-icon-menu-icon
DOC Add example for using resource location for pages / modeladmin
2017-10-18 09:01:41 +01:00
Jake B
97dfd9ac47 DOC Add example for using resource location for pages / modeladmin 2017-10-18 15:55:50 +11:00
Christopher Joe
0b3363d0a0 BUG Fix documentation for permissions 2017-10-18 13:21:55 +13:00
Christopher Joe
076d7d78c6 BUG cache the cacheKey in TreeDropdownField, so it doesn't need to query for it multiple times in the same request 2017-10-18 11:49:28 +13:00
Damian Mooyman
2b09216b0c Merge pull request #7270 from robbieaverill/pulls/3.6/fix-trailing-period-on-duplicate-folder-name
FIX Files without extensions (folders) do not have a trailing period added
2017-10-18 10:26:05 +13:00
Robbie Averill
2f579b64cb FIX Files without extensions (folders) do not have a trailing period added 2017-10-18 09:25:27 +13:00
Daniel Hensby
3e9dc5c7d2 Merge pull request #7483 from zanderwar/patch-1
get_environment_type() still exists in SS4
2017-10-17 13:55:49 +01:00
Daniel Hensby
36826a07a1 Merge pull request #7480 from Firesphere/7339-Password_reset_message
[FIX] Password reset message
2017-10-17 13:39:07 +01:00
Reece Alexander
8a1e466c75
get_environment_type() still exists in SS4 2017-10-17 13:00:24 +01:00
Daniel Hensby
dcc21ea21b Merge pull request #7485 from open-sausages/pulls/4.0/sake-path-fixesmore
BUG Ensure sake works when called from any directory
2017-10-17 12:54:37 +01:00
Damian Mooyman
884fdd61b1
BUG Ensure sake works when called from any directory 2017-10-17 13:52:39 +13:00
Chris Joe
cafa3fc29a BUG switch to trigger_error() when a resource is not found (#7468)
* BUG switch to `trigger_error()` when a resource is not found rather than throw an exception

* Add unit test for module url failing
2017-10-16 16:11:42 +13:00
Simon Erkelens
6506a5b958 Don't add a . when there's no extension 2017-10-16 11:56:35 +13:00
Daniel Hensby
8ce6d89e78 Merge pull request #7410 from creative-commoners/pulls/3.7/mark-image-title-as-alt-text
NEW Add (alt text) to title field for clarity
2017-10-13 11:16:37 +01:00
Damian Mooyman
e9e7bd649e Merge pull request #7479 from creative-commoners/pulls/4.0/remove-forums-in-controller-template
DOCS Remove forums link and replace with Slack and Stack Overflow in default controller template
2017-10-13 16:57:47 +13:00
Robbie Averill
eb1ee32571 DOCS Remove forums link and replace with Slack and Stack Overflow in default controller template 2017-10-13 15:03:45 +13:00
Chris Joe
11817592fd Merge pull request #7477 from open-sausages/pulls/4.0/intercept-incorrect-deletes
ENHANCEMENT Allow extensions to intercept incorrect deletes on unpublish
2017-10-13 11:49:26 +13:00
Damian Mooyman
7e97f04e47
ENHANCEMENT Allow extensions to intercept incorrect deletes on unpublish 2017-10-13 10:12:08 +13:00
Daniel Hensby
a244884117 Merge pull request #7476 from webbuilders-group/win-base-url-fix
BUGFIX: Fixed issue on Windows where the BASE_URL constant would get set wrong if the site was in a sub-folder of the web root
2017-10-12 15:31:53 +01:00