Sam Minnee
77c95b3434
MINOR: Hamish is all class. ;-)
2012-04-12 13:19:48 +12:00
Sam Minnée
d766100335
Merge pull request #304 from halkyon/e_strict_fixes
...
Enable E_STRICT by default for development, fix all E_STRICT errors affected by tests.
2012-04-11 17:54:18 -07:00
Sam Minnee
aa659a2326
MINOR: Fixed classname displayed in Hierarchy::markChildren() error. ( #4406 )
2012-04-12 12:38:07 +12:00
Sean Harvey
2b8e14fdff
API CHANGE Fixing CompositeField/SelectionGroup
...
performReadonlyTransformation and performDisabledTransformation to be
consistent and conform with parent FormField. $trans argument is no longer allowed, just uses
DisabledTransformation or ReadonlyTransformation instead.
2012-04-12 12:24:06 +12:00
Sean Harvey
852ffcf492
MINOR MemberDatetimeOptionsetField::validate() now passes in $validator argument instead of getting it from the form, which is how other FormFields work like CompositeField
2012-04-12 12:23:18 +12:00
Sean Harvey
3c70ea4922
MINOR Fixing broken test MemberDatetimeOptionsetFieldTest, passing in null for $validator argument
2012-04-12 12:20:18 +12:00
Sam Minnée
1189322b41
Merge pull request #302 from robert-h-curry/7113-nested-controls-breaking-last
...
BUGFIX: Issue #7113 : Recalculate itemIteratorCount when popping viewer state.
2012-04-11 17:19:46 -07:00
Sean Harvey
865cde0c39
BUGFIX FormField::name_to_label() is now declared as static as it was never used as an instance method
...
API CHANGE FormField::validate() $validator argument is now required for FormField classes
2012-04-12 12:18:55 +12:00
Sean Harvey
8369cded32
MINOR Code formatting in EmailField
2012-04-12 12:17:30 +12:00
Sean Harvey
1e61b76ca8
MINOR ConfirmedPasswordField::validate() now passes in $validator
...
argument instead of getting it from the form, which is how other
FormFields work like CompositeField
2012-04-12 12:14:42 +12:00
Sean Harvey
859f7add20
MINOR TableField_Item::Fields() now conforms to parent
...
TableListField_Item::Fields() for E_STRICT compliance
2012-04-12 12:13:22 +12:00
Sean Harvey
42988ecb18
BUGFIX Argument hinting of FormField instance for TabSet::push() to
...
comply with parent CompositeField::push() for E_STRICT compliance
2012-04-12 12:11:53 +12:00
Sean Harvey
9cf1686786
MINOR Code formatting fixes for CurrencyField
2012-04-12 12:11:22 +12:00
Sean Harvey
fd3de5158d
BUGFIX Use of Link() in security classes now refers to $this->controller
...
instead of calling the instance method Link statically (which isn't
allowed for E_STRICT compliance.)
2012-04-12 12:09:39 +12:00
Sean Harvey
6b40377a1c
BUGFIX Time::setValue() now conforms to DBField::setValue() for E_STRICT compliance.
2012-04-12 12:08:22 +12:00
Sean Harvey
9a9cebb369
MINOR Versioned::add_to_class() now conforms to parent
...
DataExtension::add_to_class() with $args being optional (default to
null). This is for E_STRICT compliance.
2012-04-12 12:07:35 +12:00
Sean Harvey
972dfee5c3
MINOR Fixing E_STRICT compliance in simpletest
2012-04-12 12:06:47 +12:00
Sean Harvey
41433f1211
BUGFIX Fixing FulltextSearchable and Hierarchy to conform to the parent DataExtension for E_STRICT compliance.
2012-04-12 12:06:02 +12:00
Sean Harvey
9bd7068394
MINOR Fixed class documentation for CompositeDBField
2012-04-12 12:04:58 +12:00
Sean Harvey
a9f95051bc
BUGFIX File::ini2bytes() is now declared as static, as it was never an
...
instance method
2012-04-12 12:03:33 +12:00
Sean Harvey
4c1aba8542
BUGFIX Object::get_extensions() is now declared as static, as it was
...
never an instance method
2012-04-12 12:02:13 +12:00
Sean Harvey
630bfcc823
MINOR error_reporting() now defaults to E_ALL | E_STRICT which means
...
strict errors are now reported *unless* the site is in live mode (which
supresses everything except fatal errors and warnings)
2012-04-12 12:01:15 +12:00
Robert Curry
695ae711e7
MINOR: Issue #7113 : Add test for nested loops.
2012-04-12 11:56:49 +12:00
Sam Minnée
d34d57a034
Merge pull request #303 from mateusz/os-7126
...
BUGFIX: remove form auto-detection from the generic JS state handler.
2012-04-11 16:51:36 -07:00
Sam Minnée
b435d0a3d2
Merge pull request #288 from jmwohl/patch-1
...
For png images with transparency, the imagesaveaplpha() needs to be set ...
2012-04-11 16:33:02 -07:00
Mateusz Uzdowski
452a507cc9
BUGFIX: remove form auto-detection from the generic JS state handler.
...
Forms take care of PJAX state on their own in the submit and load functions (os-7126)
2012-04-12 11:31:28 +12:00
Sam Minnée
168eaf72d8
Merge pull request #300 from silverstripe-scienceninjas/feature/ssviewer-enhancements
...
Feature/ssviewer enhancements
2012-04-11 16:29:22 -07:00
Robert Curry
0daa76d0b7
BUGFIX: Issue #7113 : Recalculate itemIteratorCount when popping viewer state.
2012-04-12 11:16:41 +12:00
Ingo Schommer
6a10ed19c1
MINOR Added TinyMCE language pack
2012-04-11 18:05:29 +02:00
Ingo Schommer
e045ffeb29
Merge pull request #205 from AngryPHPNerd/sapphire
...
---
In SS-2.4 you can prefix files with an underscore to exclude them from manifest this can be useful for backups of old classes or huge data files.
I think this behaviour should be readded.
(I will add a unit test for this ...)
2012-04-11 17:32:34 +02:00
Ingo Schommer
a3d99b082d
MINOR Resetting Security::$database_is_ready state during tests (regression from a9509a610d
)
2012-04-11 17:22:55 +02:00
Ingo Schommer
ca24120a5e
MINOR Install screen visual tweaks, more visible disabled state on install button, conditional version number (to avoid it showing without a version), referencing new theme in install screen, using new layout in install progress screen as well
2012-04-11 16:49:31 +02:00
Ingo Schommer
ac45e5b9c0
Merge branch 'integration'
...
Conflicts:
admin/css/ie8.css
admin/css/screen.css
admin/scss/_style.scss
dev/install/config-form.html
dev/install/install.css
dev/install/php5-required.html
2012-04-11 16:31:12 +02:00
Ingo Schommer
aed5e93da2
Merge pull request #301 from stojg/database-is-ready-checks
...
MINOR Security::database_is_ready() check are doing duplicate DB queries...
2012-04-11 06:38:22 -07:00
Ingo Schommer
6cd91ff449
Merge pull request #299 from ajoneil/sapphire
...
---
Conflicts:
forms/NumericField.php
2012-04-11 15:36:35 +02:00
Ingo Schommer
fb12dbe075
Merge pull request #298 from silverstripe-big-o/sapphire
...
---
...s CMS - fixed the issue with the width of the date fields - aligned action buttons in filter panel with the designs.
- There are a couple changes to dropdown widths for the filter side panel in Big-o integration branch already.
Conflicts:
admin/code/ModelAdmin.php
admin/css/screen.css
2012-04-11 15:20:25 +02:00
Ingo Schommer
5ea080a585
Merge pull request #296 from halkyon/old_js_validation_remnants
...
MINOR Removing old client side validation remains - NumericField.js
2012-04-11 06:15:25 -07:00
Ingo Schommer
800d5fbc01
Merge pull request #291 from halkyon/pg_fixes
...
MINOR Fixed failing tests on pgsql
2012-04-11 06:14:57 -07:00
Stig Lindqvist
a9509a610d
MINOR Security::database_is_ready() check are doing duplicate DB queries for Members.
...
The will make sure that if the database has been ready once, it is ready for the rest of the request
2012-04-12 00:29:35 +12:00
Stig Lindqvist
5750eb02b1
Merge pull request #295 from halkyon/redirectorpage_changes
...
MINOR Removed RedirectorPage.js (has been moved to cms module)
2012-04-11 04:10:23 -07:00
Paul Clarke
4f23ac1722
ENHANCEMENT Installer styling, moving away from blackcandy
2012-04-11 22:51:10 +12:00
Hamish Friedlander
5c336329b6
MINOR: When Up called and we are at the top of the scope, throw a useful error, not just an index undefined error
2012-04-11 22:08:05 +12:00
Stig Lindqvist
6f76d42bb2
Merge pull request #290 from stojg/pull/passwordencryptor-config
...
API CHANGE Use Config for registering default password encryptors
2012-04-11 02:59:24 -07:00
Hamish Friedlander
556950de47
MINOR: Add some basic docs on new include feature
2012-04-11 21:57:28 +12:00
Hamish Friedlander
21bf409b7b
BUGFIX: Pass arguments through to subtemplates when rendering those too
2012-04-11 21:50:06 +12:00
Hamish Friedlander
e4a043ac0b
ENHANCEMENT: Allow arguments to be passed to templates via an array passed to SSViewer#process and via keyword=value pairs in the <% include %> tag
2012-04-11 21:34:27 +12:00
Hamish Friedlander
40ca21e6e5
MINOR: Remove bugfix that is (a) unnessecary because the key is already just sha hashes, underscores and numbers and (b) broken because it strips the open and close quotes from the key
2012-04-11 21:30:57 +12:00
Sam Minnee
adf658c91f
BUGFIX: Removed obsolete field File.Sort
2012-04-11 18:13:13 +12:00
Andrew O'Neil
716ff9dcfa
MINOR: Ensure all form fields have FieldHolder() with identical signature to FormField::FieldHolder(). Fixes E_STRICT warnings.
2012-04-11 18:07:55 +12:00
Will Rossiter
d982047545
Merge pull request #297 from halkyon/js_cleanup
...
MINOR Remove empty Security_login.js file.
2012-04-10 23:00:03 -07:00