Ingo Schommer
bf91594e4f
Disable tab state logic on uninit'ed tabs, allow opt-out
...
Fixes a problem when switching between ajax tabs,
e.g. "Content" and "Settings" in admin/pages/edit/show/<id>.
2012-07-13 17:34:55 +02:00
Ingo Schommer
c493dc730a
Avoid lonely question mark for GridField URLs in CMS
2012-07-13 17:33:48 +02:00
Ingo Schommer
155758f546
NEW Save and restore tab state upon CMS navigation ( fixes #7647 )
...
Implemented independently of URL state to ensure that
state is retained on every user interaction, rather than
having to add it to each URL specifically.
Same reasons for not saving it as HTML5 history metadata,
as that's only inspected on history events, not
normal CMS navigation.
2012-07-13 16:46:23 +02:00
Ingo Schommer
a5a08530fc
BUG Force "full" ajax content reload with invalid fragments
...
When one or more fragments are requested that are not in
the current DOM, we need to force loading the outermost
fragment instead (currently hardcoded to "Content").
This mainly prevents history back navigation from breaking,
e.g. admin/pages -> admin/pages/list ->
admin/pages/list/?ParentID=99 -> admin/pages/edit/show/5 -> (back)
2012-07-13 10:19:24 +02:00
Ingo Schommer
7a52a7fe41
BUG Default form submits to text/html, fixing validation ( #7653 )
...
Was using text/json, which Form->httpSubmission() interprets
(correctly) to returning JSON validation data.
This trips up the interface, which expects HTML with
the validation errors directly in the markup.
2012-07-12 17:10:50 +02:00
Ingo Schommer
fa62c1b0ba
Smarter concat of query params in LeftAndMain.js
...
Broke when CMS URL already had query params,
such as ?locale=en_US with the Translatable module enabled.
With this patch it doesn't double-concat ?locale....
Still doubles query params, but that's acceptable
until we find a more solid URL manipulation lib for JS.
2012-06-29 14:23:01 +02:00
Hamish Friedlander
daa226a9af
BUGFIX: Fix trac ticket #7476
...
We missed making an event delegatable in https://github.com/silverstripe/sapphire/pull/542
the result was 7476 wasnt actually fixed
2012-06-22 10:46:03 +12:00
Sean Harvey
c6039ae8d1
BUGFIX When updating the tree from EditForm, ensure we only change the
...
text of the tree node for the first .text element, instead of the nested
ones.
2012-06-20 22:00:19 +12:00
Ingo Schommer
dd99fbc69e
BUGFIX Apply batch action node deselection ( fixes #7476 )
...
The form ID list was only updated on node checking, but not unchecking.
2012-06-18 00:31:27 +02:00
Hamish Friedlander
c12db51c22
BUGFIX: Fix trac/7485
2012-06-18 10:23:04 +12:00
Sean Harvey
c801671a90
BUGFIX #7394 : Allow unselect dropdowns in chosen if there's an empty option
2012-06-15 14:32:21 +12:00
Sam Minnée
7ce7ac406e
Merge pull request #528 from mango9/master
...
Ticket #5578
2012-06-14 16:43:20 -07:00
Ingo Schommer
deff232567
MINOR Using onadd in preview JS
2012-06-15 01:19:31 +02:00
Hamish Friedlander
acee026875
BUGFIX: Buttons in the cms that didnt have .ss-ui-button werent becoming buttons because we changed buttons to trigger on onadd, but the ss-ui-button class was being added dynamically
2012-06-15 01:19:31 +02:00
Ingo Schommer
2fa835a027
MINOR Moving edit form focus logic from onadd() to onmatch() to give the form time to become visible (see #7258 )
2012-06-15 01:19:20 +02:00
Ingo Schommer
ecb48bb57c
BUGFIX Force full window reload on IE7/IE8 every 20 pushState requests (see #7258 )
2012-06-15 01:19:20 +02:00
Ingo Schommer
5260738148
MINOR Avoid reinitialising tabs (see #7258 )
2012-06-15 01:19:19 +02:00
Ingo Schommer
980686ab75
MINOR Limiting console.log() output to explicit enabling through window.debug to avoid failing IE
2012-06-15 01:19:19 +02:00
Hamish Friedlander
21e7ec61f4
ENHANCEMENT: In dev mode, include some basic leak detection functions in the admin panel
2012-06-15 01:19:19 +02:00
Hamish Friedlander
b86a787521
BUGFIX: Use new jQuery.Entwine event capturing, onadd and onremove features to plug some memory leaks
2012-06-15 01:19:15 +02:00
Paul Meyrick
882b4267cb
BUGFIX: Ticket #5578 SiteTree->CanCreateTopLevel() doesn't change dragged tree nodes or ParentID changes
2012-06-14 17:17:27 +12:00
Ingo Schommer
e23a7585a7
MINOR Using new jQuery.changetracker.destroy method in LeftAndMain.EditForm.js
2012-06-13 23:16:13 +02:00
Ingo Schommer
0b6d45356e
MINOR Added destroy() method to jQuery.changetracker plugin
2012-06-13 23:16:09 +02:00
Andrew Short
d9c7bb8eb9
ENHANCEMENT: Implemented help text for form fields.
...
The title attribute is extracted from form fields and displayed inline
below the field.
2012-06-13 13:19:12 +02:00
Andrew Short
513737097b
MINOR: Fixed tab border being shown when tabs were hidden.
2012-06-13 13:46:00 +10:00
Ingo Schommer
ce3d48e310
MINOR Supressed dependencies of tree logic on SiteTree elements (not properly isolated to work well with Folder objects)
2012-06-13 00:51:53 +02:00
Ingo Schommer
896d198890
BUGFIX Correct DOM structure on updating tree nodes from edit forms, adding badge classes to force strike-through styling on deleted nodes (see #7410 )
2012-06-12 19:16:34 +02:00
Ingo Schommer
2637969bcd
API CHANGE Renamed JS event from 'reloadeditform' on 'aftersubmitform', 'beforesave' to 'beforesubmitform'. Listening to bubbled event on container to avoid binding to forms which are removed before the event is triggered.
2012-06-12 17:13:36 +02:00
Andrew Short
34eb1b39dd
BUGFIX: Fixed incorrect variables breaking form submission.
2012-06-11 23:31:02 +10:00
Ingo Schommer
d4baf2d19d
BUGFIX Stability improvements on CMS layout logic
...
- Changed application order
- Fixed layout trigger after preview toggle
- Replaced button row dimension approximation with double application of jQuery.layout() - once before sizing the action panel height to set correct width on container, then again for the height
2012-06-06 21:05:36 +02:00
Ingo Schommer
415a680802
BUGFIX CMS Breadcrumbs and tabs as inline blocks which can span multiple lines, rather than being cropped off ( fixes #6882 )
2012-06-06 21:05:33 +02:00
Ingo Schommer
12f2e1e176
Merge branch 'pjax-multiple'
2012-06-05 14:01:18 +02:00
Ingo Schommer
f794e98d7e
BUGFIX Moved localised JS messages in correct module ( fixes #7393 )
2012-06-04 11:52:31 +02:00
Ingo Schommer
69d3497497
MINOR Fixed node deselection when changing areas (e.g. "pages" to "edit page")
2012-06-04 11:05:05 +02:00
Ingo Schommer
c18c29f464
BUGFIX Updating tree state (after adding/renaming nodes, changing parent). Deselecting nodes when switching to edit view ( fixes #7389 , #7336 , #7309 )
2012-06-03 18:48:47 +02:00
Ingo Schommer
460148c12a
MINOR Debug messages for tracking down JS layout sequence issues (disabled by default)
2012-06-02 12:31:55 +02:00
Ingo Schommer
5a93ee77f8
MINOR Fixed tab selection state
2012-05-30 16:36:26 +02:00
Ingo Schommer
0eac6ea5c3
MINOR Apply loading indicators to all forms, not just .cms-edit-form (which means it includes the "pages list view"). Move to correct place in LeftAndMain.js (not specific to '.cms-content')
2012-05-30 16:36:25 +02:00
Ingo Schommer
19bfd01a60
ENHANCEMENT Declare a single DOM element with multiple Pjax fragments. Unified ajax response handling in CMS, followup from submitForm() refactoring. Removed replacement of arbitrary CSS selectors through Pjax, relies on a fragment now (to keep logic consistent).
2012-05-30 16:36:23 +02:00
Ingo Schommer
75e51de9ed
API CHANGE Moved submitForm() from $('.cms-content') to $('.cms-container'), unifying ajax response handling between panel loading and form submission
2012-05-30 15:07:14 +02:00
Ingo Schommer
5178954311
UNFINISHED Processing multiple PJAX responses on CMS JavaScript, introducing data-pjax-fragment attribute to identify reloadable template parts
2012-05-30 15:07:13 +02:00
Ingo Schommer
5b03f49245
BUGFIX Respecting server-overrides on X-Pjax responses during ajax redirects. Fixes GridFieldDetailForm redirect after delete, e.g. in ModelAdmin. Partially reverts 8b4b896. Closes pull request #488
2012-05-29 11:34:47 +02:00
Sean Harvey
ecf847b61c
ENHANCEMENT Re-instate pinging every 5 minutes in the CMS as a measure
...
to keep sessions alive. Moved Security/ping to admin/security/ping
2012-05-23 17:15:17 +12:00
Mateusz Uzdowski
8d469b66c8
BUGFIX: add missing onunmatches
2012-05-23 16:24:15 +12:00
Sean Harvey
0d4f7a04dc
BUGFIX Fixing incorrect arguments to submitForm() in
...
LeftAndMain.AddForm.js
2012-05-22 15:37:31 +12:00
Sean Harvey
ce7a96b116
BUGFIX Fixed missing comma in LeftAndMain.AddForm
2012-05-22 14:57:30 +12:00
Mateusz Uzdowski
78b7836d04
BUGFIX: add missing onunmatch
2012-05-22 14:49:57 +12:00
Mateusz Uzdowski
ac2567761b
BUGFIX: add missing selectors and namespace qualifiers
2012-05-22 11:29:06 +12:00
Ingo Schommer
7c589f07dc
MINOR Don't invoke layout() in onmatch() for cms-preview, as it causes a gap above the menu/logo div for some reason. It's also unnecessary processing, since the preview is always hidden by default, and layout() will be triggered through redraw() when required (e.g. preview panel expansion)
2012-05-18 20:07:06 +02:00
Ingo Schommer
d23e8ec14c
BUGFIX Fixed cms menu expansion logic when shown alongside preview panel, retain cookie preference
2012-05-18 20:07:06 +02:00
