Ingo Schommer
2a35f2f928
Merge remote-tracking branch 'origin/3.1'
2013-08-07 17:34:11 +02:00
Ingo Schommer
afe06661ef
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
admin/templates/Includes/LeftAndMain_Menu.ss
admin/templates/Includes/ModelAdmin_ImportSpec.ss
admin/templates/Includes/ModelAdmin_Tools.ss
admin/templates/LeftAndMain.ss
admin/templates/ModelSidebar.ss
i18n/i18n.php
templates/ComplexTableField.ss
templates/ComplexTableField_popup.ss
templates/FileIFrameField_iframe.ss
templates/Includes/GridFieldItemEditView.ss
templates/Includes/TableListField_PageControls.ss
templates/RelationComplexTableField.ss
templates/TableField.ss
templates/TableListField.ss
2013-08-07 17:14:47 +02:00
Ingo Schommer
00ffe72944
Translations: Switch to Transifex format
...
- Based on new (last) translation download from getlocalization.com
- Removed untranslated strings. Getlocalization started including those at some point
which is highly annoying, unnecessary and breaks the new transfix system,
since it'll mark all of the english strings as actual translations
- Avoid dots in entities. It confuses the Transifex YML parser
- Removed some locales unknown to Transifex which didn't have any translations anyway
- Removed "lolcat" locale, uses custom notation (en@lolcal)
which SilverStripe's i18n system can't handle
(needs mapping from SS naming to Zend naming)
- Renamed "Te Reo/Maori" locale from "mi_NZ" to "mi" (Transifex/CLDR notation)
- Namespaced all entities used in templates (deprecated usage)
- Converted dots to underscores where template filenames are used for namespaces,
since Transifex YML parsing handles them as separate YML keys otherwise
- Removed whitespace in entity names, SilverStripe i18n can't handle it
- Only allow selection of locales registered through i18n::$all_locales to avoid
issues with unknown locales in Zend's CLDR database
2013-08-07 00:25:16 +02:00
Ingo Schommer
542728cd94
Merge remote-tracking branch 'origin/3.1'
2013-08-03 19:47:32 +02:00
Ingo Schommer
c5442810cf
Merge pull request #2271 from ARNHOE/3.1-twotoneborders
...
Updated field class to use doubleborder mixin
2013-08-03 09:49:23 -07:00
Ingo Schommer
0e7231ff60
API Disable discontinued Google Spellcheck in TinyMCE
...
Replaced by browser-based spellchecking if available (Chrome, Firefox),
with instructions on how to use PSpell as an alternative.
2013-08-03 16:16:45 +02:00
Will Rossiter
919a8c21c3
FIX: pass controller as reference inside closure.
...
Non referenced causes segfaults on PHP <= 5.3.8 environments when opening subtrees in the CMS. Likely the cause of silverstripe-cms/issues/803.
2013-07-31 14:12:08 +12:00
Michael Andrewartha
769b7f2af5
Fixing expanding/collapse CMS menu targeting wrong element
...
If a user clicks the log out button (for example) and the menu is
collapsed, the menu expands and then you have to press log out
again
2013-07-30 15:02:26 +12:00
Arno Poot
fefb7af0f5
BUG Fieldgroup styling
2013-07-28 15:52:39 +02:00
ARNHOE
e71adf6b6b
Added chosen.js support to dropdown in fieldgroup
2013-07-26 20:25:27 +02:00
Arno Poot
968e99f45e
Updated field class to use doubleborder mixin
2013-07-26 16:44:00 +02:00
Hamish Friedlander
0a79ac3592
Merge branch 'origin/3.1'
...
Conflicts:
templates/forms/CheckboxSetField.ss
templates/forms/FormField_holder.ss
templates/forms/OptionsetField.ss
2013-07-19 16:25:38 +12:00
Sam Minnée
2ca089532f
Merge pull request #2219 from chillu/pulls/clickjacking
...
BUG Prevent clickjacking in CMS and Security controllers (fixes #2215 )
2013-07-16 14:35:53 -07:00
Ingo Schommer
d4a1e6d294
BUG Prevent clickjacking in CMS and Security controllers ( fixes #2215 )
2013-07-14 22:44:09 +02:00
ARNHOE
2427d57fa5
Updated loop/if/with to be more consistent
2013-07-14 20:43:52 +12:00
Andrew Short
8a62593754
Merge branch '3.1'
2013-07-10 18:27:19 +10:00
Simon Welsh
e5ed8f1ef2
Merge branch '3.0' into 3.1
2013-07-10 12:31:38 +12:00
Simon Welsh
b506eb1b29
Use httpError() instead of non-existent HTTPResponse_Exception class
2013-07-10 12:30:27 +12:00
Simon Welsh
fbce9fd7cd
Merge branch '3.1'
...
Conflicts:
.travis.yml
docs/en/misc/contributing/code.md
javascript/HtmlEditorField.js
2013-07-05 10:22:58 +12:00
Ingo Schommer
a9f150126c
Fix CMSBatchActionHandler::$allowed_actions
...
Regression from earlier API change to deny actions unless specified
2013-06-28 10:07:57 +02:00
Simon Welsh
1edf45fbed
Merge pull request #2130 from chillu/pulls/allowed_actions-deny
...
API Enforce $allowed_actions in RequestHandler->checkAccessAction()
2013-06-24 12:41:15 -07:00
Ingo Schommer
1046530ff6
"Insert Media" dialog: Prevent loading indicator in IE8+
...
Fixes https://github.com/silverstripe/silverstripe-cms/issues/782
2013-06-24 17:14:32 +02:00
Ingo Schommer
8c9ef8feb9
"Insert Media" dialog: Reposition separately ( fixes #783 )
...
FF21 and IE10 seem to propagate the DOM attribute changes differently
from Chrome: The dimensions can't be set in the same setOptions()
call through jQuery UI here. Fixed this by a separate setOption() call.
2013-06-24 16:13:29 +02:00
Ingo Schommer
fb784af738
API Enforce $allowed_actions in RequestHandler->checkAccessAction()
...
See discussion at https://groups.google.com/forum/?fromgroups#!topic/silverstripe-dev/Dodomh9QZjk
Fixes an access issue where all public methods on FormField were allowed,
and not checked for $allowed_actions. Before this patch you could e.g.
call FormField->Value() on the first field by using action_Value.
Removes the following assertion because it only worked due to RequestHandlingTest_AllowedControllerExtension
*not* having $allowed_extensions declared: "Actions on magic methods are only accessible if explicitly allowed on the controller."
2013-06-24 14:50:40 +02:00
ARNHOE
6e7cae50fd
Updated helplink to 3.1
2013-06-22 18:08:25 +02:00
Tom Densham
3596892001
FIX: GridField button styling
...
Remove all top/bottom margins from buttons and apply to GridFieldButtonRow component. Ensure that all buttons are added to a suitable GridFieldButtonRow in ModelAdmin, SecurityAdmin and Group.
2013-06-21 14:22:00 +01:00
Damian Mooyman
f47383f52e
BUG Fixed issue where file upload via the HTML Editor media dialogue would not prompt users to overwrite existing files
2013-06-20 15:21:18 +12:00
Ingo Schommer
a4189a6744
Merge pull request #2117 from ohararyan/3.1
...
FIX make sure select dropdowns in add page dialog aren't cut off
2013-06-19 05:30:54 -07:00
Ingo Schommer
8769da5622
CMS UI: Resize iframe alongside dialog
...
Fixes regression from 9f600ada2c
2013-06-19 14:28:34 +02:00
Ingo Schommer
2160fb8000
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
admin/javascript/LeftAndMain.js
tests/behat/features/bootstrap/SilverStripe/Framework/Test/Behaviour/CmsUiContext.php
tests/control/ControllerTest.php
2013-06-19 14:03:43 +02:00
Ingo Schommer
94b4237372
Merge remote-tracking branch 'origin/3.1'
2013-06-19 11:17:33 +02:00
Sam Minnée
34287895ef
Merge pull request #2099 from chillu/pulls/insert-media-tweaks
...
Various "Insert Media" dialog tweaks
2013-06-18 21:32:00 -07:00
Ryan O'Hara
36d9563da8
FIX make sure select dropdowns in add page dialog aren't cut off due to .parent-mode class having overflow:auto
2013-06-19 11:27:22 +12:00
Sam Minnée
8bf4d417c6
Merge pull request #2094 from chillu/pulls/dialog-sizing
...
Min/max constraints for CMS dialog
2013-06-18 14:56:41 -07:00
Sean Harvey
726e4c313e
Merge pull request #2084 from chillu/pulls/cmsform
...
Handle ValidationException on CMS forms
2013-06-18 14:41:51 -07:00
Ingo Schommer
04c337dc82
Tab breadcrumbs floating (regression from #1778 )
2013-06-17 01:26:04 +02:00
Ingo Schommer
939773643a
Accessibility: Open main tabs by keyboard focus
...
Regression caused by jQuery UI 1.9 upgrae
2013-06-15 12:23:51 +02:00
Ingo Schommer
ad28a3adc2
Updated browser warning in CMS JS
2013-06-15 11:58:35 +02:00
Ingo Schommer
9e4a7c835f
Accessibility: Visible focus rings
2013-06-15 11:52:02 +02:00
Ingo Schommer
5b651e4593
Only clear tab entries from window.sessionStorage
2013-06-15 11:16:11 +02:00
Ingo Schommer
be62c731f5
Compressed layout in "Insert Media" detail screen
...
- Same font size as other CMS UI
- Smaller thumbnail height
- Less label width and padding for file info
2013-06-15 10:13:45 +02:00
Ingo Schommer
6338b0b2d9
Reduced line height for form field help text
2013-06-15 10:13:45 +02:00
Ingo Schommer
4bc2f9bc0d
Localization-resilient SCSS selector ( fixes #1590 )
2013-06-15 10:13:45 +02:00
Ingo Schommer
071f30ded7
Consistent dropdown styles between chosen.js and treedropdown
...
Removed trigger background. Incidentally this also makes it less
obvious that the trigger has too much padding on the right
(which I can't figure out ...)
2013-06-15 10:13:45 +02:00
Ingo Schommer
ea4f8cec07
Tighten "Insert Media" dialog layout
...
Reduce space usage to fit into typical dialog dimensions without scrolling
2013-06-15 10:13:44 +02:00
Ingo Schommer
1bd31c84f2
Reduced URL field width in "Insert Media" to avoid wrap
...
450px width are often not available to the dialog (with all margins/paddings subtracted from the window).
Ensure the URL doesn't cause an unnecessary wrap. Ideally we can size this to the dialog width
automatically of course.
2013-06-15 10:13:44 +02:00
Ingo Schommer
10a558c882
Hide "delete" button in "Insert Media" dialog
2013-06-15 10:13:44 +02:00
Ingo Schommer
3f295adbdd
.field.noborder style, use it in "Insert Media" dialog
2013-06-15 10:13:43 +02:00
Will Rossiter
acf42e87c2
Merge pull request #2090 from chillu/pulls/tabs-float
...
Fixed Tab floating in CMS (fixes #1778 )
2013-06-14 00:00:53 -07:00
Ingo Schommer
9f600ada2c
Min/max constraints for CMS dialog
2013-06-13 20:03:16 +02:00
Ingo Schommer
3b40711b98
BUG Resize infinite loops in IE8 ( fixes #575 )
...
IE8 gets a bit confused and fires resize events
when element dimensions in the DOM are changed
as a result of a resize event, causing an infinite loop.
Apart from artificially throttling the event, the only solution
I've found is to check for actual window dimension changes.
http://stackoverflow.com/questions/12366315/window-resize-event-continually-fires-in-ie7?lq=1
This implicitly fixes an issue where TreeDropdownField panel isn't
accessible in the "Insert Media" popup, because the resize event happes
to be triggered by the popup overlay, and in effect closes the drop down
panel right after opening it.
Relating to the jQuery UI component, there's a host of issues and discussions around this, but no solution…
http://bugs.jquery.com/ticket/4097
http://bugs.jqueryui.com/ticket/4758
http://bugs.jqueryui.com/ticket/4065
http://bugs.jqueryui.com/ticket/7514
http://bugs.jqueryui.com/ticket/8881
https://groups.google.com/forum/?fromgroups#!topic/jquery-ui/fDSvwAKL6Go
http://www.mail-archive.com/jquery-ui@googlegroups.com/msg04839.html
2013-06-13 17:37:25 +02:00
Ingo Schommer
5ff69b98ab
LeftAndMain.js: Fix 'X-Reload' for IE10 ( fixes #647 )
2013-06-13 15:17:14 +02:00
Ingo Schommer
d42cbdd613
Removed "Last visited" from admin/myprofile ( fixes #648 )
...
It doesn't make any sense in this context
2013-06-13 15:01:23 +02:00
Ingo Schommer
bfff11eb9c
API New CMSForm class to allow validation responses in CMS ( fixes #1777 )
...
Thanks to @willmorgan for getting this discussion started
(see https://github.com/silverstripe/sapphire/pull/1814 ).
2013-06-13 07:51:05 +02:00
Robert Curry
6ca27cd257
Always load preview when in preview mode, not in edit mode
2013-06-13 07:45:05 +02:00
Robert Curry
a365759a0d
Always load preview when in preview mode, not in edit mode
2013-06-13 11:31:57 +12:00
Ingo Schommer
65209a0ed5
AssetAdmin reset button and chosen.js ( fixes #1640 )
...
See https://github.com/harvesthq/chosen/issues/215
2013-06-13 00:45:59 +02:00
Ingo Schommer
98f8191dff
Fixed Tab floating in CMS ( fixes #1778 )
...
Removed inline-block from header elements which seems
to cause the issues of tabs stacking on top of each other.
Replaced header background to work on multiline scenarios
Added bottom margin to breadcrumbs so they don't look cramped
when tabs are floated below them.
See https://github.com/silverstripe/silverstripe-framework/pull/1863 ,
https://github.com/silverstripe/silverstripe-framework/issues/1943 ,
https://groups.google.com/forum/?fromgroups#!topic/silverstripe-dev/c-W-ZxDlDuA ,
http://open.silverstripe.org/ticket/6882
2013-06-13 00:04:56 +02:00
Will Rossiter
358988e9c6
Merge pull request #2059 from adrexia/batch-actions
...
Batch actions styling
2013-06-03 19:14:13 -07:00
Will Rossiter
cc7a6eeaed
Merge pull request #2060 from adrexia/preview
...
Preview Background styling
2013-06-03 19:00:02 -07:00
Naomi Guyer
aaa8bf0029
Preview Background styling
...
* Added background color to preview for sites that don't have a
background color (based on @clarkepaul's commit:
https://github.com/silverstripe-droptables/sapphire/commit/7750c8f75fc4a
764b384c6e19dbe543c4811cdcb)
2013-06-04 12:57:09 +12:00
Naomi Guyer
91605ca8ad
Batch actions styling
...
* Removed cog icon (usually associated with settings), and tidied up
padding (based on @clarkepaul's commit:
https://github.com/silverstripe-droptables/sapphire/commit/b09cd5f7f8e73
4df1f7ca0d387a5b97a03a3b604)
2013-06-04 12:48:51 +12:00
Naomi Guyer
01e7bfb350
Filter notice styling and panel adjustments
...
* Based on @clarkepaul's commit here:
https://github.com/silverstripe-droptables/sapphire/commit/e5de6c06489f3
449ee8131bf4ee2a4e1b2380bee
* Kept margin adjustments, but avoided implementing tab changes, as
tabs have chnaged a lot since original commit
2013-06-04 12:11:05 +12:00
Ingo Schommer
e137d9e2f0
Merge pull request #2039 from g4b0/sitetree-edit-disabled
...
BUG: fixed "regression" adding a new class to SiteTree elem (edit-disabled)
2013-06-03 04:46:48 -07:00
Will Rossiter
db85f3ca16
FIX extra_requirements to accept non associative arrays.
...
Added unit tests for extra_requirements_js and extra_requirements_css.
Fixed YAML documentation to indicate list syntax.
2013-06-02 13:37:34 +12:00
Ingo Schommer
5a1d476e8d
Merge branch 'idvalidattr' of git://github.com/wilr/sapphire into wilr-idvalidattr
2013-05-31 19:27:19 +02:00
Sam Minnee
4548b67538
NEW: Add LeftAndMain.session_keepalive_ping config option.
...
The Session-keepalive ping that is built into LeftAndMain (i.e. all of the CMS admin) can now be
turned off. The main reason you would want to do this is if you have enabled Session.timeout,
and you want users to be locked out of the CMS after a period.
2013-05-31 16:27:30 +12:00
g4b0
7bcaf90e2a
BUG: fixed "regression" inserted with 9281ebc64764a58f86f685f9765e1d8b60995e5a adding a new class to SiteTree elem (edit-disabled)
2013-05-30 17:09:34 +02:00
Sam Minnee
f1e567eb93
NEW: More helpful message for 'sake dev/build' on new envs.
...
This change alters the no-db message on cli execution to give a bit more of a helpful set-up instruction.
The main motivation for this is so that composer can be set to run dev/build on post-install and post-update.
With that feature added, this will ensure that users installing with composer create-project won't be left
in the dark.
An improvement on this would be a shell script that interactively asked for details to populate this file
with, but one step at a time.
2013-05-30 16:49:43 +12:00
Sean Harvey
a29c51d2db
Merge pull request #2032 from phptek/bug/revert-9741d1
...
BUGFIX: Removed regression introduced in 9741d1.
2013-05-29 21:13:22 -07:00
Russell Michell
b154c0f0e7
BUGFIX: Removed regression introduced in 9741d1. With the former in place, CMS authors can no longer perform batch publish actions
2013-05-30 16:05:56 +12:00
Ingo Schommer
bd918915e2
Merge pull request #2023 from g4b0/left-and-main-classes
...
BUG: correct handling of multiple classes
2013-05-29 07:23:26 -07:00
Loz Calver
9be5f07231
Fixes for LeftAndMain::require_themed_css()
...
LeftAndMain::require_themed_css() was setting an incorrect property, and a typo meant that those requirements would never be detected anyway
2013-05-28 15:48:23 +01:00
g4b0
9fc58feb03
BUG: correct handling of multiple classes
2013-05-28 16:25:25 +02:00
Mateusz Uzdowski
37d6871c15
Add explicit extension trigger to preview iframe updates.
2013-05-26 12:51:25 +12:00
Will Rossiter
831a507c90
FIX: Update references to ID values from 79c9433
2013-05-26 11:11:55 +12:00
Will Rossiter
e1ce3e15d8
PHPDoc updates
2013-05-26 11:11:54 +12:00
Ingo Schommer
67d1327b90
Avoid collision of status flags in tree items when updating tree nodes
...
Fixes silverstripe/silverstripe-cms#445
See https://github.com/silverstripe/silverstripe-framework/pull/1996
Thanks to Jean-Fabien for getting this started
2013-05-25 11:27:50 +02:00
Will Rossiter
9273df15ff
Merge pull request #2003 from edlinklater/641-insert_link_styling
...
Formatting tweaks, fixes silverstripe/silverstripe-cms#641
2013-05-24 23:00:05 -07:00
Will Rossiter
d31fa7eb1b
Merge pull request #2004 from adrexia/logout-button
...
Replace logout button with a more commonly used symbol
2013-05-24 21:57:36 -07:00
Naomi Guyer
c445997f32
Replace logout button with a more commonly used symbol
...
* Power icon swapped for door icon
* Minor hover/focus opacity effect added to button
2013-05-25 16:45:49 +12:00
Ed Linklater
98ba6b331c
Formatting tweaks, fixes silverstripe/silverstripe-cms#641
2013-05-25 15:54:49 +12:00
Sam Minnée
eedcacb256
Merge pull request #2000 from wilr/1640
...
FIX: IE8 does not bubble reset form events (Fixes #1640 )
2013-05-24 19:51:20 -07:00
Sam Minnée
370a07aef2
Merge pull request #1978 from kinglozzer/1783-uninitialised-tabs
...
FIX: Attempting to select uninitialised tab on validation error (fixes #1783 )
2013-05-24 19:46:40 -07:00
Will Rossiter
d540c443bc
FIX: IE8 does not bubble reset form events. Use click handler for reset button. ( Fixes #1640 )
2013-05-25 14:12:44 +12:00
Naomi Guyer
be5eaf1353
BUG: Fix alignment of media button
2013-05-25 13:40:37 +12:00
Russell Michell
9741d1f63b
BUGFIX: Pages set as 'deletedindraft' were allowed to be published through CMS batch-actions leaving an empty title in the SiteTree.
2013-05-24 15:40:46 +12:00
Loz Calver
c8725d1c93
Attempting to select uninitialised tab on validation error ( fixes #1783 )
2013-05-23 16:01:27 +01:00
Ingo Schommer
30b53e65fe
API Full-width HTMLEditorField by default
2013-05-22 16:15:16 +02:00
Ingo Schommer
9bda0b7c54
Merge pull request #1965 from kinglozzer/1958-stacked-field-descriptions
...
FIX: Remove left margin on stacked form field descriptions (fixes #1958 )
2013-05-21 08:05:45 -07:00
Will Rossiter
ddcfcf7bed
Update @package, @subpackage labels
...
Cleanup of framework's use of @package and @subpackage labels and additional of labels for classes missing packages.
Moved all GridField related components to the one name.
Countless spelling fixes, grammar for other comments.
Link ClassName references in file headers.
2013-05-21 22:24:41 +12:00
Loz Calver
55a4fb40a6
FIX: Remove left margin on stacked form field descriptions ( fixes #1958 )
2013-05-21 09:52:45 +01:00
Mateusz Uzdowski
b480886cab
BUG All tabs are in open state when changing the name of a folder.
...
Submitting the form via AJAX changes the DOM controlled by the tabs
widget, it needs to be notified about the change.
2013-05-16 11:15:03 +12:00
Sean Harvey
33be390db8
Put back cog icon for multi-select batch actions (was removed in f4b080e
)
2013-05-15 21:09:19 +12:00
Will Rossiter
8b073c1cad
FIX: allow cite elements in TinyMCE
2013-05-11 23:20:00 +12:00
Ingo Schommer
e5d3a1da6b
Disable ContentNegotiator in CMS ( fixes #1850 )
2013-05-08 23:45:53 +02:00
Loz Calver
c53b61c347
Fix broken CMSSettings saving
...
Regression from da7e515d13
2013-04-11 17:25:15 +01:00
Damian Mooyman
9da57b083a
BUG Fixed broken ErrorPage icons in CMS view
2013-04-10 17:15:42 +12:00
Sean Harvey
97b1f8616f
Merge pull request #1739 from kinglozzer/leftandmain-uninitialized-tabs
...
FIX: Edge case attempting to destroy uninitialized tabs
2013-04-09 14:08:12 -07:00
Ingo Schommer
9456b8043c
Fixed "insert media" styling (regression from 27b0cda0
)
2013-04-09 14:47:10 +02:00
Ingo Schommer
310bc8d09c
Better default icon for ModelAdmin
...
Cogwheels doesn't really communicate its meaning well...
New icon is from http://thenounproject.com/noun/database/#icon-No6001 ,
doesn't require permanent attribution (CC0)
2013-04-09 13:43:32 +02:00
Loz Calver
975c6992df
FIX: Edge case attempting to destroy uninitialized tabs
...
Another edge case very similar to
https://github.com/silverstripe/sapphire/commit/07fb7563273fa82bd93eb255
70571c0a298198e5
2013-04-09 11:21:54 +01:00
Ingo Schommer
17362f9474
Showing "Help" menu item below "Settings"
2013-04-09 12:20:20 +02:00
Ingo Schommer
7d600f57d5
CMSMenu sort order ( fixes #1716 )
...
Regression caused by b645703eb9
2013-04-09 12:19:33 +02:00
Sam Minnee
e6d8280296
Removed notice-level erorr in CMS page list.
2013-04-09 11:42:30 +12:00
Ingo Schommer
01f46d039f
NEW Enforce max node counts to avoid excessive resource usage
...
Rendering potentially 1000s of nodes can exceed the CPU and memory constraints
of a normal PHP process, as well as the rendering capabilities of browsers.
Set a hard maximum for the renderable nodes, deferring to a "show as list" action
in the main CMS tree. For TreeDropdownField, we don't have the list fallback option,
so ask the user to search for the node title instead.
Also makes both the "node_threshold_total" and "node_threshold_leaf" values configurable
2013-04-09 10:24:18 +12:00
Will Rossiter
d94a6a5407
Polish add page screen. Disable styles and fix SelectionField
2013-04-08 19:54:46 +12:00
Ingo Schommer
828ac7fe4f
API Replaced SSViewer.custom_theme with SSViewer.theme_enabled
...
Since we can't influence the setting of configuration values,
we also can't set/unset the 'custom_theme' value based on which
theme is set. This means the 'custom_theme' value goes stale,
and we can't rely on it e.g. in FilesystemPublisher.
The 'theme_enabled' toggle is a cleaner solution to the same problem,
since the 'custom_theme' was really just a way to remember the original
theme, while still disabling it. The toggle makes this more explicit,
but also requires users of the 'theme' setting to check for it.
2013-04-07 23:59:10 +02:00
Ingo Schommer
1dda9ae45f
Fixed extra_requirements docs
2013-04-05 15:35:30 +02:00
g4b0
f033321adc
Solved json obj to array issue
2013-03-28 22:06:37 +01:00
Andrew Short
10f46ba08e
Include padding on padded edit form panels inside a tabset
2013-03-29 02:23:43 +11:00
Ingo Schommer
ace7c04b9e
Merge pull request #1345 from ajshort/pulls/modeladmin-tabs
...
FIX: Set ModelAdmin tab targets to avoid creating new panels
2013-03-28 07:56:17 -07:00
Andrew Short
f2b4b95350
FIX: Set ModelAdmin tab targets to avoid creating new panels
2013-03-29 01:41:31 +11:00
g4b0
93428bd8f2
Solved json obj to array issue
2013-03-28 14:52:13 +01:00
Ingo Schommer
3c30c36b71
Fixed help_link config usage
2013-03-27 21:48:55 +01:00
Ingo Schommer
3f2b6a518f
FIX Don't silently unset ParentID in "add page" dialog
...
Happened when changing the page type, because the "selectedNode"
property isn't set in all cases
2013-03-25 23:40:35 +01:00
Ingo Schommer
3334eafcb1
API Marked statics private, use Config API instead ( #8317 )
...
See "Static configuration properties are now immutable, you must use Config API." in the 3.1 change log for details.
2013-03-24 17:20:53 +01:00
Daniel Hensby
a03d1e66ca
BUG CMS messages touch the bottom of the inputs
...
making spacing even: http://screencast.com/t/oYHnG1Bj
2013-03-20 13:50:10 +01:00
Ingo Schommer
74014650ed
Merge pull request #1205 from UndefinedOffset/3.0
...
BUG Fixed issue with cms help toggles not functioning correctly
2013-03-20 05:47:05 -07:00
Ingo Schommer
2debbd37dc
Updated history.js dependency
2013-03-20 00:46:32 +01:00
Ingo Schommer
53c84ee1fe
Merge remote-tracking branch 'origin/3.0' into 3.1
2013-03-19 14:04:29 +01:00
Ingo Schommer
52ffb307a7
Fixed ValidationException handling in LeftAndMain
...
getResult() isn't always available, and has the same content
as the native Exception->getMessage() anyway
2013-03-19 14:02:28 +01:00
Andrew Short
b8a51c3792
Merge branch '3.0' into 3.1
2013-03-19 22:27:09 +11:00
Ingo Schommer
dd6f33ab37
FIX Respect tree node limits, fix search result node display
...
- Renamed $minNodeCount to more accurate $nodeCountThreshold
- The $minNodeCount attribute wasn't properly respected
during actual querying, so SilverStripe would always traverse
the entire tree (and load all objects into memory),
before then marking nodes as "unexpanded", which prevents
them from actually being rendered.
- Fixes nodes on search results to be expanded by default
- Fixes nodes on search results to correctly ajax-expand
2013-03-19 00:05:14 +01:00
Ingo Schommer
b2552f885b
Merge pull request #1288 from chillu/pulls/tab-state-overrides
...
Tab state overrides
2013-03-18 04:12:05 -07:00
Andrew Short
6ae931df24
Merge branch '3.0' into 3.1
2013-03-15 21:47:23 +11:00
Ingo Schommer
8ece47ad55
Merge pull request #1290 from patbolo/ticket/8322
...
FIX #8322 Use POST instead of GET when using LeftAndMain::savetreenode s...
2013-03-14 16:38:26 -07:00
jean
412f58b559
FIX #8322 Use POST instead of GET when using LeftAndMain::savetreenode so large site trees can be reorganised as well
2013-03-15 10:16:33 +13:00
Ingo Schommer
da7e515d13
Tab state overrides by class or HTML5 history state
...
Necessary to switch from tree view to list view programmatically,
which reloads the whole tabset and needs to enable the "list" tab.
Used for the new "Show list as children" functionality in the cms.
2013-03-14 17:28:53 +01:00
Ingo Schommer
746904ca7d
FIX Respect previous tab choices in CMS on load
...
Previously only worked on ajax interactions.
This makes it much easier to default the CMS to
the "list view" rather than "tree view".
2013-03-14 16:22:32 +01:00
James Cocker
7e575481c7
CMS CSS Minor Polishing Tweaks
...
Fixed what I believe to be a few very minor CSS regressions, that appeared after the CSS restructure for the side-by-side preview.
- Reverted background of the right panel (and tab active state) to the slightly darker shade (as per 3.0) to keep each of the 3 panels visually separate.
- Slightly increased padding on ui-tabs-panel as felt a but too close for comfort. Had decreased since 3.0.
- Decreased padding for logged in user name in menu, felt too excessive. (3.0 was neater)
- Evened out padding above buttons in site tree sidebar
Screenshots showing changes:
3.0: http://spdr.me/xauh
3.1 before commit: http://spdr.me/jkIe
3.1 after commit: http://spdr.me/IxtB
2013-03-14 09:41:38 +01:00
Ingo Schommer
b81f39aee5
API Handle uncaught ValidationException on CMS controller execution
...
This removes the need for a lot of boilerplate code
around DataObject->write() logic, and avoids generic 500 errors
on user-level failures. This should really be a per-project choice,
but at the moment request handling doesn't allow to configure
custom exception handling.
2013-03-08 12:55:30 +01:00
Loz Calver
9a1ccd8a67
FIX: Prevent opening preview when clicking the link for current page again
2013-03-01 11:42:34 +00:00
Ingo Schommer
2b6d735182
Using composer.lock for LeftAndMain->CMSVersion()
...
See https://github.com/silverstripe/silverstripe-cms/pull/289 for context
2013-02-28 13:38:19 +01:00
Ingo Schommer
64b465f0cb
Merge pull request #1143 from svandragt/3.1
...
ENHANCEMENT Sort menu items according to priority descending, then title ascending
2013-02-27 01:25:49 -08:00
Ingo Schommer
bea1b9002d
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
control/HTTP.php
2013-02-26 13:28:35 +01:00
Ingo Schommer
25af4adce2
Merge tag '3.0.5' into 3.0
2013-02-20 02:21:41 +01:00
UndefinedOffset
e954c8c1d1
No longer caching the target element to be toggled
2013-02-19 12:10:19 -04:00
UndefinedOffset
b3e40dd0c3
Fixed issue with cms help toggles not functioning correctly
2013-02-19 11:38:40 -04:00
roed
9e7c622abe
fixed error property $ of object is not a function
...
changed $ to jQuery, because without it the system would generate the following error:
Uncaught TypeError: Property '$' of object [object Window] is not a function
2013-02-19 15:48:29 +01:00
roed
396af557df
fixed error property $ of object is not a function
...
changed $ to jQuery, because without it the system would generate the following error:
Uncaught TypeError: Property '$' of object [object Window] is not a function
2013-02-19 09:20:29 +01:00
Ingo Schommer
0c6ac1960e
Fixed whitespace usage
2013-02-18 15:43:52 +01:00
Ingo Schommer
a86e4ee00c
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
tests/injector/InjectorTest.php
tests/travis/before_script
2013-02-18 14:15:42 +01:00
ARNHOE
924c76ccb1
Create nl_NL.js
2013-02-18 03:13:09 -08:00
Hamish Friedlander
4b54383d68
API change request handling to be more orthogonal
...
RequestHandler#handleAction now exists. It takes the request, and
the action to call on itself. All calls from handleRequest to call an action
will go through this method
Controller#handleAction has had it's signature changed to
match new RequestHandler#handleAction
RequestHandler#findAction has been added, which extracts the
"match URL to rules to find action" portion of RequestHandler#handleRequest
into a separate, overrideable function
GridField#handleAction has beeen renamed to handleAlterAction and
CMSBatchActionHandler#handleAction has been renamed to handleBatchAction to
avoid name clash with new RequestHandler#handleAction
Reason for change: The exact behaviour of request handling depended heavily
on whether you inherited from RequestHandler or Controller, and whether the
rule extracted it's action directly (like "foo/$ID" => 'foo') or dynamically
(like "$Action/$ID" => "handleAction"). This cleans up behaviour so
all calls follow the same path through handleRequest and handleAction, and
the additional behaviour that Controller adds is clear.
2013-02-18 14:56:04 +13:00
Hamish Friedlander
7efae6b95f
Merge remote-tracking branch 'origin/3.0' into 3.1
2013-02-18 14:31:57 +13:00
Ingo Schommer
eafafb31e3
Fixed screen.css (wrong compilation)
2013-02-18 01:28:17 +01:00
Ingo Schommer
604ede30a4
BUGFIX Escape HTML in CMS status messages
2013-02-17 23:27:15 +01:00
Ingo Schommer
e21bd49462
BUG TimeField respects user choice ( fixes #8260 )
...
Regression from c969e04731
.
Also fixes width to accommodate for widest common format:
"11:11:11 AM"
2013-02-17 21:00:02 +01:00
Ingo Schommer
923ad8861f
Layout regression in "add pages"
...
Unrelated fields affected by changes to CMS tooltips. See 1ca3883a76
.
2013-02-13 10:15:06 +01:00